[INFO] crate travis-after-all 2.0.0 is already in cache [INFO] extracting crate travis-after-all 2.0.0 into work/ex/clippy-test-run/sources/stable/reg/travis-after-all/2.0.0 [INFO] extracting crate travis-after-all 2.0.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/travis-after-all/2.0.0 [INFO] validating manifest of travis-after-all-2.0.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of travis-after-all-2.0.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing travis-after-all-2.0.0 [INFO] finished frobbing travis-after-all-2.0.0 [INFO] frobbed toml for travis-after-all-2.0.0 written to work/ex/clippy-test-run/sources/stable/reg/travis-after-all/2.0.0/Cargo.toml [INFO] started frobbing travis-after-all-2.0.0 [INFO] finished frobbing travis-after-all-2.0.0 [INFO] frobbed toml for travis-after-all-2.0.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/travis-after-all/2.0.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting travis-after-all-2.0.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/travis-after-all/2.0.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 697ca68c8289fdaffc40b5c56a3464b8755f4dd8f7ba49f1fad7e65ffe7fb1e2 [INFO] running `"docker" "start" "-a" "697ca68c8289fdaffc40b5c56a3464b8755f4dd8f7ba49f1fad7e65ffe7fb1e2"` [INFO] [stderr] Checking serde_json v0.9.10 [INFO] [stderr] Checking serde_urlencoded v0.4.3 [INFO] [stderr] Checking reqwest v0.4.0 [INFO] [stderr] Checking travis-after-all v2.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | build_id: build_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `build_id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:105:13 [INFO] [stderr] | [INFO] [stderr] 105 | job_number: job_number, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `job_number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | polling_interval: polling_interval, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `polling_interval` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | build_id: build_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `build_id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:105:13 [INFO] [stderr] | [INFO] [stderr] 105 | job_number: job_number, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `job_number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | polling_interval: polling_interval, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `polling_interval` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:61:28 [INFO] [stderr] | [INFO] [stderr] 61 | const USER_AGENT: &'static str = concat!("travis-after-all/", env!("CARGO_PKG_VERSION")); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:62:28 [INFO] [stderr] | [INFO] [stderr] 62 | const TRAVIS_JOB_NUMBER : &'static str = "TRAVIS_JOB_NUMBER"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:63:28 [INFO] [stderr] | [INFO] [stderr] 63 | const TRAVIS_BUILD_ID: &'static str = "TRAVIS_BUILD_ID"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:64:28 [INFO] [stderr] | [INFO] [stderr] 64 | const TRAVIS_API_URL: &'static str = "https://api.travis-ci.org"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:65:28 [INFO] [stderr] | [INFO] [stderr] 65 | const POLLING_INTERVAL: &'static str = "LEADER_POLLING_INTERVAL"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:61:28 [INFO] [stderr] | [INFO] [stderr] 61 | const USER_AGENT: &'static str = concat!("travis-after-all/", env!("CARGO_PKG_VERSION")); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:62:28 [INFO] [stderr] | [INFO] [stderr] 62 | const TRAVIS_JOB_NUMBER : &'static str = "TRAVIS_JOB_NUMBER"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:63:28 [INFO] [stderr] | [INFO] [stderr] 63 | const TRAVIS_BUILD_ID: &'static str = "TRAVIS_BUILD_ID"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:64:28 [INFO] [stderr] | [INFO] [stderr] 64 | const TRAVIS_API_URL: &'static str = "https://api.travis-ci.org"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:65:28 [INFO] [stderr] | [INFO] [stderr] 65 | const POLLING_INTERVAL: &'static str = "LEADER_POLLING_INTERVAL"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/error.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | / pub fn from_str(message: &str) -> Error { [INFO] [stderr] 24 | | Error::from_string(message.into()) [INFO] [stderr] 25 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/error.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | / pub fn from_str(message: &str) -> Error { [INFO] [stderr] 24 | | Error::from_string(message.into()) [INFO] [stderr] 25 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:130:28 [INFO] [stderr] | [INFO] [stderr] 130 | res.json().map_err(|e| From::from(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `From::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:155:9 [INFO] [stderr] | [INFO] [stderr] 155 | / match matrix.others_succeeded() { [INFO] [stderr] 156 | | true => Ok(()), [INFO] [stderr] 157 | | false => Err(Error::FailedBuilds) [INFO] [stderr] 158 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if matrix.others_succeeded() { Ok(()) } else { Err(Error::FailedBuilds) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:130:28 [INFO] [stderr] | [INFO] [stderr] 130 | res.json().map_err(|e| From::from(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `From::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:155:9 [INFO] [stderr] | [INFO] [stderr] 155 | / match matrix.others_succeeded() { [INFO] [stderr] 156 | | true => Ok(()), [INFO] [stderr] 157 | | false => Err(Error::FailedBuilds) [INFO] [stderr] 158 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if matrix.others_succeeded() { Ok(()) } else { Err(Error::FailedBuilds) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:39:17 [INFO] [stderr] | [INFO] [stderr] 39 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:54:17 [INFO] [stderr] | [INFO] [stderr] 54 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:39:17 [INFO] [stderr] | [INFO] [stderr] 39 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:54:17 [INFO] [stderr] | [INFO] [stderr] 54 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 13.27s [INFO] running `"docker" "inspect" "697ca68c8289fdaffc40b5c56a3464b8755f4dd8f7ba49f1fad7e65ffe7fb1e2"` [INFO] running `"docker" "rm" "-f" "697ca68c8289fdaffc40b5c56a3464b8755f4dd8f7ba49f1fad7e65ffe7fb1e2"` [INFO] [stdout] 697ca68c8289fdaffc40b5c56a3464b8755f4dd8f7ba49f1fad7e65ffe7fb1e2