[INFO] crate translate-storage 0.0.1 is already in cache [INFO] extracting crate translate-storage 0.0.1 into work/ex/clippy-test-run/sources/stable/reg/translate-storage/0.0.1 [INFO] extracting crate translate-storage 0.0.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/translate-storage/0.0.1 [INFO] validating manifest of translate-storage-0.0.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of translate-storage-0.0.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing translate-storage-0.0.1 [INFO] finished frobbing translate-storage-0.0.1 [INFO] frobbed toml for translate-storage-0.0.1 written to work/ex/clippy-test-run/sources/stable/reg/translate-storage/0.0.1/Cargo.toml [INFO] started frobbing translate-storage-0.0.1 [INFO] finished frobbing translate-storage-0.0.1 [INFO] frobbed toml for translate-storage-0.0.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/translate-storage/0.0.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting translate-storage-0.0.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/translate-storage/0.0.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 05489be230d3bea61683651e774ecb9484900de729b29b031346031de9b1d89a [INFO] running `"docker" "start" "-a" "05489be230d3bea61683651e774ecb9484900de729b29b031346031de9b1d89a"` [INFO] [stderr] Checking locale_config v0.2.2 [INFO] [stderr] Checking translate-storage v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> src/lib.rs:32:1 [INFO] [stderr] | [INFO] [stderr] 32 | / macro_rules! unpack { [INFO] [stderr] 33 | | ($x:expr => $p:pat => $r:expr) => {{ [INFO] [stderr] 34 | | match $x { [INFO] [stderr] 35 | | $p => Some($r), [INFO] [stderr] ... | [INFO] [stderr] 44 | | }}; [INFO] [stderr] 45 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_macros)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/po.rs:90:5 [INFO] [stderr] | [INFO] [stderr] 90 | return Err(()); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> src/lib.rs:32:1 [INFO] [stderr] | [INFO] [stderr] 32 | / macro_rules! unpack { [INFO] [stderr] 33 | | ($x:expr => $p:pat => $r:expr) => {{ [INFO] [stderr] 34 | | match $x { [INFO] [stderr] 35 | | $p => Some($r), [INFO] [stderr] ... | [INFO] [stderr] 44 | | }}; [INFO] [stderr] 45 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_macros)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/po.rs:90:5 [INFO] [stderr] | [INFO] [stderr] 90 | return Err(()); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/po.rs:242:9 [INFO] [stderr] | [INFO] [stderr] 242 | return res; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `res` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/po.rs:312:9 [INFO] [stderr] | [INFO] [stderr] 312 | return Ok(Some(unit)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Some(unit))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/po.rs:294:26 [INFO] [stderr] | [INFO] [stderr] 294 | const TAGS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/po.rs:294:36 [INFO] [stderr] | [INFO] [stderr] 294 | const TAGS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/po.rs:353:9 [INFO] [stderr] | [INFO] [stderr] 353 | return res; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `res` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/po.rs:242:9 [INFO] [stderr] | [INFO] [stderr] 242 | return res; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `res` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/po.rs:312:9 [INFO] [stderr] | [INFO] [stderr] 312 | return Ok(Some(unit)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Some(unit))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/po.rs:294:26 [INFO] [stderr] | [INFO] [stderr] 294 | const TAGS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/po.rs:294:36 [INFO] [stderr] | [INFO] [stderr] 294 | const TAGS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/po.rs:353:9 [INFO] [stderr] | [INFO] [stderr] 353 | return res; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `res` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/po.rs:133:25 [INFO] [stderr] | [INFO] [stderr] 133 | / match flag { [INFO] [stderr] 134 | | "fuzzy" => unit._state = State::NeedsWork, [INFO] [stderr] 135 | | _ => (), // TODO: Implement other flags (do we need any?) [INFO] [stderr] 136 | | } [INFO] [stderr] | |_________________________^ help: try this: `if let "fuzzy" = flag { unit._state = State::NeedsWork }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/po.rs:212:5 [INFO] [stderr] | [INFO] [stderr] 212 | / match oru { [INFO] [stderr] 213 | | &Some(Ok(ref u)) => u.source().is_singular() && u.source().is_blank(), [INFO] [stderr] 214 | | _ => false, [INFO] [stderr] 215 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 212 | match *oru { [INFO] [stderr] 213 | Some(Ok(ref u)) => u.source().is_singular() && u.source().is_blank(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/po.rs:347:9 [INFO] [stderr] | [INFO] [stderr] 347 | / if self._next_unit.is_none() { [INFO] [stderr] 348 | | return None; [INFO] [stderr] 349 | | } [INFO] [stderr] | |_________^ help: replace_it_with: `self._next_unit?;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::question_mark)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:105:9 [INFO] [stderr] | [INFO] [stderr] 105 | / match self { [INFO] [stderr] 106 | | &Message::Empty => true, [INFO] [stderr] 107 | | _ => false, [INFO] [stderr] 108 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 105 | match *self { [INFO] [stderr] 106 | Message::Empty => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:112:9 [INFO] [stderr] | [INFO] [stderr] 112 | / match self { [INFO] [stderr] 113 | | &Message::Singular(_) => true, [INFO] [stderr] 114 | | _ => false, [INFO] [stderr] 115 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 112 | match *self { [INFO] [stderr] 113 | Message::Singular(_) => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:119:9 [INFO] [stderr] | [INFO] [stderr] 119 | / match self { [INFO] [stderr] 120 | | &Message::Plural(_) => true, [INFO] [stderr] 121 | | _ => false, [INFO] [stderr] 122 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 119 | match *self { [INFO] [stderr] 120 | Message::Plural(_) => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:126:9 [INFO] [stderr] | [INFO] [stderr] 126 | / match self { [INFO] [stderr] 127 | | &Message::Empty => true, [INFO] [stderr] 128 | | &Message::Singular(ref s) => s == "", [INFO] [stderr] 129 | | &Message::Plural(ref m) => m.values().all(|s| s == ""), [INFO] [stderr] 130 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 126 | match *self { [INFO] [stderr] 127 | Message::Empty => true, [INFO] [stderr] 128 | Message::Singular(ref s) => s == "", [INFO] [stderr] 129 | Message::Plural(ref m) => m.values().all(|s| s == ""), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:134:9 [INFO] [stderr] | [INFO] [stderr] 134 | / match self { [INFO] [stderr] 135 | | &Message::Singular(ref s) => Some(s.as_ref()), [INFO] [stderr] 136 | | _ => None, [INFO] [stderr] 137 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 134 | match *self { [INFO] [stderr] 135 | Message::Singular(ref s) => Some(s.as_ref()), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:256:9 [INFO] [stderr] | [INFO] [stderr] 256 | / match self { [INFO] [stderr] 257 | | &Error::Io(0, ref err) => err.fmt(f), [INFO] [stderr] 258 | | &Error::Io(line, ref err) => write!(f, "{} at line {}", err, line), [INFO] [stderr] 259 | | &Error::Parse(line, ref got, ref exp) => { [INFO] [stderr] ... | [INFO] [stderr] 272 | | } [INFO] [stderr] 273 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 256 | match *self { [INFO] [stderr] 257 | Error::Io(0, ref err) => err.fmt(f), [INFO] [stderr] 258 | Error::Io(line, ref err) => write!(f, "{} at line {}", err, line), [INFO] [stderr] 259 | Error::Parse(line, ref got, ref exp) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:283:9 [INFO] [stderr] | [INFO] [stderr] 283 | / match self { [INFO] [stderr] 284 | | &Error::Io(_, ref err) => Some(err), [INFO] [stderr] 285 | | &Error::Parse(..) => None, [INFO] [stderr] 286 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 283 | match *self { [INFO] [stderr] 284 | Error::Io(_, ref err) => Some(err), [INFO] [stderr] 285 | Error::Parse(..) => None, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/po.rs:133:25 [INFO] [stderr] | [INFO] [stderr] 133 | / match flag { [INFO] [stderr] 134 | | "fuzzy" => unit._state = State::NeedsWork, [INFO] [stderr] 135 | | _ => (), // TODO: Implement other flags (do we need any?) [INFO] [stderr] 136 | | } [INFO] [stderr] | |_________________________^ help: try this: `if let "fuzzy" = flag { unit._state = State::NeedsWork }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/po.rs:212:5 [INFO] [stderr] | [INFO] [stderr] 212 | / match oru { [INFO] [stderr] 213 | | &Some(Ok(ref u)) => u.source().is_singular() && u.source().is_blank(), [INFO] [stderr] 214 | | _ => false, [INFO] [stderr] 215 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 212 | match *oru { [INFO] [stderr] 213 | Some(Ok(ref u)) => u.source().is_singular() && u.source().is_blank(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/po.rs:347:9 [INFO] [stderr] | [INFO] [stderr] 347 | / if self._next_unit.is_none() { [INFO] [stderr] 348 | | return None; [INFO] [stderr] 349 | | } [INFO] [stderr] | |_________^ help: replace_it_with: `self._next_unit?;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::question_mark)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 43 [INFO] [stderr] --> src/po.rs:408:5 [INFO] [stderr] | [INFO] [stderr] 408 | / fn integration_test() { [INFO] [stderr] 409 | | let mut reader = PoReader::new(SAMPLE_PO.as_ref()); [INFO] [stderr] 410 | | [INFO] [stderr] 411 | | assert_eq!(LanguageRange::new("cs").unwrap(), *reader.target_language()); [INFO] [stderr] ... | [INFO] [stderr] 469 | | assert!(reader.next().is_none()); [INFO] [stderr] 470 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:105:9 [INFO] [stderr] | [INFO] [stderr] 105 | / match self { [INFO] [stderr] 106 | | &Message::Empty => true, [INFO] [stderr] 107 | | _ => false, [INFO] [stderr] 108 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 105 | match *self { [INFO] [stderr] 106 | Message::Empty => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:112:9 [INFO] [stderr] | [INFO] [stderr] 112 | / match self { [INFO] [stderr] 113 | | &Message::Singular(_) => true, [INFO] [stderr] 114 | | _ => false, [INFO] [stderr] 115 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 112 | match *self { [INFO] [stderr] 113 | Message::Singular(_) => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:119:9 [INFO] [stderr] | [INFO] [stderr] 119 | / match self { [INFO] [stderr] 120 | | &Message::Plural(_) => true, [INFO] [stderr] 121 | | _ => false, [INFO] [stderr] 122 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 119 | match *self { [INFO] [stderr] 120 | Message::Plural(_) => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:126:9 [INFO] [stderr] | [INFO] [stderr] 126 | / match self { [INFO] [stderr] 127 | | &Message::Empty => true, [INFO] [stderr] 128 | | &Message::Singular(ref s) => s == "", [INFO] [stderr] 129 | | &Message::Plural(ref m) => m.values().all(|s| s == ""), [INFO] [stderr] 130 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 126 | match *self { [INFO] [stderr] 127 | Message::Empty => true, [INFO] [stderr] 128 | Message::Singular(ref s) => s == "", [INFO] [stderr] 129 | Message::Plural(ref m) => m.values().all(|s| s == ""), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:134:9 [INFO] [stderr] | [INFO] [stderr] 134 | / match self { [INFO] [stderr] 135 | | &Message::Singular(ref s) => Some(s.as_ref()), [INFO] [stderr] 136 | | _ => None, [INFO] [stderr] 137 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 134 | match *self { [INFO] [stderr] 135 | Message::Singular(ref s) => Some(s.as_ref()), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:256:9 [INFO] [stderr] | [INFO] [stderr] 256 | / match self { [INFO] [stderr] 257 | | &Error::Io(0, ref err) => err.fmt(f), [INFO] [stderr] 258 | | &Error::Io(line, ref err) => write!(f, "{} at line {}", err, line), [INFO] [stderr] 259 | | &Error::Parse(line, ref got, ref exp) => { [INFO] [stderr] ... | [INFO] [stderr] 272 | | } [INFO] [stderr] 273 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 256 | match *self { [INFO] [stderr] 257 | Error::Io(0, ref err) => err.fmt(f), [INFO] [stderr] 258 | Error::Io(line, ref err) => write!(f, "{} at line {}", err, line), [INFO] [stderr] 259 | Error::Parse(line, ref got, ref exp) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:283:9 [INFO] [stderr] | [INFO] [stderr] 283 | / match self { [INFO] [stderr] 284 | | &Error::Io(_, ref err) => Some(err), [INFO] [stderr] 285 | | &Error::Parse(..) => None, [INFO] [stderr] 286 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 283 | match *self { [INFO] [stderr] 284 | Error::Io(_, ref err) => Some(err), [INFO] [stderr] 285 | Error::Parse(..) => None, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.96s [INFO] running `"docker" "inspect" "05489be230d3bea61683651e774ecb9484900de729b29b031346031de9b1d89a"` [INFO] running `"docker" "rm" "-f" "05489be230d3bea61683651e774ecb9484900de729b29b031346031de9b1d89a"` [INFO] [stdout] 05489be230d3bea61683651e774ecb9484900de729b29b031346031de9b1d89a