[INFO] crate transaction-pool 1.13.3 is already in cache
[INFO] extracting crate transaction-pool 1.13.3 into work/ex/clippy-test-run/sources/stable/reg/transaction-pool/1.13.3
[INFO] extracting crate transaction-pool 1.13.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/transaction-pool/1.13.3
[INFO] validating manifest of transaction-pool-1.13.3 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of transaction-pool-1.13.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing transaction-pool-1.13.3
[INFO] finished frobbing transaction-pool-1.13.3
[INFO] frobbed toml for transaction-pool-1.13.3 written to work/ex/clippy-test-run/sources/stable/reg/transaction-pool/1.13.3/Cargo.toml
[INFO] started frobbing transaction-pool-1.13.3
[INFO] finished frobbing transaction-pool-1.13.3
[INFO] frobbed toml for transaction-pool-1.13.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/transaction-pool/1.13.3/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting transaction-pool-1.13.3 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/transaction-pool/1.13.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 97e222a41081af442c9b4653ff580ea78b50c5d798ef5105791cf298908c647e
[INFO] running `"docker" "start" "-a" "97e222a41081af442c9b4653ff580ea78b50c5d798ef5105791cf298908c647e"`
[INFO] [stderr]     Checking trace-time v0.1.1
[INFO] [stderr]     Checking uint v0.4.1
[INFO] [stderr]     Checking error-chain v0.12.0
[INFO] [stderr]     Checking transaction-pool v1.13.3 (/opt/crater/workdir)
[INFO] [stderr]     Checking ethereum-types v0.4.0
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/transactions.rs:177:3
[INFO] [stderr]     |
[INFO] [stderr] 177 |         return true;
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]    --> src/pool.rs:238:13
[INFO] [stderr]     |
[INFO] [stderr] 238 |         previous: Option<((S::Score, Transaction<T>), (S::Score, Transaction<T>))>,
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::type_complexity)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]    --> src/pool.rs:239:12
[INFO] [stderr]     |
[INFO] [stderr] 239 |         current: Option<((S::Score, Transaction<T>), (S::Score, Transaction<T>))>,
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to want to iterate on a map's values
[INFO] [stderr]    --> src/pool.rs:479:34
[INFO] [stderr]     |
[INFO] [stderr] 479 |         for (_sender, transactions) in &self.transactions {
[INFO] [stderr]     |                                        ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::for_kv_map)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map
[INFO] [stderr] help: use the corresponding method
[INFO] [stderr]     |
[INFO] [stderr] 479 |         for transactions in self.transactions.values() {
[INFO] [stderr]     |             ^^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]   --> src/transactions.rs:74:34
[INFO] [stderr]    |
[INFO] [stderr] 74 |     pub fn worst_and_best(&self) -> Option<((S::Score, Transaction<T>), (S::Score, Transaction<T>))> {
[INFO] [stderr]    |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/transactions.rs:177:3
[INFO] [stderr]     |
[INFO] [stderr] 177 |         return true;
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'ethereum_types::H160::low_u64': will be renamed to `low_u64_be` in version 0.3
[INFO] [stderr]   --> src/tests/tx_builder.rs:54:110
[INFO] [stderr]    |
[INFO] [stderr] 54 |         let hash = self.nonce ^ (U256::from(100) * self.gas_price) ^ (U256::from(100_000) * U256::from(self.sender.low_u64()));
[INFO] [stderr]    |                                                                                                                    ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `scores`.
[INFO] [stderr]   --> src/tests/helpers.rs:60:13
[INFO] [stderr]    |
[INFO] [stderr] 60 |             for i in 0..txs.len() {
[INFO] [stderr]    |                      ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 60 |             for <item> in scores.iter_mut().take(txs.len()) {
[INFO] [stderr]    |                 ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `new` usually take no self; consider choosing a less ambiguous name
[INFO] [stderr]   --> src/tests/tx_builder.rs:53:13
[INFO] [stderr]    |
[INFO] [stderr] 53 |     pub fn new(self) -> Transaction {
[INFO] [stderr]    |                ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `new` usually return `Self`
[INFO] [stderr]   --> src/tests/tx_builder.rs:53:2
[INFO] [stderr]    |
[INFO] [stderr] 53 |       pub fn new(self) -> Transaction {
[INFO] [stderr]    |  _____^
[INFO] [stderr] 54 | |         let hash = self.nonce ^ (U256::from(100) * self.gas_price) ^ (U256::from(100_000) * U256::from(self.sender.low_u64()));
[INFO] [stderr] 55 | |         Transaction {
[INFO] [stderr] 56 | |             hash: hash.into(),
[INFO] [stderr] ...  |
[INFO] [stderr] 62 | |         }
[INFO] [stderr] 63 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_ret_no_self)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/tests/mod.rs:249:4
[INFO] [stderr]     |
[INFO] [stderr] 249 |             current_gas = current_gas + tx.gas
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `current_gas += tx.gas`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/tests/mod.rs:370:4
[INFO] [stderr]     |
[INFO] [stderr] 370 |             current_gas = current_gas + tx.gas
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `current_gas += tx.gas`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/tests/mod.rs:641:29
[INFO] [stderr]     |
[INFO] [stderr] 641 |             self.0.borrow_mut().push("rejected".into());
[INFO] [stderr]     |                                      ^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"rejected"`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/tests/mod.rs:645:29
[INFO] [stderr]     |
[INFO] [stderr] 645 |             self.0.borrow_mut().push("dropped".into());
[INFO] [stderr]     |                                      ^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"dropped"`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/tests/mod.rs:649:29
[INFO] [stderr]     |
[INFO] [stderr] 649 |             self.0.borrow_mut().push("invalid".into());
[INFO] [stderr]     |                                      ^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"invalid"`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/tests/mod.rs:653:29
[INFO] [stderr]     |
[INFO] [stderr] 653 |             self.0.borrow_mut().push("canceled".into());
[INFO] [stderr]     |                                      ^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"canceled"`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/tests/mod.rs:657:29
[INFO] [stderr]     |
[INFO] [stderr] 657 |             self.0.borrow_mut().push("culled".into());
[INFO] [stderr]     |                                      ^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"culled"`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]    --> src/pool.rs:238:13
[INFO] [stderr]     |
[INFO] [stderr] 238 |         previous: Option<((S::Score, Transaction<T>), (S::Score, Transaction<T>))>,
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::type_complexity)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]    --> src/pool.rs:239:12
[INFO] [stderr]     |
[INFO] [stderr] 239 |         current: Option<((S::Score, Transaction<T>), (S::Score, Transaction<T>))>,
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to want to iterate on a map's values
[INFO] [stderr]    --> src/pool.rs:479:34
[INFO] [stderr]     |
[INFO] [stderr] 479 |         for (_sender, transactions) in &self.transactions {
[INFO] [stderr]     |                                        ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::for_kv_map)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map
[INFO] [stderr] help: use the corresponding method
[INFO] [stderr]     |
[INFO] [stderr] 479 |         for transactions in self.transactions.values() {
[INFO] [stderr]     |             ^^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]   --> src/transactions.rs:74:34
[INFO] [stderr]    |
[INFO] [stderr] 74 |     pub fn worst_and_best(&self) -> Option<((S::Score, Transaction<T>), (S::Score, Transaction<T>))> {
[INFO] [stderr]    |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 9.14s
[INFO] running `"docker" "inspect" "97e222a41081af442c9b4653ff580ea78b50c5d798ef5105791cf298908c647e"`
[INFO] running `"docker" "rm" "-f" "97e222a41081af442c9b4653ff580ea78b50c5d798ef5105791cf298908c647e"`
[INFO] [stdout] 97e222a41081af442c9b4653ff580ea78b50c5d798ef5105791cf298908c647e