[INFO] crate traktor 0.1.0 is already in cache [INFO] extracting crate traktor 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/traktor/0.1.0 [INFO] extracting crate traktor 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/traktor/0.1.0 [INFO] validating manifest of traktor-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of traktor-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing traktor-0.1.0 [INFO] finished frobbing traktor-0.1.0 [INFO] frobbed toml for traktor-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/traktor/0.1.0/Cargo.toml [INFO] started frobbing traktor-0.1.0 [INFO] finished frobbing traktor-0.1.0 [INFO] frobbed toml for traktor-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/traktor/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting traktor-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/traktor/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 94cfcc9f18de95a658e703469f7f252c11c5f463410e3916afc4ab8b9779b305 [INFO] running `"docker" "start" "-a" "94cfcc9f18de95a658e703469f7f252c11c5f463410e3916afc4ab8b9779b305"` [INFO] [stderr] Checking traktor v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/models.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/models.rs:139:13 [INFO] [stderr] | [INFO] [stderr] 139 | title: title, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `title` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/models.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/models.rs:139:13 [INFO] [stderr] | [INFO] [stderr] 139 | title: title, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `title` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:122:9 [INFO] [stderr] | [INFO] [stderr] 122 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/models.rs:25:23 [INFO] [stderr] | [INFO] [stderr] 25 | match self.albums [INFO] [stderr] | _______________________^ [INFO] [stderr] 26 | | .iter() [INFO] [stderr] 27 | | .find(|&x| x.borrow().title == title) [INFO] [stderr] 28 | | .map(|x| x.clone()) { [INFO] [stderr] | |_____________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 25 | match self.albums [INFO] [stderr] 26 | .iter() [INFO] [stderr] 27 | .find(|&x| x.borrow().title == title).cloned() { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/models.rs:44:23 [INFO] [stderr] | [INFO] [stderr] 44 | match self.artists [INFO] [stderr] | _______________________^ [INFO] [stderr] 45 | | .iter() [INFO] [stderr] 46 | | .find(|&x| x.borrow().name == name) [INFO] [stderr] 47 | | .map(|x| x.clone()) { [INFO] [stderr] | |_____________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 44 | match self.artists [INFO] [stderr] 45 | .iter() [INFO] [stderr] 46 | .find(|&x| x.borrow().name == name).cloned() { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/models.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | / match Track::new(node, &artist_option, &album_option) { [INFO] [stderr] 63 | | Ok(track_inst) => { [INFO] [stderr] 64 | | let track = Rc::new(track_inst); [INFO] [stderr] 65 | | [INFO] [stderr] ... | [INFO] [stderr] 78 | | Err(_) => {} [INFO] [stderr] 79 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 62 | if let Ok(track_inst) = Track::new(node, &artist_option, &album_option) { [INFO] [stderr] 63 | let track = Rc::new(track_inst); [INFO] [stderr] 64 | [INFO] [stderr] 65 | self.tracks.push(track.clone()); [INFO] [stderr] 66 | if let Some(artist) = artist_option { [INFO] [stderr] 67 | let mut artist = artist.borrow_mut(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/parser.rs:71:37 [INFO] [stderr] | [INFO] [stderr] 71 | / match node_attributes.is_empty() { [INFO] [stderr] 72 | | true => { [INFO] [stderr] 73 | | if let XmlEvent::StartElement { attributes, .. } = e { [INFO] [stderr] 74 | | node_attributes = attributes; [INFO] [stderr] ... | [INFO] [stderr] 79 | | } [INFO] [stderr] 80 | | } [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 71 | if node_attributes.is_empty() { [INFO] [stderr] 72 | if let XmlEvent::StartElement { attributes, .. } = e { [INFO] [stderr] 73 | node_attributes = attributes; [INFO] [stderr] 74 | } [INFO] [stderr] 75 | } else { [INFO] [stderr] 76 | node_elements.push(e); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/parser.rs:126:44 [INFO] [stderr] | [INFO] [stderr] 126 | fn get_element_with_name<'a, 'b>(elements: &'a NodeElements, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/parser.rs:131:19 [INFO] [stderr] | [INFO] [stderr] 131 | .find(|x| match *x { [INFO] [stderr] | ___________________^ [INFO] [stderr] 132 | | &XmlEvent::StartElement { ref name, .. } => &name.local_name == lookup_name, [INFO] [stderr] 133 | | _ => false, [INFO] [stderr] 134 | | }) [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 131 | .find(|x| match *(*x) { [INFO] [stderr] 132 | XmlEvent::StartElement { ref name, .. } => &name.local_name == lookup_name, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/parser.rs:132:63 [INFO] [stderr] | [INFO] [stderr] 132 | &XmlEvent::StartElement { ref name, .. } => &name.local_name == lookup_name, [INFO] [stderr] | ----------------^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `name.local_name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/parser.rs:137:34 [INFO] [stderr] | [INFO] [stderr] 137 | pub fn get_attribute(attributes: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[xml::attribute::OwnedAttribute]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/parser.rs:146:40 [INFO] [stderr] | [INFO] [stderr] 146 | pub fn get_element_attribute(elements: &NodeElements, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/parser.rs:152:13 [INFO] [stderr] | [INFO] [stderr] 152 | / match element { [INFO] [stderr] 153 | | &XmlEvent::StartElement { ref attributes, .. } => { [INFO] [stderr] 154 | | get_attribute(&attributes, attribute_key) [INFO] [stderr] 155 | | } [INFO] [stderr] 156 | | _ => None, [INFO] [stderr] 157 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 152 | match *element { [INFO] [stderr] 153 | XmlEvent::StartElement { ref attributes, .. } => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:122:9 [INFO] [stderr] | [INFO] [stderr] 122 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/models.rs:25:23 [INFO] [stderr] | [INFO] [stderr] 25 | match self.albums [INFO] [stderr] | _______________________^ [INFO] [stderr] 26 | | .iter() [INFO] [stderr] 27 | | .find(|&x| x.borrow().title == title) [INFO] [stderr] 28 | | .map(|x| x.clone()) { [INFO] [stderr] | |_____________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 25 | match self.albums [INFO] [stderr] 26 | .iter() [INFO] [stderr] 27 | .find(|&x| x.borrow().title == title).cloned() { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/models.rs:44:23 [INFO] [stderr] | [INFO] [stderr] 44 | match self.artists [INFO] [stderr] | _______________________^ [INFO] [stderr] 45 | | .iter() [INFO] [stderr] 46 | | .find(|&x| x.borrow().name == name) [INFO] [stderr] 47 | | .map(|x| x.clone()) { [INFO] [stderr] | |_____________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 44 | match self.artists [INFO] [stderr] 45 | .iter() [INFO] [stderr] 46 | .find(|&x| x.borrow().name == name).cloned() { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/models.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | / match Track::new(node, &artist_option, &album_option) { [INFO] [stderr] 63 | | Ok(track_inst) => { [INFO] [stderr] 64 | | let track = Rc::new(track_inst); [INFO] [stderr] 65 | | [INFO] [stderr] ... | [INFO] [stderr] 78 | | Err(_) => {} [INFO] [stderr] 79 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 62 | if let Ok(track_inst) = Track::new(node, &artist_option, &album_option) { [INFO] [stderr] 63 | let track = Rc::new(track_inst); [INFO] [stderr] 64 | [INFO] [stderr] 65 | self.tracks.push(track.clone()); [INFO] [stderr] 66 | if let Some(artist) = artist_option { [INFO] [stderr] 67 | let mut artist = artist.borrow_mut(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/parser.rs:71:37 [INFO] [stderr] | [INFO] [stderr] 71 | / match node_attributes.is_empty() { [INFO] [stderr] 72 | | true => { [INFO] [stderr] 73 | | if let XmlEvent::StartElement { attributes, .. } = e { [INFO] [stderr] 74 | | node_attributes = attributes; [INFO] [stderr] ... | [INFO] [stderr] 79 | | } [INFO] [stderr] 80 | | } [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 71 | if node_attributes.is_empty() { [INFO] [stderr] 72 | if let XmlEvent::StartElement { attributes, .. } = e { [INFO] [stderr] 73 | node_attributes = attributes; [INFO] [stderr] 74 | } [INFO] [stderr] 75 | } else { [INFO] [stderr] 76 | node_elements.push(e); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/parser.rs:126:44 [INFO] [stderr] | [INFO] [stderr] 126 | fn get_element_with_name<'a, 'b>(elements: &'a NodeElements, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/parser.rs:131:19 [INFO] [stderr] | [INFO] [stderr] 131 | .find(|x| match *x { [INFO] [stderr] | ___________________^ [INFO] [stderr] 132 | | &XmlEvent::StartElement { ref name, .. } => &name.local_name == lookup_name, [INFO] [stderr] 133 | | _ => false, [INFO] [stderr] 134 | | }) [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 131 | .find(|x| match *(*x) { [INFO] [stderr] 132 | XmlEvent::StartElement { ref name, .. } => &name.local_name == lookup_name, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/parser.rs:132:63 [INFO] [stderr] | [INFO] [stderr] 132 | &XmlEvent::StartElement { ref name, .. } => &name.local_name == lookup_name, [INFO] [stderr] | ----------------^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `name.local_name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/parser.rs:137:34 [INFO] [stderr] | [INFO] [stderr] 137 | pub fn get_attribute(attributes: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[xml::attribute::OwnedAttribute]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/parser.rs:146:40 [INFO] [stderr] | [INFO] [stderr] 146 | pub fn get_element_attribute(elements: &NodeElements, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/parser.rs:152:13 [INFO] [stderr] | [INFO] [stderr] 152 | / match element { [INFO] [stderr] 153 | | &XmlEvent::StartElement { ref attributes, .. } => { [INFO] [stderr] 154 | | get_attribute(&attributes, attribute_key) [INFO] [stderr] 155 | | } [INFO] [stderr] 156 | | _ => None, [INFO] [stderr] 157 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 152 | match *element { [INFO] [stderr] 153 | XmlEvent::StartElement { ref attributes, .. } => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.81s [INFO] running `"docker" "inspect" "94cfcc9f18de95a658e703469f7f252c11c5f463410e3916afc4ab8b9779b305"` [INFO] running `"docker" "rm" "-f" "94cfcc9f18de95a658e703469f7f252c11c5f463410e3916afc4ab8b9779b305"` [INFO] [stdout] 94cfcc9f18de95a658e703469f7f252c11c5f463410e3916afc4ab8b9779b305