[INFO] crate trace2_macro 0.1.0 is already in cache [INFO] extracting crate trace2_macro 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/trace2_macro/0.1.0 [INFO] extracting crate trace2_macro 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/trace2_macro/0.1.0 [INFO] validating manifest of trace2_macro-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of trace2_macro-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing trace2_macro-0.1.0 [INFO] finished frobbing trace2_macro-0.1.0 [INFO] frobbed toml for trace2_macro-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/trace2_macro/0.1.0/Cargo.toml [INFO] started frobbing trace2_macro-0.1.0 [INFO] finished frobbing trace2_macro-0.1.0 [INFO] frobbed toml for trace2_macro-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/trace2_macro/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting trace2_macro-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/trace2_macro/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 44bed685c217edc6a0a00ba8198920b05d7beebb7e5812e60923dafc9250b6a8 [INFO] running `"docker" "start" "-a" "44bed685c217edc6a0a00ba8198920b05d7beebb7e5812e60923dafc9250b6a8"` [INFO] [stderr] Checking syn v0.14.9 [INFO] [stderr] Checking trace2_macro v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> codegen.rs:22:20 [INFO] [stderr] | [INFO] [stderr] 22 | if ident.ident.to_string() != "self" { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `*ident.ident` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> folder.rs:84:20 [INFO] [stderr] | [INFO] [stderr] 84 | if last.ident.to_string() == "trace2" { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `*last.ident` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> folder.rs:99:16 [INFO] [stderr] | [INFO] [stderr] 99 | if let Some(_) = some_config { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 100 | | // we are folding from a larger scope, ignore this [INFO] [stderr] 101 | | if self.scope > FoldScope::Fn { [INFO] [stderr] 102 | | return i; [INFO] [stderr] 103 | | } [INFO] [stderr] 104 | | } [INFO] [stderr] | |_________- help: try this: `if some_config.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> folder.rs:113:16 [INFO] [stderr] | [INFO] [stderr] 113 | if let Some(_) = some_config { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 114 | | // we are folding from a larger scope, ignore this [INFO] [stderr] 115 | | if self.scope > FoldScope::Fn { [INFO] [stderr] 116 | | return i; [INFO] [stderr] 117 | | } [INFO] [stderr] 118 | | } [INFO] [stderr] | |_________- help: try this: `if some_config.is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> folder.rs:140:16 [INFO] [stderr] | [INFO] [stderr] 140 | if let Some(_) = some_config { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 141 | | // we are folding from a larger scope, ignore this [INFO] [stderr] 142 | | if self.scope > FoldScope::Impl { [INFO] [stderr] 143 | | return i; [INFO] [stderr] 144 | | } [INFO] [stderr] 145 | | } [INFO] [stderr] | |_________- help: try this: `if some_config.is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> folder.rs:180:5 [INFO] [stderr] | [INFO] [stderr] 180 | / named!(parse -> Self, do_parse!( [INFO] [stderr] 181 | | config: option!(parens!(syn!(Config))) >> [INFO] [stderr] 182 | | (AttrTTS(config.map(|pair| pair.1).unwrap_or_default())) [INFO] [stderr] 183 | | )); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> codegen.rs:22:20 [INFO] [stderr] | [INFO] [stderr] 22 | if ident.ident.to_string() != "self" { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `*ident.ident` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> folder.rs:84:20 [INFO] [stderr] | [INFO] [stderr] 84 | if last.ident.to_string() == "trace2" { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `*last.ident` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> folder.rs:99:16 [INFO] [stderr] | [INFO] [stderr] 99 | if let Some(_) = some_config { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 100 | | // we are folding from a larger scope, ignore this [INFO] [stderr] 101 | | if self.scope > FoldScope::Fn { [INFO] [stderr] 102 | | return i; [INFO] [stderr] 103 | | } [INFO] [stderr] 104 | | } [INFO] [stderr] | |_________- help: try this: `if some_config.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> folder.rs:113:16 [INFO] [stderr] | [INFO] [stderr] 113 | if let Some(_) = some_config { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 114 | | // we are folding from a larger scope, ignore this [INFO] [stderr] 115 | | if self.scope > FoldScope::Fn { [INFO] [stderr] 116 | | return i; [INFO] [stderr] 117 | | } [INFO] [stderr] 118 | | } [INFO] [stderr] | |_________- help: try this: `if some_config.is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> folder.rs:140:16 [INFO] [stderr] | [INFO] [stderr] 140 | if let Some(_) = some_config { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 141 | | // we are folding from a larger scope, ignore this [INFO] [stderr] 142 | | if self.scope > FoldScope::Impl { [INFO] [stderr] 143 | | return i; [INFO] [stderr] 144 | | } [INFO] [stderr] 145 | | } [INFO] [stderr] | |_________- help: try this: `if some_config.is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> folder.rs:180:5 [INFO] [stderr] | [INFO] [stderr] 180 | / named!(parse -> Self, do_parse!( [INFO] [stderr] 181 | | config: option!(parens!(syn!(Config))) >> [INFO] [stderr] 182 | | (AttrTTS(config.map(|pair| pair.1).unwrap_or_default())) [INFO] [stderr] 183 | | )); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 11.56s [INFO] running `"docker" "inspect" "44bed685c217edc6a0a00ba8198920b05d7beebb7e5812e60923dafc9250b6a8"` [INFO] running `"docker" "rm" "-f" "44bed685c217edc6a0a00ba8198920b05d7beebb7e5812e60923dafc9250b6a8"` [INFO] [stdout] 44bed685c217edc6a0a00ba8198920b05d7beebb7e5812e60923dafc9250b6a8