[INFO] crate tower-web-macros 0.3.2 is already in cache [INFO] extracting crate tower-web-macros 0.3.2 into work/ex/clippy-test-run/sources/stable/reg/tower-web-macros/0.3.2 [INFO] extracting crate tower-web-macros 0.3.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tower-web-macros/0.3.2 [INFO] validating manifest of tower-web-macros-0.3.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tower-web-macros-0.3.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tower-web-macros-0.3.2 [INFO] finished frobbing tower-web-macros-0.3.2 [INFO] frobbed toml for tower-web-macros-0.3.2 written to work/ex/clippy-test-run/sources/stable/reg/tower-web-macros/0.3.2/Cargo.toml [INFO] started frobbing tower-web-macros-0.3.2 [INFO] finished frobbing tower-web-macros-0.3.2 [INFO] frobbed toml for tower-web-macros-0.3.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tower-web-macros/0.3.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tower-web-macros-0.3.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/tower-web-macros/0.3.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b2d23db4483cb5b65323962ab6a5b0f253929e57d495636ac1d38523a6bca5b8 [INFO] running `"docker" "start" "-a" "b2d23db4483cb5b65323962ab6a5b0f253929e57d495636ac1d38523a6bca5b8"` [INFO] [stderr] Checking syn v0.15.26 [INFO] [stderr] Checking tower-web-macros v0.3.2 (/opt/crater/workdir) [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/resource/mod.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | mod resource; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/resource/mod.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | mod resource; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/derive/extract.rs:131:20 [INFO] [stderr] | [INFO] [stderr] 131 | fn from_shadow(&self) -> TokenStream { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/derive/response.rs:564:45 [INFO] [stderr] | [INFO] [stderr] 564 | self.err = Some(format!("`template` attribute must be at the struct level.")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"`template` attribute must be at the struct level.".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/resource/attr.rs:206:49 [INFO] [stderr] | [INFO] [stderr] 206 | self.path_captures = path.split("/") [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/resource/attr.rs:271:32 [INFO] [stderr] | [INFO] [stderr] 271 | for (i, b) in s.as_bytes().into_iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/derive/extract.rs:131:20 [INFO] [stderr] | [INFO] [stderr] 131 | fn from_shadow(&self) -> TokenStream { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/derive/response.rs:564:45 [INFO] [stderr] | [INFO] [stderr] 564 | self.err = Some(format!("`template` attribute must be at the struct level.")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"`template` attribute must be at the struct level.".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/resource/attr.rs:206:49 [INFO] [stderr] | [INFO] [stderr] 206 | self.path_captures = path.split("/") [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/resource/attr.rs:271:32 [INFO] [stderr] | [INFO] [stderr] 271 | for (i, b) in s.as_bytes().into_iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/resource/ty_tree.rs:99:5 [INFO] [stderr] | [INFO] [stderr] 99 | / let mut rem = 0; [INFO] [stderr] 100 | | [INFO] [stderr] 101 | | if src.len() > ::MAX_VARIANTS { [INFO] [stderr] 102 | | rem = src.len() % ::MAX_VARIANTS; [INFO] [stderr] 103 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let rem = if src.len() > ::MAX_VARIANTS { src.len() % ::MAX_VARIANTS } else { 0 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/resource/ty_tree.rs:99:5 [INFO] [stderr] | [INFO] [stderr] 99 | / let mut rem = 0; [INFO] [stderr] 100 | | [INFO] [stderr] 101 | | if src.len() > ::MAX_VARIANTS { [INFO] [stderr] 102 | | rem = src.len() % ::MAX_VARIANTS; [INFO] [stderr] 103 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let rem = if src.len() > ::MAX_VARIANTS { src.len() % ::MAX_VARIANTS } else { 0 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 14.81s [INFO] running `"docker" "inspect" "b2d23db4483cb5b65323962ab6a5b0f253929e57d495636ac1d38523a6bca5b8"` [INFO] running `"docker" "rm" "-f" "b2d23db4483cb5b65323962ab6a5b0f253929e57d495636ac1d38523a6bca5b8"` [INFO] [stdout] b2d23db4483cb5b65323962ab6a5b0f253929e57d495636ac1d38523a6bca5b8