[INFO] crate tongue 0.1.2 is already in cache [INFO] extracting crate tongue 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/tongue/0.1.2 [INFO] extracting crate tongue 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tongue/0.1.2 [INFO] validating manifest of tongue-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tongue-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tongue-0.1.2 [INFO] finished frobbing tongue-0.1.2 [INFO] frobbed toml for tongue-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/tongue/0.1.2/Cargo.toml [INFO] started frobbing tongue-0.1.2 [INFO] finished frobbing tongue-0.1.2 [INFO] frobbed toml for tongue-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tongue/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tongue-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/tongue/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7194f3d4b0255103621642db86dd3098cc2e512a8828af61ece3189162b3f2ae [INFO] running `"docker" "start" "-a" "7194f3d4b0255103621642db86dd3098cc2e512a8828af61ece3189162b3f2ae"` [INFO] [stderr] Checking tongue v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/tongue/terminal.rs:55:25 [INFO] [stderr] | [INFO] [stderr] 55 | term.c_cflag |= (libc::CS8); [INFO] [stderr] | ^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/tongue/input.rs:72:17 [INFO] [stderr] | [INFO] [stderr] 72 | / if buffer[1] == 91 { [INFO] [stderr] 73 | | if buffer[2] == 65 { [INFO] [stderr] 74 | | // Up [INFO] [stderr] 75 | | match config.history.pop() { [INFO] [stderr] ... | [INFO] [stderr] 90 | | } [INFO] [stderr] 91 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 72 | if buffer[1] == 91 && buffer[2] == 65 { [INFO] [stderr] 73 | // Up [INFO] [stderr] 74 | match config.history.pop() { [INFO] [stderr] 75 | Some(last_history) => { [INFO] [stderr] 76 | line = last_history; [INFO] [stderr] 77 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unused variable: `n` [INFO] [stderr] --> src/tongue/evaluator.rs:60:16 [INFO] [stderr] | [INFO] [stderr] 60 | Ok(n) => {}, [INFO] [stderr] | ^ help: consider using `_n` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/tongue/evaluator.rs:23:10 [INFO] [stderr] | [INFO] [stderr] 23 | fn _eval(mut n: Node, config: &mut Config) { [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: The function/method `libc::tcsetattr` doesn't need a mutable reference [INFO] [stderr] --> src/tongue/terminal.rs:45:62 [INFO] [stderr] | [INFO] [stderr] 45 | libc::tcsetattr(libc::STDIN_FILENO, libc::TCSAFLUSH, &mut term); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `libc::tcsetattr` doesn't need a mutable reference [INFO] [stderr] --> src/tongue/terminal.rs:59:62 [INFO] [stderr] | [INFO] [stderr] 59 | libc::tcsetattr(libc::STDIN_FILENO, libc::TCSAFLUSH, &mut term); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/tongue/util.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | handle.read(&mut buffer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/tongue/util.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | buf_writer.write(s.as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/tongue/util.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | buf_writer.flush(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/tongue/input.rs:26:20 [INFO] [stderr] | [INFO] [stderr] 26 | if line.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/tongue/input.rs:38:20 [INFO] [stderr] | [INFO] [stderr] 38 | if line.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/tongue/input.rs:44:20 [INFO] [stderr] | [INFO] [stderr] 44 | if line.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/tongue/input.rs:94:20 [INFO] [stderr] | [INFO] [stderr] 94 | if line.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/tongue/lexer.rs:17:12 [INFO] [stderr] | [INFO] [stderr] 17 | if is_string == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `is_string` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/tongue/lexer.rs:22:32 [INFO] [stderr] | [INFO] [stderr] 22 | if token.is_empty() == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!token.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/tongue/lexer.rs:43:28 [INFO] [stderr] | [INFO] [stderr] 43 | if token.is_empty() == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!token.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/tongue/lexer.rs:49:28 [INFO] [stderr] | [INFO] [stderr] 49 | if token.is_empty() == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!token.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/tongue/lexer.rs:57:28 [INFO] [stderr] | [INFO] [stderr] 57 | if token.is_empty() == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!token.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/tongue/lexer.rs:65:28 [INFO] [stderr] | [INFO] [stderr] 65 | if token.is_empty() == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!token.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/tongue/lexer.rs:72:28 [INFO] [stderr] | [INFO] [stderr] 72 | if token.is_empty() == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!token.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/tongue/lexer.rs:83:20 [INFO] [stderr] | [INFO] [stderr] 83 | if token.is_empty() == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!token.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/tongue/node.rs:33:53 [INFO] [stderr] | [INFO] [stderr] 33 | } else if self.l != None && other.l == None { [INFO] [stderr] | _____________________________________________________^ [INFO] [stderr] 34 | | return false; [INFO] [stderr] 35 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/tongue/node.rs:31:53 [INFO] [stderr] | [INFO] [stderr] 31 | } else if self.l == None && other.l != None { [INFO] [stderr] | _____________________________________________________^ [INFO] [stderr] 32 | | return false; [INFO] [stderr] 33 | | } else if self.l != None && other.l == None { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/tongue/node.rs:41:53 [INFO] [stderr] | [INFO] [stderr] 41 | } else if self.r != None && other.r == None { [INFO] [stderr] | _____________________________________________________^ [INFO] [stderr] 42 | | return false; [INFO] [stderr] 43 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/tongue/node.rs:39:53 [INFO] [stderr] | [INFO] [stderr] 39 | } else if self.r == None && other.r != None { [INFO] [stderr] | _____________________________________________________^ [INFO] [stderr] 40 | | return false; [INFO] [stderr] 41 | | } else if self.r != None && other.r == None { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/tongue/node.rs:53:19 [INFO] [stderr] | [INFO] [stderr] 53 | } else if self.options.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.options.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/tongue/terminal.rs:55:25 [INFO] [stderr] | [INFO] [stderr] 55 | term.c_cflag |= (libc::CS8); [INFO] [stderr] | ^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/tongue/input.rs:72:17 [INFO] [stderr] | [INFO] [stderr] 72 | / if buffer[1] == 91 { [INFO] [stderr] 73 | | if buffer[2] == 65 { [INFO] [stderr] 74 | | // Up [INFO] [stderr] 75 | | match config.history.pop() { [INFO] [stderr] ... | [INFO] [stderr] 90 | | } [INFO] [stderr] 91 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 72 | if buffer[1] == 91 && buffer[2] == 65 { [INFO] [stderr] 73 | // Up [INFO] [stderr] 74 | match config.history.pop() { [INFO] [stderr] 75 | Some(last_history) => { [INFO] [stderr] 76 | line = last_history; [INFO] [stderr] 77 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/tongue/node.rs:77:5 [INFO] [stderr] | [INFO] [stderr] 77 | / match node.l { [INFO] [stderr] 78 | | Some(n) => { [INFO] [stderr] 79 | | s.push_str(" "); [INFO] [stderr] 80 | | s.push_str(&print_node(*n.clone())); [INFO] [stderr] ... | [INFO] [stderr] 83 | | }, [INFO] [stderr] 84 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 77 | if let Some(n) = node.l { [INFO] [stderr] 78 | s.push_str(" "); [INFO] [stderr] 79 | s.push_str(&print_node(*n.clone())); [INFO] [stderr] 80 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/tongue/node.rs:86:5 [INFO] [stderr] | [INFO] [stderr] 86 | / match node.r { [INFO] [stderr] 87 | | Some(n) => { [INFO] [stderr] 88 | | s.push_str(" "); [INFO] [stderr] 89 | | s.push_str(&print_node(*n.clone())); [INFO] [stderr] ... | [INFO] [stderr] 92 | | }, [INFO] [stderr] 93 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 86 | if let Some(n) = node.r { [INFO] [stderr] 87 | s.push_str(" "); [INFO] [stderr] 88 | s.push_str(&print_node(*n.clone())); [INFO] [stderr] 89 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/tongue/parser.rs:56:17 [INFO] [stderr] | [INFO] [stderr] 56 | / match tmp.r { [INFO] [stderr] 57 | | Some(r) => { [INFO] [stderr] 58 | | root.r = Some(Box::new(insert(*r, v))); [INFO] [stderr] 59 | | }, [INFO] [stderr] ... | [INFO] [stderr] 62 | | }, [INFO] [stderr] 63 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 56 | if let Some(r) = tmp.r { [INFO] [stderr] 57 | root.r = Some(Box::new(insert(*r, v))); [INFO] [stderr] 58 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/tongue/evaluator.rs:43:27 [INFO] [stderr] | [INFO] [stderr] 43 | } else if n.v == "cd" { [INFO] [stderr] | ___________________________^ [INFO] [stderr] 44 | | exec(n, config); [INFO] [stderr] 45 | | } else { [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/tongue/evaluator.rs:41:30 [INFO] [stderr] | [INFO] [stderr] 41 | } else if n.v == "alias" { [INFO] [stderr] | ______________________________^ [INFO] [stderr] 42 | | exec(n, config); [INFO] [stderr] 43 | | } else if n.v == "cd" { [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/tongue/evaluator.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | / match n.l { [INFO] [stderr] 27 | | Some(l) => { [INFO] [stderr] 28 | | match n.r { [INFO] [stderr] 29 | | Some(r) => { [INFO] [stderr] ... | [INFO] [stderr] 39 | | }, [INFO] [stderr] 40 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 26 | if let Some(l) = n.l { [INFO] [stderr] 27 | match n.r { [INFO] [stderr] 28 | Some(r) => { [INFO] [stderr] 29 | config.variable.insert(l.v, r.v); [INFO] [stderr] 30 | }, [INFO] [stderr] 31 | None => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/tongue/evaluator.rs:28:17 [INFO] [stderr] | [INFO] [stderr] 28 | / match n.r { [INFO] [stderr] 29 | | Some(r) => { [INFO] [stderr] 30 | | config.variable.insert(l.v, r.v); [INFO] [stderr] 31 | | }, [INFO] [stderr] ... | [INFO] [stderr] 34 | | }, [INFO] [stderr] 35 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 28 | if let Some(r) = n.r { [INFO] [stderr] 29 | config.variable.insert(l.v, r.v); [INFO] [stderr] 30 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/tongue/builtin.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | / match config.aliase.get(key) { [INFO] [stderr] 14 | | Some(val) => { [INFO] [stderr] 15 | | println!("{} -> {}", key, val); [INFO] [stderr] 16 | | }, [INFO] [stderr] 17 | | None => {}, [INFO] [stderr] 18 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 13 | if let Some(val) = config.aliase.get(key) { [INFO] [stderr] 14 | println!("{} -> {}", key, val); [INFO] [stderr] 15 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `tongue`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unused variable: `n` [INFO] [stderr] --> src/tongue/evaluator.rs:60:16 [INFO] [stderr] | [INFO] [stderr] 60 | Ok(n) => {}, [INFO] [stderr] | ^ help: consider using `_n` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `expected` [INFO] [stderr] --> src/tongue/lexer.rs:160:13 [INFO] [stderr] | [INFO] [stderr] 160 | let expected: Vec = vec![ [INFO] [stderr] | ^^^^^^^^ help: consider using `_expected` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `got` [INFO] [stderr] --> src/tongue/lexer.rs:166:13 [INFO] [stderr] | [INFO] [stderr] 166 | let got = tokenize("println(\"Hello, World!\")"); [INFO] [stderr] | ^^^ help: consider using `_got` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `node` [INFO] [stderr] --> src/tongue/parser.rs:129:9 [INFO] [stderr] | [INFO] [stderr] 129 | let node = Node { [INFO] [stderr] | ^^^^ help: consider using `_node` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/tongue/evaluator.rs:23:10 [INFO] [stderr] | [INFO] [stderr] 23 | fn _eval(mut n: Node, config: &mut Config) { [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: The function/method `libc::tcsetattr` doesn't need a mutable reference [INFO] [stderr] --> src/tongue/terminal.rs:45:62 [INFO] [stderr] | [INFO] [stderr] 45 | libc::tcsetattr(libc::STDIN_FILENO, libc::TCSAFLUSH, &mut term); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `libc::tcsetattr` doesn't need a mutable reference [INFO] [stderr] --> src/tongue/terminal.rs:59:62 [INFO] [stderr] | [INFO] [stderr] 59 | libc::tcsetattr(libc::STDIN_FILENO, libc::TCSAFLUSH, &mut term); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/tongue/util.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | handle.read(&mut buffer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/tongue/util.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | buf_writer.write(s.as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/tongue/util.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | buf_writer.flush(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/tongue/input.rs:26:20 [INFO] [stderr] | [INFO] [stderr] 26 | if line.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/tongue/input.rs:38:20 [INFO] [stderr] | [INFO] [stderr] 38 | if line.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/tongue/input.rs:44:20 [INFO] [stderr] | [INFO] [stderr] 44 | if line.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/tongue/input.rs:94:20 [INFO] [stderr] | [INFO] [stderr] 94 | if line.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/tongue/lexer.rs:17:12 [INFO] [stderr] | [INFO] [stderr] 17 | if is_string == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `is_string` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/tongue/lexer.rs:22:32 [INFO] [stderr] | [INFO] [stderr] 22 | if token.is_empty() == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!token.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/tongue/lexer.rs:43:28 [INFO] [stderr] | [INFO] [stderr] 43 | if token.is_empty() == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!token.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/tongue/lexer.rs:49:28 [INFO] [stderr] | [INFO] [stderr] 49 | if token.is_empty() == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!token.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/tongue/lexer.rs:57:28 [INFO] [stderr] | [INFO] [stderr] 57 | if token.is_empty() == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!token.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/tongue/lexer.rs:65:28 [INFO] [stderr] | [INFO] [stderr] 65 | if token.is_empty() == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!token.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/tongue/lexer.rs:72:28 [INFO] [stderr] | [INFO] [stderr] 72 | if token.is_empty() == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!token.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/tongue/lexer.rs:83:20 [INFO] [stderr] | [INFO] [stderr] 83 | if token.is_empty() == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!token.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/tongue/node.rs:33:53 [INFO] [stderr] | [INFO] [stderr] 33 | } else if self.l != None && other.l == None { [INFO] [stderr] | _____________________________________________________^ [INFO] [stderr] 34 | | return false; [INFO] [stderr] 35 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/tongue/node.rs:31:53 [INFO] [stderr] | [INFO] [stderr] 31 | } else if self.l == None && other.l != None { [INFO] [stderr] | _____________________________________________________^ [INFO] [stderr] 32 | | return false; [INFO] [stderr] 33 | | } else if self.l != None && other.l == None { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/tongue/node.rs:41:53 [INFO] [stderr] | [INFO] [stderr] 41 | } else if self.r != None && other.r == None { [INFO] [stderr] | _____________________________________________________^ [INFO] [stderr] 42 | | return false; [INFO] [stderr] 43 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/tongue/node.rs:39:53 [INFO] [stderr] | [INFO] [stderr] 39 | } else if self.r == None && other.r != None { [INFO] [stderr] | _____________________________________________________^ [INFO] [stderr] 40 | | return false; [INFO] [stderr] 41 | | } else if self.r != None && other.r == None { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/tongue/node.rs:53:19 [INFO] [stderr] | [INFO] [stderr] 53 | } else if self.options.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.options.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/tongue/node.rs:77:5 [INFO] [stderr] | [INFO] [stderr] 77 | / match node.l { [INFO] [stderr] 78 | | Some(n) => { [INFO] [stderr] 79 | | s.push_str(" "); [INFO] [stderr] 80 | | s.push_str(&print_node(*n.clone())); [INFO] [stderr] ... | [INFO] [stderr] 83 | | }, [INFO] [stderr] 84 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 77 | if let Some(n) = node.l { [INFO] [stderr] 78 | s.push_str(" "); [INFO] [stderr] 79 | s.push_str(&print_node(*n.clone())); [INFO] [stderr] 80 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/tongue/node.rs:86:5 [INFO] [stderr] | [INFO] [stderr] 86 | / match node.r { [INFO] [stderr] 87 | | Some(n) => { [INFO] [stderr] 88 | | s.push_str(" "); [INFO] [stderr] 89 | | s.push_str(&print_node(*n.clone())); [INFO] [stderr] ... | [INFO] [stderr] 92 | | }, [INFO] [stderr] 93 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 86 | if let Some(n) = node.r { [INFO] [stderr] 87 | s.push_str(" "); [INFO] [stderr] 88 | s.push_str(&print_node(*n.clone())); [INFO] [stderr] 89 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/tongue/parser.rs:56:17 [INFO] [stderr] | [INFO] [stderr] 56 | / match tmp.r { [INFO] [stderr] 57 | | Some(r) => { [INFO] [stderr] 58 | | root.r = Some(Box::new(insert(*r, v))); [INFO] [stderr] 59 | | }, [INFO] [stderr] ... | [INFO] [stderr] 62 | | }, [INFO] [stderr] 63 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 56 | if let Some(r) = tmp.r { [INFO] [stderr] 57 | root.r = Some(Box::new(insert(*r, v))); [INFO] [stderr] 58 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/tongue/evaluator.rs:43:27 [INFO] [stderr] | [INFO] [stderr] 43 | } else if n.v == "cd" { [INFO] [stderr] | ___________________________^ [INFO] [stderr] 44 | | exec(n, config); [INFO] [stderr] 45 | | } else { [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/tongue/evaluator.rs:41:30 [INFO] [stderr] | [INFO] [stderr] 41 | } else if n.v == "alias" { [INFO] [stderr] | ______________________________^ [INFO] [stderr] 42 | | exec(n, config); [INFO] [stderr] 43 | | } else if n.v == "cd" { [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/tongue/evaluator.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | / match n.l { [INFO] [stderr] 27 | | Some(l) => { [INFO] [stderr] 28 | | match n.r { [INFO] [stderr] 29 | | Some(r) => { [INFO] [stderr] ... | [INFO] [stderr] 39 | | }, [INFO] [stderr] 40 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 26 | if let Some(l) = n.l { [INFO] [stderr] 27 | match n.r { [INFO] [stderr] 28 | Some(r) => { [INFO] [stderr] 29 | config.variable.insert(l.v, r.v); [INFO] [stderr] 30 | }, [INFO] [stderr] 31 | None => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/tongue/evaluator.rs:28:17 [INFO] [stderr] | [INFO] [stderr] 28 | / match n.r { [INFO] [stderr] 29 | | Some(r) => { [INFO] [stderr] 30 | | config.variable.insert(l.v, r.v); [INFO] [stderr] 31 | | }, [INFO] [stderr] ... | [INFO] [stderr] 34 | | }, [INFO] [stderr] 35 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 28 | if let Some(r) = n.r { [INFO] [stderr] 29 | config.variable.insert(l.v, r.v); [INFO] [stderr] 30 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/tongue/builtin.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | / match config.aliase.get(key) { [INFO] [stderr] 14 | | Some(val) => { [INFO] [stderr] 15 | | println!("{} -> {}", key, val); [INFO] [stderr] 16 | | }, [INFO] [stderr] 17 | | None => {}, [INFO] [stderr] 18 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 13 | if let Some(val) = config.aliase.get(key) { [INFO] [stderr] 14 | println!("{} -> {}", key, val); [INFO] [stderr] 15 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `tongue`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "7194f3d4b0255103621642db86dd3098cc2e512a8828af61ece3189162b3f2ae"` [INFO] running `"docker" "rm" "-f" "7194f3d4b0255103621642db86dd3098cc2e512a8828af61ece3189162b3f2ae"` [INFO] [stdout] 7194f3d4b0255103621642db86dd3098cc2e512a8828af61ece3189162b3f2ae