[INFO] crate tomlcli 0.2.0 is already in cache [INFO] extracting crate tomlcli 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/tomlcli/0.2.0 [INFO] extracting crate tomlcli 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tomlcli/0.2.0 [INFO] validating manifest of tomlcli-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tomlcli-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tomlcli-0.2.0 [INFO] finished frobbing tomlcli-0.2.0 [INFO] frobbed toml for tomlcli-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/tomlcli/0.2.0/Cargo.toml [INFO] started frobbing tomlcli-0.2.0 [INFO] finished frobbing tomlcli-0.2.0 [INFO] frobbed toml for tomlcli-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tomlcli/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tomlcli-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/tomlcli/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 35e77c93efbd459bd5751d322e13fcab5e55f3cd878f7bef2e58c09d1c88a5fd [INFO] running `"docker" "start" "-a" "35e77c93efbd459bd5751d322e13fcab5e55f3cd878f7bef2e58c09d1c88a5fd"` [INFO] [stderr] Checking tomlcli v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | / match *boolean { [INFO] [stderr] 71 | | true => print!("{}", yellow("true", has_color)), [INFO] [stderr] 72 | | false => print!("{}", yellow("false", has_color)), [INFO] [stderr] 73 | | } [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if *boolean { print!("{}", yellow("true", has_color)) } else { print!("{}", yellow("false", has_color)) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:105:17 [INFO] [stderr] | [INFO] [stderr] 105 | / match *value { [INFO] [stderr] 106 | | Value::Table(ref table) => { [INFO] [stderr] 107 | | #[allow(unused_assignments)] [INFO] [stderr] 108 | | [INFO] [stderr] ... | [INFO] [stderr] 124 | | _ => {} [INFO] [stderr] 125 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 105 | if let Value::Table(ref table) = *value { [INFO] [stderr] 106 | #[allow(unused_assignments)] [INFO] [stderr] 107 | [INFO] [stderr] 108 | let mut fullname = if let Some(parent_name) = parent_name { [INFO] [stderr] 109 | format!("{}.{}", parent_name, name) [INFO] [stderr] 110 | } else { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:132:44 [INFO] [stderr] | [INFO] [stderr] 132 | fn select_path<'a>(value: &'a Value, path: &String) -> Option<&'a Value> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | / match *boolean { [INFO] [stderr] 71 | | true => print!("{}", yellow("true", has_color)), [INFO] [stderr] 72 | | false => print!("{}", yellow("false", has_color)), [INFO] [stderr] 73 | | } [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if *boolean { print!("{}", yellow("true", has_color)) } else { print!("{}", yellow("false", has_color)) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:105:17 [INFO] [stderr] | [INFO] [stderr] 105 | / match *value { [INFO] [stderr] 106 | | Value::Table(ref table) => { [INFO] [stderr] 107 | | #[allow(unused_assignments)] [INFO] [stderr] 108 | | [INFO] [stderr] ... | [INFO] [stderr] 124 | | _ => {} [INFO] [stderr] 125 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 105 | if let Value::Table(ref table) = *value { [INFO] [stderr] 106 | #[allow(unused_assignments)] [INFO] [stderr] 107 | [INFO] [stderr] 108 | let mut fullname = if let Some(parent_name) = parent_name { [INFO] [stderr] 109 | format!("{}.{}", parent_name, name) [INFO] [stderr] 110 | } else { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:132:44 [INFO] [stderr] | [INFO] [stderr] 132 | fn select_path<'a>(value: &'a Value, path: &String) -> Option<&'a Value> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.98s [INFO] running `"docker" "inspect" "35e77c93efbd459bd5751d322e13fcab5e55f3cd878f7bef2e58c09d1c88a5fd"` [INFO] running `"docker" "rm" "-f" "35e77c93efbd459bd5751d322e13fcab5e55f3cd878f7bef2e58c09d1c88a5fd"` [INFO] [stdout] 35e77c93efbd459bd5751d322e13fcab5e55f3cd878f7bef2e58c09d1c88a5fd