[INFO] crate toml_document 0.1.3 is already in cache [INFO] extracting crate toml_document 0.1.3 into work/ex/clippy-test-run/sources/stable/reg/toml_document/0.1.3 [INFO] extracting crate toml_document 0.1.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/toml_document/0.1.3 [INFO] validating manifest of toml_document-0.1.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of toml_document-0.1.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing toml_document-0.1.3 [INFO] finished frobbing toml_document-0.1.3 [INFO] frobbed toml for toml_document-0.1.3 written to work/ex/clippy-test-run/sources/stable/reg/toml_document/0.1.3/Cargo.toml [INFO] started frobbing toml_document-0.1.3 [INFO] finished frobbing toml_document-0.1.3 [INFO] frobbed toml for toml_document-0.1.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/toml_document/0.1.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting toml_document-0.1.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/toml_document/0.1.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] cf02d5cbe5250aeb2d8eb19f939db262625127f5c0130d009c9cd1869af66345 [INFO] running `"docker" "start" "-a" "cf02d5cbe5250aeb2d8eb19f939db262625127f5c0130d009c9cd1869af66345"` [INFO] [stderr] Checking toml_document v0.1.3 (/opt/crater/workdir) [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | lo: lo, [INFO] [stderr] | ^^^^^^ help: replace it with: `lo` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:3:24 [INFO] [stderr] | [INFO] [stderr] 3 | #![cfg_attr(test, deny(warnings))] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::redundant_field_names)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:101:13 [INFO] [stderr] | [INFO] [stderr] 101 | hi: hi, [INFO] [stderr] | ^^^^^^ help: replace it with: `hi` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:330:21 [INFO] [stderr] | [INFO] [stderr] 330 | lo: lo, [INFO] [stderr] | ^^^^^^ help: replace it with: `lo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:331:21 [INFO] [stderr] | [INFO] [stderr] 331 | hi: hi, [INFO] [stderr] | ^^^^^^ help: replace it with: `hi` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:528:51 [INFO] [stderr] | [INFO] [stderr] 528 | return Some(DocValue::String(StringData { raw: raw, escaped: ret })); [INFO] [stderr] | ^^^^^^^^ help: replace it with: `raw` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/public.rs:979:17 [INFO] [stderr] | [INFO] [stderr] 979 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:164:13 [INFO] [stderr] | [INFO] [stderr] 164 | key: key, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:165:13 [INFO] [stderr] | [INFO] [stderr] 165 | value: value [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:218:17 [INFO] [stderr] | [INFO] [stderr] 218 | lead: lead, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `lead` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:381:13 [INFO] [stderr] | [INFO] [stderr] 381 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:390:13 [INFO] [stderr] | [INFO] [stderr] 390 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:413:13 [INFO] [stderr] | [INFO] [stderr] 413 | lead: lead, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `lead` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:475:17 [INFO] [stderr] | [INFO] [stderr] 475 | lead: lead, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `lead` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:476:17 [INFO] [stderr] | [INFO] [stderr] 476 | trail: trail, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `trail` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:486:13 [INFO] [stderr] | [INFO] [stderr] 486 | raw: raw, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `raw` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | lo: lo, [INFO] [stderr] | ^^^^^^ help: replace it with: `lo` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:101:13 [INFO] [stderr] | [INFO] [stderr] 101 | hi: hi, [INFO] [stderr] | ^^^^^^ help: replace it with: `hi` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:330:21 [INFO] [stderr] | [INFO] [stderr] 330 | lo: lo, [INFO] [stderr] | ^^^^^^ help: replace it with: `lo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:331:21 [INFO] [stderr] | [INFO] [stderr] 331 | hi: hi, [INFO] [stderr] | ^^^^^^ help: replace it with: `hi` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:528:51 [INFO] [stderr] | [INFO] [stderr] 528 | return Some(DocValue::String(StringData { raw: raw, escaped: ret })); [INFO] [stderr] | ^^^^^^^^ help: replace it with: `raw` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/public.rs:979:17 [INFO] [stderr] | [INFO] [stderr] 979 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:164:13 [INFO] [stderr] | [INFO] [stderr] 164 | key: key, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:165:13 [INFO] [stderr] | [INFO] [stderr] 165 | value: value [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:218:17 [INFO] [stderr] | [INFO] [stderr] 218 | lead: lead, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `lead` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:381:13 [INFO] [stderr] | [INFO] [stderr] 381 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:390:13 [INFO] [stderr] | [INFO] [stderr] 390 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:413:13 [INFO] [stderr] | [INFO] [stderr] 413 | lead: lead, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `lead` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:475:17 [INFO] [stderr] | [INFO] [stderr] 475 | lead: lead, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `lead` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:476:17 [INFO] [stderr] | [INFO] [stderr] 476 | trail: trail, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `trail` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:486:13 [INFO] [stderr] | [INFO] [stderr] 486 | raw: raw, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `raw` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:73:9 [INFO] [stderr] | [INFO] [stderr] 73 | return (self.input.lines().count(), 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(self.input.lines().count(), 0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/parser.rs:238:20 [INFO] [stderr] | [INFO] [stderr] 238 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 239 | | if !self.values(&mut ret.values) { return None } [INFO] [stderr] 240 | | } [INFO] [stderr] | |_____________^ help: try: `if !self.values(&mut ret.values) { return None }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:528:9 [INFO] [stderr] | [INFO] [stderr] 528 | return Some(DocValue::String(StringData { raw: raw, escaped: ret })); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(DocValue::String(StringData { raw: raw, escaped: ret }))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:577:9 [INFO] [stderr] | [INFO] [stderr] 577 | return ret; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `ret` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:637:13 [INFO] [stderr] | [INFO] [stderr] 637 | return None [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:767:9 [INFO] [stderr] | [INFO] [stderr] 767 | / return Some(DocValue::InlineArray( [INFO] [stderr] 768 | | InlineArrayData { values: ret, comma_trail: "".to_string() } [INFO] [stderr] 769 | | )) [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 767 | Some(DocValue::InlineArray( [INFO] [stderr] 768 | InlineArrayData { values: ret, comma_trail: "".to_string() } [INFO] [stderr] 769 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:791:9 [INFO] [stderr] | [INFO] [stderr] 791 | return Some(DocValue::new_table(ret, String::new())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(DocValue::new_table(ret, String::new()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:937:13 [INFO] [stderr] | [INFO] [stderr] 937 | / return Result::Err(ParserError { [INFO] [stderr] 938 | | lo: 0, [INFO] [stderr] 939 | | hi: 0, [INFO] [stderr] 940 | | desc: format!("redefinition of table `{}`", [INFO] [stderr] 941 | | &*keys.vec.last().as_ref().unwrap().escaped), [INFO] [stderr] 942 | | }); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 937 | Result::Err(ParserError { [INFO] [stderr] 938 | lo: 0, [INFO] [stderr] 939 | hi: 0, [INFO] [stderr] 940 | desc: format!("redefinition of table `{}`", [INFO] [stderr] 941 | &*keys.vec.last().as_ref().unwrap().escaped), [INFO] [stderr] 942 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:1011:17 [INFO] [stderr] | [INFO] [stderr] 1011 | / return Result::Err(ParserError { [INFO] [stderr] 1012 | | lo: 0, [INFO] [stderr] 1013 | | hi: 0, [INFO] [stderr] 1014 | | desc: [INFO] [stderr] ... | [INFO] [stderr] 1017 | | Parser::last_key_text(&keys.vec)), [INFO] [stderr] 1018 | | }); [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 1011 | Result::Err(ParserError { [INFO] [stderr] 1012 | lo: 0, [INFO] [stderr] 1013 | hi: 0, [INFO] [stderr] 1014 | desc: [INFO] [stderr] 1015 | format!( [INFO] [stderr] 1016 | "key `{}` was previously not an array", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/parser.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] error: unneeded return statement [INFO] [stderr] --> src/parser.rs:73:9 [INFO] [stderr] | [INFO] [stderr] 73 | return (self.input.lines().count(), 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(self.input.lines().count(), 0)` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:3:24 [INFO] [stderr] | [INFO] [stderr] 3 | #![cfg_attr(test, deny(warnings))] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::needless_return)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/parser.rs:238:20 [INFO] [stderr] | [INFO] [stderr] 238 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 239 | | if !self.values(&mut ret.values) { return None } [INFO] [stderr] 240 | | } [INFO] [stderr] | |_____________^ help: try: `if !self.values(&mut ret.values) { return None }` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:3:24 [INFO] [stderr] | [INFO] [stderr] 3 | #![cfg_attr(test, deny(warnings))] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::collapsible_if)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] error: unneeded return statement [INFO] [stderr] --> src/parser.rs:528:9 [INFO] [stderr] | [INFO] [stderr] 528 | return Some(DocValue::String(StringData { raw: raw, escaped: ret })); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(DocValue::String(StringData { raw: raw, escaped: ret }))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: unneeded return statement [INFO] [stderr] --> src/parser.rs:577:9 [INFO] [stderr] | [INFO] [stderr] 577 | return ret; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `ret` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: unneeded return statement [INFO] [stderr] --> src/parser.rs:637:13 [INFO] [stderr] | [INFO] [stderr] 637 | return None [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: unneeded return statement [INFO] [stderr] --> src/parser.rs:767:9 [INFO] [stderr] | [INFO] [stderr] 767 | / return Some(DocValue::InlineArray( [INFO] [stderr] 768 | | InlineArrayData { values: ret, comma_trail: "".to_string() } [INFO] [stderr] 769 | | )) [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 767 | Some(DocValue::InlineArray( [INFO] [stderr] 768 | InlineArrayData { values: ret, comma_trail: "".to_string() } [INFO] [stderr] 769 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: unneeded return statement [INFO] [stderr] --> src/parser.rs:791:9 [INFO] [stderr] | [INFO] [stderr] 791 | return Some(DocValue::new_table(ret, String::new())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(DocValue::new_table(ret, String::new()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: unneeded return statement [INFO] [stderr] --> src/parser.rs:937:13 [INFO] [stderr] | [INFO] [stderr] 937 | / return Result::Err(ParserError { [INFO] [stderr] 938 | | lo: 0, [INFO] [stderr] 939 | | hi: 0, [INFO] [stderr] 940 | | desc: format!("redefinition of table `{}`", [INFO] [stderr] 941 | | &*keys.vec.last().as_ref().unwrap().escaped), [INFO] [stderr] 942 | | }); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 937 | Result::Err(ParserError { [INFO] [stderr] 938 | lo: 0, [INFO] [stderr] 939 | hi: 0, [INFO] [stderr] 940 | desc: format!("redefinition of table `{}`", [INFO] [stderr] 941 | &*keys.vec.last().as_ref().unwrap().escaped), [INFO] [stderr] 942 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: unneeded return statement [INFO] [stderr] --> src/parser.rs:1011:17 [INFO] [stderr] | [INFO] [stderr] 1011 | / return Result::Err(ParserError { [INFO] [stderr] 1012 | | lo: 0, [INFO] [stderr] 1013 | | hi: 0, [INFO] [stderr] 1014 | | desc: [INFO] [stderr] ... | [INFO] [stderr] 1017 | | Parser::last_key_text(&keys.vec)), [INFO] [stderr] 1018 | | }); [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 1011 | Result::Err(ParserError { [INFO] [stderr] 1012 | lo: 0, [INFO] [stderr] 1013 | hi: 0, [INFO] [stderr] 1014 | desc: [INFO] [stderr] 1015 | format!( [INFO] [stderr] 1016 | "key `{}` was previously not an array", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> src/public.rs:2425:47 [INFO] [stderr] | [INFO] [stderr] 2425 | -9223372036854775808); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `9_223_372_036_854_775_808` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:3:24 [INFO] [stderr] | [INFO] [stderr] 3 | #![cfg_attr(test, deny(warnings))] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::unreadable_literal)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> src/public.rs:2437:46 [INFO] [stderr] | [INFO] [stderr] 2437 | 9223372036854775807); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `9_223_372_036_854_775_807` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/parser.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:3:24 [INFO] [stderr] | [INFO] [stderr] 3 | #![cfg_attr(test, deny(warnings))] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(deprecated)] implied by #[deny(warnings)] [INFO] [stderr] [INFO] [stderr] error: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/parser.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:7:9 [INFO] [stderr] | [INFO] [stderr] 7 | #![deny(unused_imports)] [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: unused import: `Write` [INFO] [stderr] --> src/display.rs:1:43 [INFO] [stderr] | [INFO] [stderr] 1 | use std::fmt::{Display, Error, Formatter, Write}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `toml_document`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/parser.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:7:9 [INFO] [stderr] | [INFO] [stderr] 7 | #![deny(unused_imports)] [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: unused import: `Write` [INFO] [stderr] --> src/display.rs:1:43 [INFO] [stderr] | [INFO] [stderr] 1 | use std::fmt::{Display, Error, Formatter, Write}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to 29 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `toml_document`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "cf02d5cbe5250aeb2d8eb19f939db262625127f5c0130d009c9cd1869af66345"` [INFO] running `"docker" "rm" "-f" "cf02d5cbe5250aeb2d8eb19f939db262625127f5c0130d009c9cd1869af66345"` [INFO] [stdout] cf02d5cbe5250aeb2d8eb19f939db262625127f5c0130d009c9cd1869af66345