[INFO] crate toml 0.4.10 is already in cache [INFO] extracting crate toml 0.4.10 into work/ex/clippy-test-run/sources/stable/reg/toml/0.4.10 [INFO] extracting crate toml 0.4.10 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/toml/0.4.10 [INFO] validating manifest of toml-0.4.10 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of toml-0.4.10 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing toml-0.4.10 [INFO] finished frobbing toml-0.4.10 [INFO] frobbed toml for toml-0.4.10 written to work/ex/clippy-test-run/sources/stable/reg/toml/0.4.10/Cargo.toml [INFO] started frobbing toml-0.4.10 [INFO] finished frobbing toml-0.4.10 [INFO] frobbed toml for toml-0.4.10 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/toml/0.4.10/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting toml-0.4.10 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/toml/0.4.10:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4942e93e0a2458a595acd7f744218d4cfc1c778855e6991e9514ce4d8c67bc96 [INFO] running `"docker" "start" "-a" "4942e93e0a2458a595acd7f744218d4cfc1c778855e6991e9514ce4d8c67bc96"` [INFO] [stderr] Checking toml v0.4.10 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/datetime.rs:233:17 [INFO] [stderr] | [INFO] [stderr] 233 | nanosecond: nanosecond, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `nanosecond` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/datetime.rs:296:13 [INFO] [stderr] | [INFO] [stderr] 296 | time: time, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/datetime.rs:297:13 [INFO] [stderr] | [INFO] [stderr] 297 | offset: offset, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ser.rs:252:13 [INFO] [stderr] | [INFO] [stderr] 252 | dst: dst, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `dst` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ser.rs:268:13 [INFO] [stderr] | [INFO] [stderr] 268 | dst: dst, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `dst` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ser.rs:892:13 [INFO] [stderr] | [INFO] [stderr] 892 | len: len, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ser.rs:1079:25 [INFO] [stderr] | [INFO] [stderr] 1079 | key: key, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ser.rs:1081:25 [INFO] [stderr] | [INFO] [stderr] 1081 | first: first, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `first` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ser.rs:1082:25 [INFO] [stderr] | [INFO] [stderr] 1082 | table_emitted: table_emitted, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `table_emitted` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ser.rs:1135:25 [INFO] [stderr] | [INFO] [stderr] 1135 | key: key, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ser.rs:1137:25 [INFO] [stderr] | [INFO] [stderr] 1137 | first: first, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `first` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ser.rs:1138:25 [INFO] [stderr] | [INFO] [stderr] 1138 | table_emitted: table_emitted, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `table_emitted` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:255:17 [INFO] [stderr] | [INFO] [stderr] 255 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:384:13 [INFO] [stderr] | [INFO] [stderr] 384 | array: array, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `array` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:478:13 [INFO] [stderr] | [INFO] [stderr] 478 | key: key, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:510:13 [INFO] [stderr] | [INFO] [stderr] 510 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:771:54 [INFO] [stderr] | [INFO] [stderr] 771 | .map(|val| (val, TableEnumDeserializer { value: value })) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:821:54 [INFO] [stderr] | [INFO] [stderr] 821 | .map(|val| (val, TableEnumDeserializer { value: value })) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:927:13 [INFO] [stderr] | [INFO] [stderr] 927 | input: input, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:970:25 [INFO] [stderr] | [INFO] [stderr] 970 | at: at, [INFO] [stderr] | ^^^^^^ help: replace it with: `at` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:973:25 [INFO] [stderr] | [INFO] [stderr] 973 | array: array, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `array` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:1041:50 [INFO] [stderr] | [INFO] [stderr] 1041 | Ok(Line::Table { at: start, header: ret, array: array }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `array` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:1063:44 [INFO] [stderr] | [INFO] [stderr] 1063 | Value { e: E::String(val), start: start, end: end } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:1063:58 [INFO] [stderr] | [INFO] [stderr] 1063 | Value { e: E::String(val), start: start, end: end } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:1066:46 [INFO] [stderr] | [INFO] [stderr] 1066 | Value { e: E::Boolean(true), start: start, end: end } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:1066:60 [INFO] [stderr] | [INFO] [stderr] 1066 | Value { e: E::Boolean(true), start: start, end: end } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:1069:47 [INFO] [stderr] | [INFO] [stderr] 1069 | Value { e: E::Boolean(false), start: start, end: end } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:1069:61 [INFO] [stderr] | [INFO] [stderr] 1069 | Value { e: E::Boolean(false), start: start, end: end } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:1076:21 [INFO] [stderr] | [INFO] [stderr] 1076 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:1077:21 [INFO] [stderr] | [INFO] [stderr] 1077 | end: end [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:1083:21 [INFO] [stderr] | [INFO] [stderr] 1083 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:1084:21 [INFO] [stderr] | [INFO] [stderr] 1084 | end: end [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:1105:17 [INFO] [stderr] | [INFO] [stderr] 1105 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:1106:17 [INFO] [stderr] | [INFO] [stderr] 1106 | end: end [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:1111:17 [INFO] [stderr] | [INFO] [stderr] 1111 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:1112:17 [INFO] [stderr] | [INFO] [stderr] 1112 | end: end [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:1157:25 [INFO] [stderr] | [INFO] [stderr] 1157 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:1158:25 [INFO] [stderr] | [INFO] [stderr] 1158 | end: end, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:1169:56 [INFO] [stderr] | [INFO] [stderr] 1169 | let to_integer = |f| Value { e: E::Integer(f), start: start, end: end }; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:1169:70 [INFO] [stderr] | [INFO] [stderr] 1169 | let to_integer = |f| Value { e: E::Integer(f), start: start, end: end }; [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:1177:65 [INFO] [stderr] | [INFO] [stderr] 1177 | self.float(s, None).map(|f| Value { e: E::Float(f), start: start, end: end }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:1177:79 [INFO] [stderr] | [INFO] [stderr] 1177 | self.float(s, None).map(|f| Value { e: E::Float(f), start: start, end: end }) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:1183:41 [INFO] [stderr] | [INFO] [stderr] 1183 | e: E::Float(f), start: start, end: end [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:1183:55 [INFO] [stderr] | [INFO] [stderr] 1183 | e: E::Float(f), start: start, end: end [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:1189:52 [INFO] [stderr] | [INFO] [stderr] 1189 | Ok(Value { e: E::Float(f64::INFINITY), start: start, end: end }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:1189:66 [INFO] [stderr] | [INFO] [stderr] 1189 | Ok(Value { e: E::Float(f64::INFINITY), start: start, end: end }) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:1191:56 [INFO] [stderr] | [INFO] [stderr] 1191 | Ok(Value { e: E::Float(f64::NEG_INFINITY), start: start, end: end }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:1191:70 [INFO] [stderr] | [INFO] [stderr] 1191 | Ok(Value { e: E::Float(f64::NEG_INFINITY), start: start, end: end }) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:1193:47 [INFO] [stderr] | [INFO] [stderr] 1193 | Ok(Value { e: E::Float(f64::NAN), start: start, end: end }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:1193:61 [INFO] [stderr] | [INFO] [stderr] 1193 | Ok(Value { e: E::Float(f64::NAN), start: start, end: end }) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:1195:48 [INFO] [stderr] | [INFO] [stderr] 1195 | Ok(Value { e: E::Float(-f64::NAN), start: start, end: end }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:1195:62 [INFO] [stderr] | [INFO] [stderr] 1195 | Ok(Value { e: E::Float(-f64::NAN), start: start, end: end }) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:1205:36 [INFO] [stderr] | [INFO] [stderr] 1205 | self.number(Span { start: start, end: end }, s) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:1205:50 [INFO] [stderr] | [INFO] [stderr] 1205 | self.number(Span { start: start, end: end }, s) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:1575:52 [INFO] [stderr] | [INFO] [stderr] 1575 | self.error(at, ErrorKind::Wanted { expected: expected, found: found }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `expected` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:1575:72 [INFO] [stderr] | [INFO] [stderr] 1575 | self.error(at, ErrorKind::Wanted { expected: expected, found: found }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `found` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:1620:17 [INFO] [stderr] | [INFO] [stderr] 1620 | kind: kind, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:1782:13 [INFO] [stderr] | [INFO] [stderr] 1782 | array: array, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `array` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:1783:13 [INFO] [stderr] | [INFO] [stderr] 1783 | tokens: tokens, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tokens` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:1784:13 [INFO] [stderr] | [INFO] [stderr] 1784 | require_newline_after_table: require_newline_after_table, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `require_newline_after_table` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokens.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | input: input, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokens.rs:329:25 [INFO] [stderr] | [INFO] [stderr] 329 | multiline: multiline, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `multiline` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokens.rs:445:16 [INFO] [stderr] | [INFO] [stderr] 445 | Span { start: start, end: end } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokens.rs:445:30 [INFO] [stderr] | [INFO] [stderr] 445 | Span { start: start, end: end } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spanned.rs:119:21 [INFO] [stderr] | [INFO] [stderr] 119 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spanned.rs:120:21 [INFO] [stderr] | [INFO] [stderr] 120 | end: end, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spanned.rs:121:21 [INFO] [stderr] | [INFO] [stderr] 121 | value: value [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/datetime.rs:233:17 [INFO] [stderr] | [INFO] [stderr] 233 | nanosecond: nanosecond, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `nanosecond` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/datetime.rs:296:13 [INFO] [stderr] | [INFO] [stderr] 296 | time: time, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/datetime.rs:297:13 [INFO] [stderr] | [INFO] [stderr] 297 | offset: offset, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ser.rs:252:13 [INFO] [stderr] | [INFO] [stderr] 252 | dst: dst, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `dst` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ser.rs:268:13 [INFO] [stderr] | [INFO] [stderr] 268 | dst: dst, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `dst` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ser.rs:892:13 [INFO] [stderr] | [INFO] [stderr] 892 | len: len, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ser.rs:1079:25 [INFO] [stderr] | [INFO] [stderr] 1079 | key: key, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ser.rs:1081:25 [INFO] [stderr] | [INFO] [stderr] 1081 | first: first, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `first` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ser.rs:1082:25 [INFO] [stderr] | [INFO] [stderr] 1082 | table_emitted: table_emitted, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `table_emitted` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ser.rs:1135:25 [INFO] [stderr] | [INFO] [stderr] 1135 | key: key, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ser.rs:1137:25 [INFO] [stderr] | [INFO] [stderr] 1137 | first: first, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `first` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ser.rs:1138:25 [INFO] [stderr] | [INFO] [stderr] 1138 | table_emitted: table_emitted, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `table_emitted` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:255:17 [INFO] [stderr] | [INFO] [stderr] 255 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:384:13 [INFO] [stderr] | [INFO] [stderr] 384 | array: array, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `array` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:478:13 [INFO] [stderr] | [INFO] [stderr] 478 | key: key, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:510:13 [INFO] [stderr] | [INFO] [stderr] 510 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:771:54 [INFO] [stderr] | [INFO] [stderr] 771 | .map(|val| (val, TableEnumDeserializer { value: value })) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:821:54 [INFO] [stderr] | [INFO] [stderr] 821 | .map(|val| (val, TableEnumDeserializer { value: value })) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:927:13 [INFO] [stderr] | [INFO] [stderr] 927 | input: input, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:970:25 [INFO] [stderr] | [INFO] [stderr] 970 | at: at, [INFO] [stderr] | ^^^^^^ help: replace it with: `at` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:973:25 [INFO] [stderr] | [INFO] [stderr] 973 | array: array, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `array` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:1041:50 [INFO] [stderr] | [INFO] [stderr] 1041 | Ok(Line::Table { at: start, header: ret, array: array }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `array` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:1063:44 [INFO] [stderr] | [INFO] [stderr] 1063 | Value { e: E::String(val), start: start, end: end } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:1063:58 [INFO] [stderr] | [INFO] [stderr] 1063 | Value { e: E::String(val), start: start, end: end } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:1066:46 [INFO] [stderr] | [INFO] [stderr] 1066 | Value { e: E::Boolean(true), start: start, end: end } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:1066:60 [INFO] [stderr] | [INFO] [stderr] 1066 | Value { e: E::Boolean(true), start: start, end: end } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:1069:47 [INFO] [stderr] | [INFO] [stderr] 1069 | Value { e: E::Boolean(false), start: start, end: end } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:1069:61 [INFO] [stderr] | [INFO] [stderr] 1069 | Value { e: E::Boolean(false), start: start, end: end } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:1076:21 [INFO] [stderr] | [INFO] [stderr] 1076 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:1077:21 [INFO] [stderr] | [INFO] [stderr] 1077 | end: end [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:1083:21 [INFO] [stderr] | [INFO] [stderr] 1083 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:1084:21 [INFO] [stderr] | [INFO] [stderr] 1084 | end: end [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:1105:17 [INFO] [stderr] | [INFO] [stderr] 1105 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:1106:17 [INFO] [stderr] | [INFO] [stderr] 1106 | end: end [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:1111:17 [INFO] [stderr] | [INFO] [stderr] 1111 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:1112:17 [INFO] [stderr] | [INFO] [stderr] 1112 | end: end [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:1157:25 [INFO] [stderr] | [INFO] [stderr] 1157 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:1158:25 [INFO] [stderr] | [INFO] [stderr] 1158 | end: end, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:1169:56 [INFO] [stderr] | [INFO] [stderr] 1169 | let to_integer = |f| Value { e: E::Integer(f), start: start, end: end }; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:1169:70 [INFO] [stderr] | [INFO] [stderr] 1169 | let to_integer = |f| Value { e: E::Integer(f), start: start, end: end }; [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:1177:65 [INFO] [stderr] | [INFO] [stderr] 1177 | self.float(s, None).map(|f| Value { e: E::Float(f), start: start, end: end }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:1177:79 [INFO] [stderr] | [INFO] [stderr] 1177 | self.float(s, None).map(|f| Value { e: E::Float(f), start: start, end: end }) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:1183:41 [INFO] [stderr] | [INFO] [stderr] 1183 | e: E::Float(f), start: start, end: end [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:1183:55 [INFO] [stderr] | [INFO] [stderr] 1183 | e: E::Float(f), start: start, end: end [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:1189:52 [INFO] [stderr] | [INFO] [stderr] 1189 | Ok(Value { e: E::Float(f64::INFINITY), start: start, end: end }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:1189:66 [INFO] [stderr] | [INFO] [stderr] 1189 | Ok(Value { e: E::Float(f64::INFINITY), start: start, end: end }) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:1191:56 [INFO] [stderr] | [INFO] [stderr] 1191 | Ok(Value { e: E::Float(f64::NEG_INFINITY), start: start, end: end }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:1191:70 [INFO] [stderr] | [INFO] [stderr] 1191 | Ok(Value { e: E::Float(f64::NEG_INFINITY), start: start, end: end }) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:1193:47 [INFO] [stderr] | [INFO] [stderr] 1193 | Ok(Value { e: E::Float(f64::NAN), start: start, end: end }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:1193:61 [INFO] [stderr] | [INFO] [stderr] 1193 | Ok(Value { e: E::Float(f64::NAN), start: start, end: end }) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:1195:48 [INFO] [stderr] | [INFO] [stderr] 1195 | Ok(Value { e: E::Float(-f64::NAN), start: start, end: end }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:1195:62 [INFO] [stderr] | [INFO] [stderr] 1195 | Ok(Value { e: E::Float(-f64::NAN), start: start, end: end }) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:1205:36 [INFO] [stderr] | [INFO] [stderr] 1205 | self.number(Span { start: start, end: end }, s) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:1205:50 [INFO] [stderr] | [INFO] [stderr] 1205 | self.number(Span { start: start, end: end }, s) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:1575:52 [INFO] [stderr] | [INFO] [stderr] 1575 | self.error(at, ErrorKind::Wanted { expected: expected, found: found }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `expected` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:1575:72 [INFO] [stderr] | [INFO] [stderr] 1575 | self.error(at, ErrorKind::Wanted { expected: expected, found: found }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `found` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:1620:17 [INFO] [stderr] | [INFO] [stderr] 1620 | kind: kind, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:1782:13 [INFO] [stderr] | [INFO] [stderr] 1782 | array: array, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `array` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:1783:13 [INFO] [stderr] | [INFO] [stderr] 1783 | tokens: tokens, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tokens` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:1784:13 [INFO] [stderr] | [INFO] [stderr] 1784 | require_newline_after_table: require_newline_after_table, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `require_newline_after_table` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokens.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | input: input, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokens.rs:329:25 [INFO] [stderr] | [INFO] [stderr] 329 | multiline: multiline, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `multiline` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokens.rs:445:16 [INFO] [stderr] | [INFO] [stderr] 445 | Span { start: start, end: end } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokens.rs:445:30 [INFO] [stderr] | [INFO] [stderr] 445 | Span { start: start, end: end } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spanned.rs:119:21 [INFO] [stderr] | [INFO] [stderr] 119 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spanned.rs:120:21 [INFO] [stderr] | [INFO] [stderr] 120 | end: end, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spanned.rs:121:21 [INFO] [stderr] | [INFO] [stderr] 121 | value: value [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/datetime.rs:43:19 [INFO] [stderr] | [INFO] [stderr] 43 | pub const FIELD: &'static str = "$__toml_private_datetime"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/datetime.rs:44:18 [INFO] [stderr] | [INFO] [stderr] 44 | pub const NAME: &'static str = "$__toml_private_Datetime"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/de.rs:1802:13 [INFO] [stderr] | [INFO] [stderr] 1802 | / if self.require_newline_after_table { [INFO] [stderr] 1803 | | if !self.tokens.eat_comment()? { [INFO] [stderr] 1804 | | self.tokens.eat_newline_or_eof()?; [INFO] [stderr] 1805 | | } [INFO] [stderr] 1806 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1802 | if self.require_newline_after_table && !self.tokens.eat_comment()? { [INFO] [stderr] 1803 | self.tokens.eat_newline_or_eof()?; [INFO] [stderr] 1804 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/spanned.rs:29:18 [INFO] [stderr] | [INFO] [stderr] 29 | pub const NAME: &'static str = "$__toml_private_Spanned"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/spanned.rs:31:19 [INFO] [stderr] | [INFO] [stderr] 31 | pub const START: &'static str = "$__toml_private_start"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/spanned.rs:33:17 [INFO] [stderr] | [INFO] [stderr] 33 | pub const END: &'static str = "$__toml_private_end"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/spanned.rs:35:19 [INFO] [stderr] | [INFO] [stderr] 35 | pub const VALUE: &'static str = "$__toml_private_value"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/datetime.rs:43:19 [INFO] [stderr] | [INFO] [stderr] 43 | pub const FIELD: &'static str = "$__toml_private_datetime"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/datetime.rs:44:18 [INFO] [stderr] | [INFO] [stderr] 44 | pub const NAME: &'static str = "$__toml_private_Datetime"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/de.rs:1802:13 [INFO] [stderr] | [INFO] [stderr] 1802 | / if self.require_newline_after_table { [INFO] [stderr] 1803 | | if !self.tokens.eat_comment()? { [INFO] [stderr] 1804 | | self.tokens.eat_newline_or_eof()?; [INFO] [stderr] 1805 | | } [INFO] [stderr] 1806 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1802 | if self.require_newline_after_table && !self.tokens.eat_comment()? { [INFO] [stderr] 1803 | self.tokens.eat_newline_or_eof()?; [INFO] [stderr] 1804 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tokens.rs:604:60 [INFO] [stderr] | [INFO] [stderr] 604 | err(r#""\UFFFFFFFF"#, Error::InvalidEscapeValue(2, 0xffffffff)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/spanned.rs:29:18 [INFO] [stderr] | [INFO] [stderr] 29 | pub const NAME: &'static str = "$__toml_private_Spanned"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/spanned.rs:31:19 [INFO] [stderr] | [INFO] [stderr] 31 | pub const START: &'static str = "$__toml_private_start"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/spanned.rs:33:17 [INFO] [stderr] | [INFO] [stderr] 33 | pub const END: &'static str = "$__toml_private_end"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/spanned.rs:35:19 [INFO] [stderr] | [INFO] [stderr] 35 | pub const VALUE: &'static str = "$__toml_private_value"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/value.rs:702:27 [INFO] [stderr] | [INFO] [stderr] 702 | Ok(Value::Integer(value.into())) [INFO] [stderr] | ^^^^^^^^^^^^ help: consider removing `.into()`: `value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/datetime.rs:140:22 [INFO] [stderr] | [INFO] [stderr] 140 | let y1 = digit(&mut chars)? as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(digit(&mut chars)?)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/datetime.rs:141:22 [INFO] [stderr] | [INFO] [stderr] 141 | let y2 = digit(&mut chars)? as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(digit(&mut chars)?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/datetime.rs:142:22 [INFO] [stderr] | [INFO] [stderr] 142 | let y3 = digit(&mut chars)? as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(digit(&mut chars)?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/datetime.rs:143:22 [INFO] [stderr] | [INFO] [stderr] 143 | let y4 = digit(&mut chars)? as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(digit(&mut chars)?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/datetime.rs:214:51 [INFO] [stderr] | [INFO] [stderr] 214 | nanosecond += p * (byte - b'0') as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(byte - b'0')` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/datetime.rs:261:20 [INFO] [stderr] | [INFO] [stderr] 261 | } else if next.is_none() { [INFO] [stderr] | ____________________^ [INFO] [stderr] 262 | | None [INFO] [stderr] 263 | | } else { [INFO] [stderr] 264 | | let sign = match next { [INFO] [stderr] ... | [INFO] [stderr] 282 | | }) [INFO] [stderr] 283 | | } [INFO] [stderr] | |_____________^ help: replace_it_with: `next?;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::question_mark)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/ser.rs:336:27 [INFO] [stderr] | [INFO] [stderr] 336 | let use_default = if let &mut Some(ref mut s) = &mut Rc::get_mut(&mut self.settings) [INFO] [stderr] | ___________________________^ [INFO] [stderr] 337 | | .unwrap().string { [INFO] [stderr] 338 | | s.literal = value; [INFO] [stderr] 339 | | false [INFO] [stderr] 340 | | } else { [INFO] [stderr] 341 | | true [INFO] [stderr] 342 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 336 | let use_default = if let Some(ref mut s) = *(&mut Rc::get_mut(&mut self.settings) [INFO] [stderr] 337 | .unwrap().string) { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/ser.rs:392:27 [INFO] [stderr] | [INFO] [stderr] 392 | let use_default = if let &mut Some(ref mut a) = &mut Rc::get_mut(&mut self.settings) [INFO] [stderr] | ___________________________^ [INFO] [stderr] 393 | | .unwrap().array { [INFO] [stderr] 394 | | a.indent = value; [INFO] [stderr] 395 | | false [INFO] [stderr] 396 | | } else { [INFO] [stderr] 397 | | true [INFO] [stderr] 398 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 392 | let use_default = if let Some(ref mut a) = *(&mut Rc::get_mut(&mut self.settings) [INFO] [stderr] 393 | .unwrap().array) { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/ser.rs:412:27 [INFO] [stderr] | [INFO] [stderr] 412 | let use_default = if let &mut Some(ref mut a) = &mut Rc::get_mut(&mut self.settings) [INFO] [stderr] | ___________________________^ [INFO] [stderr] 413 | | .unwrap().array { [INFO] [stderr] 414 | | a.trailing_comma = value; [INFO] [stderr] 415 | | false [INFO] [stderr] 416 | | } else { [INFO] [stderr] 417 | | true [INFO] [stderr] 418 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 412 | let use_default = if let Some(ref mut a) = *(&mut Rc::get_mut(&mut self.settings) [INFO] [stderr] 413 | .unwrap().array) { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a value that implements Copy. Dropping a copy leaves the original intact. [INFO] [stderr] --> src/ser.rs:432:9 [INFO] [stderr] | [INFO] [stderr] 432 | drop(write!(self.dst, "{}", t)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::drop_copy)] on by default [INFO] [stderr] note: argument has type std::result::Result<(), std::fmt::Error> [INFO] [stderr] --> src/ser.rs:432:14 [INFO] [stderr] | [INFO] [stderr] 432 | drop(write!(self.dst, "{}", t)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_copy [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a value that implements Copy. Dropping a copy leaves the original intact. [INFO] [stderr] --> src/ser.rs:520:13 [INFO] [stderr] | [INFO] [stderr] 520 | drop(write!(self.dst, "{}", key)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: argument has type std::result::Result<(), std::fmt::Error> [INFO] [stderr] --> src/ser.rs:520:18 [INFO] [stderr] | [INFO] [stderr] 520 | drop(write!(self.dst, "{}", key)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_copy [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the `r @ _` pattern can be written as just `r` [INFO] [stderr] --> src/ser.rs:611:21 [INFO] [stderr] | [INFO] [stderr] 611 | (_, r @ _) => r, [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a value that implements Copy. Dropping a copy leaves the original intact. [INFO] [stderr] --> src/ser.rs:654:46 [INFO] [stderr] | [INFO] [stderr] 654 | c if c < '\u{1f}' => drop(write!(self.dst, "\\u{:04X}", ch as u32)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: argument has type std::result::Result<(), std::fmt::Error> [INFO] [stderr] --> src/ser.rs:654:51 [INFO] [stderr] | [INFO] [stderr] 654 | c if c < '\u{1f}' => drop(write!(self.dst, "\\u{:04X}", ch as u32)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_copy [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a value that implements Copy. Dropping a copy leaves the original intact. [INFO] [stderr] --> src/ser.rs:748:13 [INFO] [stderr] | [INFO] [stderr] 748 | drop(write!($this.dst, "-")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 813 | serialize_float!(self, v) [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: argument has type std::result::Result<(), std::fmt::Error> [INFO] [stderr] --> src/ser.rs:813:9 [INFO] [stderr] | [INFO] [stderr] 813 | serialize_float!(self, v) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_copy [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a value that implements Copy. Dropping a copy leaves the original intact. [INFO] [stderr] --> src/ser.rs:751:13 [INFO] [stderr] | [INFO] [stderr] 751 | drop(write!($this.dst, "nan")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 813 | serialize_float!(self, v) [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: argument has type std::result::Result<(), std::fmt::Error> [INFO] [stderr] --> src/ser.rs:813:9 [INFO] [stderr] | [INFO] [stderr] 813 | serialize_float!(self, v) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_copy [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a value that implements Copy. Dropping a copy leaves the original intact. [INFO] [stderr] --> src/ser.rs:753:13 [INFO] [stderr] | [INFO] [stderr] 753 | drop(write!($this.dst, "{}", $v)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 813 | serialize_float!(self, v) [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: argument has type std::result::Result<(), std::fmt::Error> [INFO] [stderr] --> src/ser.rs:813:9 [INFO] [stderr] | [INFO] [stderr] 813 | serialize_float!(self, v) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_copy [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a value that implements Copy. Dropping a copy leaves the original intact. [INFO] [stderr] --> src/ser.rs:756:13 [INFO] [stderr] | [INFO] [stderr] 756 | drop(write!($this.dst, ".0")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 813 | serialize_float!(self, v) [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: argument has type std::result::Result<(), std::fmt::Error> [INFO] [stderr] --> src/ser.rs:813:9 [INFO] [stderr] | [INFO] [stderr] 813 | serialize_float!(self, v) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_copy [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a value that implements Copy. Dropping a copy leaves the original intact. [INFO] [stderr] --> src/ser.rs:748:13 [INFO] [stderr] | [INFO] [stderr] 748 | drop(write!($this.dst, "-")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 817 | serialize_float!(self, v) [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: argument has type std::result::Result<(), std::fmt::Error> [INFO] [stderr] --> src/ser.rs:817:9 [INFO] [stderr] | [INFO] [stderr] 817 | serialize_float!(self, v) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_copy [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a value that implements Copy. Dropping a copy leaves the original intact. [INFO] [stderr] --> src/ser.rs:751:13 [INFO] [stderr] | [INFO] [stderr] 751 | drop(write!($this.dst, "nan")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 817 | serialize_float!(self, v) [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: argument has type std::result::Result<(), std::fmt::Error> [INFO] [stderr] --> src/ser.rs:817:9 [INFO] [stderr] | [INFO] [stderr] 817 | serialize_float!(self, v) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_copy [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a value that implements Copy. Dropping a copy leaves the original intact. [INFO] [stderr] --> src/ser.rs:753:13 [INFO] [stderr] | [INFO] [stderr] 753 | drop(write!($this.dst, "{}", $v)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 817 | serialize_float!(self, v) [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: argument has type std::result::Result<(), std::fmt::Error> [INFO] [stderr] --> src/ser.rs:817:9 [INFO] [stderr] | [INFO] [stderr] 817 | serialize_float!(self, v) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_copy [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a value that implements Copy. Dropping a copy leaves the original intact. [INFO] [stderr] --> src/ser.rs:756:13 [INFO] [stderr] | [INFO] [stderr] 756 | drop(write!($this.dst, ".0")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 817 | serialize_float!(self, v) [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: argument has type std::result::Result<(), std::fmt::Error> [INFO] [stderr] --> src/ser.rs:817:9 [INFO] [stderr] | [INFO] [stderr] 817 | serialize_float!(self, v) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_copy [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the `e @ _` pattern can be written as just `e` [INFO] [stderr] --> src/de.rs:257:13 [INFO] [stderr] | [INFO] [stderr] 257 | e @ _ => Err(Error::from_kind(ErrorKind::Wanted { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/de.rs:558:38 [INFO] [stderr] | [INFO] [stderr] 558 | if name == datetime::NAME && fields == &[datetime::FIELD] { [INFO] [stderr] | ^^^^^^^^^^------------------ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `[datetime::FIELD]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/de.rs:568:13 [INFO] [stderr] | [INFO] [stderr] 568 | / match &self.value.e { [INFO] [stderr] 569 | | &E::InlineTable(ref values) | &E::DottedTable(ref values) => { [INFO] [stderr] 570 | | let extra_fields = values.iter() [INFO] [stderr] 571 | | .filter_map(|key_value| { [INFO] [stderr] ... | [INFO] [stderr] 588 | | _ => {} [INFO] [stderr] 589 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 568 | match self.value.e { [INFO] [stderr] 569 | E::InlineTable(ref values) | E::DottedTable(ref values) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/de.rs:592:37 [INFO] [stderr] | [INFO] [stderr] 592 | if name == spanned::NAME && fields == &[spanned::START, spanned::END, spanned::VALUE] { [INFO] [stderr] | ^^^^^^^^^^----------------------------------------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `[spanned::START, spanned::END, spanned::VALUE]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: the `e @ _` pattern can be written as just `e` [INFO] [stderr] --> src/de.rs:641:13 [INFO] [stderr] | [INFO] [stderr] 641 | e @ _ => Err(Error::from_kind(ErrorKind::Wanted { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/de.rs:836:20 [INFO] [stderr] | [INFO] [stderr] 836 | if values.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `values.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the `e @ _` pattern can be written as just `e` [INFO] [stderr] --> src/de.rs:842:13 [INFO] [stderr] | [INFO] [stderr] 842 | e @ _ => Err(Error::from_kind(ErrorKind::Wanted { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `e @ _` pattern can be written as just `e` [INFO] [stderr] --> src/de.rs:897:13 [INFO] [stderr] | [INFO] [stderr] 897 | e @ _ => Err(Error::from_kind(ErrorKind::Wanted { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/de.rs:1280:9 [INFO] [stderr] | [INFO] [stderr] 1280 | / let mut exponent = None; [INFO] [stderr] 1281 | | if suffix.starts_with('e') || suffix.starts_with('E') { [INFO] [stderr] 1282 | | let (a, b) = if suffix.len() == 1 { [INFO] [stderr] 1283 | | self.eat(Token::Plus)?; [INFO] [stderr] ... | [INFO] [stderr] 1296 | | exponent = Some(a); [INFO] [stderr] 1297 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let exponent = if suffix.starts_with('e') || suffix.starts_with('E') { ..; Some(a) } else { None };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/de.rs:1385:35 [INFO] [stderr] | [INFO] [stderr] 1385 | fn inline_table(&mut self) -> Result<(Span, Vec<(Cow<'a, str>, Value<'a>)>), Error> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/value.rs:702:27 [INFO] [stderr] | [INFO] [stderr] 702 | Ok(Value::Integer(value.into())) [INFO] [stderr] | ^^^^^^^^^^^^ help: consider removing `.into()`: `value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/datetime.rs:140:22 [INFO] [stderr] | [INFO] [stderr] 140 | let y1 = digit(&mut chars)? as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(digit(&mut chars)?)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/datetime.rs:141:22 [INFO] [stderr] | [INFO] [stderr] 141 | let y2 = digit(&mut chars)? as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(digit(&mut chars)?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/datetime.rs:142:22 [INFO] [stderr] | [INFO] [stderr] 142 | let y3 = digit(&mut chars)? as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(digit(&mut chars)?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/datetime.rs:143:22 [INFO] [stderr] | [INFO] [stderr] 143 | let y4 = digit(&mut chars)? as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(digit(&mut chars)?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/datetime.rs:214:51 [INFO] [stderr] | [INFO] [stderr] 214 | nanosecond += p * (byte - b'0') as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(byte - b'0')` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/datetime.rs:261:20 [INFO] [stderr] | [INFO] [stderr] 261 | } else if next.is_none() { [INFO] [stderr] | ____________________^ [INFO] [stderr] 262 | | None [INFO] [stderr] 263 | | } else { [INFO] [stderr] 264 | | let sign = match next { [INFO] [stderr] ... | [INFO] [stderr] 282 | | }) [INFO] [stderr] 283 | | } [INFO] [stderr] | |_____________^ help: replace_it_with: `next?;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::question_mark)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/tokens.rs:254:48 [INFO] [stderr] | [INFO] [stderr] 254 | self.chars.clone().next().map(|i| i.0).unwrap_or(self.input.len()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| self.input.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/ser.rs:336:27 [INFO] [stderr] | [INFO] [stderr] 336 | let use_default = if let &mut Some(ref mut s) = &mut Rc::get_mut(&mut self.settings) [INFO] [stderr] | ___________________________^ [INFO] [stderr] 337 | | .unwrap().string { [INFO] [stderr] 338 | | s.literal = value; [INFO] [stderr] 339 | | false [INFO] [stderr] 340 | | } else { [INFO] [stderr] 341 | | true [INFO] [stderr] 342 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 336 | let use_default = if let Some(ref mut s) = *(&mut Rc::get_mut(&mut self.settings) [INFO] [stderr] 337 | .unwrap().string) { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/ser.rs:392:27 [INFO] [stderr] | [INFO] [stderr] 392 | let use_default = if let &mut Some(ref mut a) = &mut Rc::get_mut(&mut self.settings) [INFO] [stderr] | ___________________________^ [INFO] [stderr] 393 | | .unwrap().array { [INFO] [stderr] 394 | | a.indent = value; [INFO] [stderr] 395 | | false [INFO] [stderr] 396 | | } else { [INFO] [stderr] 397 | | true [INFO] [stderr] 398 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 392 | let use_default = if let Some(ref mut a) = *(&mut Rc::get_mut(&mut self.settings) [INFO] [stderr] 393 | .unwrap().array) { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/ser.rs:412:27 [INFO] [stderr] | [INFO] [stderr] 412 | let use_default = if let &mut Some(ref mut a) = &mut Rc::get_mut(&mut self.settings) [INFO] [stderr] | ___________________________^ [INFO] [stderr] 413 | | .unwrap().array { [INFO] [stderr] 414 | | a.trailing_comma = value; [INFO] [stderr] 415 | | false [INFO] [stderr] 416 | | } else { [INFO] [stderr] 417 | | true [INFO] [stderr] 418 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 412 | let use_default = if let Some(ref mut a) = *(&mut Rc::get_mut(&mut self.settings) [INFO] [stderr] 413 | .unwrap().array) { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a value that implements Copy. Dropping a copy leaves the original intact. [INFO] [stderr] --> src/ser.rs:432:9 [INFO] [stderr] | [INFO] [stderr] 432 | drop(write!(self.dst, "{}", t)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::drop_copy)] on by default [INFO] [stderr] note: argument has type std::result::Result<(), std::fmt::Error> [INFO] [stderr] --> src/ser.rs:432:14 [INFO] [stderr] | [INFO] [stderr] 432 | drop(write!(self.dst, "{}", t)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_copy [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a value that implements Copy. Dropping a copy leaves the original intact. [INFO] [stderr] --> src/ser.rs:520:13 [INFO] [stderr] | [INFO] [stderr] 520 | drop(write!(self.dst, "{}", key)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: argument has type std::result::Result<(), std::fmt::Error> [INFO] [stderr] --> src/ser.rs:520:18 [INFO] [stderr] | [INFO] [stderr] 520 | drop(write!(self.dst, "{}", key)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_copy [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the `r @ _` pattern can be written as just `r` [INFO] [stderr] --> src/ser.rs:611:21 [INFO] [stderr] | [INFO] [stderr] 611 | (_, r @ _) => r, [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a value that implements Copy. Dropping a copy leaves the original intact. [INFO] [stderr] --> src/ser.rs:654:46 [INFO] [stderr] | [INFO] [stderr] 654 | c if c < '\u{1f}' => drop(write!(self.dst, "\\u{:04X}", ch as u32)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: argument has type std::result::Result<(), std::fmt::Error> [INFO] [stderr] --> src/ser.rs:654:51 [INFO] [stderr] | [INFO] [stderr] 654 | c if c < '\u{1f}' => drop(write!(self.dst, "\\u{:04X}", ch as u32)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_copy [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/tokens.rs:484:17 [INFO] [stderr] | [INFO] [stderr] 484 | fn to_owned(&mut self, input: &str) { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a value that implements Copy. Dropping a copy leaves the original intact. [INFO] [stderr] --> src/ser.rs:748:13 [INFO] [stderr] | [INFO] [stderr] 748 | drop(write!($this.dst, "-")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 813 | serialize_float!(self, v) [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: argument has type std::result::Result<(), std::fmt::Error> [INFO] [stderr] --> src/ser.rs:813:9 [INFO] [stderr] | [INFO] [stderr] 813 | serialize_float!(self, v) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_copy [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a value that implements Copy. Dropping a copy leaves the original intact. [INFO] [stderr] --> src/ser.rs:751:13 [INFO] [stderr] | [INFO] [stderr] 751 | drop(write!($this.dst, "nan")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 813 | serialize_float!(self, v) [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: argument has type std::result::Result<(), std::fmt::Error> [INFO] [stderr] --> src/ser.rs:813:9 [INFO] [stderr] | [INFO] [stderr] 813 | serialize_float!(self, v) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_copy [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a value that implements Copy. Dropping a copy leaves the original intact. [INFO] [stderr] --> src/ser.rs:753:13 [INFO] [stderr] | [INFO] [stderr] 753 | drop(write!($this.dst, "{}", $v)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 813 | serialize_float!(self, v) [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: argument has type std::result::Result<(), std::fmt::Error> [INFO] [stderr] --> src/ser.rs:813:9 [INFO] [stderr] | [INFO] [stderr] 813 | serialize_float!(self, v) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_copy [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a value that implements Copy. Dropping a copy leaves the original intact. [INFO] [stderr] --> src/ser.rs:756:13 [INFO] [stderr] | [INFO] [stderr] 756 | drop(write!($this.dst, ".0")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 813 | serialize_float!(self, v) [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: argument has type std::result::Result<(), std::fmt::Error> [INFO] [stderr] --> src/ser.rs:813:9 [INFO] [stderr] | [INFO] [stderr] 813 | serialize_float!(self, v) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_copy [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a value that implements Copy. Dropping a copy leaves the original intact. [INFO] [stderr] --> src/ser.rs:748:13 [INFO] [stderr] | [INFO] [stderr] 748 | drop(write!($this.dst, "-")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 817 | serialize_float!(self, v) [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: argument has type std::result::Result<(), std::fmt::Error> [INFO] [stderr] --> src/ser.rs:817:9 [INFO] [stderr] | [INFO] [stderr] 817 | serialize_float!(self, v) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_copy [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a value that implements Copy. Dropping a copy leaves the original intact. [INFO] [stderr] --> src/ser.rs:751:13 [INFO] [stderr] | [INFO] [stderr] 751 | drop(write!($this.dst, "nan")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 817 | serialize_float!(self, v) [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: argument has type std::result::Result<(), std::fmt::Error> [INFO] [stderr] --> src/ser.rs:817:9 [INFO] [stderr] | [INFO] [stderr] 817 | serialize_float!(self, v) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_copy [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a value that implements Copy. Dropping a copy leaves the original intact. [INFO] [stderr] --> src/ser.rs:753:13 [INFO] [stderr] | [INFO] [stderr] 753 | drop(write!($this.dst, "{}", $v)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 817 | serialize_float!(self, v) [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: argument has type std::result::Result<(), std::fmt::Error> [INFO] [stderr] --> src/ser.rs:817:9 [INFO] [stderr] | [INFO] [stderr] 817 | serialize_float!(self, v) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_copy [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a value that implements Copy. Dropping a copy leaves the original intact. [INFO] [stderr] --> src/ser.rs:756:13 [INFO] [stderr] | [INFO] [stderr] 756 | drop(write!($this.dst, ".0")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 817 | serialize_float!(self, v) [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: argument has type std::result::Result<(), std::fmt::Error> [INFO] [stderr] --> src/ser.rs:817:9 [INFO] [stderr] | [INFO] [stderr] 817 | serialize_float!(self, v) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_copy [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to 11 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `toml`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: the `e @ _` pattern can be written as just `e` [INFO] [stderr] --> src/de.rs:257:13 [INFO] [stderr] | [INFO] [stderr] 257 | e @ _ => Err(Error::from_kind(ErrorKind::Wanted { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/de.rs:558:38 [INFO] [stderr] | [INFO] [stderr] 558 | if name == datetime::NAME && fields == &[datetime::FIELD] { [INFO] [stderr] | ^^^^^^^^^^------------------ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `[datetime::FIELD]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/de.rs:568:13 [INFO] [stderr] | [INFO] [stderr] 568 | / match &self.value.e { [INFO] [stderr] 569 | | &E::InlineTable(ref values) | &E::DottedTable(ref values) => { [INFO] [stderr] 570 | | let extra_fields = values.iter() [INFO] [stderr] 571 | | .filter_map(|key_value| { [INFO] [stderr] ... | [INFO] [stderr] 588 | | _ => {} [INFO] [stderr] 589 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 568 | match self.value.e { [INFO] [stderr] 569 | E::InlineTable(ref values) | E::DottedTable(ref values) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/de.rs:592:37 [INFO] [stderr] | [INFO] [stderr] 592 | if name == spanned::NAME && fields == &[spanned::START, spanned::END, spanned::VALUE] { [INFO] [stderr] | ^^^^^^^^^^----------------------------------------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `[spanned::START, spanned::END, spanned::VALUE]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: the `e @ _` pattern can be written as just `e` [INFO] [stderr] --> src/de.rs:641:13 [INFO] [stderr] | [INFO] [stderr] 641 | e @ _ => Err(Error::from_kind(ErrorKind::Wanted { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/de.rs:836:20 [INFO] [stderr] | [INFO] [stderr] 836 | if values.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `values.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the `e @ _` pattern can be written as just `e` [INFO] [stderr] --> src/de.rs:842:13 [INFO] [stderr] | [INFO] [stderr] 842 | e @ _ => Err(Error::from_kind(ErrorKind::Wanted { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `e @ _` pattern can be written as just `e` [INFO] [stderr] --> src/de.rs:897:13 [INFO] [stderr] | [INFO] [stderr] 897 | e @ _ => Err(Error::from_kind(ErrorKind::Wanted { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/de.rs:1280:9 [INFO] [stderr] | [INFO] [stderr] 1280 | / let mut exponent = None; [INFO] [stderr] 1281 | | if suffix.starts_with('e') || suffix.starts_with('E') { [INFO] [stderr] 1282 | | let (a, b) = if suffix.len() == 1 { [INFO] [stderr] 1283 | | self.eat(Token::Plus)?; [INFO] [stderr] ... | [INFO] [stderr] 1296 | | exponent = Some(a); [INFO] [stderr] 1297 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let exponent = if suffix.starts_with('e') || suffix.starts_with('E') { ..; Some(a) } else { None };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/de.rs:1385:35 [INFO] [stderr] | [INFO] [stderr] 1385 | fn inline_table(&mut self) -> Result<(Span, Vec<(Cow<'a, str>, Value<'a>)>), Error> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/tokens.rs:254:48 [INFO] [stderr] | [INFO] [stderr] 254 | self.chars.clone().next().map(|i| i.0).unwrap_or(self.input.len()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| self.input.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/tokens.rs:484:17 [INFO] [stderr] | [INFO] [stderr] 484 | fn to_owned(&mut self, input: &str) { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] error: aborting due to 11 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `toml`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "4942e93e0a2458a595acd7f744218d4cfc1c778855e6991e9514ce4d8c67bc96"` [INFO] running `"docker" "rm" "-f" "4942e93e0a2458a595acd7f744218d4cfc1c778855e6991e9514ce4d8c67bc96"` [INFO] [stdout] 4942e93e0a2458a595acd7f744218d4cfc1c778855e6991e9514ce4d8c67bc96