[INFO] crate tokio_kcp 0.7.1 is already in cache [INFO] extracting crate tokio_kcp 0.7.1 into work/ex/clippy-test-run/sources/stable/reg/tokio_kcp/0.7.1 [INFO] extracting crate tokio_kcp 0.7.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tokio_kcp/0.7.1 [INFO] validating manifest of tokio_kcp-0.7.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tokio_kcp-0.7.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tokio_kcp-0.7.1 [INFO] finished frobbing tokio_kcp-0.7.1 [INFO] frobbed toml for tokio_kcp-0.7.1 written to work/ex/clippy-test-run/sources/stable/reg/tokio_kcp/0.7.1/Cargo.toml [INFO] started frobbing tokio_kcp-0.7.1 [INFO] finished frobbing tokio_kcp-0.7.1 [INFO] frobbed toml for tokio_kcp-0.7.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tokio_kcp/0.7.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tokio_kcp-0.7.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/tokio_kcp/0.7.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 28e1d6bac8fe4f10cd12eb81491545849f0aeec685e73f945fe5b5e551d078d6 [INFO] running `"docker" "start" "-a" "28e1d6bac8fe4f10cd12eb81491545849f0aeec685e73f945fe5b5e551d078d6"` [INFO] [stderr] Checking priority-queue v0.3.2 [INFO] [stderr] Checking kcp v0.4.10 [INFO] [stderr] Checking tokio_kcp v0.7.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/skcp.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | udp: udp, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `udp` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/skcp.rs:140:27 [INFO] [stderr] | [INFO] [stderr] 140 | KcpOutputHandle { inner: inner } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/skcp.rs:187:13 [INFO] [stderr] | [INFO] [stderr] 187 | peer: peer, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `peer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/skcp.rs:323:45 [INFO] [stderr] | [INFO] [stderr] 323 | kcp: kcp, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `kcp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/skcp.rs:327:45 [INFO] [stderr] | [INFO] [stderr] 327 | udp: udp, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `udp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/session.rs:115:45 [INFO] [stderr] | [INFO] [stderr] 115 | timeout: timeout, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `timeout` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/session.rs:310:13 [INFO] [stderr] | [INFO] [stderr] 310 | kcp: kcp, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `kcp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/session.rs:311:13 [INFO] [stderr] | [INFO] [stderr] 311 | addr: addr, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/session.rs:312:13 [INFO] [stderr] | [INFO] [stderr] 312 | expire_dur: expire_dur, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `expire_dur` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/session.rs:313:13 [INFO] [stderr] | [INFO] [stderr] 313 | mode: mode, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `mode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/kcp_io.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | kcp: kcp, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `kcp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/kcp_io.rs:170:16 [INFO] [stderr] | [INFO] [stderr] 170 | reg: reg, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `reg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stream.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | udp: udp, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `udp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stream.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | io: io, [INFO] [stderr] | ^^^^^^ help: replace it with: `io` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stream.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | buf: buf, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `buf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stream.rs:179:30 [INFO] [stderr] | [INFO] [stderr] 179 | Ok(ServerKcpStream { io: io }) [INFO] [stderr] | ^^^^^^ help: replace it with: `io` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/listener.rs:49:17 [INFO] [stderr] | [INFO] [stderr] 49 | config: config, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/listener.rs:51:17 [INFO] [stderr] | [INFO] [stderr] 51 | output_handle: output_handle, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `output_handle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | addr: addr, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/debug.rs:21:17 [INFO] [stderr] | [INFO] [stderr] 21 | write!(fmt, "\\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/skcp.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | udp: udp, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `udp` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/skcp.rs:140:27 [INFO] [stderr] | [INFO] [stderr] 140 | KcpOutputHandle { inner: inner } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/skcp.rs:187:13 [INFO] [stderr] | [INFO] [stderr] 187 | peer: peer, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `peer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/skcp.rs:323:45 [INFO] [stderr] | [INFO] [stderr] 323 | kcp: kcp, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `kcp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/skcp.rs:327:45 [INFO] [stderr] | [INFO] [stderr] 327 | udp: udp, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `udp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/session.rs:115:45 [INFO] [stderr] | [INFO] [stderr] 115 | timeout: timeout, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `timeout` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/session.rs:310:13 [INFO] [stderr] | [INFO] [stderr] 310 | kcp: kcp, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `kcp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/session.rs:311:13 [INFO] [stderr] | [INFO] [stderr] 311 | addr: addr, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/session.rs:312:13 [INFO] [stderr] | [INFO] [stderr] 312 | expire_dur: expire_dur, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `expire_dur` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/session.rs:313:13 [INFO] [stderr] | [INFO] [stderr] 313 | mode: mode, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `mode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/kcp_io.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | kcp: kcp, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `kcp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/kcp_io.rs:170:16 [INFO] [stderr] | [INFO] [stderr] 170 | reg: reg, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `reg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stream.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | udp: udp, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `udp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stream.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | io: io, [INFO] [stderr] | ^^^^^^ help: replace it with: `io` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stream.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | buf: buf, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `buf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stream.rs:179:30 [INFO] [stderr] | [INFO] [stderr] 179 | Ok(ServerKcpStream { io: io }) [INFO] [stderr] | ^^^^^^ help: replace it with: `io` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/listener.rs:49:17 [INFO] [stderr] | [INFO] [stderr] 49 | config: config, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/listener.rs:51:17 [INFO] [stderr] | [INFO] [stderr] 51 | output_handle: output_handle, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `output_handle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | addr: addr, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/debug.rs:21:17 [INFO] [stderr] | [INFO] [stderr] 21 | write!(fmt, "\\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/skcp.rs:443:51 [INFO] [stderr] | [INFO] [stderr] 443 | Ok(Instant::now() + Duration::from_millis(next as u64)) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(next)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/session.rs:163:31 [INFO] [stderr] | [INFO] [stderr] 163 | .or_insert(HashSet::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(HashSet::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/server.rs:130:18 [INFO] [stderr] | [INFO] [stderr] 130 | _marker: PhantomData (Request, Response, Error)>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/server.rs:143:23 [INFO] [stderr] | [INFO] [stderr] 143 | type Future = Then< [INFO] [stderr] | _______________________^ [INFO] [stderr] 144 | | S::Future, [INFO] [stderr] 145 | | Result, [INFO] [stderr] 146 | | fn(Result) -> Result, [INFO] [stderr] 147 | | >; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:38:28 [INFO] [stderr] | [INFO] [stderr] 38 | (timespec.sec * 1000 + timespec.nsec as i64 / 1000 / 1000) as u32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(timespec.nsec)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/skcp.rs:443:51 [INFO] [stderr] | [INFO] [stderr] 443 | Ok(Instant::now() + Duration::from_millis(next as u64)) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(next)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/session.rs:163:31 [INFO] [stderr] | [INFO] [stderr] 163 | .or_insert(HashSet::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(HashSet::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/server.rs:130:18 [INFO] [stderr] | [INFO] [stderr] 130 | _marker: PhantomData (Request, Response, Error)>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/server.rs:143:23 [INFO] [stderr] | [INFO] [stderr] 143 | type Future = Then< [INFO] [stderr] | _______________________^ [INFO] [stderr] 144 | | S::Future, [INFO] [stderr] 145 | | Result, [INFO] [stderr] 146 | | fn(Result) -> Result, [INFO] [stderr] 147 | | >; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:38:28 [INFO] [stderr] | [INFO] [stderr] 38 | (timespec.sec * 1000 + timespec.nsec as i64 / 1000 / 1000) as u32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(timespec.nsec)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/bench_client.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | count: count, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `count` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/bench_client.rs:105:13 [INFO] [stderr] | [INFO] [stderr] 105 | count: count, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/bench_client.rs:110:13 [INFO] [stderr] | [INFO] [stderr] 110 | mode: mode, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `mode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/bench_client.rs:112:13 [INFO] [stderr] | [INFO] [stderr] 112 | i: i, [INFO] [stderr] | ^^^^ help: replace it with: `i` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/echo.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | count: count, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `count` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/echo.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | count: count, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/echo_bench.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | count: count, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `count` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/echo_bench.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | count: count, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/echo_bench.rs:109:13 [INFO] [stderr] | [INFO] [stderr] 109 | mode: mode, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `mode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::AsyncRead::framed': Use tokio_codec::Decoder::framed instead [INFO] [stderr] --> examples/client.rs:55:37 [INFO] [stderr] | [INFO] [stderr] 55 | let (sink, stream) = stream.framed(Bytes).split(); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'bytes::BufMut::put_u32': use put_u32_be or put_u32_le [INFO] [stderr] --> examples/bench_client.rs:74:17 [INFO] [stderr] | [INFO] [stderr] 74 | buf.put_u32::(self.index as u32); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'bytes::BufMut::put_u32': use put_u32_be or put_u32_le [INFO] [stderr] --> examples/bench_client.rs:75:17 [INFO] [stderr] | [INFO] [stderr] 75 | buf.put_u32::(cur); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'bytes::Buf::get_u32': use get_u32_be or get_u32_le [INFO] [stderr] --> examples/bench_client.rs:138:26 [INFO] [stderr] | [INFO] [stderr] 138 | let sn = cur.get_u32::(); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'bytes::Buf::get_u32': use get_u32_be or get_u32_le [INFO] [stderr] --> examples/bench_client.rs:139:26 [INFO] [stderr] | [INFO] [stderr] 139 | let ts = cur.get_u32::(); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> examples/bench_client.rs:29:28 [INFO] [stderr] | [INFO] [stderr] 29 | (timespec.sec * 1000 + timespec.nsec as i64 / 1000 / 1000) as u32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(timespec.nsec)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> tests/echo.rs:20:22 [INFO] [stderr] | [INFO] [stderr] 20 | const TEST_PAYLOAD: &'static [u8] = b"HellO\x01WoRlD"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'bytes::BufMut::put_u32': use put_u32_be or put_u32_le [INFO] [stderr] --> tests/echo.rs:43:17 [INFO] [stderr] | [INFO] [stderr] 43 | buf.put_u32::(self.count as u32); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'bytes::Buf::get_u32': use get_u32_be or get_u32_le [INFO] [stderr] --> tests/echo.rs:86:27 [INFO] [stderr] | [INFO] [stderr] 86 | let cnt = cur.get_u32::(); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'bytes::BufMut::put_u32': use put_u32_be or put_u32_le [INFO] [stderr] --> tests/echo_bench.rs:74:17 [INFO] [stderr] | [INFO] [stderr] 74 | buf.put_u32::(self.index as u32); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'bytes::BufMut::put_u32': use put_u32_be or put_u32_le [INFO] [stderr] --> tests/echo_bench.rs:75:17 [INFO] [stderr] | [INFO] [stderr] 75 | buf.put_u32::(cur); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'bytes::Buf::get_u32': use get_u32_be or get_u32_le [INFO] [stderr] --> tests/echo_bench.rs:136:26 [INFO] [stderr] | [INFO] [stderr] 136 | let sn = cur.get_u32::(); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'bytes::Buf::get_u32': use get_u32_be or get_u32_le [INFO] [stderr] --> tests/echo_bench.rs:137:26 [INFO] [stderr] | [INFO] [stderr] 137 | let ts = cur.get_u32::(); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> tests/echo_bench.rs:29:28 [INFO] [stderr] | [INFO] [stderr] 29 | (timespec.sec * 1000 + timespec.nsec as i64 / 1000 / 1000) as u32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(timespec.nsec)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 26.35s [INFO] running `"docker" "inspect" "28e1d6bac8fe4f10cd12eb81491545849f0aeec685e73f945fe5b5e551d078d6"` [INFO] running `"docker" "rm" "-f" "28e1d6bac8fe4f10cd12eb81491545849f0aeec685e73f945fe5b5e551d078d6"` [INFO] [stdout] 28e1d6bac8fe4f10cd12eb81491545849f0aeec685e73f945fe5b5e551d078d6