[INFO] crate tokio-zookeeper 0.1.3 is already in cache [INFO] extracting crate tokio-zookeeper 0.1.3 into work/ex/clippy-test-run/sources/stable/reg/tokio-zookeeper/0.1.3 [INFO] extracting crate tokio-zookeeper 0.1.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tokio-zookeeper/0.1.3 [INFO] validating manifest of tokio-zookeeper-0.1.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tokio-zookeeper-0.1.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tokio-zookeeper-0.1.3 [INFO] finished frobbing tokio-zookeeper-0.1.3 [INFO] frobbed toml for tokio-zookeeper-0.1.3 written to work/ex/clippy-test-run/sources/stable/reg/tokio-zookeeper/0.1.3/Cargo.toml [INFO] started frobbing tokio-zookeeper-0.1.3 [INFO] finished frobbing tokio-zookeeper-0.1.3 [INFO] frobbed toml for tokio-zookeeper-0.1.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tokio-zookeeper/0.1.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tokio-zookeeper-0.1.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/tokio-zookeeper/0.1.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 69111b0621f5ec11bbb17b563491b7fee86492a57e5a9a31d5a9ecfdd9063df2 [INFO] running `"docker" "start" "-a" "69111b0621f5ec11bbb17b563491b7fee86492a57e5a9a31d5a9ecfdd9063df2"` [INFO] [stderr] Checking tokio-zookeeper v0.1.3 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/proto/mod.rs:135:17 [INFO] [stderr] | [INFO] [stderr] 135 | rx: rx, [INFO] [stderr] | ^^^^^^ help: replace it with: `rx` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:431:17 [INFO] [stderr] | [INFO] [stderr] 431 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:508:17 [INFO] [stderr] | [INFO] [stderr] 508 | version: version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/proto/mod.rs:135:17 [INFO] [stderr] | [INFO] [stderr] 135 | rx: rx, [INFO] [stderr] | ^^^^^^ help: replace it with: `rx` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:431:17 [INFO] [stderr] | [INFO] [stderr] 431 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:508:17 [INFO] [stderr] | [INFO] [stderr] 508 | version: version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/proto/request.rs:109:26 [INFO] [stderr] | [INFO] [stderr] 109 | writer.write_all(self.as_ref()) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try this: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/proto/mod.rs:117:5 [INFO] [stderr] | [INFO] [stderr] 117 | / pub(crate) fn new( [INFO] [stderr] 118 | | addr: S::Addr, [INFO] [stderr] 119 | | stream: S, [INFO] [stderr] 120 | | log: slog::Logger, [INFO] [stderr] ... | [INFO] [stderr] 144 | | Enqueuer(tx) [INFO] [stderr] 145 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 35 [INFO] [stderr] --> src/proto/mod.rs:283:5 [INFO] [stderr] | [INFO] [stderr] 283 | / fn poll_read( [INFO] [stderr] 284 | | &mut self, [INFO] [stderr] 285 | | default_watcher: &mut mpsc::UnboundedSender, [INFO] [stderr] 286 | | logger: &mut slog::Logger, [INFO] [stderr] ... | [INFO] [stderr] 490 | | } [INFO] [stderr] 491 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/types/acl.rs:39:24 [INFO] [stderr] | [INFO] [stderr] 39 | pub(crate) fn code(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:323:20 [INFO] [stderr] | [INFO] [stderr] 323 | let addr = addr.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*addr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/proto/request.rs:109:26 [INFO] [stderr] | [INFO] [stderr] 109 | writer.write_all(self.as_ref()) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try this: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/proto/mod.rs:117:5 [INFO] [stderr] | [INFO] [stderr] 117 | / pub(crate) fn new( [INFO] [stderr] 118 | | addr: S::Addr, [INFO] [stderr] 119 | | stream: S, [INFO] [stderr] 120 | | log: slog::Logger, [INFO] [stderr] ... | [INFO] [stderr] 144 | | Enqueuer(tx) [INFO] [stderr] 145 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 35 [INFO] [stderr] --> src/proto/mod.rs:283:5 [INFO] [stderr] | [INFO] [stderr] 283 | / fn poll_read( [INFO] [stderr] 284 | | &mut self, [INFO] [stderr] 285 | | default_watcher: &mut mpsc::UnboundedSender, [INFO] [stderr] 286 | | logger: &mut slog::Logger, [INFO] [stderr] ... | [INFO] [stderr] 490 | | } [INFO] [stderr] 491 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/types/acl.rs:39:24 [INFO] [stderr] | [INFO] [stderr] 39 | pub(crate) fn code(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:323:20 [INFO] [stderr] | [INFO] [stderr] 323 | let addr = addr.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*addr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 12.76s [INFO] running `"docker" "inspect" "69111b0621f5ec11bbb17b563491b7fee86492a57e5a9a31d5a9ecfdd9063df2"` [INFO] running `"docker" "rm" "-f" "69111b0621f5ec11bbb17b563491b7fee86492a57e5a9a31d5a9ecfdd9063df2"` [INFO] [stdout] 69111b0621f5ec11bbb17b563491b7fee86492a57e5a9a31d5a9ecfdd9063df2