[INFO] crate tokio-tungstenite 0.6.0 is already in cache [INFO] extracting crate tokio-tungstenite 0.6.0 into work/ex/clippy-test-run/sources/stable/reg/tokio-tungstenite/0.6.0 [INFO] extracting crate tokio-tungstenite 0.6.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tokio-tungstenite/0.6.0 [INFO] validating manifest of tokio-tungstenite-0.6.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tokio-tungstenite-0.6.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tokio-tungstenite-0.6.0 [INFO] finished frobbing tokio-tungstenite-0.6.0 [INFO] frobbed toml for tokio-tungstenite-0.6.0 written to work/ex/clippy-test-run/sources/stable/reg/tokio-tungstenite/0.6.0/Cargo.toml [INFO] started frobbing tokio-tungstenite-0.6.0 [INFO] finished frobbing tokio-tungstenite-0.6.0 [INFO] frobbed toml for tokio-tungstenite-0.6.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tokio-tungstenite/0.6.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tokio-tungstenite-0.6.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/tokio-tungstenite/0.6.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6dc15576ea0180b55b590e7e11e7de80d7f3fc6f4c6a5989830d6dd8042b6a8f [INFO] running `"docker" "start" "-a" "6dc15576ea0180b55b590e7e11e7de80d7f3fc6f4c6a5989830d6dd8042b6a8f"` [INFO] [stderr] Checking byte-tools v0.3.1 [INFO] [stderr] Checking opaque-debug v0.2.2 [INFO] [stderr] Checking input_buffer v0.2.0 [INFO] [stderr] Checking tokio-dns-unofficial v0.3.1 [INFO] [stderr] Checking block-padding v0.1.3 [INFO] [stderr] Checking block-buffer v0.7.2 [INFO] [stderr] Checking sha-1 v0.8.1 [INFO] [stderr] Checking tungstenite v0.6.1 [INFO] [stderr] Checking tokio-tungstenite v0.6.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/connect.rs:67:38 [INFO] [stderr] | [INFO] [stderr] 67 | .map_err(|e| Error::Tls(e))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::Tls` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/connect.rs:66:34 [INFO] [stderr] | [INFO] [stderr] 66 | .map(|s| StreamSwitcher::Tls(s)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `StreamSwitcher::Tls` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/connect.rs:127:47 [INFO] [stderr] | [INFO] [stderr] 127 | Err(e) => return Box::new(future::err(e.into())), [INFO] [stderr] | ^^^^^^^^ help: consider removing `.into()`: `e` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:196:39 [INFO] [stderr] | [INFO] [stderr] 196 | self.inner.read_message().map(|m| Some(m)).to_async() [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `Some` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/connect.rs:67:38 [INFO] [stderr] | [INFO] [stderr] 67 | .map_err(|e| Error::Tls(e))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::Tls` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/connect.rs:66:34 [INFO] [stderr] | [INFO] [stderr] 66 | .map(|s| StreamSwitcher::Tls(s)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `StreamSwitcher::Tls` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/connect.rs:127:47 [INFO] [stderr] | [INFO] [stderr] 127 | Err(e) => return Box::new(future::err(e.into())), [INFO] [stderr] | ^^^^^^^^ help: consider removing `.into()`: `e` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:196:39 [INFO] [stderr] | [INFO] [stderr] 196 | self.inner.read_message().map(|m| Some(m)).to_async() [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `Some` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> examples/server.rs:38:35 [INFO] [stderr] | [INFO] [stderr] 38 | let addr = env::args().nth(1).unwrap_or("127.0.0.1:8080".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "127.0.0.1:8080".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 21.01s [INFO] running `"docker" "inspect" "6dc15576ea0180b55b590e7e11e7de80d7f3fc6f4c6a5989830d6dd8042b6a8f"` [INFO] running `"docker" "rm" "-f" "6dc15576ea0180b55b590e7e11e7de80d7f3fc6f4c6a5989830d6dd8042b6a8f"` [INFO] [stdout] 6dc15576ea0180b55b590e7e11e7de80d7f3fc6f4c6a5989830d6dd8042b6a8f