[INFO] crate tokio-thrift-codegen 0.1.0 is already in cache [INFO] extracting crate tokio-thrift-codegen 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/tokio-thrift-codegen/0.1.0 [INFO] extracting crate tokio-thrift-codegen 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tokio-thrift-codegen/0.1.0 [INFO] validating manifest of tokio-thrift-codegen-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tokio-thrift-codegen-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tokio-thrift-codegen-0.1.0 [INFO] finished frobbing tokio-thrift-codegen-0.1.0 [INFO] frobbed toml for tokio-thrift-codegen-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/tokio-thrift-codegen/0.1.0/Cargo.toml [INFO] started frobbing tokio-thrift-codegen-0.1.0 [INFO] finished frobbing tokio-thrift-codegen-0.1.0 [INFO] frobbed toml for tokio-thrift-codegen-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tokio-thrift-codegen/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tokio-thrift-codegen-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/tokio-thrift-codegen/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a3e1403edac980050577f27895eb524eebacc3ecbf918bb72068f925de127ba9 [INFO] running `"docker" "start" "-a" "a3e1403edac980050577f27895eb524eebacc3ecbf918bb72068f925de127ba9"` [INFO] [stderr] Checking handlebars v0.22.0 [INFO] [stderr] Checking tokio-thrift-codegen v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/parser.rs:551:9 [INFO] [stderr] | [INFO] [stderr] 551 | f [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/parser.rs:550:17 [INFO] [stderr] | [INFO] [stderr] 550 | let f = format!("{}{}.{}{}", sgn, n, frac, pow).parse::().expect("internal error: failed to parse double literal internally"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/parser.rs:551:9 [INFO] [stderr] | [INFO] [stderr] 551 | f [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/parser.rs:550:17 [INFO] [stderr] | [INFO] [stderr] 550 | let f = format!("{}{}.{}{}", sgn, n, frac, pow).parse::().expect("internal error: failed to parse double literal internally"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `k` [INFO] [stderr] --> src/parser.rs:567:13 [INFO] [stderr] | [INFO] [stderr] 567 | k: const_value ~ blank? ~ [INFO] [stderr] | ^ help: consider using `_k` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `vs` [INFO] [stderr] --> src/parser.rs:566:9 [INFO] [stderr] | [INFO] [stderr] 566 | vs: many0!(chain!( [INFO] [stderr] | ^^ help: consider using `_vs` instead [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/parser.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | / match self { [INFO] [stderr] 55 | | &String => s.emit_enum_variant("string", 0, 0, |_| Ok(())), [INFO] [stderr] 56 | | &Void => s.emit_enum_variant("void", 1, 0, |_| Ok(())), [INFO] [stderr] 57 | | &Byte => s.emit_enum_variant("byte", 2, 0, |_| Ok(())), [INFO] [stderr] ... | [INFO] [stderr] 92 | | }), [INFO] [stderr] 93 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 54 | match *self { [INFO] [stderr] 55 | String => s.emit_enum_variant("string", 0, 0, |_| Ok(())), [INFO] [stderr] 56 | Void => s.emit_enum_variant("void", 1, 0, |_| Ok(())), [INFO] [stderr] 57 | Byte => s.emit_enum_variant("byte", 2, 0, |_| Ok(())), [INFO] [stderr] 58 | Bool => s.emit_enum_variant("bool", 3, 0, |_| Ok(())), [INFO] [stderr] 59 | Binary => s.emit_enum_variant("binary", 4, 0, |_| Ok(())), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/parser.rs:119:9 [INFO] [stderr] | [INFO] [stderr] 119 | / match self { [INFO] [stderr] 120 | | &Ty::String => "String".to_string(), [INFO] [stderr] 121 | | &Ty::Void => "()".to_string(), [INFO] [stderr] 122 | | &Ty::Byte => "u8".to_string(), [INFO] [stderr] ... | [INFO] [stderr] 145 | | } [INFO] [stderr] 146 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 119 | match *self { [INFO] [stderr] 120 | Ty::String => "String".to_string(), [INFO] [stderr] 121 | Ty::Void => "()".to_string(), [INFO] [stderr] 122 | Ty::Byte => "u8".to_string(), [INFO] [stderr] 123 | Ty::Bool => "bool".to_string(), [INFO] [stderr] 124 | Ty::Binary => "Vec".to_string(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unused variable: `k` [INFO] [stderr] --> src/parser.rs:567:13 [INFO] [stderr] | [INFO] [stderr] 567 | k: const_value ~ blank? ~ [INFO] [stderr] | ^ help: consider using `_k` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `vs` [INFO] [stderr] --> src/parser.rs:566:9 [INFO] [stderr] | [INFO] [stderr] 566 | vs: many0!(chain!( [INFO] [stderr] | ^^ help: consider using `_vs` instead [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/parser.rs:549:50 [INFO] [stderr] | [INFO] [stderr] 549 | let pow = pow.map(|i| format!("e{}", i)).unwrap_or("".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:36:33 [INFO] [stderr] | [INFO] [stderr] 36 | doc.headers.iter().find(|h| match *h { [INFO] [stderr] | _________________________________^ [INFO] [stderr] 37 | | &Header::Include(_) => false, [INFO] [stderr] 38 | | &Header::Namespace(ref n) => n.lang == "rust", [INFO] [stderr] 39 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 36 | doc.headers.iter().find(|h| match *(*h) { [INFO] [stderr] 37 | Header::Include(_) => false, [INFO] [stderr] 38 | Header::Namespace(ref n) => n.lang == "rust", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:40:15 [INFO] [stderr] | [INFO] [stderr] 40 | ).map(|h| match h { [INFO] [stderr] | _______________^ [INFO] [stderr] 41 | | &Header::Include(_) => panic!("internal error"), [INFO] [stderr] 42 | | &Header::Namespace(ref n) => n, [INFO] [stderr] 43 | | }) [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 40 | ).map(|h| match *h { [INFO] [stderr] 41 | Header::Include(_) => panic!("internal error"), [INFO] [stderr] 42 | Header::Namespace(ref n) => n, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:53:10 [INFO] [stderr] | [INFO] [stderr] 53 | .ok_or(RenderError::new("Param 0 is required for to_protocol helper."))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| RenderError::new("Param 0 is required for to_protocol helper."))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/lib.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | rc.writer.write(ret.as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:66:28 [INFO] [stderr] | [INFO] [stderr] 66 | let param = h.param(0).ok_or(RenderError::new("Param 0 is required for to_rust helper."))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| RenderError::new("Param 0 is required for to_rust helper."))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/lib.rs:70:5 [INFO] [stderr] | [INFO] [stderr] 70 | rc.writer.write(ret.as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:80:28 [INFO] [stderr] | [INFO] [stderr] 80 | let param = h.param(0).ok_or(RenderError::new("Param 0 is required for to_literal helper."))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| RenderError::new("Param 0 is required for to_literal helper."))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/lib.rs:90:5 [INFO] [stderr] | [INFO] [stderr] 90 | rc.writer.write(ret.as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:101:28 [INFO] [stderr] | [INFO] [stderr] 101 | let param = h.param(0).ok_or(RenderError::new("Param 0 is required for expr helper."))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| RenderError::new("Param 0 is required for expr helper."))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/lib.rs:116:5 [INFO] [stderr] | [INFO] [stderr] 116 | rc.writer.write(expr.as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:156:9 [INFO] [stderr] | [INFO] [stderr] 156 | / match def { [INFO] [stderr] 157 | | &Const(ref c) => gen_const (c, &mut data, wr, &mut handlebars)?, [INFO] [stderr] 158 | | &Typedef(ref t) => gen_typedef (t, &mut data, wr, &mut handlebars)?, [INFO] [stderr] 159 | | &Enum(ref e) => gen_enum (e, &mut data, wr, &mut handlebars)?, [INFO] [stderr] ... | [INFO] [stderr] 163 | | &Service(ref s) => gen_service (s, &mut data, wr, &mut handlebars)?, [INFO] [stderr] 164 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 156 | match *def { [INFO] [stderr] 157 | Const(ref c) => gen_const (c, &mut data, wr, &mut handlebars)?, [INFO] [stderr] 158 | Typedef(ref t) => gen_typedef (t, &mut data, wr, &mut handlebars)?, [INFO] [stderr] 159 | Enum(ref e) => gen_enum (e, &mut data, wr, &mut handlebars)?, [INFO] [stderr] 160 | Struct(ref s) => gen_struct (s, &mut data, wr, &mut handlebars)?, [INFO] [stderr] 161 | Union(_) => return Err(Error::NotSupported("union is not supported yet".to_string())), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `tokio-thrift-codegen`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/parser.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | / match self { [INFO] [stderr] 55 | | &String => s.emit_enum_variant("string", 0, 0, |_| Ok(())), [INFO] [stderr] 56 | | &Void => s.emit_enum_variant("void", 1, 0, |_| Ok(())), [INFO] [stderr] 57 | | &Byte => s.emit_enum_variant("byte", 2, 0, |_| Ok(())), [INFO] [stderr] ... | [INFO] [stderr] 92 | | }), [INFO] [stderr] 93 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 54 | match *self { [INFO] [stderr] 55 | String => s.emit_enum_variant("string", 0, 0, |_| Ok(())), [INFO] [stderr] 56 | Void => s.emit_enum_variant("void", 1, 0, |_| Ok(())), [INFO] [stderr] 57 | Byte => s.emit_enum_variant("byte", 2, 0, |_| Ok(())), [INFO] [stderr] 58 | Bool => s.emit_enum_variant("bool", 3, 0, |_| Ok(())), [INFO] [stderr] 59 | Binary => s.emit_enum_variant("binary", 4, 0, |_| Ok(())), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/parser.rs:119:9 [INFO] [stderr] | [INFO] [stderr] 119 | / match self { [INFO] [stderr] 120 | | &Ty::String => "String".to_string(), [INFO] [stderr] 121 | | &Ty::Void => "()".to_string(), [INFO] [stderr] 122 | | &Ty::Byte => "u8".to_string(), [INFO] [stderr] ... | [INFO] [stderr] 145 | | } [INFO] [stderr] 146 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 119 | match *self { [INFO] [stderr] 120 | Ty::String => "String".to_string(), [INFO] [stderr] 121 | Ty::Void => "()".to_string(), [INFO] [stderr] 122 | Ty::Byte => "u8".to_string(), [INFO] [stderr] 123 | Ty::Bool => "bool".to_string(), [INFO] [stderr] 124 | Ty::Binary => "Vec".to_string(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/parser.rs:549:50 [INFO] [stderr] | [INFO] [stderr] 549 | let pow = pow.map(|i| format!("e{}", i)).unwrap_or("".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/parser.rs:1386:5 [INFO] [stderr] | [INFO] [stderr] 1386 | assert_eq!(double_constant(b"1.0 ").unwrap().1, 1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/parser.rs:1386:5 [INFO] [stderr] | [INFO] [stderr] 1386 | assert_eq!(double_constant(b"1.0 ").unwrap().1, 1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/parser.rs:1387:5 [INFO] [stderr] | [INFO] [stderr] 1387 | assert_eq!(double_constant(b"-0.01 ").unwrap().1, -0.01); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/parser.rs:1387:5 [INFO] [stderr] | [INFO] [stderr] 1387 | assert_eq!(double_constant(b"-0.01 ").unwrap().1, -0.01); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/parser.rs:1388:5 [INFO] [stderr] | [INFO] [stderr] 1388 | assert_eq!(double_constant(b"-1.0e-2 ").unwrap().1, -0.01); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/parser.rs:1388:5 [INFO] [stderr] | [INFO] [stderr] 1388 | assert_eq!(double_constant(b"-1.0e-2 ").unwrap().1, -0.01); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/parser.rs:1389:5 [INFO] [stderr] | [INFO] [stderr] 1389 | assert_eq!(double_constant(b"-1E2 ").unwrap().1, -100.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/parser.rs:1389:5 [INFO] [stderr] | [INFO] [stderr] 1389 | assert_eq!(double_constant(b"-1E2 ").unwrap().1, -100.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:36:33 [INFO] [stderr] | [INFO] [stderr] 36 | doc.headers.iter().find(|h| match *h { [INFO] [stderr] | _________________________________^ [INFO] [stderr] 37 | | &Header::Include(_) => false, [INFO] [stderr] 38 | | &Header::Namespace(ref n) => n.lang == "rust", [INFO] [stderr] 39 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 36 | doc.headers.iter().find(|h| match *(*h) { [INFO] [stderr] 37 | Header::Include(_) => false, [INFO] [stderr] 38 | Header::Namespace(ref n) => n.lang == "rust", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:40:15 [INFO] [stderr] | [INFO] [stderr] 40 | ).map(|h| match h { [INFO] [stderr] | _______________^ [INFO] [stderr] 41 | | &Header::Include(_) => panic!("internal error"), [INFO] [stderr] 42 | | &Header::Namespace(ref n) => n, [INFO] [stderr] 43 | | }) [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 40 | ).map(|h| match *h { [INFO] [stderr] 41 | Header::Include(_) => panic!("internal error"), [INFO] [stderr] 42 | Header::Namespace(ref n) => n, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:53:10 [INFO] [stderr] | [INFO] [stderr] 53 | .ok_or(RenderError::new("Param 0 is required for to_protocol helper."))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| RenderError::new("Param 0 is required for to_protocol helper."))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/lib.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | rc.writer.write(ret.as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:66:28 [INFO] [stderr] | [INFO] [stderr] 66 | let param = h.param(0).ok_or(RenderError::new("Param 0 is required for to_rust helper."))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| RenderError::new("Param 0 is required for to_rust helper."))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/lib.rs:70:5 [INFO] [stderr] | [INFO] [stderr] 70 | rc.writer.write(ret.as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:80:28 [INFO] [stderr] | [INFO] [stderr] 80 | let param = h.param(0).ok_or(RenderError::new("Param 0 is required for to_literal helper."))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| RenderError::new("Param 0 is required for to_literal helper."))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/lib.rs:90:5 [INFO] [stderr] | [INFO] [stderr] 90 | rc.writer.write(ret.as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:101:28 [INFO] [stderr] | [INFO] [stderr] 101 | let param = h.param(0).ok_or(RenderError::new("Param 0 is required for expr helper."))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| RenderError::new("Param 0 is required for expr helper."))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/lib.rs:116:5 [INFO] [stderr] | [INFO] [stderr] 116 | rc.writer.write(expr.as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:156:9 [INFO] [stderr] | [INFO] [stderr] 156 | / match def { [INFO] [stderr] 157 | | &Const(ref c) => gen_const (c, &mut data, wr, &mut handlebars)?, [INFO] [stderr] 158 | | &Typedef(ref t) => gen_typedef (t, &mut data, wr, &mut handlebars)?, [INFO] [stderr] 159 | | &Enum(ref e) => gen_enum (e, &mut data, wr, &mut handlebars)?, [INFO] [stderr] ... | [INFO] [stderr] 163 | | &Service(ref s) => gen_service (s, &mut data, wr, &mut handlebars)?, [INFO] [stderr] 164 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 156 | match *def { [INFO] [stderr] 157 | Const(ref c) => gen_const (c, &mut data, wr, &mut handlebars)?, [INFO] [stderr] 158 | Typedef(ref t) => gen_typedef (t, &mut data, wr, &mut handlebars)?, [INFO] [stderr] 159 | Enum(ref e) => gen_enum (e, &mut data, wr, &mut handlebars)?, [INFO] [stderr] 160 | Struct(ref s) => gen_struct (s, &mut data, wr, &mut handlebars)?, [INFO] [stderr] 161 | Union(_) => return Err(Error::NotSupported("union is not supported yet".to_string())), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: aborting due to 8 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `tokio-thrift-codegen`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "a3e1403edac980050577f27895eb524eebacc3ecbf918bb72068f925de127ba9"` [INFO] running `"docker" "rm" "-f" "a3e1403edac980050577f27895eb524eebacc3ecbf918bb72068f925de127ba9"` [INFO] [stdout] a3e1403edac980050577f27895eb524eebacc3ecbf918bb72068f925de127ba9