[INFO] crate tokio-stomp 0.1.0 is already in cache [INFO] extracting crate tokio-stomp 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/tokio-stomp/0.1.0 [INFO] extracting crate tokio-stomp 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tokio-stomp/0.1.0 [INFO] validating manifest of tokio-stomp-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tokio-stomp-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tokio-stomp-0.1.0 [INFO] finished frobbing tokio-stomp-0.1.0 [INFO] frobbed toml for tokio-stomp-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/tokio-stomp/0.1.0/Cargo.toml [INFO] started frobbing tokio-stomp-0.1.0 [INFO] finished frobbing tokio-stomp-0.1.0 [INFO] frobbed toml for tokio-stomp-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tokio-stomp/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tokio-stomp-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/tokio-stomp/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] dd714d4cbee085d1f62f1bfbe717448f946bda11fcbefd61f53373f86f9d7652 [INFO] running `"docker" "start" "-a" "dd714d4cbee085d1f62f1bfbe717448f946bda11fcbefd61f53373f86f9d7652"` [INFO] [stderr] Checking tokio-stomp v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:628:13 [INFO] [stderr] | [INFO] [stderr] 628 | host: host, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `host` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:629:13 [INFO] [stderr] | [INFO] [stderr] 629 | login: login, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `login` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:630:13 [INFO] [stderr] | [INFO] [stderr] 630 | passcode: passcode, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `passcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:628:13 [INFO] [stderr] | [INFO] [stderr] 628 | host: host, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `host` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:629:13 [INFO] [stderr] | [INFO] [stderr] 629 | login: login, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `login` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:630:13 [INFO] [stderr] | [INFO] [stderr] 630 | passcode: passcode, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `passcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::Framed': Moved to tokio-codec [INFO] [stderr] --> src/lib.rs:18:41 [INFO] [stderr] | [INFO] [stderr] 18 | use tokio_io::codec::{Decoder, Encoder, Framed}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::Framed': Moved to tokio-codec [INFO] [stderr] --> src/lib.rs:25:18 [INFO] [stderr] | [INFO] [stderr] 25 | type Transport = Framed; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::AsyncRead::framed': Use tokio_codec::Decoder::framed instead [INFO] [stderr] --> src/lib.rs:583:33 [INFO] [stderr] | [INFO] [stderr] 583 | let transport = tcp.framed(StompCodec); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::Framed': Moved to tokio-codec [INFO] [stderr] --> src/lib.rs:18:41 [INFO] [stderr] | [INFO] [stderr] 18 | use tokio_io::codec::{Decoder, Encoder, Framed}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::Framed': Moved to tokio-codec [INFO] [stderr] --> src/lib.rs:25:18 [INFO] [stderr] | [INFO] [stderr] 25 | type Transport = Framed; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:38:18 [INFO] [stderr] | [INFO] [stderr] 38 | headers: &[(&'a [u8], Option>)], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:342:5 [INFO] [stderr] | [INFO] [stderr] 342 | / fn from_frame<'a>(frame: Frame<'a>) -> Result> { [INFO] [stderr] 343 | | frame.to_server_msg() [INFO] [stderr] 344 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:348:5 [INFO] [stderr] | [INFO] [stderr] 348 | / fn to_frame<'a>(&'a self) -> Frame<'a> { [INFO] [stderr] 349 | | self.content.to_frame() [INFO] [stderr] 350 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:353:5 [INFO] [stderr] | [INFO] [stderr] 353 | / fn from_frame<'a>(frame: Frame<'a>) -> Result> { [INFO] [stderr] 354 | | frame.to_client_msg() [INFO] [stderr] 355 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:427:1 [INFO] [stderr] | [INFO] [stderr] 427 | / fn opt_str_to_bytes<'a>(s: &'a Option) -> Option> { [INFO] [stderr] 428 | | s.as_ref().map(|v| Cow::Borrowed(v.as_bytes())) [INFO] [stderr] 429 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:443:5 [INFO] [stderr] | [INFO] [stderr] 443 | / fn to_frame<'a>(&'a self) -> Frame<'a> { [INFO] [stderr] 444 | | use opt_str_to_bytes as sb; [INFO] [stderr] 445 | | use ClientMsg::*; [INFO] [stderr] 446 | | use Cow::*; [INFO] [stderr] ... | [INFO] [stderr] 533 | | } [INFO] [stderr] 534 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:553:18 [INFO] [stderr] | [INFO] [stderr] 553 | item.map(|v| Some(v)) [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `Some` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:638:72 [INFO] [stderr] | [INFO] [stderr] 638 | .and_then(|transport| transport.into_future().map_err(|(e, _)| e.into())) [INFO] [stderr] | ^^^^^^^^ help: consider removing `.into()`: `e` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::AsyncRead::framed': Use tokio_codec::Decoder::framed instead [INFO] [stderr] --> src/lib.rs:583:33 [INFO] [stderr] | [INFO] [stderr] 583 | let transport = tcp.framed(StompCodec); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:38:18 [INFO] [stderr] | [INFO] [stderr] 38 | headers: &[(&'a [u8], Option>)], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:342:5 [INFO] [stderr] | [INFO] [stderr] 342 | / fn from_frame<'a>(frame: Frame<'a>) -> Result> { [INFO] [stderr] 343 | | frame.to_server_msg() [INFO] [stderr] 344 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:348:5 [INFO] [stderr] | [INFO] [stderr] 348 | / fn to_frame<'a>(&'a self) -> Frame<'a> { [INFO] [stderr] 349 | | self.content.to_frame() [INFO] [stderr] 350 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:353:5 [INFO] [stderr] | [INFO] [stderr] 353 | / fn from_frame<'a>(frame: Frame<'a>) -> Result> { [INFO] [stderr] 354 | | frame.to_client_msg() [INFO] [stderr] 355 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:427:1 [INFO] [stderr] | [INFO] [stderr] 427 | / fn opt_str_to_bytes<'a>(s: &'a Option) -> Option> { [INFO] [stderr] 428 | | s.as_ref().map(|v| Cow::Borrowed(v.as_bytes())) [INFO] [stderr] 429 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:443:5 [INFO] [stderr] | [INFO] [stderr] 443 | / fn to_frame<'a>(&'a self) -> Frame<'a> { [INFO] [stderr] 444 | | use opt_str_to_bytes as sb; [INFO] [stderr] 445 | | use ClientMsg::*; [INFO] [stderr] 446 | | use Cow::*; [INFO] [stderr] ... | [INFO] [stderr] 533 | | } [INFO] [stderr] 534 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:553:18 [INFO] [stderr] | [INFO] [stderr] 553 | item.map(|v| Some(v)) [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `Some` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:638:72 [INFO] [stderr] | [INFO] [stderr] 638 | .and_then(|transport| transport.into_future().map_err(|(e, _)| e.into())) [INFO] [stderr] | ^^^^^^^^ help: consider removing `.into()`: `e` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio::executor::current_thread::run': use block_on_all instead [INFO] [stderr] --> examples/connect.rs:8:39 [INFO] [stderr] | [INFO] [stderr] 8 | use tokio::executor::current_thread::{run, spawn}; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio::executor::current_thread::run': use block_on_all instead [INFO] [stderr] --> examples/connect.rs:66:5 [INFO] [stderr] | [INFO] [stderr] 66 | run(|_| spawn(fut)); [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio::executor::current_thread::run': use block_on_all instead [INFO] [stderr] --> examples/natrail.rs:8:39 [INFO] [stderr] | [INFO] [stderr] 8 | use tokio::executor::current_thread::{run, spawn}; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio::executor::current_thread::run': use block_on_all instead [INFO] [stderr] --> examples/natrail.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | run(|_| spawn(fut)); [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio::executor::current_thread::run': use block_on_all instead [INFO] [stderr] --> examples/ping_pong.rs:8:39 [INFO] [stderr] | [INFO] [stderr] 8 | use tokio::executor::current_thread::{run, spawn}; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio::executor::current_thread::run': use block_on_all instead [INFO] [stderr] --> examples/ping_pong.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | run(|_| spawn(fut1)); [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio::executor::current_thread::run': use block_on_all instead [INFO] [stderr] --> examples/ping_pong.rs:70:5 [INFO] [stderr] | [INFO] [stderr] 70 | run(|_| spawn(fut2)); [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> examples/natrail.rs:23:22 [INFO] [stderr] | [INFO] [stderr] 23 | destination: queue.into(), [INFO] [stderr] | ^^^^^^^^^^^^ help: consider removing `.into()`: `queue` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 8.69s [INFO] running `"docker" "inspect" "dd714d4cbee085d1f62f1bfbe717448f946bda11fcbefd61f53373f86f9d7652"` [INFO] running `"docker" "rm" "-f" "dd714d4cbee085d1f62f1bfbe717448f946bda11fcbefd61f53373f86f9d7652"` [INFO] [stdout] dd714d4cbee085d1f62f1bfbe717448f946bda11fcbefd61f53373f86f9d7652