[INFO] crate tokio-smtp 0.3.0 is already in cache [INFO] extracting crate tokio-smtp 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/tokio-smtp/0.3.0 [INFO] extracting crate tokio-smtp 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tokio-smtp/0.3.0 [INFO] validating manifest of tokio-smtp-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tokio-smtp-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tokio-smtp-0.3.0 [INFO] finished frobbing tokio-smtp-0.3.0 [INFO] frobbed toml for tokio-smtp-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/tokio-smtp/0.3.0/Cargo.toml [INFO] started frobbing tokio-smtp-0.3.0 [INFO] finished frobbing tokio-smtp-0.3.0 [INFO] frobbed toml for tokio-smtp-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tokio-smtp/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tokio-smtp-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/tokio-smtp/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] dc617f727cb247784f3e299cbd1fa9acf43268cf91d5efa050f9d4bad10a5f65 [INFO] running `"docker" "start" "-a" "dc617f727cb247784f3e299cbd1fa9acf43268cf91d5efa050f9d4bad10a5f65"` [INFO] [stderr] Checking emailaddress v0.4.0 [INFO] [stderr] Checking tokio-smtp v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::Framed': Moved to tokio-codec [INFO] [stderr] --> src/client.rs:101:41 [INFO] [stderr] | [INFO] [stderr] 101 | use tokio_io::codec::{Encoder, Decoder, Framed}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::Framed': Moved to tokio-codec [INFO] [stderr] --> src/client.rs:108:31 [INFO] [stderr] | [INFO] [stderr] 108 | pub type ClientTransport = Framed, ClientCodec>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::Framed': Moved to tokio-codec [INFO] [stderr] --> src/client.rs:337:36 [INFO] [stderr] | [INFO] [stderr] 337 | type HandshakeItem = (Response, Framed, ClientCodec>); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::Framed': Moved to tokio-codec [INFO] [stderr] --> src/client.rs:404:26 [INFO] [stderr] | [INFO] [stderr] 404 | fn clientauth(stream: Framed, ClientCodec>, params: &ClientParams, features: &[String]) -> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::Framed': Moved to tokio-codec [INFO] [stderr] --> src/client.rs:405:23 [INFO] [stderr] | [INFO] [stderr] 405 | Box, ClientCodec>, Error = IoError>> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::Framed': Moved to tokio-codec [INFO] [stderr] --> src/client.rs:101:41 [INFO] [stderr] | [INFO] [stderr] 101 | use tokio_io::codec::{Encoder, Decoder, Framed}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::Framed': Moved to tokio-codec [INFO] [stderr] --> src/client.rs:108:31 [INFO] [stderr] | [INFO] [stderr] 108 | pub type ClientTransport = Framed, ClientCodec>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::Framed': Moved to tokio-codec [INFO] [stderr] --> src/client.rs:337:36 [INFO] [stderr] | [INFO] [stderr] 337 | type HandshakeItem = (Response, Framed, ClientCodec>); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::Framed': Moved to tokio-codec [INFO] [stderr] --> src/client.rs:404:26 [INFO] [stderr] | [INFO] [stderr] 404 | fn clientauth(stream: Framed, ClientCodec>, params: &ClientParams, features: &[String]) -> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::Framed': Moved to tokio-codec [INFO] [stderr] --> src/client.rs:405:23 [INFO] [stderr] | [INFO] [stderr] 405 | Box, ClientCodec>, Error = IoError>> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::AsyncRead::framed': Use tokio_codec::Decoder::framed instead [INFO] [stderr] --> src/client.rs:346:12 [INFO] [stderr] | [INFO] [stderr] 346 | io.framed(ClientCodec::new()) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::AsyncRead::framed': Use tokio_codec::Decoder::framed instead [INFO] [stderr] --> src/client.rs:346:12 [INFO] [stderr] | [INFO] [stderr] 346 | io.framed(ClientCodec::new()) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/response.rs:29:20 [INFO] [stderr] | [INFO] [stderr] 29 | pub fn numeric(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/response.rs:39:24 [INFO] [stderr] | [INFO] [stderr] 39 | pub fn is_positive(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/response.rs:87:20 [INFO] [stderr] | [INFO] [stderr] 87 | pub fn numeric(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/response.rs:29:20 [INFO] [stderr] | [INFO] [stderr] 29 | pub fn numeric(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/response.rs:39:24 [INFO] [stderr] | [INFO] [stderr] 39 | pub fn is_positive(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/response.rs:87:20 [INFO] [stderr] | [INFO] [stderr] 87 | pub fn numeric(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/response.rs:397:19 [INFO] [stderr] | [INFO] [stderr] 397 | (Some("me".as_ref()), vec!["me", "8BITMIME", "SIZE 42"]), [INFO] [stderr] | ^^^^^^^^^^^^^ help: try this: `"me"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/response.rs:398:19 [INFO] [stderr] | [INFO] [stderr] 398 | (Some("me".as_ref()), vec!["me mo", "8BITMIME", "SIZE 42"]), [INFO] [stderr] | ^^^^^^^^^^^^^ help: try this: `"me"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/util.rs:37:32 [INFO] [stderr] | [INFO] [stderr] 37 | for (input, expect) in vec![ [INFO] [stderr] | ________________________________^ [INFO] [stderr] 38 | | ("bjorn", "bjorn"), [INFO] [stderr] 39 | | ("bjørn", "bjørn"), [INFO] [stderr] 40 | | ("Ø+= ❤️‰", "Ø+2B+3D+20❤️‰"), [INFO] [stderr] 41 | | ("+", "+2B"), [INFO] [stderr] 42 | | ] { [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.41s [INFO] running `"docker" "inspect" "dc617f727cb247784f3e299cbd1fa9acf43268cf91d5efa050f9d4bad10a5f65"` [INFO] running `"docker" "rm" "-f" "dc617f727cb247784f3e299cbd1fa9acf43268cf91d5efa050f9d4bad10a5f65"` [INFO] [stdout] dc617f727cb247784f3e299cbd1fa9acf43268cf91d5efa050f9d4bad10a5f65