[INFO] crate tokio-serde-msgpack 0.2.0 is already in cache [INFO] extracting crate tokio-serde-msgpack 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/tokio-serde-msgpack/0.2.0 [INFO] extracting crate tokio-serde-msgpack 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tokio-serde-msgpack/0.2.0 [INFO] validating manifest of tokio-serde-msgpack-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tokio-serde-msgpack-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tokio-serde-msgpack-0.2.0 [INFO] finished frobbing tokio-serde-msgpack-0.2.0 [INFO] frobbed toml for tokio-serde-msgpack-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/tokio-serde-msgpack/0.2.0/Cargo.toml [INFO] started frobbing tokio-serde-msgpack-0.2.0 [INFO] finished frobbing tokio-serde-msgpack-0.2.0 [INFO] frobbed toml for tokio-serde-msgpack-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tokio-serde-msgpack/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tokio-serde-msgpack-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/tokio-serde-msgpack/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 37809e92065c86588ee850781ac0865410f64be40edc2c09123fce0d3f9b919d [INFO] running `"docker" "start" "-a" "37809e92065c86588ee850781ac0865410f64be40edc2c09123fce0d3f9b919d"` [INFO] [stderr] Checking rmp v0.8.7 [INFO] [stderr] Checking tokio-stdin-stdout v0.1.5 [INFO] [stderr] Checking rmp-serde v0.13.7 [INFO] [stderr] Checking tokio-serde-msgpack v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::FramedRead': Moved to tokio-codec [INFO] [stderr] --> src/lib.rs:11:41 [INFO] [stderr] | [INFO] [stderr] 11 | use tokio_io::codec::{Decoder, Encoder, FramedRead, FramedWrite}; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::FramedWrite': Moved to tokio-codec [INFO] [stderr] --> src/lib.rs:11:53 [INFO] [stderr] | [INFO] [stderr] 11 | use tokio_io::codec::{Decoder, Encoder, FramedRead, FramedWrite}; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::FramedRead': Moved to tokio-codec [INFO] [stderr] --> src/lib.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | tokio_io::codec::FramedRead, MsgPackDecoder<'lt, R>>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::FramedWrite': Moved to tokio-codec [INFO] [stderr] --> src/lib.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | tokio_io::codec::FramedWrite, MsgPackEncoder>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::FramedRead': Moved to tokio-codec [INFO] [stderr] --> src/lib.rs:29:15 [INFO] [stderr] | [INFO] [stderr] 29 | let rx2 = FramedRead::new(rx, MsgPackDecoder::<'lt, R>::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::FramedWrite': Moved to tokio-codec [INFO] [stderr] --> src/lib.rs:30:15 [INFO] [stderr] | [INFO] [stderr] 30 | let tx2 = FramedWrite::new(tx, MsgPackEncoder::::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `MsgPackDecoder<'de, T>` [INFO] [stderr] --> src/lib.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | / pub fn new() -> Self { [INFO] [stderr] 46 | | MsgPackDecoder { ghost: PhantomData } [INFO] [stderr] 47 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 34 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:75:12 [INFO] [stderr] | [INFO] [stderr] 75 | if buf.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:80:65 [INFO] [stderr] | [INFO] [stderr] 80 | let rv = Deserialize::deserialize(&mut des).map_err(|e| DecodeError::Decode(e)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `DecodeError::Decode` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `MsgPackEncoder` [INFO] [stderr] --> src/lib.rs:106:5 [INFO] [stderr] | [INFO] [stderr] 106 | / pub fn new() -> Self { [INFO] [stderr] 107 | | MsgPackEncoder { ghost: PhantomData } [INFO] [stderr] 108 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 95 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:141:22 [INFO] [stderr] | [INFO] [stderr] 141 | .map_err(|e| EncodeError::Encode(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `EncodeError::Encode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::FramedRead': Moved to tokio-codec [INFO] [stderr] --> src/lib.rs:11:41 [INFO] [stderr] | [INFO] [stderr] 11 | use tokio_io::codec::{Decoder, Encoder, FramedRead, FramedWrite}; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::FramedWrite': Moved to tokio-codec [INFO] [stderr] --> src/lib.rs:11:53 [INFO] [stderr] | [INFO] [stderr] 11 | use tokio_io::codec::{Decoder, Encoder, FramedRead, FramedWrite}; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::FramedRead': Moved to tokio-codec [INFO] [stderr] --> src/lib.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | tokio_io::codec::FramedRead, MsgPackDecoder<'lt, R>>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::FramedWrite': Moved to tokio-codec [INFO] [stderr] --> src/lib.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | tokio_io::codec::FramedWrite, MsgPackEncoder>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::FramedRead': Moved to tokio-codec [INFO] [stderr] --> src/lib.rs:29:15 [INFO] [stderr] | [INFO] [stderr] 29 | let rx2 = FramedRead::new(rx, MsgPackDecoder::<'lt, R>::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::FramedWrite': Moved to tokio-codec [INFO] [stderr] --> src/lib.rs:30:15 [INFO] [stderr] | [INFO] [stderr] 30 | let tx2 = FramedWrite::new(tx, MsgPackEncoder::::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `MsgPackDecoder<'de, T>` [INFO] [stderr] --> src/lib.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | / pub fn new() -> Self { [INFO] [stderr] 46 | | MsgPackDecoder { ghost: PhantomData } [INFO] [stderr] 47 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 34 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:75:12 [INFO] [stderr] | [INFO] [stderr] 75 | if buf.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:80:65 [INFO] [stderr] | [INFO] [stderr] 80 | let rv = Deserialize::deserialize(&mut des).map_err(|e| DecodeError::Decode(e)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `DecodeError::Decode` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `MsgPackEncoder` [INFO] [stderr] --> src/lib.rs:106:5 [INFO] [stderr] | [INFO] [stderr] 106 | / pub fn new() -> Self { [INFO] [stderr] 107 | | MsgPackEncoder { ghost: PhantomData } [INFO] [stderr] 108 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 95 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:141:22 [INFO] [stderr] | [INFO] [stderr] 141 | .map_err(|e| EncodeError::Encode(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `EncodeError::Encode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::FramedRead': Moved to tokio-codec [INFO] [stderr] --> examples/client.rs:14:23 [INFO] [stderr] | [INFO] [stderr] 14 | use tokio_io::codec::{FramedRead, LinesCodec}; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::LinesCodec': Moved to tokio-codec [INFO] [stderr] --> examples/client.rs:14:35 [INFO] [stderr] | [INFO] [stderr] 14 | use tokio_io::codec::{FramedRead, LinesCodec}; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::FramedRead': Moved to tokio-codec [INFO] [stderr] --> examples/client.rs:45:24 [INFO] [stderr] | [INFO] [stderr] 45 | let lines_in = FramedRead::new(stdin, LinesCodec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::LinesCodec': Moved to tokio-codec [INFO] [stderr] --> examples/client.rs:45:47 [INFO] [stderr] | [INFO] [stderr] 45 | let lines_in = FramedRead::new(stdin, LinesCodec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> examples/client.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | counter = counter + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `counter += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.74s [INFO] running `"docker" "inspect" "37809e92065c86588ee850781ac0865410f64be40edc2c09123fce0d3f9b919d"` [INFO] running `"docker" "rm" "-f" "37809e92065c86588ee850781ac0865410f64be40edc2c09123fce0d3f9b919d"` [INFO] [stdout] 37809e92065c86588ee850781ac0865410f64be40edc2c09123fce0d3f9b919d