[INFO] crate tokio-interceptor 0.1.0 is already in cache [INFO] extracting crate tokio-interceptor 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/tokio-interceptor/0.1.0 [INFO] extracting crate tokio-interceptor 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tokio-interceptor/0.1.0 [INFO] validating manifest of tokio-interceptor-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tokio-interceptor-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tokio-interceptor-0.1.0 [INFO] finished frobbing tokio-interceptor-0.1.0 [INFO] frobbed toml for tokio-interceptor-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/tokio-interceptor/0.1.0/Cargo.toml [INFO] started frobbing tokio-interceptor-0.1.0 [INFO] finished frobbing tokio-interceptor-0.1.0 [INFO] frobbed toml for tokio-interceptor-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tokio-interceptor/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tokio-interceptor-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/tokio-interceptor/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a9183ef707187aa32cdb6709207fb9fb842a73a30fc24d0b811666ad72c9ce34 [INFO] running `"docker" "start" "-a" "a9183ef707187aa32cdb6709207fb9fb842a73a30fc24d0b811666ad72c9ce34"` [INFO] [stderr] Checking anymap v0.12.1 [INFO] [stderr] Checking tokio-interceptor v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:198:20 [INFO] [stderr] | [INFO] [stderr] 198 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 199 | | if self.direction.is_forwards() { [INFO] [stderr] 200 | | self.direction = Direction::Backwards; [INFO] [stderr] 201 | | let stack = mem::replace(&mut ctx.stack, vec![]); [INFO] [stderr] ... | [INFO] [stderr] 207 | | } [INFO] [stderr] 208 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 198 | } else if self.direction.is_forwards() { [INFO] [stderr] 199 | self.direction = Direction::Backwards; [INFO] [stderr] 200 | let stack = mem::replace(&mut ctx.stack, vec![]); [INFO] [stderr] 201 | ctx.queue = stack.into_iter().rev().collect(); [INFO] [stderr] 202 | self.next_ctx = Box::new(future::ok(ctx)); [INFO] [stderr] 203 | continue; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:198:20 [INFO] [stderr] | [INFO] [stderr] 198 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 199 | | if self.direction.is_forwards() { [INFO] [stderr] 200 | | self.direction = Direction::Backwards; [INFO] [stderr] 201 | | let stack = mem::replace(&mut ctx.stack, vec![]); [INFO] [stderr] ... | [INFO] [stderr] 207 | | } [INFO] [stderr] 208 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 198 | } else if self.direction.is_forwards() { [INFO] [stderr] 199 | self.direction = Direction::Backwards; [INFO] [stderr] 200 | let stack = mem::replace(&mut ctx.stack, vec![]); [INFO] [stderr] 201 | ctx.queue = stack.into_iter().rev().collect(); [INFO] [stderr] 202 | self.next_ctx = Box::new(future::ok(ctx)); [INFO] [stderr] 203 | continue; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `effects::HandleEffects` [INFO] [stderr] --> src/effects.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | / pub fn new() -> HandleEffects { [INFO] [stderr] 34 | | HandleEffects(PhantomData) [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 29 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/events.rs:121:21 [INFO] [stderr] | [INFO] [stderr] 121 | event_handlers: HashMap>>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `events::EventDispatcher` [INFO] [stderr] --> src/events.rs:125:5 [INFO] [stderr] | [INFO] [stderr] 125 | / pub fn new() -> EventDispatcher { [INFO] [stderr] 126 | | EventDispatcher { [INFO] [stderr] 127 | | event_handlers: HashMap::new(), [INFO] [stderr] 128 | | } [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 120 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/events.rs:133:65 [INFO] [stderr] | [INFO] [stderr] 133 | interceptors.into_iter().map(|i| Rc::new(i)).collect()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove closure as shown: `Rc::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `IdentityEvent` [INFO] [stderr] --> src/lib.rs:274:5 [INFO] [stderr] | [INFO] [stderr] 274 | struct IdentityEvent; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/queue.rs:52:44 [INFO] [stderr] | [INFO] [stderr] 52 | self.0.extend(iter.into_iter().map(|i| Rc::new(i))) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove closure as shown: `Rc::new` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `effects::HandleEffects` [INFO] [stderr] --> src/effects.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | / pub fn new() -> HandleEffects { [INFO] [stderr] 34 | | HandleEffects(PhantomData) [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 29 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/events.rs:121:21 [INFO] [stderr] | [INFO] [stderr] 121 | event_handlers: HashMap>>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `events::EventDispatcher` [INFO] [stderr] --> src/events.rs:125:5 [INFO] [stderr] | [INFO] [stderr] 125 | / pub fn new() -> EventDispatcher { [INFO] [stderr] 126 | | EventDispatcher { [INFO] [stderr] 127 | | event_handlers: HashMap::new(), [INFO] [stderr] 128 | | } [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 120 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/events.rs:133:65 [INFO] [stderr] | [INFO] [stderr] 133 | interceptors.into_iter().map(|i| Rc::new(i)).collect()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove closure as shown: `Rc::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/queue.rs:52:44 [INFO] [stderr] | [INFO] [stderr] 52 | self.0.extend(iter.into_iter().map(|i| Rc::new(i))) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove closure as shown: `Rc::new` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:258:9 [INFO] [stderr] | [INFO] [stderr] 258 | app.dispatch(BeforeEvent(Rc::clone(&called))).wait(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:290:9 [INFO] [stderr] | [INFO] [stderr] 290 | app.dispatch(BeforeEvent(Rc::clone(&called_second))).wait(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:322:9 [INFO] [stderr] | [INFO] [stderr] 322 | app.dispatch(BeforeEvent(Rc::clone(&called_second))).wait(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> examples/todo.rs:71:20 [INFO] [stderr] | [INFO] [stderr] 71 | let menu = format!(r#" [INFO] [stderr] | ____________________^ [INFO] [stderr] 72 | | --- [INFO] [stderr] 73 | | What do you want to do? [INFO] [stderr] 74 | | 1 - Display tasks [INFO] [stderr] ... | [INFO] [stderr] 78 | | --- [INFO] [stderr] 79 | | "#); [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] help: consider using .to_string() [INFO] [stderr] | [INFO] [stderr] 71 | let menu = r#" [INFO] [stderr] 72 | --- [INFO] [stderr] 73 | What do you want to do? [INFO] [stderr] 74 | 1 - Display tasks [INFO] [stderr] 75 | 2 - Add a new task [INFO] [stderr] 76 | 3 - Change task "done" status [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> examples/todo.rs:214:49 [INFO] [stderr] | [INFO] [stderr] 214 | context.effects.push(Box::new(Print(format!("\nTODO:")))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"\nTODO:".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> examples/todo.rs:216:16 [INFO] [stderr] | [INFO] [stderr] 216 | if 0 == todos.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `todos.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> examples/todo.rs:280:36 [INFO] [stderr] | [INFO] [stderr] 280 | let todo = state.todos.get_mut(index).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `state.todos[index]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 8.12s [INFO] running `"docker" "inspect" "a9183ef707187aa32cdb6709207fb9fb842a73a30fc24d0b811666ad72c9ce34"` [INFO] running `"docker" "rm" "-f" "a9183ef707187aa32cdb6709207fb9fb842a73a30fc24d0b811666ad72c9ce34"` [INFO] [stdout] a9183ef707187aa32cdb6709207fb9fb842a73a30fc24d0b811666ad72c9ce34