[INFO] crate tokio-icmp 0.1.0 is already in cache [INFO] extracting crate tokio-icmp 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/tokio-icmp/0.1.0 [INFO] extracting crate tokio-icmp 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tokio-icmp/0.1.0 [INFO] validating manifest of tokio-icmp-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tokio-icmp-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tokio-icmp-0.1.0 [INFO] finished frobbing tokio-icmp-0.1.0 [INFO] frobbed toml for tokio-icmp-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/tokio-icmp/0.1.0/Cargo.toml [INFO] started frobbing tokio-icmp-0.1.0 [INFO] finished frobbing tokio-icmp-0.1.0 [INFO] frobbed toml for tokio-icmp-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tokio-icmp/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tokio-icmp-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/tokio-icmp/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a22e98b5d0cfa4a1856a71908b6be782796c4a07342264764aa2a11d04185c51 [INFO] running `"docker" "start" "-a" "a22e98b5d0cfa4a1856a71908b6be782796c4a07342264764aa2a11d04185c51"` [INFO] [stderr] Compiling syntex_errors v0.42.0 [INFO] [stderr] Compiling syntex_syntax v0.42.0 [INFO] [stderr] Compiling syntex v0.42.2 [INFO] [stderr] Compiling pnet_macros v0.21.0 [INFO] [stderr] Compiling pnet_packet v0.21.0 [INFO] [stderr] Checking tokio-icmp v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/socket.rs:63:27 [INFO] [stderr] | [INFO] [stderr] 63 | Err(e) => Err(e.into()) [INFO] [stderr] | ^^^^^^^^ help: consider removing `.into()`: `e` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/send.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | let ref mut inner = self.inner.as_mut() [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 42 | let inner = &mut self.inner.as_mut() [INFO] [stderr] 43 | .expect("tokio_icmp::SendIcmpPacket polled after completion"); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/recv.rs:31:17 [INFO] [stderr] | [INFO] [stderr] 31 | let ref mut inner = self.inner.as_mut() [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 31 | let inner = &mut self.inner.as_mut() [INFO] [stderr] 32 | .expect("RecvIcmpPacket polled after completion"); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/socket.rs:63:27 [INFO] [stderr] | [INFO] [stderr] 63 | Err(e) => Err(e.into()) [INFO] [stderr] | ^^^^^^^^ help: consider removing `.into()`: `e` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/send.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | let ref mut inner = self.inner.as_mut() [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 42 | let inner = &mut self.inner.as_mut() [INFO] [stderr] 43 | .expect("tokio_icmp::SendIcmpPacket polled after completion"); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/recv.rs:31:17 [INFO] [stderr] | [INFO] [stderr] 31 | let ref mut inner = self.inner.as_mut() [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 31 | let inner = &mut self.inner.as_mut() [INFO] [stderr] 32 | .expect("RecvIcmpPacket polled after completion"); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 47.36s [INFO] running `"docker" "inspect" "a22e98b5d0cfa4a1856a71908b6be782796c4a07342264764aa2a11d04185c51"` [INFO] running `"docker" "rm" "-f" "a22e98b5d0cfa4a1856a71908b6be782796c4a07342264764aa2a11d04185c51"` [INFO] [stdout] a22e98b5d0cfa4a1856a71908b6be782796c4a07342264764aa2a11d04185c51