[INFO] crate tokio-hglib 0.2.0 is already in cache [INFO] extracting crate tokio-hglib 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/tokio-hglib/0.2.0 [INFO] extracting crate tokio-hglib 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tokio-hglib/0.2.0 [INFO] validating manifest of tokio-hglib-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tokio-hglib-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tokio-hglib-0.2.0 [INFO] finished frobbing tokio-hglib-0.2.0 [INFO] frobbed toml for tokio-hglib-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/tokio-hglib/0.2.0/Cargo.toml [INFO] started frobbing tokio-hglib-0.2.0 [INFO] finished frobbing tokio-hglib-0.2.0 [INFO] frobbed toml for tokio-hglib-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tokio-hglib/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tokio-hglib-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/tokio-hglib/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f5d1cc4b0fb178a9590bab8ac1f41756aa30a34c05f693ee36242c5dca9c4c02 [INFO] running `"docker" "start" "-a" "f5d1cc4b0fb178a9590bab8ac1f41756aa30a34c05f693ee36242c5dca9c4c02"` [INFO] [stderr] Checking tokio-signal v0.2.7 [INFO] [stderr] Checking tokio-process v0.2.3 [INFO] [stderr] Checking tokio-hglib v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `codec::ChannelCodec` [INFO] [stderr] --> src/codec.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | / pub fn new() -> ChannelCodec { [INFO] [stderr] 28 | | ChannelCodec {} [INFO] [stderr] 29 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 23 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `codec::BlockCodec` [INFO] [stderr] --> src/codec.rs:94:5 [INFO] [stderr] | [INFO] [stderr] 94 | / pub fn new() -> BlockCodec { [INFO] [stderr] 95 | | BlockCodec {} [INFO] [stderr] 96 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 90 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/message.rs:35:14 [INFO] [stderr] | [INFO] [stderr] 35 | .ok_or(new_parse_error(format!("malformed line in hello message: {}", line)))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| new_parse_error(format!("malformed line in hello message: {}", line)))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/protocol.rs:275:7 [INFO] [stderr] | [INFO] [stderr] 275 | v.ok_or(io::Error::new(io::ErrorKind::UnexpectedEof, "no result code received")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| io::Error::new(io::ErrorKind::UnexpectedEof, "no result code received"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `codec::ChannelCodec` [INFO] [stderr] --> src/codec.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | / pub fn new() -> ChannelCodec { [INFO] [stderr] 28 | | ChannelCodec {} [INFO] [stderr] 29 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 23 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `codec::BlockCodec` [INFO] [stderr] --> src/codec.rs:94:5 [INFO] [stderr] | [INFO] [stderr] 94 | / pub fn new() -> BlockCodec { [INFO] [stderr] 95 | | BlockCodec {} [INFO] [stderr] 96 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 90 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/message.rs:35:14 [INFO] [stderr] | [INFO] [stderr] 35 | .ok_or(new_parse_error(format!("malformed line in hello message: {}", line)))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| new_parse_error(format!("malformed line in hello message: {}", line)))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/protocol.rs:275:7 [INFO] [stderr] | [INFO] [stderr] 275 | v.ok_or(io::Error::new(io::ErrorKind::UnexpectedEof, "no result code received")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| io::Error::new(io::ErrorKind::UnexpectedEof, "no result code received"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/channel_decoding.rs:20:50 [INFO] [stderr] | [INFO] [stderr] 20 | assert_eq!(Some(ChannelMessage::InputRequest(0xdeadbeef)), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xdead_beef` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/channel_decoding.rs:22:49 [INFO] [stderr] | [INFO] [stderr] 22 | assert_eq!(Some(ChannelMessage::LineRequest(0xdeadbeef)), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xdead_beef` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/channel_decoding.rs:52:50 [INFO] [stderr] | [INFO] [stderr] 52 | assert_eq!(Some(ChannelMessage::InputRequest(0xdeadbeef)), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xdead_beef` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 16.71s [INFO] running `"docker" "inspect" "f5d1cc4b0fb178a9590bab8ac1f41756aa30a34c05f693ee36242c5dca9c4c02"` [INFO] running `"docker" "rm" "-f" "f5d1cc4b0fb178a9590bab8ac1f41756aa30a34c05f693ee36242c5dca9c4c02"` [INFO] [stdout] f5d1cc4b0fb178a9590bab8ac1f41756aa30a34c05f693ee36242c5dca9c4c02