[INFO] crate tokio-coap 0.2.0 is already in cache [INFO] extracting crate tokio-coap 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/tokio-coap/0.2.0 [INFO] extracting crate tokio-coap 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tokio-coap/0.2.0 [INFO] validating manifest of tokio-coap-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tokio-coap-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tokio-coap-0.2.0 [INFO] finished frobbing tokio-coap-0.2.0 [INFO] frobbed toml for tokio-coap-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/tokio-coap/0.2.0/Cargo.toml [INFO] started frobbing tokio-coap-0.2.0 [INFO] finished frobbing tokio-coap-0.2.0 [INFO] frobbed toml for tokio-coap-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tokio-coap/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tokio-coap-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/tokio-coap/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 55f61fa68d774da4f356f212e1d41662d455665a72204916dfb762085a373edd [INFO] running `"docker" "start" "-a" "55f61fa68d774da4f356f212e1d41662d455665a72204916dfb762085a373edd"` [INFO] [stderr] Checking smallvec v0.5.1 [INFO] [stderr] Checking tokio-coap v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/message/option/mod.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | options: options, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `options` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/message/mod.rs:303:13 [INFO] [stderr] | [INFO] [stderr] 303 | version: version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/message/mod.rs:304:13 [INFO] [stderr] | [INFO] [stderr] 304 | mtype: mtype, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `mtype` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/message/mod.rs:305:13 [INFO] [stderr] | [INFO] [stderr] 305 | code: code, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/message/mod.rs:306:13 [INFO] [stderr] | [INFO] [stderr] 306 | mid: mid, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `mid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/message/mod.rs:307:13 [INFO] [stderr] | [INFO] [stderr] 307 | token: token, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `token` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/message/mod.rs:308:13 [INFO] [stderr] | [INFO] [stderr] 308 | options: options, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `options` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/message/mod.rs:309:13 [INFO] [stderr] | [INFO] [stderr] 309 | payload: payload, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `payload` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/message/option/mod.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | options: options, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `options` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/message/mod.rs:303:13 [INFO] [stderr] | [INFO] [stderr] 303 | version: version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/message/mod.rs:304:13 [INFO] [stderr] | [INFO] [stderr] 304 | mtype: mtype, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `mtype` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/message/mod.rs:305:13 [INFO] [stderr] | [INFO] [stderr] 305 | code: code, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/message/mod.rs:306:13 [INFO] [stderr] | [INFO] [stderr] 306 | mid: mid, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `mid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/message/mod.rs:307:13 [INFO] [stderr] | [INFO] [stderr] 307 | token: token, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `token` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/message/mod.rs:308:13 [INFO] [stderr] | [INFO] [stderr] 308 | options: options, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `options` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/message/mod.rs:309:13 [INFO] [stderr] | [INFO] [stderr] 309 | payload: payload, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `payload` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/message/mod.rs:123:41 [INFO] [stderr] | [INFO] [stderr] 123 | Code::Get => Self::build(0, 01), [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_prefixed_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 123 | Code::Get => Self::build(0, 1), [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 123 | Code::Get => Self::build(0, 0o1), [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/message/mod.rs:124:42 [INFO] [stderr] | [INFO] [stderr] 124 | Code::Post => Self::build(0, 02), [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 124 | Code::Post => Self::build(0, 2), [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 124 | Code::Post => Self::build(0, 0o2), [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/message/mod.rs:125:41 [INFO] [stderr] | [INFO] [stderr] 125 | Code::Put => Self::build(0, 03), [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 125 | Code::Put => Self::build(0, 3), [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 125 | Code::Put => Self::build(0, 0o3), [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/message/mod.rs:126:44 [INFO] [stderr] | [INFO] [stderr] 126 | Code::Delete => Self::build(0, 04), [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 126 | Code::Delete => Self::build(0, 4), [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 126 | Code::Delete => Self::build(0, 0o4), [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/message/mod.rs:127:45 [INFO] [stderr] | [INFO] [stderr] 127 | Code::Created => Self::build(2, 01), [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 127 | Code::Created => Self::build(2, 1), [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 127 | Code::Created => Self::build(2, 0o1), [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/message/mod.rs:128:45 [INFO] [stderr] | [INFO] [stderr] 128 | Code::Deleted => Self::build(2, 02), [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 128 | Code::Deleted => Self::build(2, 2), [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 128 | Code::Deleted => Self::build(2, 0o2), [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/message/mod.rs:129:43 [INFO] [stderr] | [INFO] [stderr] 129 | Code::Valid => Self::build(2, 03), [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 129 | Code::Valid => Self::build(2, 3), [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 129 | Code::Valid => Self::build(2, 0o3), [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/message/mod.rs:130:45 [INFO] [stderr] | [INFO] [stderr] 130 | Code::Changed => Self::build(2, 04), [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 130 | Code::Changed => Self::build(2, 4), [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 130 | Code::Changed => Self::build(2, 0o4), [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/message/mod.rs:131:45 [INFO] [stderr] | [INFO] [stderr] 131 | Code::Content => Self::build(2, 05), [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 131 | Code::Content => Self::build(2, 5), [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 131 | Code::Content => Self::build(2, 0o5), [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/message/mod.rs:133:50 [INFO] [stderr] | [INFO] [stderr] 133 | Code::Unauthorized => Self::build(4, 01), [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 133 | Code::Unauthorized => Self::build(4, 1), [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 133 | Code::Unauthorized => Self::build(4, 0o1), [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/message/mod.rs:134:47 [INFO] [stderr] | [INFO] [stderr] 134 | Code::BadOption => Self::build(4, 02), [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 134 | Code::BadOption => Self::build(4, 2), [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 134 | Code::BadOption => Self::build(4, 0o2), [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/message/mod.rs:135:47 [INFO] [stderr] | [INFO] [stderr] 135 | Code::Forbidden => Self::build(4, 03), [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 135 | Code::Forbidden => Self::build(4, 3), [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 135 | Code::Forbidden => Self::build(4, 0o3), [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/message/mod.rs:136:46 [INFO] [stderr] | [INFO] [stderr] 136 | Code::NotFound => Self::build(4, 04), [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 136 | Code::NotFound => Self::build(4, 4), [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 136 | Code::NotFound => Self::build(4, 0o4), [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/message/mod.rs:137:54 [INFO] [stderr] | [INFO] [stderr] 137 | Code::MethodNotAllowed => Self::build(4, 05), [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 137 | Code::MethodNotAllowed => Self::build(4, 5), [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 137 | Code::MethodNotAllowed => Self::build(4, 0o5), [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/message/mod.rs:138:51 [INFO] [stderr] | [INFO] [stderr] 138 | Code::NotAcceptable => Self::build(4, 06), [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 138 | Code::NotAcceptable => Self::build(4, 6), [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 138 | Code::NotAcceptable => Self::build(4, 0o6), [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/message/mod.rs:143:52 [INFO] [stderr] | [INFO] [stderr] 143 | Code::NotImplemented => Self::build(5, 01), [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 143 | Code::NotImplemented => Self::build(5, 1), [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 143 | Code::NotImplemented => Self::build(5, 0o1), [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/message/mod.rs:144:48 [INFO] [stderr] | [INFO] [stderr] 144 | Code::BadGateway => Self::build(5, 02), [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 144 | Code::BadGateway => Self::build(5, 2), [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 144 | Code::BadGateway => Self::build(5, 0o2), [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/message/mod.rs:145:56 [INFO] [stderr] | [INFO] [stderr] 145 | Code::ServiceUnavailable => Self::build(5, 03), [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 145 | Code::ServiceUnavailable => Self::build(5, 3), [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 145 | Code::ServiceUnavailable => Self::build(5, 0o3), [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/message/mod.rs:146:52 [INFO] [stderr] | [INFO] [stderr] 146 | Code::GatewayTimeout => Self::build(5, 04), [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 146 | Code::GatewayTimeout => Self::build(5, 4), [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 146 | Code::GatewayTimeout => Self::build(5, 0o4), [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/message/mod.rs:147:58 [INFO] [stderr] | [INFO] [stderr] 147 | Code::ProxyingNotSupported => Self::build(5, 05), [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 147 | Code::ProxyingNotSupported => Self::build(5, 5), [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 147 | Code::ProxyingNotSupported => Self::build(5, 0o5), [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/message/mod.rs:272:21 [INFO] [stderr] | [INFO] [stderr] 272 | ((pkt[i - 1] as u16) << 8) | pkt[i] as u16 + 269 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `((pkt[i - 1] as u16) << 8) | (pkt[i] as u16 + 269)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/message/mod.rs:123:41 [INFO] [stderr] | [INFO] [stderr] 123 | Code::Get => Self::build(0, 01), [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_prefixed_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 123 | Code::Get => Self::build(0, 1), [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 123 | Code::Get => Self::build(0, 0o1), [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/message/mod.rs:124:42 [INFO] [stderr] | [INFO] [stderr] 124 | Code::Post => Self::build(0, 02), [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 124 | Code::Post => Self::build(0, 2), [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 124 | Code::Post => Self::build(0, 0o2), [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/message/mod.rs:125:41 [INFO] [stderr] | [INFO] [stderr] 125 | Code::Put => Self::build(0, 03), [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 125 | Code::Put => Self::build(0, 3), [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 125 | Code::Put => Self::build(0, 0o3), [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/message/mod.rs:126:44 [INFO] [stderr] | [INFO] [stderr] 126 | Code::Delete => Self::build(0, 04), [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 126 | Code::Delete => Self::build(0, 4), [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 126 | Code::Delete => Self::build(0, 0o4), [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/message/mod.rs:127:45 [INFO] [stderr] | [INFO] [stderr] 127 | Code::Created => Self::build(2, 01), [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 127 | Code::Created => Self::build(2, 1), [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 127 | Code::Created => Self::build(2, 0o1), [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/message/mod.rs:128:45 [INFO] [stderr] | [INFO] [stderr] 128 | Code::Deleted => Self::build(2, 02), [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 128 | Code::Deleted => Self::build(2, 2), [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 128 | Code::Deleted => Self::build(2, 0o2), [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/message/mod.rs:129:43 [INFO] [stderr] | [INFO] [stderr] 129 | Code::Valid => Self::build(2, 03), [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 129 | Code::Valid => Self::build(2, 3), [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 129 | Code::Valid => Self::build(2, 0o3), [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/message/mod.rs:130:45 [INFO] [stderr] | [INFO] [stderr] 130 | Code::Changed => Self::build(2, 04), [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 130 | Code::Changed => Self::build(2, 4), [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 130 | Code::Changed => Self::build(2, 0o4), [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/message/mod.rs:131:45 [INFO] [stderr] | [INFO] [stderr] 131 | Code::Content => Self::build(2, 05), [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 131 | Code::Content => Self::build(2, 5), [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 131 | Code::Content => Self::build(2, 0o5), [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/message/mod.rs:133:50 [INFO] [stderr] | [INFO] [stderr] 133 | Code::Unauthorized => Self::build(4, 01), [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 133 | Code::Unauthorized => Self::build(4, 1), [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 133 | Code::Unauthorized => Self::build(4, 0o1), [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/message/mod.rs:134:47 [INFO] [stderr] | [INFO] [stderr] 134 | Code::BadOption => Self::build(4, 02), [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 134 | Code::BadOption => Self::build(4, 2), [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 134 | Code::BadOption => Self::build(4, 0o2), [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/message/mod.rs:135:47 [INFO] [stderr] | [INFO] [stderr] 135 | Code::Forbidden => Self::build(4, 03), [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 135 | Code::Forbidden => Self::build(4, 3), [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 135 | Code::Forbidden => Self::build(4, 0o3), [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/message/mod.rs:136:46 [INFO] [stderr] | [INFO] [stderr] 136 | Code::NotFound => Self::build(4, 04), [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 136 | Code::NotFound => Self::build(4, 4), [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 136 | Code::NotFound => Self::build(4, 0o4), [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/message/mod.rs:137:54 [INFO] [stderr] | [INFO] [stderr] 137 | Code::MethodNotAllowed => Self::build(4, 05), [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 137 | Code::MethodNotAllowed => Self::build(4, 5), [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 137 | Code::MethodNotAllowed => Self::build(4, 0o5), [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/message/mod.rs:138:51 [INFO] [stderr] | [INFO] [stderr] 138 | Code::NotAcceptable => Self::build(4, 06), [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 138 | Code::NotAcceptable => Self::build(4, 6), [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 138 | Code::NotAcceptable => Self::build(4, 0o6), [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/message/mod.rs:143:52 [INFO] [stderr] | [INFO] [stderr] 143 | Code::NotImplemented => Self::build(5, 01), [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 143 | Code::NotImplemented => Self::build(5, 1), [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 143 | Code::NotImplemented => Self::build(5, 0o1), [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/message/mod.rs:144:48 [INFO] [stderr] | [INFO] [stderr] 144 | Code::BadGateway => Self::build(5, 02), [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 144 | Code::BadGateway => Self::build(5, 2), [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 144 | Code::BadGateway => Self::build(5, 0o2), [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/message/mod.rs:145:56 [INFO] [stderr] | [INFO] [stderr] 145 | Code::ServiceUnavailable => Self::build(5, 03), [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 145 | Code::ServiceUnavailable => Self::build(5, 3), [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 145 | Code::ServiceUnavailable => Self::build(5, 0o3), [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/message/mod.rs:146:52 [INFO] [stderr] | [INFO] [stderr] 146 | Code::GatewayTimeout => Self::build(5, 04), [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 146 | Code::GatewayTimeout => Self::build(5, 4), [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 146 | Code::GatewayTimeout => Self::build(5, 0o4), [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/message/mod.rs:147:58 [INFO] [stderr] | [INFO] [stderr] 147 | Code::ProxyingNotSupported => Self::build(5, 05), [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 147 | Code::ProxyingNotSupported => Self::build(5, 5), [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 147 | Code::ProxyingNotSupported => Self::build(5, 0o5), [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/message/mod.rs:272:21 [INFO] [stderr] | [INFO] [stderr] 272 | ((pkt[i - 1] as u16) << 8) | pkt[i] as u16 + 269 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `((pkt[i - 1] as u16) << 8) | (pkt[i] as u16 + 269)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `message::option::Options` [INFO] [stderr] --> src/message/option/mod.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | / pub fn new() -> Self { [INFO] [stderr] 15 | | Options { [INFO] [stderr] 16 | | map: BTreeMap::new(), [INFO] [stderr] 17 | | } [INFO] [stderr] 18 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 9 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/message/option/mod.rs:27:29 [INFO] [stderr] | [INFO] [stderr] 27 | .or_insert_with(|| Vec::new()) [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove closure as shown: `Vec::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/message/option/mod.rs:34:29 [INFO] [stderr] | [INFO] [stderr] 34 | .or_insert_with(|| Vec::new()) [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove closure as shown: `Vec::new` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/message/option/mod.rs:131:5 [INFO] [stderr] | [INFO] [stderr] 131 | *last_option_number = *last_option_number + delta; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*last_option_number += delta` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/message/option/mod.rs:339:32 [INFO] [stderr] | [INFO] [stderr] 339 | value = (value << 8) + *byte as u64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(*byte)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/message/option/mod.rs:349:9 [INFO] [stderr] | [INFO] [stderr] 349 | n = n >> 8; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `n >>= 8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/message/option/mod.rs:315:21 [INFO] [stderr] | [INFO] [stderr] 315 | n = n >> 8; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `n >>= 8` [INFO] [stderr] ... [INFO] [stderr] 366 | / options![ [INFO] [stderr] 367 | | (1, IfMatch, opaque, 0, 8), [INFO] [stderr] 368 | | (3, UriHost, string, 1, 8), [INFO] [stderr] 369 | | (4, ETag, opaque, 0, 8), [INFO] [stderr] ... | [INFO] [stderr] 383 | | (284, NoResponse, uint, 0, 1), [INFO] [stderr] 384 | | ]; [INFO] [stderr] | |__- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/message/option/mod.rs:315:21 [INFO] [stderr] | [INFO] [stderr] 315 | n = n >> 8; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `n >>= 8` [INFO] [stderr] ... [INFO] [stderr] 366 | / options![ [INFO] [stderr] 367 | | (1, IfMatch, opaque, 0, 8), [INFO] [stderr] 368 | | (3, UriHost, string, 1, 8), [INFO] [stderr] 369 | | (4, ETag, opaque, 0, 8), [INFO] [stderr] ... | [INFO] [stderr] 383 | | (284, NoResponse, uint, 0, 1), [INFO] [stderr] 384 | | ]; [INFO] [stderr] | |__- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `message::option::Options` [INFO] [stderr] --> src/message/option/mod.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | / pub fn new() -> Self { [INFO] [stderr] 15 | | Options { [INFO] [stderr] 16 | | map: BTreeMap::new(), [INFO] [stderr] 17 | | } [INFO] [stderr] 18 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 9 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/message/option/mod.rs:27:29 [INFO] [stderr] | [INFO] [stderr] 27 | .or_insert_with(|| Vec::new()) [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove closure as shown: `Vec::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/message/option/mod.rs:34:29 [INFO] [stderr] | [INFO] [stderr] 34 | .or_insert_with(|| Vec::new()) [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove closure as shown: `Vec::new` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/message/option/mod.rs:315:21 [INFO] [stderr] | [INFO] [stderr] 315 | n = n >> 8; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `n >>= 8` [INFO] [stderr] ... [INFO] [stderr] 366 | / options![ [INFO] [stderr] 367 | | (1, IfMatch, opaque, 0, 8), [INFO] [stderr] 368 | | (3, UriHost, string, 1, 8), [INFO] [stderr] 369 | | (4, ETag, opaque, 0, 8), [INFO] [stderr] ... | [INFO] [stderr] 383 | | (284, NoResponse, uint, 0, 1), [INFO] [stderr] 384 | | ]; [INFO] [stderr] | |__- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/message/option/mod.rs:131:5 [INFO] [stderr] | [INFO] [stderr] 131 | *last_option_number = *last_option_number + delta; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*last_option_number += delta` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/message/option/mod.rs:315:21 [INFO] [stderr] | [INFO] [stderr] 315 | n = n >> 8; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `n >>= 8` [INFO] [stderr] ... [INFO] [stderr] 366 | / options![ [INFO] [stderr] 367 | | (1, IfMatch, opaque, 0, 8), [INFO] [stderr] 368 | | (3, UriHost, string, 1, 8), [INFO] [stderr] 369 | | (4, ETag, opaque, 0, 8), [INFO] [stderr] ... | [INFO] [stderr] 383 | | (284, NoResponse, uint, 0, 1), [INFO] [stderr] 384 | | ]; [INFO] [stderr] | |__- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/message/option/mod.rs:339:32 [INFO] [stderr] | [INFO] [stderr] 339 | value = (value << 8) + *byte as u64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(*byte)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/message/option/mod.rs:349:9 [INFO] [stderr] | [INFO] [stderr] 349 | n = n >> 8; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `n >>= 8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/message/option/mod.rs:315:21 [INFO] [stderr] | [INFO] [stderr] 315 | n = n >> 8; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `n >>= 8` [INFO] [stderr] ... [INFO] [stderr] 366 | / options![ [INFO] [stderr] 367 | | (1, IfMatch, opaque, 0, 8), [INFO] [stderr] 368 | | (3, UriHost, string, 1, 8), [INFO] [stderr] 369 | | (4, ETag, opaque, 0, 8), [INFO] [stderr] ... | [INFO] [stderr] 383 | | (284, NoResponse, uint, 0, 1), [INFO] [stderr] 384 | | ]; [INFO] [stderr] | |__- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/message/option/mod.rs:315:21 [INFO] [stderr] | [INFO] [stderr] 315 | n = n >> 8; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `n >>= 8` [INFO] [stderr] ... [INFO] [stderr] 366 | / options![ [INFO] [stderr] 367 | | (1, IfMatch, opaque, 0, 8), [INFO] [stderr] 368 | | (3, UriHost, string, 1, 8), [INFO] [stderr] 369 | | (4, ETag, opaque, 0, 8), [INFO] [stderr] ... | [INFO] [stderr] 383 | | (284, NoResponse, uint, 0, 1), [INFO] [stderr] 384 | | ]; [INFO] [stderr] | |__- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/message/option/mod.rs:315:21 [INFO] [stderr] | [INFO] [stderr] 315 | n = n >> 8; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `n >>= 8` [INFO] [stderr] ... [INFO] [stderr] 366 | / options![ [INFO] [stderr] 367 | | (1, IfMatch, opaque, 0, 8), [INFO] [stderr] 368 | | (3, UriHost, string, 1, 8), [INFO] [stderr] 369 | | (4, ETag, opaque, 0, 8), [INFO] [stderr] ... | [INFO] [stderr] 383 | | (284, NoResponse, uint, 0, 1), [INFO] [stderr] 384 | | ]; [INFO] [stderr] | |__- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/message/option/mod.rs:315:21 [INFO] [stderr] | [INFO] [stderr] 315 | n = n >> 8; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `n >>= 8` [INFO] [stderr] ... [INFO] [stderr] 366 | / options![ [INFO] [stderr] 367 | | (1, IfMatch, opaque, 0, 8), [INFO] [stderr] 368 | | (3, UriHost, string, 1, 8), [INFO] [stderr] 369 | | (4, ETag, opaque, 0, 8), [INFO] [stderr] ... | [INFO] [stderr] 383 | | (284, NoResponse, uint, 0, 1), [INFO] [stderr] 384 | | ]; [INFO] [stderr] | |__- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/message/option/mod.rs:315:21 [INFO] [stderr] | [INFO] [stderr] 315 | n = n >> 8; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `n >>= 8` [INFO] [stderr] ... [INFO] [stderr] 366 | / options![ [INFO] [stderr] 367 | | (1, IfMatch, opaque, 0, 8), [INFO] [stderr] 368 | | (3, UriHost, string, 1, 8), [INFO] [stderr] 369 | | (4, ETag, opaque, 0, 8), [INFO] [stderr] ... | [INFO] [stderr] 383 | | (284, NoResponse, uint, 0, 1), [INFO] [stderr] 384 | | ]; [INFO] [stderr] | |__- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/message/option/mod.rs:315:21 [INFO] [stderr] | [INFO] [stderr] 315 | n = n >> 8; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `n >>= 8` [INFO] [stderr] ... [INFO] [stderr] 366 | / options![ [INFO] [stderr] 367 | | (1, IfMatch, opaque, 0, 8), [INFO] [stderr] 368 | | (3, UriHost, string, 1, 8), [INFO] [stderr] 369 | | (4, ETag, opaque, 0, 8), [INFO] [stderr] ... | [INFO] [stderr] 383 | | (284, NoResponse, uint, 0, 1), [INFO] [stderr] 384 | | ]; [INFO] [stderr] | |__- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/message/option/mod.rs:315:21 [INFO] [stderr] | [INFO] [stderr] 315 | n = n >> 8; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `n >>= 8` [INFO] [stderr] ... [INFO] [stderr] 366 | / options![ [INFO] [stderr] 367 | | (1, IfMatch, opaque, 0, 8), [INFO] [stderr] 368 | | (3, UriHost, string, 1, 8), [INFO] [stderr] 369 | | (4, ETag, opaque, 0, 8), [INFO] [stderr] ... | [INFO] [stderr] 383 | | (284, NoResponse, uint, 0, 1), [INFO] [stderr] 384 | | ]; [INFO] [stderr] | |__- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `message::Message` [INFO] [stderr] --> src/message/mod.rs:167:5 [INFO] [stderr] | [INFO] [stderr] 167 | / pub fn new() -> Self { [INFO] [stderr] 168 | | Message { [INFO] [stderr] 169 | | version: 1, [INFO] [stderr] 170 | | mtype: Mtype::Confirmable, [INFO] [stderr] ... | [INFO] [stderr] 177 | | } [INFO] [stderr] 178 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 166 | impl Default for message::Message { [INFO] [stderr] 167 | fn default() -> Self { [INFO] [stderr] 168 | Self::new() [INFO] [stderr] 169 | } [INFO] [stderr] 170 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/message/mod.rs:210:29 [INFO] [stderr] | [INFO] [stderr] 210 | .or_insert_with(|| Vec::new()) [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove closure as shown: `Vec::new` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/message/option/mod.rs:315:21 [INFO] [stderr] | [INFO] [stderr] 315 | n = n >> 8; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `n >>= 8` [INFO] [stderr] ... [INFO] [stderr] 366 | / options![ [INFO] [stderr] 367 | | (1, IfMatch, opaque, 0, 8), [INFO] [stderr] 368 | | (3, UriHost, string, 1, 8), [INFO] [stderr] 369 | | (4, ETag, opaque, 0, 8), [INFO] [stderr] ... | [INFO] [stderr] 383 | | (284, NoResponse, uint, 0, 1), [INFO] [stderr] 384 | | ]; [INFO] [stderr] | |__- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/message/mod.rs:231:20 [INFO] [stderr] | [INFO] [stderr] 231 | let mid = ((pkt[2] as u16) << 8) | pkt[3] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(pkt[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/message/mod.rs:231:44 [INFO] [stderr] | [INFO] [stderr] 231 | let mid = ((pkt[2] as u16) << 8) | pkt[3] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(pkt[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/message/mod.rs:252:31 [INFO] [stderr] | [INFO] [stderr] 252 | d @ 0...12 => d as u16, [INFO] [stderr] | ^^^^^^^^ help: try: `u16::from(d)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/message/mod.rs:255:21 [INFO] [stderr] | [INFO] [stderr] 255 | pkt[i] as u16 + 13 [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(pkt[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/message/mod.rs:259:23 [INFO] [stderr] | [INFO] [stderr] 259 | (((pkt[i - 1] as u16) << 8) | pkt[i] as u16) + 269 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(pkt[i - 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/message/mod.rs:259:51 [INFO] [stderr] | [INFO] [stderr] 259 | (((pkt[i - 1] as u16) << 8) | pkt[i] as u16) + 269 [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(pkt[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/message/mod.rs:265:31 [INFO] [stderr] | [INFO] [stderr] 265 | d @ 0...12 => d as u16, [INFO] [stderr] | ^^^^^^^^ help: try: `u16::from(d)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/message/mod.rs:268:21 [INFO] [stderr] | [INFO] [stderr] 268 | pkt[i] as u16 + 13 [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(pkt[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/message/mod.rs:272:22 [INFO] [stderr] | [INFO] [stderr] 272 | ((pkt[i - 1] as u16) << 8) | pkt[i] as u16 + 269 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(pkt[i - 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/message/mod.rs:272:50 [INFO] [stderr] | [INFO] [stderr] 272 | ((pkt[i - 1] as u16) << 8) | pkt[i] as u16 + 269 [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(pkt[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/message/mod.rs:347:12 [INFO] [stderr] | [INFO] [stderr] 347 | if self.payload.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.payload.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/message/option/mod.rs:315:21 [INFO] [stderr] | [INFO] [stderr] 315 | n = n >> 8; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `n >>= 8` [INFO] [stderr] ... [INFO] [stderr] 366 | / options![ [INFO] [stderr] 367 | | (1, IfMatch, opaque, 0, 8), [INFO] [stderr] 368 | | (3, UriHost, string, 1, 8), [INFO] [stderr] 369 | | (4, ETag, opaque, 0, 8), [INFO] [stderr] ... | [INFO] [stderr] 383 | | (284, NoResponse, uint, 0, 1), [INFO] [stderr] 384 | | ]; [INFO] [stderr] | |__- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/message/option/mod.rs:315:21 [INFO] [stderr] | [INFO] [stderr] 315 | n = n >> 8; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `n >>= 8` [INFO] [stderr] ... [INFO] [stderr] 366 | / options![ [INFO] [stderr] 367 | | (1, IfMatch, opaque, 0, 8), [INFO] [stderr] 368 | | (3, UriHost, string, 1, 8), [INFO] [stderr] 369 | | (4, ETag, opaque, 0, 8), [INFO] [stderr] ... | [INFO] [stderr] 383 | | (284, NoResponse, uint, 0, 1), [INFO] [stderr] 384 | | ]; [INFO] [stderr] | |__- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `message::Message` [INFO] [stderr] --> src/message/mod.rs:167:5 [INFO] [stderr] | [INFO] [stderr] 167 | / pub fn new() -> Self { [INFO] [stderr] 168 | | Message { [INFO] [stderr] 169 | | version: 1, [INFO] [stderr] 170 | | mtype: Mtype::Confirmable, [INFO] [stderr] ... | [INFO] [stderr] 177 | | } [INFO] [stderr] 178 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 166 | impl Default for message::Message { [INFO] [stderr] 167 | fn default() -> Self { [INFO] [stderr] 168 | Self::new() [INFO] [stderr] 169 | } [INFO] [stderr] 170 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/message/mod.rs:210:29 [INFO] [stderr] | [INFO] [stderr] 210 | .or_insert_with(|| Vec::new()) [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove closure as shown: `Vec::new` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/message/mod.rs:231:20 [INFO] [stderr] | [INFO] [stderr] 231 | let mid = ((pkt[2] as u16) << 8) | pkt[3] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(pkt[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/message/mod.rs:231:44 [INFO] [stderr] | [INFO] [stderr] 231 | let mid = ((pkt[2] as u16) << 8) | pkt[3] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(pkt[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/message/mod.rs:252:31 [INFO] [stderr] | [INFO] [stderr] 252 | d @ 0...12 => d as u16, [INFO] [stderr] | ^^^^^^^^ help: try: `u16::from(d)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/message/mod.rs:255:21 [INFO] [stderr] | [INFO] [stderr] 255 | pkt[i] as u16 + 13 [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(pkt[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/message/mod.rs:259:23 [INFO] [stderr] | [INFO] [stderr] 259 | (((pkt[i - 1] as u16) << 8) | pkt[i] as u16) + 269 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(pkt[i - 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/message/mod.rs:259:51 [INFO] [stderr] | [INFO] [stderr] 259 | (((pkt[i - 1] as u16) << 8) | pkt[i] as u16) + 269 [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(pkt[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/message/mod.rs:265:31 [INFO] [stderr] | [INFO] [stderr] 265 | d @ 0...12 => d as u16, [INFO] [stderr] | ^^^^^^^^ help: try: `u16::from(d)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/message/mod.rs:268:21 [INFO] [stderr] | [INFO] [stderr] 268 | pkt[i] as u16 + 13 [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(pkt[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/message/mod.rs:272:22 [INFO] [stderr] | [INFO] [stderr] 272 | ((pkt[i - 1] as u16) << 8) | pkt[i] as u16 + 269 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(pkt[i - 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/message/mod.rs:272:50 [INFO] [stderr] | [INFO] [stderr] 272 | ((pkt[i - 1] as u16) << 8) | pkt[i] as u16 + 269 [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(pkt[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/message/mod.rs:347:12 [INFO] [stderr] | [INFO] [stderr] 347 | if self.payload.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.payload.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/message/mod.rs:369:13 [INFO] [stderr] | [INFO] [stderr] 369 | assert!(msg.token.len() == 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `msg.token.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/message/mod.rs:371:13 [INFO] [stderr] | [INFO] [stderr] 371 | assert!(msg.payload.len() == 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `msg.payload.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/message/mod.rs:406:13 [INFO] [stderr] | [INFO] [stderr] 406 | assert!(msg.payload.len() == 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `msg.payload.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/message/mod.rs:449:13 [INFO] [stderr] | [INFO] [stderr] 449 | assert!(msg.token.len() == 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `msg.token.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/message.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `tokio-coap`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "55f61fa68d774da4f356f212e1d41662d455665a72204916dfb762085a373edd"` [INFO] running `"docker" "rm" "-f" "55f61fa68d774da4f356f212e1d41662d455665a72204916dfb762085a373edd"` [INFO] [stdout] 55f61fa68d774da4f356f212e1d41662d455665a72204916dfb762085a373edd