[INFO] crate tokio-bits 0.1.2 is already in cache [INFO] extracting crate tokio-bits 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/tokio-bits/0.1.2 [INFO] extracting crate tokio-bits 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tokio-bits/0.1.2 [INFO] validating manifest of tokio-bits-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tokio-bits-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tokio-bits-0.1.2 [INFO] finished frobbing tokio-bits-0.1.2 [INFO] frobbed toml for tokio-bits-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/tokio-bits/0.1.2/Cargo.toml [INFO] started frobbing tokio-bits-0.1.2 [INFO] finished frobbing tokio-bits-0.1.2 [INFO] frobbed toml for tokio-bits-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tokio-bits/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tokio-bits-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/tokio-bits/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 64b533c02768a551dea55ed99ea911eeab0b00ee43fb4a2e88bbb128828de187 [INFO] running `"docker" "start" "-a" "64b533c02768a551dea55ed99ea911eeab0b00ee43fb4a2e88bbb128828de187"` [INFO] [stderr] Checking tokio-bits v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stream/range.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | end: end, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stream/tube.rs:50:17 [INFO] [stderr] | [INFO] [stderr] 50 | timeout: timeout, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `timeout` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stream/range.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | end: end, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stream/tube.rs:50:17 [INFO] [stderr] | [INFO] [stderr] 50 | timeout: timeout, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `timeout` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ops/inc.rs:26:73 [INFO] [stderr] | [INFO] [stderr] 26 | ($($m:ty),*) => {$( impl Incrementable for $m { fn one() -> Self { 1 as $m } })*} [INFO] [stderr] | ^ help: try: `f64::from(1)` [INFO] [stderr] 27 | } [INFO] [stderr] 28 | impl_Incrementable!{u8, u16, u32, u64, i8, i16, i32, i64, f32, f64} [INFO] [stderr] | ------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/stream/tube.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | let _ = try_ready!(self.inner.borrow_mut().timeout.poll()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ops/inc.rs:26:73 [INFO] [stderr] | [INFO] [stderr] 26 | ($($m:ty),*) => {$( impl Incrementable for $m { fn one() -> Self { 1 as $m } })*} [INFO] [stderr] | ^ help: try: `f64::from(1)` [INFO] [stderr] 27 | } [INFO] [stderr] 28 | impl_Incrementable!{u8, u16, u32, u64, i8, i16, i32, i64, f32, f64} [INFO] [stderr] | ------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/stream/tube.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | let _ = try_ready!(self.inner.borrow_mut().timeout.poll()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | work [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:44:24 [INFO] [stderr] | [INFO] [stderr] 44 | let work = client [INFO] [stderr] | ________________________^ [INFO] [stderr] 45 | | .get(uri) [INFO] [stderr] 46 | | .map(move |res| { [INFO] [stderr] 47 | | println!("Response Status: {}", res.status()); [INFO] [stderr] 48 | | x [INFO] [stderr] 49 | | }) [INFO] [stderr] 50 | | .map_err(|_| Err(1)); [INFO] [stderr] | |____________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | work [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:44:24 [INFO] [stderr] | [INFO] [stderr] 44 | let work = client [INFO] [stderr] | ________________________^ [INFO] [stderr] 45 | | .get(uri) [INFO] [stderr] 46 | | .map(move |res| { [INFO] [stderr] 47 | | println!("Response Status: {}", res.status()); [INFO] [stderr] 48 | | x [INFO] [stderr] 49 | | }) [INFO] [stderr] 50 | | .map_err(|_| Err(1)); [INFO] [stderr] | |____________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.07s [INFO] running `"docker" "inspect" "64b533c02768a551dea55ed99ea911eeab0b00ee43fb4a2e88bbb128828de187"` [INFO] running `"docker" "rm" "-f" "64b533c02768a551dea55ed99ea911eeab0b00ee43fb4a2e88bbb128828de187"` [INFO] [stdout] 64b533c02768a551dea55ed99ea911eeab0b00ee43fb4a2e88bbb128828de187