[INFO] crate tokei 8.0.1 is already in cache [INFO] extracting crate tokei 8.0.1 into work/ex/clippy-test-run/sources/stable/reg/tokei/8.0.1 [INFO] extracting crate tokei 8.0.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tokei/8.0.1 [INFO] validating manifest of tokei-8.0.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tokei-8.0.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tokei-8.0.1 [INFO] finished frobbing tokei-8.0.1 [INFO] frobbed toml for tokei-8.0.1 written to work/ex/clippy-test-run/sources/stable/reg/tokei/8.0.1/Cargo.toml [INFO] started frobbing tokei-8.0.1 [INFO] finished frobbing tokei-8.0.1 [INFO] frobbed toml for tokei-8.0.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tokei/8.0.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tokei-8.0.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/tokei/8.0.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fdb53ba9ae818ef5fe22d84a738d45378e51605b7edadcf819e341350e61de33 [INFO] running `"docker" "start" "-a" "fdb53ba9ae818ef5fe22d84a738d45378e51605b7edadcf819e341350e61de33"` [INFO] [stderr] Compiling pest v2.1.0 [INFO] [stderr] Checking term_size v0.3.1 [INFO] [stderr] Compiling crossbeam-channel v0.3.7 [INFO] [stderr] Checking encoding_rs_io v0.1.4 [INFO] [stderr] Compiling globset v0.4.2 [INFO] [stderr] Checking ignore v0.4.6 [INFO] [stderr] Compiling pest_meta v2.1.0 [INFO] [stderr] Compiling pest_generator v2.1.0 [INFO] [stderr] Compiling pest_derive v2.1.0 [INFO] [stderr] Compiling handlebars v1.1.0 [INFO] [stderr] Compiling tokei v8.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/utils/fs.rs:88:29 [INFO] [stderr] | [INFO] [stderr] 88 | .or_insert_with(|| Language::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Language::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 37 [INFO] [stderr] --> /opt/crater/target/debug/build/tokei-e22321359313d832/out/language_type.rs:4882:5 [INFO] [stderr] | [INFO] [stderr] 4882 | / fn parse_lines<'a>(self, [INFO] [stderr] 4883 | | lines: impl IntoIterator, [INFO] [stderr] 4884 | | mut stats: Stats) [INFO] [stderr] 4885 | | -> Stats [INFO] [stderr] ... | [INFO] [stderr] 5029 | | stats [INFO] [stderr] 5030 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> /opt/crater/target/debug/build/tokei-e22321359313d832/out/language_type.rs:5010:24 [INFO] [stderr] | [INFO] [stderr] 5010 | .chain(comments.line_comments.iter().map(|s| *s)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `comments.line_comments.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/utils/fs.rs:88:29 [INFO] [stderr] | [INFO] [stderr] 88 | .or_insert_with(|| Language::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Language::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 37 [INFO] [stderr] --> /opt/crater/target/debug/build/tokei-e22321359313d832/out/language_type.rs:4882:5 [INFO] [stderr] | [INFO] [stderr] 4882 | / fn parse_lines<'a>(self, [INFO] [stderr] 4883 | | lines: impl IntoIterator, [INFO] [stderr] 4884 | | mut stats: Stats) [INFO] [stderr] 4885 | | -> Stats [INFO] [stderr] ... | [INFO] [stderr] 5029 | | stats [INFO] [stderr] 5030 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> /opt/crater/target/debug/build/tokei-e22321359313d832/out/language_type.rs:5010:24 [INFO] [stderr] | [INFO] [stderr] 5010 | .chain(comments.line_comments.iter().map(|s| *s)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `comments.line_comments.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:181:17 [INFO] [stderr] | [INFO] [stderr] 181 | e.split(",") [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:181:17 [INFO] [stderr] | [INFO] [stderr] 181 | e.split(",") [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 35.77s [INFO] running `"docker" "inspect" "fdb53ba9ae818ef5fe22d84a738d45378e51605b7edadcf819e341350e61de33"` [INFO] running `"docker" "rm" "-f" "fdb53ba9ae818ef5fe22d84a738d45378e51605b7edadcf819e341350e61de33"` [INFO] [stdout] fdb53ba9ae818ef5fe22d84a738d45378e51605b7edadcf819e341350e61de33