[INFO] crate todoist_rest 0.0.2-dev is already in cache [INFO] extracting crate todoist_rest 0.0.2-dev into work/ex/clippy-test-run/sources/stable/reg/todoist_rest/0.0.2-dev [INFO] extracting crate todoist_rest 0.0.2-dev into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/todoist_rest/0.0.2-dev [INFO] validating manifest of todoist_rest-0.0.2-dev on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of todoist_rest-0.0.2-dev on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing todoist_rest-0.0.2-dev [INFO] finished frobbing todoist_rest-0.0.2-dev [INFO] frobbed toml for todoist_rest-0.0.2-dev written to work/ex/clippy-test-run/sources/stable/reg/todoist_rest/0.0.2-dev/Cargo.toml [INFO] started frobbing todoist_rest-0.0.2-dev [INFO] finished frobbing todoist_rest-0.0.2-dev [INFO] frobbed toml for todoist_rest-0.0.2-dev written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/todoist_rest/0.0.2-dev/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting todoist_rest-0.0.2-dev against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/todoist_rest/0.0.2-dev:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a8dbe4d469bf51ba99582b7a77520620df95a701ac2e740b642f54919c4d6775 [INFO] running `"docker" "start" "-a" "a8dbe4d469bf51ba99582b7a77520620df95a701ac2e740b642f54919c4d6775"` [INFO] [stderr] Checking todoist_rest v0.0.2-dev (/opt/crater/workdir) [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/model/task.rs:118:9 [INFO] [stderr] | [INFO] [stderr] 118 | / match &self.due { [INFO] [stderr] 119 | | &Some(ref due) => { [INFO] [stderr] 120 | | state.serialize_field("due_string", &due.string)?; [INFO] [stderr] 121 | | state.serialize_field("due_date", &due.date)?; [INFO] [stderr] ... | [INFO] [stderr] 130 | | } [INFO] [stderr] 131 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 118 | match self.due { [INFO] [stderr] 119 | Some(ref due) => { [INFO] [stderr] 120 | state.serialize_field("due_string", &due.string)?; [INFO] [stderr] 121 | state.serialize_field("due_date", &due.date)?; [INFO] [stderr] 122 | state.serialize_field("due_datetime", &due.datetime)?; [INFO] [stderr] 123 | state.serialize_field("due_lang", "en")?; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/model/task.rs:118:9 [INFO] [stderr] | [INFO] [stderr] 118 | / match &self.due { [INFO] [stderr] 119 | | &Some(ref due) => { [INFO] [stderr] 120 | | state.serialize_field("due_string", &due.string)?; [INFO] [stderr] 121 | | state.serialize_field("due_date", &due.date)?; [INFO] [stderr] ... | [INFO] [stderr] 130 | | } [INFO] [stderr] 131 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 118 | match self.due { [INFO] [stderr] 119 | Some(ref due) => { [INFO] [stderr] 120 | state.serialize_field("due_string", &due.string)?; [INFO] [stderr] 121 | state.serialize_field("due_date", &due.date)?; [INFO] [stderr] 122 | state.serialize_field("due_datetime", &due.datetime)?; [INFO] [stderr] 123 | state.serialize_field("due_lang", "en")?; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.32s [INFO] running `"docker" "inspect" "a8dbe4d469bf51ba99582b7a77520620df95a701ac2e740b642f54919c4d6775"` [INFO] running `"docker" "rm" "-f" "a8dbe4d469bf51ba99582b7a77520620df95a701ac2e740b642f54919c4d6775"` [INFO] [stdout] a8dbe4d469bf51ba99582b7a77520620df95a701ac2e740b642f54919c4d6775