[INFO] crate todoist-rs 0.1.0 is already in cache [INFO] extracting crate todoist-rs 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/todoist-rs/0.1.0 [INFO] extracting crate todoist-rs 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/todoist-rs/0.1.0 [INFO] validating manifest of todoist-rs-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of todoist-rs-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing todoist-rs-0.1.0 [INFO] finished frobbing todoist-rs-0.1.0 [INFO] frobbed toml for todoist-rs-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/todoist-rs/0.1.0/Cargo.toml [INFO] started frobbing todoist-rs-0.1.0 [INFO] finished frobbing todoist-rs-0.1.0 [INFO] frobbed toml for todoist-rs-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/todoist-rs/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting todoist-rs-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/todoist-rs/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] dadcfa172ee11f0ece30a56a7a384bb75d6240744893b12fd9c1dffdd23f6129 [INFO] running `"docker" "start" "-a" "dadcfa172ee11f0ece30a56a7a384bb75d6240744893b12fd9c1dffdd23f6129"` [INFO] [stderr] Checking erased-serde v0.3.8 [INFO] [stderr] Checking uuid v0.6.5 [INFO] [stderr] Checking reqwest v0.8.8 [INFO] [stderr] Checking todoist-rs v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `serde` [INFO] [stderr] --> src/resource/item.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use serde; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fmt` [INFO] [stderr] --> src/resource/item.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use std::fmt; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Deserialize`, `Deserializer`, `Serialize`, `Serializer` [INFO] [stderr] --> src/resource/item.rs:8:13 [INFO] [stderr] | [INFO] [stderr] 8 | use serde::{Serialize, Deserialize, Serializer, Deserializer}; [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^^^ ^^^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `serde::ser::SerializeSeq` [INFO] [stderr] --> src/resource/item.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | use serde::ser::SerializeSeq; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fmt` [INFO] [stderr] --> src/resource/label.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::fmt; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fmt` [INFO] [stderr] --> src/resource/filter.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::fmt; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Deserialize`, `Deserializer`, `Serialize`, `Serializer` [INFO] [stderr] --> src/resource/filter.rs:6:13 [INFO] [stderr] | [INFO] [stderr] 6 | use serde::{Serialize, Deserialize, Serializer, Deserializer}; [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^^^ ^^^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `serde::ser::SerializeSeq` [INFO] [stderr] --> src/resource/filter.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use serde::ser::SerializeSeq; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/types/date.rs:9:17 [INFO] [stderr] | [INFO] [stderr] 9 | const FORMAT : &'static str = "%a %d %b %Y %X %z"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unused import: `super::*` [INFO] [stderr] --> src/tests.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use super::*; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `command::Create` [INFO] [stderr] --> src/tests.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use command::Create; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `serde` [INFO] [stderr] --> src/resource/item.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use serde; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fmt` [INFO] [stderr] --> src/resource/item.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use std::fmt; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Deserialize`, `Deserializer`, `Serialize`, `Serializer` [INFO] [stderr] --> src/resource/item.rs:8:13 [INFO] [stderr] | [INFO] [stderr] 8 | use serde::{Serialize, Deserialize, Serializer, Deserializer}; [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^^^ ^^^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `serde::ser::SerializeSeq` [INFO] [stderr] --> src/resource/item.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | use serde::ser::SerializeSeq; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fmt` [INFO] [stderr] --> src/resource/label.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::fmt; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fmt` [INFO] [stderr] --> src/resource/filter.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::fmt; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Deserialize`, `Deserializer`, `Serialize`, `Serializer` [INFO] [stderr] --> src/resource/filter.rs:6:13 [INFO] [stderr] | [INFO] [stderr] 6 | use serde::{Serialize, Deserialize, Serializer, Deserializer}; [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^^^ ^^^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `serde::ser::SerializeSeq` [INFO] [stderr] --> src/resource/filter.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use serde::ser::SerializeSeq; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/types/date.rs:9:17 [INFO] [stderr] | [INFO] [stderr] 9 | const FORMAT : &'static str = "%a %d %b %Y %X %z"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: method is never used: `project` [INFO] [stderr] --> src/resource/note.rs:99:5 [INFO] [stderr] | [INFO] [stderr] 99 | fn project(self) -> ProjectNote { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `project` [INFO] [stderr] --> src/resource/note.rs:99:5 [INFO] [stderr] | [INFO] [stderr] 99 | fn project(self) -> ProjectNote { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/resource/note.rs:122:48 [INFO] [stderr] | [INFO] [stderr] 122 | x.link = value.next_element()?.unwrap_or("".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/types/intbool.rs:16:17 [INFO] [stderr] | [INFO] [stderr] 16 | IntBool(match v { [INFO] [stderr] | _________________^ [INFO] [stderr] 17 | | true => 1, [INFO] [stderr] 18 | | false => 0, [INFO] [stderr] 19 | | }) [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if v { 1 } else { 0 }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/types/intbool.rs:80:9 [INFO] [stderr] | [INFO] [stderr] 80 | / if self.0 == 0 { [INFO] [stderr] 81 | | true [INFO] [stderr] 82 | | } else { [INFO] [stderr] 83 | | false [INFO] [stderr] 84 | | } [INFO] [stderr] | |_________^ help: you can reduce it to: `self.0 == 0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/types/error.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | / match self { [INFO] [stderr] 29 | | &Error::Request(ref e) => write!(f, "{}", e), [INFO] [stderr] 30 | | &Error::Serialize(ref e) => write!(f, "{}", e), [INFO] [stderr] 31 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 28 | match *self { [INFO] [stderr] 29 | Error::Request(ref e) => write!(f, "{}", e), [INFO] [stderr] 30 | Error::Serialize(ref e) => write!(f, "{}", e), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/types/error.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | / match self { [INFO] [stderr] 38 | | &Error::Request(_) => "request failed", [INFO] [stderr] 39 | | &Error::Serialize(_) => "invalid json", [INFO] [stderr] 40 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 37 | match *self { [INFO] [stderr] 38 | Error::Request(_) => "request failed", [INFO] [stderr] 39 | Error::Serialize(_) => "invalid json", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/lib.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | LiveNotification(resource::LiveNotification), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 27 | LiveNotification(Box), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/resource/note.rs:122:48 [INFO] [stderr] | [INFO] [stderr] 122 | x.link = value.next_element()?.unwrap_or("".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/types/intbool.rs:16:17 [INFO] [stderr] | [INFO] [stderr] 16 | IntBool(match v { [INFO] [stderr] | _________________^ [INFO] [stderr] 17 | | true => 1, [INFO] [stderr] 18 | | false => 0, [INFO] [stderr] 19 | | }) [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if v { 1 } else { 0 }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/types/intbool.rs:80:9 [INFO] [stderr] | [INFO] [stderr] 80 | / if self.0 == 0 { [INFO] [stderr] 81 | | true [INFO] [stderr] 82 | | } else { [INFO] [stderr] 83 | | false [INFO] [stderr] 84 | | } [INFO] [stderr] | |_________^ help: you can reduce it to: `self.0 == 0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/types/error.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | / match self { [INFO] [stderr] 29 | | &Error::Request(ref e) => write!(f, "{}", e), [INFO] [stderr] 30 | | &Error::Serialize(ref e) => write!(f, "{}", e), [INFO] [stderr] 31 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 28 | match *self { [INFO] [stderr] 29 | Error::Request(ref e) => write!(f, "{}", e), [INFO] [stderr] 30 | Error::Serialize(ref e) => write!(f, "{}", e), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/types/error.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | / match self { [INFO] [stderr] 38 | | &Error::Request(_) => "request failed", [INFO] [stderr] 39 | | &Error::Serialize(_) => "invalid json", [INFO] [stderr] 40 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 37 | match *self { [INFO] [stderr] 38 | Error::Request(_) => "request failed", [INFO] [stderr] 39 | Error::Serialize(_) => "invalid json", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/lib.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | LiveNotification(resource::LiveNotification), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 27 | LiveNotification(Box), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 19.90s [INFO] running `"docker" "inspect" "dadcfa172ee11f0ece30a56a7a384bb75d6240744893b12fd9c1dffdd23f6129"` [INFO] running `"docker" "rm" "-f" "dadcfa172ee11f0ece30a56a7a384bb75d6240744893b12fd9c1dffdd23f6129"` [INFO] [stdout] dadcfa172ee11f0ece30a56a7a384bb75d6240744893b12fd9c1dffdd23f6129