[INFO] crate tobytcp 0.11.0 is already in cache [INFO] extracting crate tobytcp 0.11.0 into work/ex/clippy-test-run/sources/stable/reg/tobytcp/0.11.0 [INFO] extracting crate tobytcp 0.11.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tobytcp/0.11.0 [INFO] validating manifest of tobytcp-0.11.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tobytcp-0.11.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tobytcp-0.11.0 [INFO] finished frobbing tobytcp-0.11.0 [INFO] frobbed toml for tobytcp-0.11.0 written to work/ex/clippy-test-run/sources/stable/reg/tobytcp/0.11.0/Cargo.toml [INFO] started frobbing tobytcp-0.11.0 [INFO] finished frobbing tobytcp-0.11.0 [INFO] frobbed toml for tobytcp-0.11.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tobytcp/0.11.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tobytcp-0.11.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/tobytcp/0.11.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b5598e3ee51b90d630b01cb51e92625fc1893201fdd5363465eac701d37e921b [INFO] running `"docker" "start" "-a" "b5598e3ee51b90d630b01cb51e92625fc1893201fdd5363465eac701d37e921b"` [INFO] [stderr] Checking tobytcp v0.11.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:153:13 [INFO] [stderr] | [INFO] [stderr] 153 | tcp_stream: tcp_stream, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tcp_stream` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:153:13 [INFO] [stderr] | [INFO] [stderr] 153 | tcp_stream: tcp_stream, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tcp_stream` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:409:39 [INFO] [stderr] | [INFO] [stderr] 409 | let mut data_main = vec![0u8; 113530]; [INFO] [stderr] | ^^^^^^ help: consider: `113_530` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:449:28 [INFO] [stderr] | [INFO] [stderr] 449 | assert_eq!(113530, received.len()); [INFO] [stderr] | ^^^^^^ help: consider: `113_530` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/protocol.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | num = num >> 8; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `num >>= 8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/lib.rs:225:5 [INFO] [stderr] | [INFO] [stderr] 225 | / if curr_size.is_none() { [INFO] [stderr] 226 | | if buf.len() >= 8 { [INFO] [stderr] 227 | | let size = Some(bytes_to(&buf[0..8])); [INFO] [stderr] 228 | | buf.drain(0..8); [INFO] [stderr] ... | [INFO] [stderr] 233 | | curr_size [INFO] [stderr] 234 | | } [INFO] [stderr] | |_____^ help: replace_it_with: `curr_size?;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::question_mark)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:242:9 [INFO] [stderr] | [INFO] [stderr] 242 | ret = ret | *byte as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ret |= *byte as u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:242:21 [INFO] [stderr] | [INFO] [stderr] 242 | ret = ret | *byte as u64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(*byte)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:244:13 [INFO] [stderr] | [INFO] [stderr] 244 | ret = ret << 8; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `ret <<= 8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:246:9 [INFO] [stderr] | [INFO] [stderr] 246 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/protocol.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | num = num >> 8; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `num >>= 8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/lib.rs:225:5 [INFO] [stderr] | [INFO] [stderr] 225 | / if curr_size.is_none() { [INFO] [stderr] 226 | | if buf.len() >= 8 { [INFO] [stderr] 227 | | let size = Some(bytes_to(&buf[0..8])); [INFO] [stderr] 228 | | buf.drain(0..8); [INFO] [stderr] ... | [INFO] [stderr] 233 | | curr_size [INFO] [stderr] 234 | | } [INFO] [stderr] | |_____^ help: replace_it_with: `curr_size?;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::question_mark)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:242:9 [INFO] [stderr] | [INFO] [stderr] 242 | ret = ret | *byte as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ret |= *byte as u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:242:21 [INFO] [stderr] | [INFO] [stderr] 242 | ret = ret | *byte as u64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(*byte)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:244:13 [INFO] [stderr] | [INFO] [stderr] 244 | ret = ret << 8; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `ret <<= 8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:246:9 [INFO] [stderr] | [INFO] [stderr] 246 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `data_main`. [INFO] [stderr] --> src/lib.rs:411:18 [INFO] [stderr] | [INFO] [stderr] 411 | for i in 0..1153 { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 411 | for in data_main.iter_mut().take(1153) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.30s [INFO] running `"docker" "inspect" "b5598e3ee51b90d630b01cb51e92625fc1893201fdd5363465eac701d37e921b"` [INFO] running `"docker" "rm" "-f" "b5598e3ee51b90d630b01cb51e92625fc1893201fdd5363465eac701d37e921b"` [INFO] [stdout] b5598e3ee51b90d630b01cb51e92625fc1893201fdd5363465eac701d37e921b