[INFO] crate to-directory 0.1.0 is already in cache
[INFO] extracting crate to-directory 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/to-directory/0.1.0
[INFO] extracting crate to-directory 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/to-directory/0.1.0
[INFO] validating manifest of to-directory-0.1.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of to-directory-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing to-directory-0.1.0
[INFO] finished frobbing to-directory-0.1.0
[INFO] frobbed toml for to-directory-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/to-directory/0.1.0/Cargo.toml
[INFO] started frobbing to-directory-0.1.0
[INFO] finished frobbing to-directory-0.1.0
[INFO] frobbed toml for to-directory-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/to-directory/0.1.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting to-directory-0.1.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/to-directory/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] a55ea871b1020d238b61b03619bf9818c7d91ea19ff0562ae94e55a0da0ca34c
[INFO] running `"docker" "start" "-a" "a55ea871b1020d238b61b03619bf9818c7d91ea19ff0562ae94e55a0da0ca34c"`
[INFO] [stderr] warning: An explicit [[bin]] section is specified in Cargo.toml which currently
[INFO] [stderr] disables Cargo from automatically inferring other binary targets.
[INFO] [stderr] This inference behavior will change in the Rust 2018 edition and the following
[INFO] [stderr] files will be included as a binary target:
[INFO] [stderr] 
[INFO] [stderr] * /opt/crater/workdir/src/main.rs
[INFO] [stderr] 
[INFO] [stderr] This is likely to break cargo build or cargo test as these files may not be
[INFO] [stderr] ready to be compiled as a binary target today. You can future-proof yourself
[INFO] [stderr] and disable this warning by adding `autobins = false` to your [package]
[INFO] [stderr] section. You may also move the files to a location where Cargo would not
[INFO] [stderr] automatically infer them to be a target, such as in subfolders.
[INFO] [stderr] 
[INFO] [stderr] For more information on this warning you can consult
[INFO] [stderr] https://github.com/rust-lang/cargo/issues/5330
[INFO] [stderr] warning: path `/opt/crater/workdir/src/main.rs` was erroneously implicitly accepted for binary `to`,
[INFO] [stderr] please set bin.path in Cargo.toml
[INFO] [stderr]     Checking bincode v0.5.9
[INFO] [stderr]     Checking to-directory v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/types.rs:31:13
[INFO] [stderr]    |
[INFO] [stderr] 31 |             name: name,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `name`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/types.rs:32:13
[INFO] [stderr]    |
[INFO] [stderr] 32 |             directory: directory,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `directory`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/database.rs:29:13
[INFO] [stderr]    |
[INFO] [stderr] 29 |             location: location,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `location`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/database.rs:30:13
[INFO] [stderr]    |
[INFO] [stderr] 30 |             bookmarks: bookmarks,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bookmarks`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/cli.rs:132:13
[INFO] [stderr]     |
[INFO] [stderr] 132 |             name: name,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `name`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/cli.rs:133:13
[INFO] [stderr]     |
[INFO] [stderr] 133 |             directory: directory,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `directory`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/cli.rs:134:13
[INFO] [stderr]     |
[INFO] [stderr] 134 |             action: action,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `action`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/types.rs:31:13
[INFO] [stderr]    |
[INFO] [stderr] 31 |             name: name,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `name`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/types.rs:32:13
[INFO] [stderr]    |
[INFO] [stderr] 32 |             directory: directory,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `directory`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/database.rs:29:13
[INFO] [stderr]    |
[INFO] [stderr] 29 |             location: location,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `location`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/database.rs:30:13
[INFO] [stderr]    |
[INFO] [stderr] 30 |             bookmarks: bookmarks,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bookmarks`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/cli.rs:132:13
[INFO] [stderr]     |
[INFO] [stderr] 132 |             name: name,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `name`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/cli.rs:133:13
[INFO] [stderr]     |
[INFO] [stderr] 133 |             directory: directory,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `directory`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/cli.rs:134:13
[INFO] [stderr]     |
[INFO] [stderr] 134 |             action: action,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `action`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::fmt`
[INFO] [stderr]  --> src/types.rs:2:5
[INFO] [stderr]   |
[INFO] [stderr] 2 | use std::fmt;
[INFO] [stderr]   |     ^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/types.rs:30:9
[INFO] [stderr]    |
[INFO] [stderr] 30 | /         return Bookmark {
[INFO] [stderr] 31 | |             name: name,
[INFO] [stderr] 32 | |             directory: directory,
[INFO] [stderr] 33 | |         };
[INFO] [stderr]    | |__________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 30 |         Bookmark {
[INFO] [stderr] 31 |             name: name,
[INFO] [stderr] 32 |             directory: directory,
[INFO] [stderr] 33 |         }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/dir.rs:13:5
[INFO] [stderr]    |
[INFO] [stderr] 13 |     return Ok(directory);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(directory)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/dir.rs:17:5
[INFO] [stderr]    |
[INFO] [stderr] 17 |     return Ok(());
[INFO] [stderr]    |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/database.rs:63:9
[INFO] [stderr]    |
[INFO] [stderr] 63 |         return Ok(db);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(db)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/database.rs:75:26
[INFO] [stderr]    |
[INFO] [stderr] 75 |             Ok(value) => return Ok(value),
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(value)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/database.rs:82:28
[INFO] [stderr]    |
[INFO] [stderr] 82 |             Some(value) => return Ok(value),
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(value)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/database.rs:111:9
[INFO] [stderr]     |
[INFO] [stderr] 111 |         return Ok(());
[INFO] [stderr]     |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/cli.rs:67:5
[INFO] [stderr]    |
[INFO] [stderr] 67 |     return Ok(req);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(req)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/cli.rs:101:25
[INFO] [stderr]     |
[INFO] [stderr] 101 |                 true => return Ok(resolved),
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(resolved)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/cli.rs:119:5
[INFO] [stderr]     |
[INFO] [stderr] 119 |     return Ok(false);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(false)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]  --> src/dir.rs:6:31
[INFO] [stderr]   |
[INFO] [stderr] 6 |     let mut directory = match env::home_dir() {
[INFO] [stderr]   |                               ^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::fmt`
[INFO] [stderr]  --> src/types.rs:2:5
[INFO] [stderr]   |
[INFO] [stderr] 2 | use std::fmt;
[INFO] [stderr]   |     ^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/types.rs:30:9
[INFO] [stderr]    |
[INFO] [stderr] 30 | /         return Bookmark {
[INFO] [stderr] 31 | |             name: name,
[INFO] [stderr] 32 | |             directory: directory,
[INFO] [stderr] 33 | |         };
[INFO] [stderr]    | |__________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 30 |         Bookmark {
[INFO] [stderr] 31 |             name: name,
[INFO] [stderr] 32 |             directory: directory,
[INFO] [stderr] 33 |         }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/dir.rs:13:5
[INFO] [stderr]    |
[INFO] [stderr] 13 |     return Ok(directory);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(directory)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/dir.rs:17:5
[INFO] [stderr]    |
[INFO] [stderr] 17 |     return Ok(());
[INFO] [stderr]    |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/database.rs:63:9
[INFO] [stderr]    |
[INFO] [stderr] 63 |         return Ok(db);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(db)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/database.rs:75:26
[INFO] [stderr]    |
[INFO] [stderr] 75 |             Ok(value) => return Ok(value),
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(value)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/database.rs:82:28
[INFO] [stderr]    |
[INFO] [stderr] 82 |             Some(value) => return Ok(value),
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(value)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/database.rs:111:9
[INFO] [stderr]     |
[INFO] [stderr] 111 |         return Ok(());
[INFO] [stderr]     |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/cli.rs:67:5
[INFO] [stderr]    |
[INFO] [stderr] 67 |     return Ok(req);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(req)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/cli.rs:101:25
[INFO] [stderr]     |
[INFO] [stderr] 101 |                 true => return Ok(resolved),
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(resolved)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/cli.rs:119:5
[INFO] [stderr]     |
[INFO] [stderr] 119 |     return Ok(false);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(false)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]  --> src/dir.rs:6:31
[INFO] [stderr]   |
[INFO] [stderr] 6 |     let mut directory = match env::home_dir() {
[INFO] [stderr]   |                               ^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `directory`
[INFO] [stderr]   --> src/dir.rs:16:15
[INFO] [stderr]    |
[INFO] [stderr] 16 | pub fn mkdirp(directory: &Path) -> ToResult<()> {
[INFO] [stderr]    |               ^^^^^^^^^ help: consider using `_directory` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `extension`
[INFO] [stderr]   --> src/database.rs:37:21
[INFO] [stderr]    |
[INFO] [stderr] 37 |         if let Some(extension) = directory.extension() {
[INFO] [stderr]    |                     ^^^^^^^^^ help: consider using `_extension` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `err`
[INFO] [stderr]   --> src/database.rs:95:17
[INFO] [stderr]    |
[INFO] [stderr] 95 |             Err(err) => {
[INFO] [stderr]    |                 ^^^ help: consider using `_err` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `directory`
[INFO] [stderr]   --> src/dir.rs:16:15
[INFO] [stderr]    |
[INFO] [stderr] 16 | pub fn mkdirp(directory: &Path) -> ToResult<()> {
[INFO] [stderr]    |               ^^^^^^^^^ help: consider using `_directory` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `extension`
[INFO] [stderr]   --> src/database.rs:37:21
[INFO] [stderr]    |
[INFO] [stderr] 37 |         if let Some(extension) = directory.extension() {
[INFO] [stderr]    |                     ^^^^^^^^^ help: consider using `_extension` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `err`
[INFO] [stderr]   --> src/database.rs:95:17
[INFO] [stderr]    |
[INFO] [stderr] 95 |             Err(err) => {
[INFO] [stderr]    |                 ^^^ help: consider using `_err` instead
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/database.rs:45:28
[INFO] [stderr]    |
[INFO] [stderr] 45 |         let mut location = PathBuf::from(directory);
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `PathBuf::from()`: `directory`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]   --> src/database.rs:75:36
[INFO] [stderr]    |
[INFO] [stderr] 75 |             Ok(value) => return Ok(value),
[INFO] [stderr]    |                                    ^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unit_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]    |
[INFO] [stderr] 75 |             Ok(value) => return Ok(()),
[INFO] [stderr]    |                                    ^^
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/cli.rs:60:24
[INFO] [stderr]    |
[INFO] [stderr] 60 |                       .unwrap_or(basedir.unwrap())
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| basedir.unwrap())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/cli.rs:100:13
[INFO] [stderr]     |
[INFO] [stderr] 100 | /             match value {
[INFO] [stderr] 101 | |                 true => return Ok(resolved),
[INFO] [stderr] 102 | |                 false => panic!("TODO: Does not exist error!"),
[INFO] [stderr] 103 | |             }
[INFO] [stderr]     | |_____________^ help: consider using an if/else expression: `if value { return Ok(resolved) } else { panic!("TODO: Does not exist error!") }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/database.rs:45:28
[INFO] [stderr]    |
[INFO] [stderr] 45 |         let mut location = PathBuf::from(directory);
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `PathBuf::from()`: `directory`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]   --> src/database.rs:75:36
[INFO] [stderr]    |
[INFO] [stderr] 75 |             Ok(value) => return Ok(value),
[INFO] [stderr]    |                                    ^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unit_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]    |
[INFO] [stderr] 75 |             Ok(value) => return Ok(()),
[INFO] [stderr]    |                                    ^^
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/cli.rs:60:24
[INFO] [stderr]    |
[INFO] [stderr] 60 |                       .unwrap_or(basedir.unwrap())
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| basedir.unwrap())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/cli.rs:100:13
[INFO] [stderr]     |
[INFO] [stderr] 100 | /             match value {
[INFO] [stderr] 101 | |                 true => return Ok(resolved),
[INFO] [stderr] 102 | |                 false => panic!("TODO: Does not exist error!"),
[INFO] [stderr] 103 | |             }
[INFO] [stderr]     | |_____________^ help: consider using an if/else expression: `if value { return Ok(resolved) } else { panic!("TODO: Does not exist error!") }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 3.01s
[INFO] running `"docker" "inspect" "a55ea871b1020d238b61b03619bf9818c7d91ea19ff0562ae94e55a0da0ca34c"`
[INFO] running `"docker" "rm" "-f" "a55ea871b1020d238b61b03619bf9818c7d91ea19ff0562ae94e55a0da0ca34c"`
[INFO] [stdout] a55ea871b1020d238b61b03619bf9818c7d91ea19ff0562ae94e55a0da0ca34c