[INFO] crate tmux_min_attacher 1.0.0 is already in cache [INFO] extracting crate tmux_min_attacher 1.0.0 into work/ex/clippy-test-run/sources/stable/reg/tmux_min_attacher/1.0.0 [INFO] extracting crate tmux_min_attacher 1.0.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tmux_min_attacher/1.0.0 [INFO] validating manifest of tmux_min_attacher-1.0.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tmux_min_attacher-1.0.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tmux_min_attacher-1.0.0 [INFO] finished frobbing tmux_min_attacher-1.0.0 [INFO] frobbed toml for tmux_min_attacher-1.0.0 written to work/ex/clippy-test-run/sources/stable/reg/tmux_min_attacher/1.0.0/Cargo.toml [INFO] started frobbing tmux_min_attacher-1.0.0 [INFO] finished frobbing tmux_min_attacher-1.0.0 [INFO] frobbed toml for tmux_min_attacher-1.0.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tmux_min_attacher/1.0.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tmux_min_attacher-1.0.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/tmux_min_attacher/1.0.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 35a792f6c8fcf1e0667c245eed7317cb81fb1310acdb4d71c08dc2a33cd62a62 [INFO] running `"docker" "start" "-a" "35a792f6c8fcf1e0667c245eed7317cb81fb1310acdb4d71c08dc2a33cd62a62"` [INFO] [stderr] Checking tmux_min_attacher v1.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:16:17 [INFO] [stderr] | [INFO] [stderr] 16 | const PROGRAM: &'static str = "tmux"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:16:17 [INFO] [stderr] | [INFO] [stderr] 16 | const PROGRAM: &'static str = "tmux"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | / match execvp(&c_program_as_cstring, &args_as_cstring) { [INFO] [stderr] 43 | | Err(e) => { [INFO] [stderr] 44 | | println!("execvp of {:?} failed: {:?}", program, e.description()); [INFO] [stderr] 45 | | } [INFO] [stderr] 46 | | _ => {} [INFO] [stderr] 47 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 42 | if let Err(e) = execvp(&c_program_as_cstring, &args_as_cstring) { [INFO] [stderr] 43 | println!("execvp of {:?} failed: {:?}", program, e.description()); [INFO] [stderr] 44 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:57:90 [INFO] [stderr] | [INFO] [stderr] 57 | let new_path = env::join_paths(["/usr/bin", "/bin", "/usr/local/bin"].iter().map(|p| PathBuf::from(p)).collect::>()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PathBuf::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | / Command::new(PROGRAM).arg("start-server").status().ok() [INFO] [stderr] 64 | | .expect("Could not start tmux server: it exited with an error status."); [INFO] [stderr] | |_______________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:71:26 [INFO] [stderr] | [INFO] [stderr] 71 | let session_output = Command::new(PROGRAM).arg("list-sessions").output().ok() [INFO] [stderr] | __________________________^ [INFO] [stderr] 72 | | .expect("Running list-sessions command exited with an error status"); [INFO] [stderr] | |____________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:74:18 [INFO] [stderr] | [INFO] [stderr] 74 | let output = str::from_utf8(&session_output.stdout).ok() [INFO] [stderr] | __________________^ [INFO] [stderr] 75 | | .expect("Could not read the (expected) utf-8 from tmux"); [INFO] [stderr] | |________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | / match execvp(&c_program_as_cstring, &args_as_cstring) { [INFO] [stderr] 43 | | Err(e) => { [INFO] [stderr] 44 | | println!("execvp of {:?} failed: {:?}", program, e.description()); [INFO] [stderr] 45 | | } [INFO] [stderr] 46 | | _ => {} [INFO] [stderr] 47 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 42 | if let Err(e) = execvp(&c_program_as_cstring, &args_as_cstring) { [INFO] [stderr] 43 | println!("execvp of {:?} failed: {:?}", program, e.description()); [INFO] [stderr] 44 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:57:90 [INFO] [stderr] | [INFO] [stderr] 57 | let new_path = env::join_paths(["/usr/bin", "/bin", "/usr/local/bin"].iter().map(|p| PathBuf::from(p)).collect::>()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PathBuf::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | / Command::new(PROGRAM).arg("start-server").status().ok() [INFO] [stderr] 64 | | .expect("Could not start tmux server: it exited with an error status."); [INFO] [stderr] | |_______________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:71:26 [INFO] [stderr] | [INFO] [stderr] 71 | let session_output = Command::new(PROGRAM).arg("list-sessions").output().ok() [INFO] [stderr] | __________________________^ [INFO] [stderr] 72 | | .expect("Running list-sessions command exited with an error status"); [INFO] [stderr] | |____________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:74:18 [INFO] [stderr] | [INFO] [stderr] 74 | let output = str::from_utf8(&session_output.stdout).ok() [INFO] [stderr] | __________________^ [INFO] [stderr] 75 | | .expect("Could not read the (expected) utf-8 from tmux"); [INFO] [stderr] | |________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:101:5 [INFO] [stderr] | [INFO] [stderr] 101 | / match detached_session_number("oink: 1 windows (created Sat Sep 14 17:11:29 2013) [130x65]") { [INFO] [stderr] 102 | | Some(n) => panic!(format!("Should have returned None, got {}!", n)), [INFO] [stderr] 103 | | None => () [INFO] [stderr] 104 | | } [INFO] [stderr] | |_____^ help: try this: `if let Some(n) = detached_session_number("oink: 1 windows (created Sat Sep 14 17:11:29 2013) [130x65]") { panic!(format!("Should have returned None, got {}!", n)) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:109:5 [INFO] [stderr] | [INFO] [stderr] 109 | / match detached_session_number("1: 1 windows (created Sat Sep 14 17:11:29 2013) [130x65] (attached)") { [INFO] [stderr] 110 | | Some(n) => panic!(format!("Should have returned None, got {}!", n)), [INFO] [stderr] 111 | | None => () [INFO] [stderr] 112 | | } [INFO] [stderr] | |_____^ help: try this: `if let Some(n) = detached_session_number("1: 1 windows (created Sat Sep 14 17:11:29 2013) [130x65] (attached)") { panic!(format!("Should have returned None, got {}!", n)) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.84s [INFO] running `"docker" "inspect" "35a792f6c8fcf1e0667c245eed7317cb81fb1310acdb4d71c08dc2a33cd62a62"` [INFO] running `"docker" "rm" "-f" "35a792f6c8fcf1e0667c245eed7317cb81fb1310acdb4d71c08dc2a33cd62a62"` [INFO] [stdout] 35a792f6c8fcf1e0667c245eed7317cb81fb1310acdb4d71c08dc2a33cd62a62