[INFO] crate tmcl 0.1.0-beta0 is already in cache [INFO] extracting crate tmcl 0.1.0-beta0 into work/ex/clippy-test-run/sources/stable/reg/tmcl/0.1.0-beta0 [INFO] extracting crate tmcl 0.1.0-beta0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tmcl/0.1.0-beta0 [INFO] validating manifest of tmcl-0.1.0-beta0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tmcl-0.1.0-beta0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tmcl-0.1.0-beta0 [INFO] finished frobbing tmcl-0.1.0-beta0 [INFO] frobbed toml for tmcl-0.1.0-beta0 written to work/ex/clippy-test-run/sources/stable/reg/tmcl/0.1.0-beta0/Cargo.toml [INFO] started frobbing tmcl-0.1.0-beta0 [INFO] finished frobbing tmcl-0.1.0-beta0 [INFO] frobbed toml for tmcl-0.1.0-beta0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tmcl/0.1.0-beta0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tmcl-0.1.0-beta0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/tmcl/0.1.0-beta0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4f4e29889031a7601dd14a9d49a1afbc2fa8023ca05105e85b4b09cf4fd93ead [INFO] running `"docker" "start" "-a" "4f4e29889031a7601dd14a9d49a1afbc2fa8023ca05105e85b4b09cf4fd93ead"` [INFO] [stderr] Checking interior_mut v0.1.0 [INFO] [stderr] Checking tmcl v0.1.0-beta0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/instructions.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | / return [ [INFO] [stderr] 66 | | (self.velocity & 0xff) as u8, [INFO] [stderr] 67 | | ((self.velocity >> 8) & 0xff) as u8, [INFO] [stderr] 68 | | ((self.velocity >> 16) & 0xff) as u8, [INFO] [stderr] 69 | | ((self.velocity >> 24) & 0xff) as u8 [INFO] [stderr] 70 | | ] [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 65 | [ [INFO] [stderr] 66 | (self.velocity & 0xff) as u8, [INFO] [stderr] 67 | ((self.velocity >> 8) & 0xff) as u8, [INFO] [stderr] 68 | ((self.velocity >> 16) & 0xff) as u8, [INFO] [stderr] 69 | ((self.velocity >> 24) & 0xff) as u8 [INFO] [stderr] 70 | ] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/instructions.rs:100:9 [INFO] [stderr] | [INFO] [stderr] 100 | / return [ [INFO] [stderr] 101 | | (self.velocity & 0xff) as u8, [INFO] [stderr] 102 | | ((self.velocity >> 8) & 0xff) as u8, [INFO] [stderr] 103 | | ((self.velocity >> 16) & 0xff) as u8, [INFO] [stderr] 104 | | ((self.velocity >> 24) & 0xff) as u8 [INFO] [stderr] 105 | | ] [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 100 | [ [INFO] [stderr] 101 | (self.velocity & 0xff) as u8, [INFO] [stderr] 102 | ((self.velocity >> 8) & 0xff) as u8, [INFO] [stderr] 103 | ((self.velocity >> 16) & 0xff) as u8, [INFO] [stderr] 104 | ((self.velocity >> 24) & 0xff) as u8 [INFO] [stderr] 105 | ] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/instructions.rs:135:9 [INFO] [stderr] | [INFO] [stderr] 135 | return [0, 0, 0, 0] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `[0, 0, 0, 0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/lib.rs:349:40 [INFO] [stderr] | [INFO] [stderr] 349 | fn from_operand(_operand: [u8; 4]) -> () {()} [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/lib.rs:349:47 [INFO] [stderr] | [INFO] [stderr] 349 | fn from_operand(_operand: [u8; 4]) -> () {()} [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/instructions.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | / return [ [INFO] [stderr] 66 | | (self.velocity & 0xff) as u8, [INFO] [stderr] 67 | | ((self.velocity >> 8) & 0xff) as u8, [INFO] [stderr] 68 | | ((self.velocity >> 16) & 0xff) as u8, [INFO] [stderr] 69 | | ((self.velocity >> 24) & 0xff) as u8 [INFO] [stderr] 70 | | ] [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 65 | [ [INFO] [stderr] 66 | (self.velocity & 0xff) as u8, [INFO] [stderr] 67 | ((self.velocity >> 8) & 0xff) as u8, [INFO] [stderr] 68 | ((self.velocity >> 16) & 0xff) as u8, [INFO] [stderr] 69 | ((self.velocity >> 24) & 0xff) as u8 [INFO] [stderr] 70 | ] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/instructions.rs:100:9 [INFO] [stderr] | [INFO] [stderr] 100 | / return [ [INFO] [stderr] 101 | | (self.velocity & 0xff) as u8, [INFO] [stderr] 102 | | ((self.velocity >> 8) & 0xff) as u8, [INFO] [stderr] 103 | | ((self.velocity >> 16) & 0xff) as u8, [INFO] [stderr] 104 | | ((self.velocity >> 24) & 0xff) as u8 [INFO] [stderr] 105 | | ] [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 100 | [ [INFO] [stderr] 101 | (self.velocity & 0xff) as u8, [INFO] [stderr] 102 | ((self.velocity >> 8) & 0xff) as u8, [INFO] [stderr] 103 | ((self.velocity >> 16) & 0xff) as u8, [INFO] [stderr] 104 | ((self.velocity >> 24) & 0xff) as u8 [INFO] [stderr] 105 | ] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/instructions.rs:135:9 [INFO] [stderr] | [INFO] [stderr] 135 | return [0, 0, 0, 0] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `[0, 0, 0, 0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/lib.rs:349:40 [INFO] [stderr] | [INFO] [stderr] 349 | fn from_operand(_operand: [u8; 4]) -> () {()} [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/lib.rs:349:47 [INFO] [stderr] | [INFO] [stderr] 349 | fn from_operand(_operand: [u8; 4]) -> () {()} [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `x` [INFO] [stderr] --> src/instructions.rs:525:30 [INFO] [stderr] | [INFO] [stderr] 525 | CALC::Add(x) => [(x >> 0) as u8, (x >> 8) as u8, (x >> 16) as u8, (x >> 24) as u8], [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `x` [INFO] [stderr] --> src/instructions.rs:526:30 [INFO] [stderr] | [INFO] [stderr] 526 | CALC::Sub(x) => [(x >> 0) as u8, (x >> 8) as u8, (x >> 16) as u8, (x >> 24) as u8], [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `x` [INFO] [stderr] --> src/instructions.rs:527:30 [INFO] [stderr] | [INFO] [stderr] 527 | CALC::Mul(x) => [(x >> 0) as u8, (x >> 8) as u8, (x >> 16) as u8, (x >> 24) as u8], [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `x` [INFO] [stderr] --> src/instructions.rs:528:30 [INFO] [stderr] | [INFO] [stderr] 528 | CALC::Div(x) => [(x >> 0) as u8, (x >> 8) as u8, (x >> 16) as u8, (x >> 24) as u8], [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `x` [INFO] [stderr] --> src/instructions.rs:529:30 [INFO] [stderr] | [INFO] [stderr] 529 | CALC::Mod(x) => [(x >> 0) as u8, (x >> 8) as u8, (x >> 16) as u8, (x >> 24) as u8], [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `x` [INFO] [stderr] --> src/instructions.rs:530:30 [INFO] [stderr] | [INFO] [stderr] 530 | CALC::And(x) => [(x >> 0) as u8, (x >> 8) as u8, (x >> 16) as u8, (x >> 24) as u8], [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `x` [INFO] [stderr] --> src/instructions.rs:531:29 [INFO] [stderr] | [INFO] [stderr] 531 | CALC::Or(x) => [(x >> 0) as u8, (x >> 8) as u8, (x >> 16) as u8, (x >> 24) as u8], [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `x` [INFO] [stderr] --> src/instructions.rs:532:30 [INFO] [stderr] | [INFO] [stderr] 532 | CALC::Xor(x) => [(x >> 0) as u8, (x >> 8) as u8, (x >> 16) as u8, (x >> 24) as u8], [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `x` [INFO] [stderr] --> src/instructions.rs:534:31 [INFO] [stderr] | [INFO] [stderr] 534 | CALC::Load(x) => [(x >> 0) as u8, (x >> 8) as u8, (x >> 16) as u8, (x >> 24) as u8], [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/modules/generic/instructions.rs:144:5 [INFO] [stderr] | [INFO] [stderr] 144 | / pub fn new(motor_number: u8, parameter_number: u8) -> STAP { [INFO] [stderr] 145 | | STAP{ [INFO] [stderr] 146 | | motor_number, [INFO] [stderr] 147 | | parameter_number, [INFO] [stderr] 148 | | } [INFO] [stderr] 149 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/modules/generic/mod.rs:47:86 [INFO] [stderr] | [INFO] [stderr] 47 | interface.transmit_command(&Command::new(self.address, instruction)).map_err(|e| Error::InterfaceError(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::InterfaceError` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/modules/generic/mod.rs:48:55 [INFO] [stderr] | [INFO] [stderr] 48 | let reply = interface.receive_reply().map_err(|e| Error::InterfaceError(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::InterfaceError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/modules/tmcm/mod.rs:47:86 [INFO] [stderr] | [INFO] [stderr] 47 | interface.transmit_command(&Command::new(self.address, instruction)).map_err(|e| Error::InterfaceError(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::InterfaceError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/modules/tmcm/mod.rs:48:55 [INFO] [stderr] | [INFO] [stderr] 48 | let reply = interface.receive_reply().map_err(|e| Error::InterfaceError(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::InterfaceError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:364:10 [INFO] [stderr] | [INFO] [stderr] 364 | (array[0] as u32 | ((array[1] as u32) << 8) | ((array[2] as u32) << 16) |((array[3] as u32) << 24)) as i32 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(array[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:364:29 [INFO] [stderr] | [INFO] [stderr] 364 | (array[0] as u32 | ((array[1] as u32) << 8) | ((array[2] as u32) << 16) |((array[3] as u32) << 24)) as i32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(array[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:364:57 [INFO] [stderr] | [INFO] [stderr] 364 | (array[0] as u32 | ((array[1] as u32) << 8) | ((array[2] as u32) << 16) |((array[3] as u32) << 24)) as i32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(array[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:364:84 [INFO] [stderr] | [INFO] [stderr] 364 | (array[0] as u32 | ((array[1] as u32) << 8) | ((array[2] as u32) << 16) |((array[3] as u32) << 24)) as i32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(array[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:370:10 [INFO] [stderr] | [INFO] [stderr] 370 | (array[0] as u16 | ((array[1] as u16) << 8)) as i16 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(array[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:370:29 [INFO] [stderr] | [INFO] [stderr] 370 | (array[0] as u16 | ((array[1] as u16) << 8)) as i16 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(array[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:382:10 [INFO] [stderr] | [INFO] [stderr] 382 | (array[0] as u32 | ((array[1] as u32) << 8) | ((array[2] as u32) << 16) |((array[3] as u32) << 24)) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(array[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:382:29 [INFO] [stderr] | [INFO] [stderr] 382 | (array[0] as u32 | ((array[1] as u32) << 8) | ((array[2] as u32) << 16) |((array[3] as u32) << 24)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(array[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:382:57 [INFO] [stderr] | [INFO] [stderr] 382 | (array[0] as u32 | ((array[1] as u32) << 8) | ((array[2] as u32) << 16) |((array[3] as u32) << 24)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(array[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:382:84 [INFO] [stderr] | [INFO] [stderr] 382 | (array[0] as u32 | ((array[1] as u32) << 8) | ((array[2] as u32) << 16) |((array[3] as u32) << 24)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(array[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:388:9 [INFO] [stderr] | [INFO] [stderr] 388 | array[0] as u16 | ((array[1] as u16) << 8) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(array[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:388:28 [INFO] [stderr] | [INFO] [stderr] 388 | array[0] as u16 | ((array[1] as u16) << 8) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(array[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `x` [INFO] [stderr] --> src/instructions.rs:525:30 [INFO] [stderr] | [INFO] [stderr] 525 | CALC::Add(x) => [(x >> 0) as u8, (x >> 8) as u8, (x >> 16) as u8, (x >> 24) as u8], [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `x` [INFO] [stderr] --> src/instructions.rs:526:30 [INFO] [stderr] | [INFO] [stderr] 526 | CALC::Sub(x) => [(x >> 0) as u8, (x >> 8) as u8, (x >> 16) as u8, (x >> 24) as u8], [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `x` [INFO] [stderr] --> src/instructions.rs:527:30 [INFO] [stderr] | [INFO] [stderr] 527 | CALC::Mul(x) => [(x >> 0) as u8, (x >> 8) as u8, (x >> 16) as u8, (x >> 24) as u8], [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `x` [INFO] [stderr] --> src/instructions.rs:528:30 [INFO] [stderr] | [INFO] [stderr] 528 | CALC::Div(x) => [(x >> 0) as u8, (x >> 8) as u8, (x >> 16) as u8, (x >> 24) as u8], [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `x` [INFO] [stderr] --> src/instructions.rs:529:30 [INFO] [stderr] | [INFO] [stderr] 529 | CALC::Mod(x) => [(x >> 0) as u8, (x >> 8) as u8, (x >> 16) as u8, (x >> 24) as u8], [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `x` [INFO] [stderr] --> src/instructions.rs:530:30 [INFO] [stderr] | [INFO] [stderr] 530 | CALC::And(x) => [(x >> 0) as u8, (x >> 8) as u8, (x >> 16) as u8, (x >> 24) as u8], [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `x` [INFO] [stderr] --> src/instructions.rs:531:29 [INFO] [stderr] | [INFO] [stderr] 531 | CALC::Or(x) => [(x >> 0) as u8, (x >> 8) as u8, (x >> 16) as u8, (x >> 24) as u8], [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `x` [INFO] [stderr] --> src/instructions.rs:532:30 [INFO] [stderr] | [INFO] [stderr] 532 | CALC::Xor(x) => [(x >> 0) as u8, (x >> 8) as u8, (x >> 16) as u8, (x >> 24) as u8], [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `x` [INFO] [stderr] --> src/instructions.rs:534:31 [INFO] [stderr] | [INFO] [stderr] 534 | CALC::Load(x) => [(x >> 0) as u8, (x >> 8) as u8, (x >> 16) as u8, (x >> 24) as u8], [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/modules/generic/instructions.rs:144:5 [INFO] [stderr] | [INFO] [stderr] 144 | / pub fn new(motor_number: u8, parameter_number: u8) -> STAP { [INFO] [stderr] 145 | | STAP{ [INFO] [stderr] 146 | | motor_number, [INFO] [stderr] 147 | | parameter_number, [INFO] [stderr] 148 | | } [INFO] [stderr] 149 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/modules/generic/mod.rs:47:86 [INFO] [stderr] | [INFO] [stderr] 47 | interface.transmit_command(&Command::new(self.address, instruction)).map_err(|e| Error::InterfaceError(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::InterfaceError` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/modules/generic/mod.rs:48:55 [INFO] [stderr] | [INFO] [stderr] 48 | let reply = interface.receive_reply().map_err(|e| Error::InterfaceError(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::InterfaceError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/modules/tmcm/mod.rs:47:86 [INFO] [stderr] | [INFO] [stderr] 47 | interface.transmit_command(&Command::new(self.address, instruction)).map_err(|e| Error::InterfaceError(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::InterfaceError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/modules/tmcm/mod.rs:48:55 [INFO] [stderr] | [INFO] [stderr] 48 | let reply = interface.receive_reply().map_err(|e| Error::InterfaceError(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::InterfaceError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:364:10 [INFO] [stderr] | [INFO] [stderr] 364 | (array[0] as u32 | ((array[1] as u32) << 8) | ((array[2] as u32) << 16) |((array[3] as u32) << 24)) as i32 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(array[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:364:29 [INFO] [stderr] | [INFO] [stderr] 364 | (array[0] as u32 | ((array[1] as u32) << 8) | ((array[2] as u32) << 16) |((array[3] as u32) << 24)) as i32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(array[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:364:57 [INFO] [stderr] | [INFO] [stderr] 364 | (array[0] as u32 | ((array[1] as u32) << 8) | ((array[2] as u32) << 16) |((array[3] as u32) << 24)) as i32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(array[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:364:84 [INFO] [stderr] | [INFO] [stderr] 364 | (array[0] as u32 | ((array[1] as u32) << 8) | ((array[2] as u32) << 16) |((array[3] as u32) << 24)) as i32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(array[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:370:10 [INFO] [stderr] | [INFO] [stderr] 370 | (array[0] as u16 | ((array[1] as u16) << 8)) as i16 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(array[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:370:29 [INFO] [stderr] | [INFO] [stderr] 370 | (array[0] as u16 | ((array[1] as u16) << 8)) as i16 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(array[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:382:10 [INFO] [stderr] | [INFO] [stderr] 382 | (array[0] as u32 | ((array[1] as u32) << 8) | ((array[2] as u32) << 16) |((array[3] as u32) << 24)) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(array[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:382:29 [INFO] [stderr] | [INFO] [stderr] 382 | (array[0] as u32 | ((array[1] as u32) << 8) | ((array[2] as u32) << 16) |((array[3] as u32) << 24)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(array[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:382:57 [INFO] [stderr] | [INFO] [stderr] 382 | (array[0] as u32 | ((array[1] as u32) << 8) | ((array[2] as u32) << 16) |((array[3] as u32) << 24)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(array[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:382:84 [INFO] [stderr] | [INFO] [stderr] 382 | (array[0] as u32 | ((array[1] as u32) << 8) | ((array[2] as u32) << 16) |((array[3] as u32) << 24)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(array[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:388:9 [INFO] [stderr] | [INFO] [stderr] 388 | array[0] as u16 | ((array[1] as u16) << 8) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(array[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:388:28 [INFO] [stderr] | [INFO] [stderr] 388 | array[0] as u16 | ((array[1] as u16) << 8) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(array[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.64s [INFO] running `"docker" "inspect" "4f4e29889031a7601dd14a9d49a1afbc2fa8023ca05105e85b4b09cf4fd93ead"` [INFO] running `"docker" "rm" "-f" "4f4e29889031a7601dd14a9d49a1afbc2fa8023ca05105e85b4b09cf4fd93ead"` [INFO] [stdout] 4f4e29889031a7601dd14a9d49a1afbc2fa8023ca05105e85b4b09cf4fd93ead