[INFO] crate tma 0.1.1 is already in cache
[INFO] extracting crate tma 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/tma/0.1.1
[INFO] extracting crate tma 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tma/0.1.1
[INFO] validating manifest of tma-0.1.1 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of tma-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing tma-0.1.1
[INFO] finished frobbing tma-0.1.1
[INFO] frobbed toml for tma-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/tma/0.1.1/Cargo.toml
[INFO] started frobbing tma-0.1.1
[INFO] finished frobbing tma-0.1.1
[INFO] frobbed toml for tma-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tma/0.1.1/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting tma-0.1.1 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/tma/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] e2e42e1653b87d5a49378c4ae0fe734e1460c083573df6f416e7f33aae53bb2f
[INFO] running `"docker" "start" "-a" "e2e42e1653b87d5a49378c4ae0fe734e1460c083573df6f416e7f33aae53bb2f"`
[INFO] [stderr]     Checking structopt v0.1.7
[INFO] [stderr]     Checking tma v0.1.1 (/opt/crater/workdir)
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/main.rs:79:5
[INFO] [stderr]    |
[INFO] [stderr] 79 |     name
[INFO] [stderr]    |     ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/main.rs:67:16
[INFO] [stderr]    |
[INFO] [stderr] 67 |       let name = match session.name.as_ref() {
[INFO] [stderr]    |  ________________^
[INFO] [stderr] 68 | |         Some(n) => n.clone(),
[INFO] [stderr] 69 | |         None => {
[INFO] [stderr] 70 | |             env::current_dir()
[INFO] [stderr] ...  |
[INFO] [stderr] 77 | |         }
[INFO] [stderr] 78 | |     };
[INFO] [stderr]    | |_____^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/main.rs:79:5
[INFO] [stderr]    |
[INFO] [stderr] 79 |     name
[INFO] [stderr]    |     ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/main.rs:67:16
[INFO] [stderr]    |
[INFO] [stderr] 67 |       let name = match session.name.as_ref() {
[INFO] [stderr]    |  ________________^
[INFO] [stderr] 68 | |         Some(n) => n.clone(),
[INFO] [stderr] 69 | |         None => {
[INFO] [stderr] 70 | |             env::current_dir()
[INFO] [stderr] ...  |
[INFO] [stderr] 77 | |         }
[INFO] [stderr] 78 | |     };
[INFO] [stderr]    | |_____^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]    --> src/main.rs:108:5
[INFO] [stderr]     |
[INFO] [stderr] 108 |     session.root.as_ref().map(|r| session_root.push(r));
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-
[INFO] [stderr]     |     |
[INFO] [stderr]     |     help: try this: `if let Some(r) = session.root.as_ref() { session_root.push(r) }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::option_map_unit_fn)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] 
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]    --> src/main.rs:110:5
[INFO] [stderr]     |
[INFO] [stderr] 110 |     session.window[0].root.as_ref().map(|r| root.push(r));
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-
[INFO] [stderr]     |     |
[INFO] [stderr]     |     help: try this: `if let Some(r) = session.window[0].root.as_ref() { root.push(r) }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] 
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]    --> src/main.rs:121:21
[INFO] [stderr]     |
[INFO] [stderr] 121 |                     window.root.as_ref().map(|root| window_root.push(root));
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-
[INFO] [stderr]     |                     |
[INFO] [stderr]     |                     help: try this: `if let Some(root) = window.root.as_ref() { window_root.push(root) }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] 
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]    --> src/main.rs:133:17
[INFO] [stderr]     |
[INFO] [stderr] 133 | /                 window.name.as_ref().map(|n| {
[INFO] [stderr] 134 | |                     tmux(vec!["rename-window", "-t", name.as_str(), n.as_str()])
[INFO] [stderr] 135 | |                         .output()
[INFO] [stderr] 136 | |                         .expect("Failed to rename window");
[INFO] [stderr] 137 | |                 });
[INFO] [stderr]     | |__________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 133 |                 if let Some(n) = window.name.as_ref() { tmux(vec!["rename-window", "-t", name.as_str(), n.as_str()])
[INFO] [stderr] 134 |                         .output()
[INFO] [stderr] 135 |                         .expect("Failed to rename window"); }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/main.rs:150:42
[INFO] [stderr]     |
[INFO] [stderr] 150 | fn create_panes(session: &Session, name: &String, window: &Window, index: usize) {
[INFO] [stderr]     |                                          ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]    --> src/main.rs:152:5
[INFO] [stderr]     |
[INFO] [stderr] 152 |     session.root.as_ref().map(|r| root.push(r));
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-
[INFO] [stderr]     |     |
[INFO] [stderr]     |     help: try this: `if let Some(r) = session.root.as_ref() { root.push(r) }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] 
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]    --> src/main.rs:153:5
[INFO] [stderr]     |
[INFO] [stderr] 153 |     window.root.as_ref().map(|r| root.push(r));
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-
[INFO] [stderr]     |     |
[INFO] [stderr]     |     help: try this: `if let Some(r) = window.root.as_ref() { root.push(r) }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] 
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]    --> src/main.rs:158:13
[INFO] [stderr]     |
[INFO] [stderr] 158 |             pane.root.as_ref().map(|r| pane_root.push(r));
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-
[INFO] [stderr]     |             |
[INFO] [stderr]     |             help: try this: `if let Some(r) = pane.root.as_ref() { pane_root.push(r) }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] 
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]    --> src/main.rs:162:13
[INFO] [stderr]     |
[INFO] [stderr] 162 |                pane.split.as_ref().map(|s| {
[INFO] [stderr]     |   _____________^
[INFO] [stderr]     |  |_____________|
[INFO] [stderr]     | ||
[INFO] [stderr] 163 | ||                 if s == "horizontal" {
[INFO] [stderr] 164 | ||                     cmd.arg("-h");
[INFO] [stderr] 165 | ||                 }
[INFO] [stderr] 166 | ||             });
[INFO] [stderr]     | ||______________^- help: try this: `if let Some(s) = pane.split.as_ref() { ... }`
[INFO] [stderr]     | |_______________|
[INFO] [stderr]     | 
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] 
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]    --> src/main.rs:169:9
[INFO] [stderr]     |
[INFO] [stderr] 169 | /         pane.command.as_ref().map(|c| {
[INFO] [stderr] 170 | |             tmux(vec!["send-keys", format!("{}\n", c).as_str()])
[INFO] [stderr] 171 | |                 .output()
[INFO] [stderr] 172 | |                 .expect("Failed to run command in pane");
[INFO] [stderr] 173 | |         });
[INFO] [stderr]     | |__________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 169 |         if let Some(c) = pane.command.as_ref() { tmux(vec!["send-keys", format!("{}\n", c).as_str()])
[INFO] [stderr] 170 |                 .output()
[INFO] [stderr] 171 |                 .expect("Failed to run command in pane"); }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]    --> src/main.rs:108:5
[INFO] [stderr]     |
[INFO] [stderr] 108 |     session.root.as_ref().map(|r| session_root.push(r));
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-
[INFO] [stderr]     |     |
[INFO] [stderr]     |     help: try this: `if let Some(r) = session.root.as_ref() { session_root.push(r) }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::option_map_unit_fn)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] 
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]    --> src/main.rs:110:5
[INFO] [stderr]     |
[INFO] [stderr] 110 |     session.window[0].root.as_ref().map(|r| root.push(r));
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-
[INFO] [stderr]     |     |
[INFO] [stderr]     |     help: try this: `if let Some(r) = session.window[0].root.as_ref() { root.push(r) }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] 
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]    --> src/main.rs:121:21
[INFO] [stderr]     |
[INFO] [stderr] 121 |                     window.root.as_ref().map(|root| window_root.push(root));
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-
[INFO] [stderr]     |                     |
[INFO] [stderr]     |                     help: try this: `if let Some(root) = window.root.as_ref() { window_root.push(root) }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] 
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]    --> src/main.rs:133:17
[INFO] [stderr]     |
[INFO] [stderr] 133 | /                 window.name.as_ref().map(|n| {
[INFO] [stderr] 134 | |                     tmux(vec!["rename-window", "-t", name.as_str(), n.as_str()])
[INFO] [stderr] 135 | |                         .output()
[INFO] [stderr] 136 | |                         .expect("Failed to rename window");
[INFO] [stderr] 137 | |                 });
[INFO] [stderr]     | |__________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 133 |                 if let Some(n) = window.name.as_ref() { tmux(vec!["rename-window", "-t", name.as_str(), n.as_str()])
[INFO] [stderr] 134 |                         .output()
[INFO] [stderr] 135 |                         .expect("Failed to rename window"); }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/main.rs:150:42
[INFO] [stderr]     |
[INFO] [stderr] 150 | fn create_panes(session: &Session, name: &String, window: &Window, index: usize) {
[INFO] [stderr]     |                                          ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]    --> src/main.rs:152:5
[INFO] [stderr]     |
[INFO] [stderr] 152 |     session.root.as_ref().map(|r| root.push(r));
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-
[INFO] [stderr]     |     |
[INFO] [stderr]     |     help: try this: `if let Some(r) = session.root.as_ref() { root.push(r) }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] 
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]    --> src/main.rs:153:5
[INFO] [stderr]     |
[INFO] [stderr] 153 |     window.root.as_ref().map(|r| root.push(r));
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-
[INFO] [stderr]     |     |
[INFO] [stderr]     |     help: try this: `if let Some(r) = window.root.as_ref() { root.push(r) }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] 
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]    --> src/main.rs:158:13
[INFO] [stderr]     |
[INFO] [stderr] 158 |             pane.root.as_ref().map(|r| pane_root.push(r));
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-
[INFO] [stderr]     |             |
[INFO] [stderr]     |             help: try this: `if let Some(r) = pane.root.as_ref() { pane_root.push(r) }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] 
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]    --> src/main.rs:162:13
[INFO] [stderr]     |
[INFO] [stderr] 162 |                pane.split.as_ref().map(|s| {
[INFO] [stderr]     |   _____________^
[INFO] [stderr]     |  |_____________|
[INFO] [stderr]     | ||
[INFO] [stderr] 163 | ||                 if s == "horizontal" {
[INFO] [stderr] 164 | ||                     cmd.arg("-h");
[INFO] [stderr] 165 | ||                 }
[INFO] [stderr] 166 | ||             });
[INFO] [stderr]     | ||______________^- help: try this: `if let Some(s) = pane.split.as_ref() { ... }`
[INFO] [stderr]     | |_______________|
[INFO] [stderr]     | 
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] 
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]    --> src/main.rs:169:9
[INFO] [stderr]     |
[INFO] [stderr] 169 | /         pane.command.as_ref().map(|c| {
[INFO] [stderr] 170 | |             tmux(vec!["send-keys", format!("{}\n", c).as_str()])
[INFO] [stderr] 171 | |                 .output()
[INFO] [stderr] 172 | |                 .expect("Failed to run command in pane");
[INFO] [stderr] 173 | |         });
[INFO] [stderr]     | |__________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 169 |         if let Some(c) = pane.command.as_ref() { tmux(vec!["send-keys", format!("{}\n", c).as_str()])
[INFO] [stderr] 170 |                 .output()
[INFO] [stderr] 171 |                 .expect("Failed to run command in pane"); }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 3.68s
[INFO] running `"docker" "inspect" "e2e42e1653b87d5a49378c4ae0fe734e1460c083573df6f416e7f33aae53bb2f"`
[INFO] running `"docker" "rm" "-f" "e2e42e1653b87d5a49378c4ae0fe734e1460c083573df6f416e7f33aae53bb2f"`
[INFO] [stdout] e2e42e1653b87d5a49378c4ae0fe734e1460c083573df6f416e7f33aae53bb2f