[INFO] crate tls-parser 0.6.0 is already in cache [INFO] extracting crate tls-parser 0.6.0 into work/ex/clippy-test-run/sources/stable/reg/tls-parser/0.6.0 [INFO] extracting crate tls-parser 0.6.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tls-parser/0.6.0 [INFO] validating manifest of tls-parser-0.6.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tls-parser-0.6.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tls-parser-0.6.0 [INFO] finished frobbing tls-parser-0.6.0 [INFO] frobbed toml for tls-parser-0.6.0 written to work/ex/clippy-test-run/sources/stable/reg/tls-parser/0.6.0/Cargo.toml [INFO] started frobbing tls-parser-0.6.0 [INFO] finished frobbing tls-parser-0.6.0 [INFO] frobbed toml for tls-parser-0.6.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tls-parser/0.6.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tls-parser-0.6.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/tls-parser/0.6.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 16e63fb7c5c43adab5c34ab6f9f4e484a0f85223c4d0821b2d98da98e3f46a71 [INFO] running `"docker" "start" "-a" "16e63fb7c5c43adab5c34ab6f9f4e484a0f85223c4d0821b2d98da98e3f46a71"` [INFO] [stderr] Checking cookie-factory v0.2.4 [INFO] [stderr] Checking nom v4.1.1 [INFO] [stderr] Compiling tls-parser v0.6.0 (/opt/crater/workdir) [INFO] [stderr] Checking rusticata-macros v1.1.0 [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tls_serialize.rs:406:17 [INFO] [stderr] | [INFO] [stderr] 406 | comp: comp, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `comp` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tls_serialize.rs:406:17 [INFO] [stderr] | [INFO] [stderr] 406 | comp: comp, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `comp` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/tls-parser-a09685fd2fd47321/out/codegen.rs:2:10 [INFO] [stderr] | [INFO] [stderr] 2 | key: 3213172566270843353, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `3_213_172_566_270_843_353` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/tls_sign_hash.rs:42:17 [INFO] [stderr] | [INFO] [stderr] 42 | EcdsaSha1 = 0203, [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_prefixed_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 42 | EcdsaSha1 = 203, [INFO] [stderr] | ^^^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 42 | EcdsaSha1 = 0o203, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/tls-parser-a09685fd2fd47321/out/codegen.rs:2:10 [INFO] [stderr] | [INFO] [stderr] 2 | key: 3213172566270843353, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `3_213_172_566_270_843_353` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/tls_sign_hash.rs:42:17 [INFO] [stderr] | [INFO] [stderr] 42 | EcdsaSha1 = 0203, [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_prefixed_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 42 | EcdsaSha1 = 203, [INFO] [stderr] | ^^^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 42 | EcdsaSha1 = 0o203, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `SignatureSchemeU16` [INFO] [stderr] --> src/tls_debug.rs:15:1 [INFO] [stderr] | [INFO] [stderr] 15 | pub struct SignatureSchemeU16 { pub d: u16 } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `SignatureSchemeU16` [INFO] [stderr] --> src/tls_debug.rs:15:1 [INFO] [stderr] | [INFO] [stderr] 15 | pub struct SignatureSchemeU16 { pub d: u16 } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/tls_extensions.rs:113:9 [INFO] [stderr] | [INFO] [stderr] 113 | / match ext { [INFO] [stderr] 114 | | &TlsExtension::SNI(_) => TlsExtensionType::ServerName, [INFO] [stderr] 115 | | &TlsExtension::MaxFragmentLength(_) => TlsExtensionType::MaxFragmentLength, [INFO] [stderr] 116 | | &TlsExtension::StatusRequest(_) => TlsExtensionType::StatusRequest, [INFO] [stderr] ... | [INFO] [stderr] 138 | | &TlsExtension::Unknown(x,_) => TlsExtensionType(x) [INFO] [stderr] 139 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 113 | match *ext { [INFO] [stderr] 114 | TlsExtension::SNI(_) => TlsExtensionType::ServerName, [INFO] [stderr] 115 | TlsExtension::MaxFragmentLength(_) => TlsExtensionType::MaxFragmentLength, [INFO] [stderr] 116 | TlsExtension::StatusRequest(_) => TlsExtensionType::StatusRequest, [INFO] [stderr] 117 | TlsExtension::EllipticCurves(_) => TlsExtensionType::SupportedGroups, [INFO] [stderr] 118 | TlsExtension::EcPointFormats(_) => TlsExtensionType::EcPointFormats, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/tls_ciphers.rs:131:13 [INFO] [stderr] | [INFO] [stderr] 131 | assert!(CIPHERS.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!CIPHERS.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/tls_extensions.rs:113:9 [INFO] [stderr] | [INFO] [stderr] 113 | / match ext { [INFO] [stderr] 114 | | &TlsExtension::SNI(_) => TlsExtensionType::ServerName, [INFO] [stderr] 115 | | &TlsExtension::MaxFragmentLength(_) => TlsExtensionType::MaxFragmentLength, [INFO] [stderr] 116 | | &TlsExtension::StatusRequest(_) => TlsExtensionType::StatusRequest, [INFO] [stderr] ... | [INFO] [stderr] 138 | | &TlsExtension::Unknown(x,_) => TlsExtensionType(x) [INFO] [stderr] 139 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 113 | match *ext { [INFO] [stderr] 114 | TlsExtension::SNI(_) => TlsExtensionType::ServerName, [INFO] [stderr] 115 | TlsExtension::MaxFragmentLength(_) => TlsExtensionType::MaxFragmentLength, [INFO] [stderr] 116 | TlsExtension::StatusRequest(_) => TlsExtensionType::StatusRequest, [INFO] [stderr] 117 | TlsExtension::EllipticCurves(_) => TlsExtensionType::SupportedGroups, [INFO] [stderr] 118 | TlsExtension::EcPointFormats(_) => TlsExtensionType::EcPointFormats, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tls.rs:192:28 [INFO] [stderr] | [INFO] [stderr] 192 | pub fn get_ciphersuite(&self) -> Option<&'static TlsCipherSuite> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/tls.rs:511:46 [INFO] [stderr] | [INFO] [stderr] 511 | TlsCipherSuiteID((chunk[0] as u16) << 8 | chunk[1] as u16) }).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(chunk[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/tls.rs:511:71 [INFO] [stderr] | [INFO] [stderr] 511 | TlsCipherSuiteID((chunk[0] as u16) << 8 | chunk[1] as u16) }).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(chunk[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tls.rs:192:28 [INFO] [stderr] | [INFO] [stderr] 192 | pub fn get_ciphersuite(&self) -> Option<&'static TlsCipherSuite> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/tls.rs:511:46 [INFO] [stderr] | [INFO] [stderr] 511 | TlsCipherSuiteID((chunk[0] as u16) << 8 | chunk[1] as u16) }).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(chunk[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/tls.rs:511:71 [INFO] [stderr] | [INFO] [stderr] 511 | TlsCipherSuiteID((chunk[0] as u16) << 8 | chunk[1] as u16) }).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(chunk[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 32 [INFO] [stderr] --> src/tls.rs:880:1 [INFO] [stderr] | [INFO] [stderr] 880 | / pub fn parse_tls_record_with_header( i:&[u8], hdr:TlsRecordHeader ) -> IResult<&[u8], Vec> { [INFO] [stderr] 881 | | match hdr.record_type { [INFO] [stderr] 882 | | TlsRecordType::ChangeCipherSpec => many1!(i, complete!(parse_tls_message_changecipherspec)), [INFO] [stderr] 883 | | TlsRecordType::Alert => many1!(i, complete!(parse_tls_message_alert)), [INFO] [stderr] ... | [INFO] [stderr] 888 | | } [INFO] [stderr] 889 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/tls_debug.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | / match self { [INFO] [stderr] 95 | | &TlsClientKeyExchangeContents::Dh(ref p) => fmt.write_fmt(format_args!("{:?}",HexSlice{d:p})), [INFO] [stderr] 96 | | &TlsClientKeyExchangeContents::Ecdh(ref p) => fmt.write_fmt(format_args!("{:?}",p)), [INFO] [stderr] 97 | | &TlsClientKeyExchangeContents::Unknown(ref p) => fmt.write_fmt(format_args!("{:?}",HexSlice{d:p})), [INFO] [stderr] 98 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 94 | match *self { [INFO] [stderr] 95 | TlsClientKeyExchangeContents::Dh(ref p) => fmt.write_fmt(format_args!("{:?}",HexSlice{d:p})), [INFO] [stderr] 96 | TlsClientKeyExchangeContents::Ecdh(ref p) => fmt.write_fmt(format_args!("{:?}",p)), [INFO] [stderr] 97 | TlsClientKeyExchangeContents::Unknown(ref p) => fmt.write_fmt(format_args!("{:?}",HexSlice{d:p})), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/tls_debug.rs:138:9 [INFO] [stderr] | [INFO] [stderr] 138 | / match self { [INFO] [stderr] 139 | | &ECParametersContent::ExplicitPrime(ref p) => fmt.write_fmt(format_args!("ExplicitPrime({:?})",p)), [INFO] [stderr] 140 | | &ECParametersContent::ExplicitChar2(ref p) => fmt.write_fmt(format_args!("ExplicitChar2({:?})",HexSlice{d:p})), [INFO] [stderr] 141 | | &ECParametersContent::NamedGroup(p) => { [INFO] [stderr] ... | [INFO] [stderr] 147 | | }, [INFO] [stderr] 148 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 138 | match *self { [INFO] [stderr] 139 | ECParametersContent::ExplicitPrime(ref p) => fmt.write_fmt(format_args!("ExplicitPrime({:?})",p)), [INFO] [stderr] 140 | ECParametersContent::ExplicitChar2(ref p) => fmt.write_fmt(format_args!("ExplicitChar2({:?})",HexSlice{d:p})), [INFO] [stderr] 141 | ECParametersContent::NamedGroup(p) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/tls_debug.rs:223:21 [INFO] [stderr] | [INFO] [stderr] 223 | format!("{}",s) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using .to_string(): `s.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 32 [INFO] [stderr] --> src/tls.rs:880:1 [INFO] [stderr] | [INFO] [stderr] 880 | / pub fn parse_tls_record_with_header( i:&[u8], hdr:TlsRecordHeader ) -> IResult<&[u8], Vec> { [INFO] [stderr] 881 | | match hdr.record_type { [INFO] [stderr] 882 | | TlsRecordType::ChangeCipherSpec => many1!(i, complete!(parse_tls_message_changecipherspec)), [INFO] [stderr] 883 | | TlsRecordType::Alert => many1!(i, complete!(parse_tls_message_alert)), [INFO] [stderr] ... | [INFO] [stderr] 888 | | } [INFO] [stderr] 889 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/tls_debug.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | / match self { [INFO] [stderr] 95 | | &TlsClientKeyExchangeContents::Dh(ref p) => fmt.write_fmt(format_args!("{:?}",HexSlice{d:p})), [INFO] [stderr] 96 | | &TlsClientKeyExchangeContents::Ecdh(ref p) => fmt.write_fmt(format_args!("{:?}",p)), [INFO] [stderr] 97 | | &TlsClientKeyExchangeContents::Unknown(ref p) => fmt.write_fmt(format_args!("{:?}",HexSlice{d:p})), [INFO] [stderr] 98 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 94 | match *self { [INFO] [stderr] 95 | TlsClientKeyExchangeContents::Dh(ref p) => fmt.write_fmt(format_args!("{:?}",HexSlice{d:p})), [INFO] [stderr] 96 | TlsClientKeyExchangeContents::Ecdh(ref p) => fmt.write_fmt(format_args!("{:?}",p)), [INFO] [stderr] 97 | TlsClientKeyExchangeContents::Unknown(ref p) => fmt.write_fmt(format_args!("{:?}",HexSlice{d:p})), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/tls_debug.rs:138:9 [INFO] [stderr] | [INFO] [stderr] 138 | / match self { [INFO] [stderr] 139 | | &ECParametersContent::ExplicitPrime(ref p) => fmt.write_fmt(format_args!("ExplicitPrime({:?})",p)), [INFO] [stderr] 140 | | &ECParametersContent::ExplicitChar2(ref p) => fmt.write_fmt(format_args!("ExplicitChar2({:?})",HexSlice{d:p})), [INFO] [stderr] 141 | | &ECParametersContent::NamedGroup(p) => { [INFO] [stderr] ... | [INFO] [stderr] 147 | | }, [INFO] [stderr] 148 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 138 | match *self { [INFO] [stderr] 139 | ECParametersContent::ExplicitPrime(ref p) => fmt.write_fmt(format_args!("ExplicitPrime({:?})",p)), [INFO] [stderr] 140 | ECParametersContent::ExplicitChar2(ref p) => fmt.write_fmt(format_args!("ExplicitChar2({:?})",HexSlice{d:p})), [INFO] [stderr] 141 | ECParametersContent::NamedGroup(p) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/tls_debug.rs:223:21 [INFO] [stderr] | [INFO] [stderr] 223 | format!("{}",s) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using .to_string(): `s.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/tls_tls13.rs:77:36 [INFO] [stderr] | [INFO] [stderr] 77 | rand_time: 0xce05cfa3, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xce05_cfa3` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/bench_handshake.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/bench_dh.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/tls_handshake.rs:73:36 [INFO] [stderr] | [INFO] [stderr] 73 | rand_time: 0xb29dd787, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xb29d_d787` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/tls_handshake.rs:401:36 [INFO] [stderr] | [INFO] [stderr] 401 | rand_time: 0x57c457da, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x57c4_57da` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> tests/tls_tls13.rs:118:19 [INFO] [stderr] | [INFO] [stderr] 118 | let ext_raw = match msg { [INFO] [stderr] | ___________________^ [INFO] [stderr] 119 | | &TlsMessage::Handshake(TlsMessageHandshake::ServerHelloV13Draft18(ref sh)) => sh.ext.unwrap(), [INFO] [stderr] 120 | | _ => { assert!(false); empty }, [INFO] [stderr] 121 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 118 | let ext_raw = match *msg { [INFO] [stderr] 119 | TlsMessage::Handshake(TlsMessageHandshake::ServerHelloV13Draft18(ref sh)) => sh.ext.unwrap(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: Could not compile `tls-parser`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: Could not compile `tls-parser`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "16e63fb7c5c43adab5c34ab6f9f4e484a0f85223c4d0821b2d98da98e3f46a71"` [INFO] running `"docker" "rm" "-f" "16e63fb7c5c43adab5c34ab6f9f4e484a0f85223c4d0821b2d98da98e3f46a71"` [INFO] [stdout] 16e63fb7c5c43adab5c34ab6f9f4e484a0f85223c4d0821b2d98da98e3f46a71