[INFO] crate tldextract 0.5.1 is already in cache [INFO] extracting crate tldextract 0.5.1 into work/ex/clippy-test-run/sources/stable/reg/tldextract/0.5.1 [INFO] extracting crate tldextract 0.5.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tldextract/0.5.1 [INFO] validating manifest of tldextract-0.5.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tldextract-0.5.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tldextract-0.5.1 [INFO] finished frobbing tldextract-0.5.1 [INFO] frobbed toml for tldextract-0.5.1 written to work/ex/clippy-test-run/sources/stable/reg/tldextract/0.5.1/Cargo.toml [INFO] started frobbing tldextract-0.5.1 [INFO] finished frobbing tldextract-0.5.1 [INFO] frobbed toml for tldextract-0.5.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tldextract/0.5.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tldextract-0.5.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/tldextract/0.5.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b2f4d7bbba574db1cd4739c84ab79ff107cd7e4eda55b51f384b94522991d51f [INFO] running `"docker" "start" "-a" "b2f4d7bbba574db1cd4739c84ab79ff107cd7e4eda55b51f384b94522991d51f"` [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Compiling rand_pcg v0.1.1 [INFO] [stderr] Compiling parking_lot_core v0.4.0 [INFO] [stderr] Checking rand v0.6.5 [INFO] [stderr] Checking parking_lot v0.7.1 [INFO] [stderr] Checking crossbeam v0.6.0 [INFO] [stderr] Checking tokio-reactor v0.1.8 [INFO] [stderr] Checking tokio-threadpool v0.1.11 [INFO] [stderr] Checking tokio-tcp v0.1.3 [INFO] [stderr] Checking tokio-uds v0.2.5 [INFO] [stderr] Checking tokio-udp v0.1.3 [INFO] [stderr] Checking tokio-fs v0.1.5 [INFO] [stderr] Checking tokio v0.1.15 [INFO] [stderr] Checking hyper v0.12.23 [INFO] [stderr] Checking hyper-tls v0.3.1 [INFO] [stderr] Checking tldextract v0.5.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:97:13 [INFO] [stderr] | [INFO] [stderr] 97 | tld_cache: tld_cache, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tld_cache` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:179:13 [INFO] [stderr] | [INFO] [stderr] 179 | suffix: suffix, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `suffix` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:180:13 [INFO] [stderr] | [INFO] [stderr] 180 | subdomain: subdomain, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `subdomain` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:181:13 [INFO] [stderr] | [INFO] [stderr] 181 | domain: domain, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `domain` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:97:13 [INFO] [stderr] | [INFO] [stderr] 97 | tld_cache: tld_cache, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tld_cache` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:179:13 [INFO] [stderr] | [INFO] [stderr] 179 | suffix: suffix, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `suffix` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:180:13 [INFO] [stderr] | [INFO] [stderr] 180 | subdomain: subdomain, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `subdomain` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:181:13 [INFO] [stderr] | [INFO] [stderr] 181 | domain: domain, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `domain` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cache/remote.rs:11:33 [INFO] [stderr] | [INFO] [stderr] 11 | const PUBLIC_SUFFIX_LIST_URLS: &'static [&'static str] = &[ [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cache/remote.rs:11:43 [INFO] [stderr] | [INFO] [stderr] 11 | const PUBLIC_SUFFIX_LIST_URLS: &'static [&'static str] = &[ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cache/remote.rs:16:26 [INFO] [stderr] | [INFO] [stderr] 16 | const PUBLIC_SUFFIX_RE: &'static str = r"^(?P[.*!]*\w[\S]*)"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cache/snapshot.rs:10:27 [INFO] [stderr] | [INFO] [stderr] 10 | pub const BUNDLED_CACHE: &'static [&'static str] = &[ [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cache/snapshot.rs:10:37 [INFO] [stderr] | [INFO] [stderr] 10 | pub const BUNDLED_CACHE: &'static [&'static str] = &[ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cache/remote.rs:11:33 [INFO] [stderr] | [INFO] [stderr] 11 | const PUBLIC_SUFFIX_LIST_URLS: &'static [&'static str] = &[ [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cache/remote.rs:11:43 [INFO] [stderr] | [INFO] [stderr] 11 | const PUBLIC_SUFFIX_LIST_URLS: &'static [&'static str] = &[ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cache/remote.rs:16:26 [INFO] [stderr] | [INFO] [stderr] 16 | const PUBLIC_SUFFIX_RE: &'static str = r"^(?P[.*!]*\w[\S]*)"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cache/snapshot.rs:10:27 [INFO] [stderr] | [INFO] [stderr] 10 | pub const BUNDLED_CACHE: &'static [&'static str] = &[ [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cache/snapshot.rs:10:37 [INFO] [stderr] | [INFO] [stderr] 10 | pub const BUNDLED_CACHE: &'static [&'static str] = &[ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/cache/remote.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | / for u in PUBLIC_SUFFIX_LIST_URLS { [INFO] [stderr] 28 | | let respfut = client.get(u.parse().unwrap()); [INFO] [stderr] 29 | | let contentfut = respfut.and_then(|resp| resp.into_body().concat2()); [INFO] [stderr] 30 | | let content = rt.block_on(contentfut)?; [INFO] [stderr] ... | [INFO] [stderr] 44 | | .collect()); [INFO] [stderr] 45 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/cache/remote.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | / for u in PUBLIC_SUFFIX_LIST_URLS { [INFO] [stderr] 28 | | let respfut = client.get(u.parse().unwrap()); [INFO] [stderr] 29 | | let contentfut = respfut.and_then(|resp| resp.into_body().concat2()); [INFO] [stderr] 30 | | let content = rt.block_on(contentfut)?; [INFO] [stderr] ... | [INFO] [stderr] 44 | | .collect()); [INFO] [stderr] 45 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:92:46 [INFO] [stderr] | [INFO] [stderr] 92 | let tld_cache = cache::get_tld_cache(cache_path.clone(), option.private_domains); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `cache_path` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:115:29 [INFO] [stderr] | [INFO] [stderr] 115 | let host = u.host().ok_or(TldExtractError::NoHostError(url.into()))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| TldExtractError::NoHostError(url.into()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:135:79 [INFO] [stderr] | [INFO] [stderr] 135 | punycode::decode_to_string(seg.trim_left_matches("xn--")).unwrap_or(seg.into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| seg.into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/lib.rs:150:20 [INFO] [stderr] | [INFO] [stderr] 150 | if let Some(_) = self.tld_cache.get(&exception_piece) { [INFO] [stderr] | _____________- ^^^^^^^ [INFO] [stderr] 151 | | continue; [INFO] [stderr] 152 | | } [INFO] [stderr] | |_____________- help: try this: `if self.tld_cache.get(&exception_piece).is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/lib.rs:154:20 [INFO] [stderr] | [INFO] [stderr] 154 | if let Some(_) = self.tld_cache.get(&piece).or(self.tld_cache.get(&wildcard_piece)) { [INFO] [stderr] | _____________- ^^^^^^^ [INFO] [stderr] 155 | | if i == 0 { [INFO] [stderr] 156 | | // The whole url is a suffix [INFO] [stderr] 157 | | suffix = Some(piece); [INFO] [stderr] ... | [INFO] [stderr] 164 | | break; [INFO] [stderr] 165 | | } [INFO] [stderr] | |_____________- help: try this: `if self.tld_cache.get(&piece).or(self.tld_cache.get(&wildcard_piece)).is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/lib.rs:154:57 [INFO] [stderr] | [INFO] [stderr] 154 | if let Some(_) = self.tld_cache.get(&piece).or(self.tld_cache.get(&wildcard_piece)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| self.tld_cache.get(&wildcard_piece))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:161:36 [INFO] [stderr] | [INFO] [stderr] 161 | subdomain = if segs[0..i - 1].len() == 0 { None } else { Some(segs[0..i - 1].join(".")) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `segs[0..i - 1].is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:92:46 [INFO] [stderr] | [INFO] [stderr] 92 | let tld_cache = cache::get_tld_cache(cache_path.clone(), option.private_domains); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `cache_path` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:115:29 [INFO] [stderr] | [INFO] [stderr] 115 | let host = u.host().ok_or(TldExtractError::NoHostError(url.into()))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| TldExtractError::NoHostError(url.into()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:135:79 [INFO] [stderr] | [INFO] [stderr] 135 | punycode::decode_to_string(seg.trim_left_matches("xn--")).unwrap_or(seg.into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| seg.into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/lib.rs:150:20 [INFO] [stderr] | [INFO] [stderr] 150 | if let Some(_) = self.tld_cache.get(&exception_piece) { [INFO] [stderr] | _____________- ^^^^^^^ [INFO] [stderr] 151 | | continue; [INFO] [stderr] 152 | | } [INFO] [stderr] | |_____________- help: try this: `if self.tld_cache.get(&exception_piece).is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/lib.rs:154:20 [INFO] [stderr] | [INFO] [stderr] 154 | if let Some(_) = self.tld_cache.get(&piece).or(self.tld_cache.get(&wildcard_piece)) { [INFO] [stderr] | _____________- ^^^^^^^ [INFO] [stderr] 155 | | if i == 0 { [INFO] [stderr] 156 | | // The whole url is a suffix [INFO] [stderr] 157 | | suffix = Some(piece); [INFO] [stderr] ... | [INFO] [stderr] 164 | | break; [INFO] [stderr] 165 | | } [INFO] [stderr] | |_____________- help: try this: `if self.tld_cache.get(&piece).or(self.tld_cache.get(&wildcard_piece)).is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/lib.rs:154:57 [INFO] [stderr] | [INFO] [stderr] 154 | if let Some(_) = self.tld_cache.get(&piece).or(self.tld_cache.get(&wildcard_piece)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| self.tld_cache.get(&wildcard_piece))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:161:36 [INFO] [stderr] | [INFO] [stderr] 161 | subdomain = if segs[0..i - 1].len() == 0 { None } else { Some(segs[0..i - 1].join(".")) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `segs[0..i - 1].is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] error: Could not compile `tldextract`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `tldextract`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "b2f4d7bbba574db1cd4739c84ab79ff107cd7e4eda55b51f384b94522991d51f"` [INFO] running `"docker" "rm" "-f" "b2f4d7bbba574db1cd4739c84ab79ff107cd7e4eda55b51f384b94522991d51f"` [INFO] [stdout] b2f4d7bbba574db1cd4739c84ab79ff107cd7e4eda55b51f384b94522991d51f