[INFO] crate tk-pool 0.5.3 is already in cache [INFO] extracting crate tk-pool 0.5.3 into work/ex/clippy-test-run/sources/stable/reg/tk-pool/0.5.3 [INFO] extracting crate tk-pool 0.5.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tk-pool/0.5.3 [INFO] validating manifest of tk-pool-0.5.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tk-pool-0.5.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tk-pool-0.5.3 [INFO] finished frobbing tk-pool-0.5.3 [INFO] frobbed toml for tk-pool-0.5.3 written to work/ex/clippy-test-run/sources/stable/reg/tk-pool/0.5.3/Cargo.toml [INFO] started frobbing tk-pool-0.5.3 [INFO] finished frobbing tk-pool-0.5.3 [INFO] frobbed toml for tk-pool-0.5.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tk-pool/0.5.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tk-pool-0.5.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/tk-pool/0.5.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fbd8cb4e25f06abf130927b42d659491912f7e96c7f99aed7e9255a3d96e3ed7 [INFO] running `"docker" "start" "-a" "fbd8cb4e25f06abf130927b42d659491912f7e96c7f99aed7e9255a3d96e3ed7"` [INFO] [stderr] Checking async-slot v0.1.0 [INFO] [stderr] Checking abstract-ns v0.4.3 [INFO] [stderr] Checking tk-bufstream v0.3.0 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Checking ns-std-threaded v0.3.0 [INFO] [stderr] Checking tk-pool v0.5.3 (/opt/crater/workdir) [INFO] [stderr] Checking ns-router v0.1.6 [INFO] [stderr] Checking tk-http v0.3.9 [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/basic.rs:10:9 [INFO] [stderr] | [INFO] [stderr] 10 | connector: connector, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `connector` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:230:13 [INFO] [stderr] | [INFO] [stderr] 230 | metrics: metrics, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `metrics` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:244:13 [INFO] [stderr] | [INFO] [stderr] 244 | errors: errors, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `errors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/queue.rs:76:9 [INFO] [stderr] | [INFO] [stderr] 76 | / return Pool { [INFO] [stderr] 77 | | channel: tx, [INFO] [stderr] 78 | | metrics, [INFO] [stderr] 79 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 76 | Pool { [INFO] [stderr] 77 | channel: tx, [INFO] [stderr] 78 | metrics, [INFO] [stderr] 79 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/uniform/aligner.rs:87:9 [INFO] [stderr] | [INFO] [stderr] 87 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/uniform/chan.rs:60:9 [INFO] [stderr] | [INFO] [stderr] 60 | return Helper { inner } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Helper { inner }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/uniform/chan.rs:122:9 [INFO] [stderr] | [INFO] [stderr] 122 | res [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/uniform/chan.rs:121:19 [INFO] [stderr] | [INFO] [stderr] 121 | let res = cell.request.take(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/uniform/failures.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | return self.addrs.contains(&addr); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.addrs.contains(&addr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: digits grouped inconsistently by underscores [INFO] [stderr] --> src/uniform/mod.rs:126:54 [INFO] [stderr] | [INFO] [stderr] 126 | (self.reconnect_timeout.subsec_nanos() / 1000_000) as u64; [INFO] [stderr] | ^^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::inconsistent_digit_grouping)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/uniform/mod.rs:167:9 [INFO] [stderr] | [INFO] [stderr] 167 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/uniform/mod.rs:206:9 [INFO] [stderr] | [INFO] [stderr] 206 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/uniform/mod.rs:274:13 [INFO] [stderr] | [INFO] [stderr] 274 | return Ok(AsyncSink::NotReady(v)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(AsyncSink::NotReady(v))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/uniform/mod.rs:338:9 [INFO] [stderr] | [INFO] [stderr] 338 | return Ok(Async::NotReady); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Async::NotReady)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/uniform/mod.rs:346:9 [INFO] [stderr] | [INFO] [stderr] 346 | return Ok(Async::NotReady); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Async::NotReady)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/uniform/aligner.rs:37:17 [INFO] [stderr] | [INFO] [stderr] 37 | / match self.items.entry(n) { [INFO] [stderr] 38 | | Occupied(mut o) => { [INFO] [stderr] 39 | | o.get_mut().remove(&addr); [INFO] [stderr] 40 | | if o.get().len() == 0 { [INFO] [stderr] ... | [INFO] [stderr] 44 | | _ => {} [INFO] [stderr] 45 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 37 | if let Occupied(mut o) = self.items.entry(n) { [INFO] [stderr] 38 | o.get_mut().remove(&addr); [INFO] [stderr] 39 | if o.get().len() == 0 { [INFO] [stderr] 40 | o.remove_entry(); [INFO] [stderr] 41 | } [INFO] [stderr] 42 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/uniform/aligner.rs:40:28 [INFO] [stderr] | [INFO] [stderr] 40 | if o.get().len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `o.get().is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/uniform/aligner.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | / match self.items.entry(0) { [INFO] [stderr] 50 | | Occupied(o) => { [INFO] [stderr] 51 | | if o.get().len() == 0 { [INFO] [stderr] 52 | | o.remove_entry(); [INFO] [stderr] ... | [INFO] [stderr] 55 | | _ => {} [INFO] [stderr] 56 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 49 | if let Occupied(o) = self.items.entry(0) { [INFO] [stderr] 50 | if o.get().len() == 0 { [INFO] [stderr] 51 | o.remove_entry(); [INFO] [stderr] 52 | } [INFO] [stderr] 53 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/uniform/aligner.rs:51:20 [INFO] [stderr] | [INFO] [stderr] 51 | if o.get().len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `o.get().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/uniform/aligner.rs:68:17 [INFO] [stderr] | [INFO] [stderr] 68 | addrs.iter().filter(|&&x| !blist(x)).map(|&x| x), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `addrs.iter().filter(|&&x| !blist(x)).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/uniform/aligner.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | / match self.items.entry(*num) { [INFO] [stderr] 93 | | Occupied(mut o) => { [INFO] [stderr] 94 | | o.get_mut().remove(&addr); [INFO] [stderr] 95 | | if o.get().len() == 0 { [INFO] [stderr] ... | [INFO] [stderr] 99 | | _ => {} [INFO] [stderr] 100 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 92 | if let Occupied(mut o) = self.items.entry(*num) { [INFO] [stderr] 93 | o.get_mut().remove(&addr); [INFO] [stderr] 94 | if o.get().len() == 0 { [INFO] [stderr] 95 | o.remove_entry(); [INFO] [stderr] 96 | } [INFO] [stderr] 97 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/uniform/aligner.rs:95:24 [INFO] [stderr] | [INFO] [stderr] 95 | if o.get().len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `o.get().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/uniform/chan.rs:114:9 [INFO] [stderr] | [INFO] [stderr] 114 | inner.task.as_ref().map(|x| x.notify()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(x) = inner.task.as_ref() { x.notify() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/uniform/chan.rs:128:9 [INFO] [stderr] | [INFO] [stderr] 128 | inner.task.as_ref().map(|x| x.notify()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(x) = inner.task.as_ref() { x.notify() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/uniform/pool.rs:22:30 [INFO] [stderr] | [INFO] [stderr] 22 | pub(in uniform) futures: FuturesUnordered::Item>, [INFO] [stderr] 24 | | Error=FutureErr>>>, [INFO] [stderr] | |____________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/uniform/pool.rs:25:34 [INFO] [stderr] | [INFO] [stderr] 25 | pub(in uniform) connections: Rc::Future as Future>::Item as Sink>::SinkItem>>>, [INFO] [stderr] | |_______________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/uniform/mod.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | self.queue.len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.queue.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/uniform/mod.rs:126:13 [INFO] [stderr] | [INFO] [stderr] 126 | (self.reconnect_timeout.subsec_nanos() / 1000_000) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.reconnect_timeout.subsec_nanos() / 1000_000)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Calling `subsec_millis()` is more concise than this calculation [INFO] [stderr] --> src/uniform/mod.rs:126:13 [INFO] [stderr] | [INFO] [stderr] 126 | (self.reconnect_timeout.subsec_nanos() / 1000_000) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.reconnect_timeout.subsec_millis()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::duration_subsec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duration_subsec [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/uniform/mod.rs:193:13 [INFO] [stderr] | [INFO] [stderr] 193 | let ref blist = self.blist; [INFO] [stderr] | ----^^^^^^^^^-------------- help: try: `let blist = &self.blist;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/uniform/mod.rs:271:16 [INFO] [stderr] | [INFO] [stderr] 271 | if self.futures.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.futures.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/uniform/mod.rs:326:16 [INFO] [stderr] | [INFO] [stderr] 326 | if self.futures.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.futures.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/uniform/mod.rs:343:12 [INFO] [stderr] | [INFO] [stderr] 343 | if self.futures.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.futures.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/basic.rs:10:9 [INFO] [stderr] | [INFO] [stderr] 10 | connector: connector, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `connector` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:230:13 [INFO] [stderr] | [INFO] [stderr] 230 | metrics: metrics, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `metrics` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:244:13 [INFO] [stderr] | [INFO] [stderr] 244 | errors: errors, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `errors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/queue.rs:76:9 [INFO] [stderr] | [INFO] [stderr] 76 | / return Pool { [INFO] [stderr] 77 | | channel: tx, [INFO] [stderr] 78 | | metrics, [INFO] [stderr] 79 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 76 | Pool { [INFO] [stderr] 77 | channel: tx, [INFO] [stderr] 78 | metrics, [INFO] [stderr] 79 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/uniform/aligner.rs:87:9 [INFO] [stderr] | [INFO] [stderr] 87 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/uniform/chan.rs:60:9 [INFO] [stderr] | [INFO] [stderr] 60 | return Helper { inner } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Helper { inner }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/uniform/chan.rs:122:9 [INFO] [stderr] | [INFO] [stderr] 122 | res [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/uniform/chan.rs:121:19 [INFO] [stderr] | [INFO] [stderr] 121 | let res = cell.request.take(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/uniform/failures.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | return self.addrs.contains(&addr); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.addrs.contains(&addr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: digits grouped inconsistently by underscores [INFO] [stderr] --> src/uniform/mod.rs:126:54 [INFO] [stderr] | [INFO] [stderr] 126 | (self.reconnect_timeout.subsec_nanos() / 1000_000) as u64; [INFO] [stderr] | ^^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::inconsistent_digit_grouping)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/uniform/mod.rs:167:9 [INFO] [stderr] | [INFO] [stderr] 167 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/uniform/mod.rs:206:9 [INFO] [stderr] | [INFO] [stderr] 206 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/uniform/mod.rs:274:13 [INFO] [stderr] | [INFO] [stderr] 274 | return Ok(AsyncSink::NotReady(v)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(AsyncSink::NotReady(v))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/uniform/mod.rs:338:9 [INFO] [stderr] | [INFO] [stderr] 338 | return Ok(Async::NotReady); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Async::NotReady)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/uniform/mod.rs:346:9 [INFO] [stderr] | [INFO] [stderr] 346 | return Ok(Async::NotReady); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Async::NotReady)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/uniform/aligner.rs:37:17 [INFO] [stderr] | [INFO] [stderr] 37 | / match self.items.entry(n) { [INFO] [stderr] 38 | | Occupied(mut o) => { [INFO] [stderr] 39 | | o.get_mut().remove(&addr); [INFO] [stderr] 40 | | if o.get().len() == 0 { [INFO] [stderr] ... | [INFO] [stderr] 44 | | _ => {} [INFO] [stderr] 45 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 37 | if let Occupied(mut o) = self.items.entry(n) { [INFO] [stderr] 38 | o.get_mut().remove(&addr); [INFO] [stderr] 39 | if o.get().len() == 0 { [INFO] [stderr] 40 | o.remove_entry(); [INFO] [stderr] 41 | } [INFO] [stderr] 42 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/uniform/aligner.rs:40:28 [INFO] [stderr] | [INFO] [stderr] 40 | if o.get().len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `o.get().is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/uniform/aligner.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | / match self.items.entry(0) { [INFO] [stderr] 50 | | Occupied(o) => { [INFO] [stderr] 51 | | if o.get().len() == 0 { [INFO] [stderr] 52 | | o.remove_entry(); [INFO] [stderr] ... | [INFO] [stderr] 55 | | _ => {} [INFO] [stderr] 56 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 49 | if let Occupied(o) = self.items.entry(0) { [INFO] [stderr] 50 | if o.get().len() == 0 { [INFO] [stderr] 51 | o.remove_entry(); [INFO] [stderr] 52 | } [INFO] [stderr] 53 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/uniform/aligner.rs:51:20 [INFO] [stderr] | [INFO] [stderr] 51 | if o.get().len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `o.get().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/uniform/aligner.rs:68:17 [INFO] [stderr] | [INFO] [stderr] 68 | addrs.iter().filter(|&&x| !blist(x)).map(|&x| x), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `addrs.iter().filter(|&&x| !blist(x)).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/uniform/aligner.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | / match self.items.entry(*num) { [INFO] [stderr] 93 | | Occupied(mut o) => { [INFO] [stderr] 94 | | o.get_mut().remove(&addr); [INFO] [stderr] 95 | | if o.get().len() == 0 { [INFO] [stderr] ... | [INFO] [stderr] 99 | | _ => {} [INFO] [stderr] 100 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 92 | if let Occupied(mut o) = self.items.entry(*num) { [INFO] [stderr] 93 | o.get_mut().remove(&addr); [INFO] [stderr] 94 | if o.get().len() == 0 { [INFO] [stderr] 95 | o.remove_entry(); [INFO] [stderr] 96 | } [INFO] [stderr] 97 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/uniform/aligner.rs:95:24 [INFO] [stderr] | [INFO] [stderr] 95 | if o.get().len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `o.get().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/uniform/chan.rs:114:9 [INFO] [stderr] | [INFO] [stderr] 114 | inner.task.as_ref().map(|x| x.notify()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(x) = inner.task.as_ref() { x.notify() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/uniform/chan.rs:128:9 [INFO] [stderr] | [INFO] [stderr] 128 | inner.task.as_ref().map(|x| x.notify()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(x) = inner.task.as_ref() { x.notify() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/uniform/pool.rs:22:30 [INFO] [stderr] | [INFO] [stderr] 22 | pub(in uniform) futures: FuturesUnordered::Item>, [INFO] [stderr] 24 | | Error=FutureErr>>>, [INFO] [stderr] | |____________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/uniform/pool.rs:25:34 [INFO] [stderr] | [INFO] [stderr] 25 | pub(in uniform) connections: Rc::Future as Future>::Item as Sink>::SinkItem>>>, [INFO] [stderr] | |_______________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/uniform/mod.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | self.queue.len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.queue.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/uniform/mod.rs:126:13 [INFO] [stderr] | [INFO] [stderr] 126 | (self.reconnect_timeout.subsec_nanos() / 1000_000) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.reconnect_timeout.subsec_nanos() / 1000_000)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Calling `subsec_millis()` is more concise than this calculation [INFO] [stderr] --> src/uniform/mod.rs:126:13 [INFO] [stderr] | [INFO] [stderr] 126 | (self.reconnect_timeout.subsec_nanos() / 1000_000) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.reconnect_timeout.subsec_millis()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::duration_subsec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duration_subsec [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/uniform/mod.rs:193:13 [INFO] [stderr] | [INFO] [stderr] 193 | let ref blist = self.blist; [INFO] [stderr] | ----^^^^^^^^^-------------- help: try: `let blist = &self.blist;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/uniform/mod.rs:271:16 [INFO] [stderr] | [INFO] [stderr] 271 | if self.futures.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.futures.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/uniform/mod.rs:326:16 [INFO] [stderr] | [INFO] [stderr] 326 | if self.futures.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.futures.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/uniform/mod.rs:343:12 [INFO] [stderr] | [INFO] [stderr] 343 | if self.futures.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.futures.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> examples/http.rs:23:12 [INFO] [stderr] | [INFO] [stderr] 23 | if let Err(_) = env::var("RUST_LOG") { [INFO] [stderr] | _____- ^^^^^^ [INFO] [stderr] 24 | | env::set_var("RUST_LOG", "warn"); [INFO] [stderr] 25 | | } [INFO] [stderr] | |_____- help: try this: `if env::var("RUST_LOG").is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 21.53s [INFO] running `"docker" "inspect" "fbd8cb4e25f06abf130927b42d659491912f7e96c7f99aed7e9255a3d96e3ed7"` [INFO] running `"docker" "rm" "-f" "fbd8cb4e25f06abf130927b42d659491912f7e96c7f99aed7e9255a3d96e3ed7"` [INFO] [stdout] fbd8cb4e25f06abf130927b42d659491912f7e96c7f99aed7e9255a3d96e3ed7