[INFO] crate tk-opc 0.1.3 is already in cache
[INFO] extracting crate tk-opc 0.1.3 into work/ex/clippy-test-run/sources/stable/reg/tk-opc/0.1.3
[INFO] extracting crate tk-opc 0.1.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tk-opc/0.1.3
[INFO] validating manifest of tk-opc-0.1.3 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of tk-opc-0.1.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing tk-opc-0.1.3
[INFO] finished frobbing tk-opc-0.1.3
[INFO] frobbed toml for tk-opc-0.1.3 written to work/ex/clippy-test-run/sources/stable/reg/tk-opc/0.1.3/Cargo.toml
[INFO] started frobbing tk-opc-0.1.3
[INFO] finished frobbing tk-opc-0.1.3
[INFO] frobbed toml for tk-opc-0.1.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tk-opc/0.1.3/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting tk-opc-0.1.3 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/tk-opc/0.1.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 027665b55b200b6dcb060cd5e2f0d1b70ca34d910f0996ba0330bddc66817e34
[INFO] running `"docker" "start" "-a" "027665b55b200b6dcb060cd5e2f0d1b70ca34d910f0996ba0330bddc66817e34"`
[INFO] [stderr]     Checking tk-opc v0.1.3 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/pixel.rs:14:13
[INFO] [stderr]    |
[INFO] [stderr] 14 |             x: x,
[INFO] [stderr]    |             ^^^^ help: replace it with: `x`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:52:13
[INFO] [stderr]    |
[INFO] [stderr] 52 |             channel: channel,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^ help: replace it with: `channel`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:66:6
[INFO] [stderr]    |
[INFO] [stderr] 66 |      command: command,
[INFO] [stderr]    |      ^^^^^^^^^^^^^^^^ help: replace it with: `command`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/pixel.rs:14:13
[INFO] [stderr]    |
[INFO] [stderr] 14 |             x: x,
[INFO] [stderr]    |             ^^^^ help: replace it with: `x`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:52:13
[INFO] [stderr]    |
[INFO] [stderr] 52 |             channel: channel,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^ help: replace it with: `channel`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:66:6
[INFO] [stderr]    |
[INFO] [stderr] 66 |      command: command,
[INFO] [stderr]    |      ^^^^^^^^^^^^^^^^ help: replace it with: `command`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/pixel.rs:99:27
[INFO] [stderr]    |
[INFO] [stderr] 99 |         self.p.next().map(|x| OpcPixel::new(x))
[INFO] [stderr]    |                           ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `OpcPixel::new`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/pixel.rs:103:27
[INFO] [stderr]     |
[INFO] [stderr] 103 |         self.p.nth(n).map(|x| OpcPixel::new(x))
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `OpcPixel::new`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/pixel.rs:128:27
[INFO] [stderr]     |
[INFO] [stderr] 128 |         self.p.next().map(|x| OpcPixel::new(x))
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `OpcPixel::new`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/pixel.rs:132:27
[INFO] [stderr]     |
[INFO] [stderr] 132 |         self.p.nth(n).map(|x| OpcPixel::new(x))
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `OpcPixel::new`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/sysexclusive.rs:26:14
[INFO] [stderr]    |
[INFO] [stderr] 26 |             ((self.sys_exclusive[1] as u16) << 8) + (self.sys_exclusive[0] as u16)
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.sys_exclusive[1])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/sysexclusive.rs:26:53
[INFO] [stderr]    |
[INFO] [stderr] 26 |             ((self.sys_exclusive[1] as u16) << 8) + (self.sys_exclusive[0] as u16)
[INFO] [stderr]    |                                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.sys_exclusive[0])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/lib.rs:87:23
[INFO] [stderr]    |
[INFO] [stderr] 87 |             length: (((buf[2] as u16) << 8) + (buf[3] as u16)),
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^ help: try: `u16::from(buf[2])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/lib.rs:87:47
[INFO] [stderr]    |
[INFO] [stderr] 87 |             length: (((buf[2] as u16) << 8) + (buf[3] as u16)),
[INFO] [stderr]    |                                               ^^^^^^^^^^^^^^^ help: try: `u16::from(buf[3])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/lib.rs:98:23
[INFO] [stderr]    |
[INFO] [stderr] 98 |             length: (((buf[2] as u16) << 8) + (buf[3] as u16)),
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^ help: try: `u16::from(buf[2])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/lib.rs:98:47
[INFO] [stderr]    |
[INFO] [stderr] 98 |             length: (((buf[2] as u16) << 8) + (buf[3] as u16)),
[INFO] [stderr]    |                                               ^^^^^^^^^^^^^^^ help: try: `u16::from(buf[3])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:102:21
[INFO] [stderr]     |
[INFO] [stderr] 102 |     pub fn to_bytes(&self) -> [u8;4] {
[INFO] [stderr]     |                     ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:109:44
[INFO] [stderr]     |
[INFO] [stderr] 109 |     pub fn write_header<T: std::io::Write>(&self, w: &mut T) -> std::io::Result<()> {
[INFO] [stderr]     |                                            ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/pixel.rs:99:27
[INFO] [stderr]    |
[INFO] [stderr] 99 |         self.p.next().map(|x| OpcPixel::new(x))
[INFO] [stderr]    |                           ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `OpcPixel::new`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/pixel.rs:103:27
[INFO] [stderr]     |
[INFO] [stderr] 103 |         self.p.nth(n).map(|x| OpcPixel::new(x))
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `OpcPixel::new`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/pixel.rs:128:27
[INFO] [stderr]     |
[INFO] [stderr] 128 |         self.p.next().map(|x| OpcPixel::new(x))
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `OpcPixel::new`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/pixel.rs:132:27
[INFO] [stderr]     |
[INFO] [stderr] 132 |         self.p.nth(n).map(|x| OpcPixel::new(x))
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `OpcPixel::new`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/sysexclusive.rs:26:14
[INFO] [stderr]    |
[INFO] [stderr] 26 |             ((self.sys_exclusive[1] as u16) << 8) + (self.sys_exclusive[0] as u16)
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.sys_exclusive[1])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/sysexclusive.rs:26:53
[INFO] [stderr]    |
[INFO] [stderr] 26 |             ((self.sys_exclusive[1] as u16) << 8) + (self.sys_exclusive[0] as u16)
[INFO] [stderr]    |                                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.sys_exclusive[0])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/lib.rs:87:23
[INFO] [stderr]    |
[INFO] [stderr] 87 |             length: (((buf[2] as u16) << 8) + (buf[3] as u16)),
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^ help: try: `u16::from(buf[2])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/lib.rs:87:47
[INFO] [stderr]    |
[INFO] [stderr] 87 |             length: (((buf[2] as u16) << 8) + (buf[3] as u16)),
[INFO] [stderr]    |                                               ^^^^^^^^^^^^^^^ help: try: `u16::from(buf[3])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/lib.rs:98:23
[INFO] [stderr]    |
[INFO] [stderr] 98 |             length: (((buf[2] as u16) << 8) + (buf[3] as u16)),
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^ help: try: `u16::from(buf[2])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/lib.rs:98:47
[INFO] [stderr]    |
[INFO] [stderr] 98 |             length: (((buf[2] as u16) << 8) + (buf[3] as u16)),
[INFO] [stderr]    |                                               ^^^^^^^^^^^^^^^ help: try: `u16::from(buf[3])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:102:21
[INFO] [stderr]     |
[INFO] [stderr] 102 |     pub fn to_bytes(&self) -> [u8;4] {
[INFO] [stderr]     |                     ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:109:44
[INFO] [stderr]     |
[INFO] [stderr] 109 |     pub fn write_header<T: std::io::Write>(&self, w: &mut T) -> std::io::Result<()> {
[INFO] [stderr]     |                                            ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 2.01s
[INFO] running `"docker" "inspect" "027665b55b200b6dcb060cd5e2f0d1b70ca34d910f0996ba0330bddc66817e34"`
[INFO] running `"docker" "rm" "-f" "027665b55b200b6dcb060cd5e2f0d1b70ca34d910f0996ba0330bddc66817e34"`
[INFO] [stdout] 027665b55b200b6dcb060cd5e2f0d1b70ca34d910f0996ba0330bddc66817e34