[INFO] crate tk-listen 0.2.0 is already in cache [INFO] extracting crate tk-listen 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/tk-listen/0.2.0 [INFO] extracting crate tk-listen 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tk-listen/0.2.0 [INFO] validating manifest of tk-listen-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tk-listen-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tk-listen-0.2.0 [INFO] finished frobbing tk-listen-0.2.0 [INFO] frobbed toml for tk-listen-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/tk-listen/0.2.0/Cargo.toml [INFO] started frobbing tk-listen-0.2.0 [INFO] finished frobbing tk-listen-0.2.0 [INFO] frobbed toml for tk-listen-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tk-listen/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tk-listen-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/tk-listen/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 423cab4f151d9e8eb60dd4107fdab4b0dcb4ab2aeb879a960e7f6e9571bbdbe8 [INFO] running `"docker" "start" "-a" "423cab4f151d9e8eb60dd4107fdab4b0dcb4ab2aeb879a960e7f6e9571bbdbe8"` [INFO] [stderr] Checking sha1 v0.4.0 [INFO] [stderr] Checking async-slot v0.1.0 [INFO] [stderr] Checking abstract-ns v0.4.3 [INFO] [stderr] Checking url v1.7.2 [INFO] [stderr] Checking tk-bufstream v0.3.0 [INFO] [stderr] Checking parking_lot_core v0.4.0 [INFO] [stderr] Checking ns-std-threaded v0.3.0 [INFO] [stderr] Checking parking_lot v0.7.1 [INFO] [stderr] Checking crossbeam v0.6.0 [INFO] [stderr] Checking tokio-reactor v0.1.8 [INFO] [stderr] Checking tokio-threadpool v0.1.11 [INFO] [stderr] Checking tokio-udp v0.1.3 [INFO] [stderr] Checking tokio-tcp v0.1.3 [INFO] [stderr] Checking tokio-uds v0.2.5 [INFO] [stderr] Checking tokio-fs v0.1.5 [INFO] [stderr] Checking tokio v0.1.15 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Checking tk-listen v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sleep_on_error.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | stream: stream, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sleep_on_error.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | delay: delay, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `delay` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bind.rs:207:9 [INFO] [stderr] | [INFO] [stderr] 207 | return Ok(Async::NotReady); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Async::NotReady)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio::net::Incoming': use `tokio::net::tcp::Incoming` instead [INFO] [stderr] --> src/bind.rs:8:31 [INFO] [stderr] | [INFO] [stderr] 8 | use tokio::net::{TcpListener, Incoming, TcpStream}; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio::net::Incoming': use `tokio::net::tcp::Incoming` instead [INFO] [stderr] --> src/bind.rs:81:33 [INFO] [stderr] | [INFO] [stderr] 81 | inputs: HashMap, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bind.rs:149:24 [INFO] [stderr] | [INFO] [stderr] 149 | if backlog.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!backlog.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bind.rs:182:28 [INFO] [stderr] | [INFO] [stderr] 182 | if backlog.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!backlog.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/bind.rs:197:13 [INFO] [stderr] | [INFO] [stderr] 197 | / loop { [INFO] [stderr] 198 | | match inp.poll() { [INFO] [stderr] 199 | | Ok(Async::Ready(pair)) => { [INFO] [stderr] 200 | | return Ok(Async::Ready(pair)); [INFO] [stderr] ... | [INFO] [stderr] 204 | | } [INFO] [stderr] 205 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `tk-listen`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "423cab4f151d9e8eb60dd4107fdab4b0dcb4ab2aeb879a960e7f6e9571bbdbe8"` [INFO] running `"docker" "rm" "-f" "423cab4f151d9e8eb60dd4107fdab4b0dcb4ab2aeb879a960e7f6e9571bbdbe8"` [INFO] [stdout] 423cab4f151d9e8eb60dd4107fdab4b0dcb4ab2aeb879a960e7f6e9571bbdbe8