[INFO] crate tk-carbon 0.2.0 is already in cache
[INFO] extracting crate tk-carbon 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/tk-carbon/0.2.0
[INFO] extracting crate tk-carbon 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tk-carbon/0.2.0
[INFO] validating manifest of tk-carbon-0.2.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of tk-carbon-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing tk-carbon-0.2.0
[INFO] finished frobbing tk-carbon-0.2.0
[INFO] frobbed toml for tk-carbon-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/tk-carbon/0.2.0/Cargo.toml
[INFO] started frobbing tk-carbon-0.2.0
[INFO] finished frobbing tk-carbon-0.2.0
[INFO] frobbed toml for tk-carbon-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tk-carbon/0.2.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting tk-carbon-0.2.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/tk-carbon/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] a8348ccbb7aba33b8aadac2c1c35474dc75cfe9bdaf5ba86471de77a8e924c90
[INFO] running `"docker" "start" "-a" "a8348ccbb7aba33b8aadac2c1c35474dc75cfe9bdaf5ba86471de77a8e924c90"`
[INFO] [stderr]     Checking netbuf v0.4.1
[INFO] [stderr]     Checking async-slot v0.1.0
[INFO] [stderr]     Checking abstract-ns v0.4.3
[INFO] [stderr]     Checking crossbeam v0.6.0
[INFO] [stderr]     Checking tokio-uds v0.2.5
[INFO] [stderr]     Checking tokio-tcp v0.1.3
[INFO] [stderr]     Checking tokio-udp v0.1.3
[INFO] [stderr]     Checking tk-bufstream v0.3.0
[INFO] [stderr]     Checking ns-std-threaded v0.3.0
[INFO] [stderr]     Checking tokio-threadpool v0.1.11
[INFO] [stderr]     Checking tokio-fs v0.1.5
[INFO] [stderr]     Checking tokio v0.1.15
[INFO] [stderr]     Checking tokio-core v0.1.17
[INFO] [stderr]     Checking ns-router v0.1.6
[INFO] [stderr]     Checking tk-carbon v0.2.0 (/opt/crater/workdir)
[INFO] [stderr]     Checking tk-easyloop v0.1.1
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/pool.rs:53:13
[INFO] [stderr]    |
[INFO] [stderr] 53 |             address_stream: address_stream,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `address_stream`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/channel.rs:31:9
[INFO] [stderr]    |
[INFO] [stderr] 31 |         max_metrics_buffered: max_metrics_buffered,
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_metrics_buffered`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/public.rs:26:9
[INFO] [stderr]    |
[INFO] [stderr] 26 | /         return (
[INFO] [stderr] 27 | |             Carbon {
[INFO] [stderr] 28 | |                 chan: tx,
[INFO] [stderr] 29 | |             },
[INFO] [stderr] ...  |
[INFO] [stderr] 33 | |             }
[INFO] [stderr] 34 | |         )
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 26 |         (
[INFO] [stderr] 27 |             Carbon {
[INFO] [stderr] 28 |                 chan: tx,
[INFO] [stderr] 29 |             },
[INFO] [stderr] 30 |             Init {
[INFO] [stderr] 31 |                 chan: rx,
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/proto.rs:67:9
[INFO] [stderr]    |
[INFO] [stderr] 67 |         return Ok(Async::NotReady);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Async::NotReady)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/pool.rs:333:20
[INFO] [stderr]     |
[INFO] [stderr] 333 |               } else {
[INFO] [stderr]     |  ____________________^
[INFO] [stderr] 334 | |                 if self.deadline < Instant::now() {
[INFO] [stderr] 335 | |                     return Err(io::ErrorKind::TimedOut.into());
[INFO] [stderr] 336 | |                 }
[INFO] [stderr] 337 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 333 |             } else if self.deadline < Instant::now() {
[INFO] [stderr] 334 |     return Err(io::ErrorKind::TimedOut.into());
[INFO] [stderr] 335 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]  --> src/config.rs:7:5
[INFO] [stderr]   |
[INFO] [stderr] 7 |     return dur.as_secs() + (dur.subsec_nanos() / 1000000) as u64;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `dur.as_secs() + (dur.subsec_nanos() / 1000000) as u64`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]  --> src/config.rs:7:50
[INFO] [stderr]   |
[INFO] [stderr] 7 |     return dur.as_secs() + (dur.subsec_nanos() / 1000000) as u64;
[INFO] [stderr]   |                                                  ^^^^^^^ help: consider: `1_000_000`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/channel.rs:55:9
[INFO] [stderr]    |
[INFO] [stderr] 55 | /         return (
[INFO] [stderr] 56 | |             self.buffered.load(Ordering::Relaxed),
[INFO] [stderr] 57 | |             self.max_metrics_buffered,
[INFO] [stderr] 58 | |         )
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 55 |         (
[INFO] [stderr] 56 |             self.buffered.load(Ordering::Relaxed),
[INFO] [stderr] 57 |             self.max_metrics_buffered,
[INFO] [stderr] 58 |         )
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/pool.rs:53:13
[INFO] [stderr]    |
[INFO] [stderr] 53 |             address_stream: address_stream,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `address_stream`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/channel.rs:31:9
[INFO] [stderr]    |
[INFO] [stderr] 31 |         max_metrics_buffered: max_metrics_buffered,
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_metrics_buffered`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]   --> src/public.rs:83:27
[INFO] [stderr]    |
[INFO] [stderr] 83 |             .filter(|&&x| x == b' ' || x == b'\n' || x == b'\n')
[INFO] [stderr]    |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::nonminimal_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 83 |             .filter(|&&x| x == b'\n' || x == b' ')
[INFO] [stderr]    |                           ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 83 |             .filter(|&&x| !(x != b' ' && x != b'\n'))
[INFO] [stderr]    |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name
[INFO] [stderr]   --> src/proto.rs:24:31
[INFO] [stderr]    |
[INFO] [stderr] 24 |     pub fn from_connection<T>(self, conn: T, handle: &Handle)
[INFO] [stderr]    |                               ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/proto.rs:43:12
[INFO] [stderr]    |
[INFO] [stderr] 43 |         if self.io.in_buf.len() > 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.io.in_buf.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/proto.rs:64:38
[INFO] [stderr]    |
[INFO] [stderr] 64 |         if self.channel.is_done() && self.io.out_buf.len() == 0 {
[INFO] [stderr]    |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.io.out_buf.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]   --> src/pool.rs:31:14
[INFO] [stderr]    |
[INFO] [stderr] 31 |       pending: VecDeque<(SocketAddr,
[INFO] [stderr]    |  ______________^
[INFO] [stderr] 32 | |                        Box<Future<Item=Conn<TcpStream>, Error=io::Error>>)>,
[INFO] [stderr]    | |___________________________________________________________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::type_complexity)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/pool.rs:209:23
[INFO] [stderr]     |
[INFO] [stderr] 209 |             } else if c.io.in_buf.len() > 0 {
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!c.io.in_buf.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/pool.rs:225:23
[INFO] [stderr]     |
[INFO] [stderr] 225 |             } else if c.io.in_buf.len() > 0 {
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!c.io.in_buf.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/pool.rs:259:12
[INFO] [stderr]     |
[INFO] [stderr] 259 |         if self.normal.len() == 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.normal.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]  --> src/config.rs:7:28
[INFO] [stderr]   |
[INFO] [stderr] 7 |     return dur.as_secs() + (dur.subsec_nanos() / 1000000) as u64;
[INFO] [stderr]   |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(dur.subsec_nanos() / 1000000)`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: Calling `subsec_millis()` is more concise than this calculation
[INFO] [stderr]  --> src/config.rs:7:28
[INFO] [stderr]   |
[INFO] [stderr] 7 |     return dur.as_secs() + (dur.subsec_nanos() / 1000000) as u64;
[INFO] [stderr]   |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `dur.subsec_millis()`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::duration_subsec)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duration_subsec
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Config`
[INFO] [stderr]   --> src/config.rs:12:5
[INFO] [stderr]    |
[INFO] [stderr] 12 | /     pub fn new() -> Config {
[INFO] [stderr] 13 | |         Config {
[INFO] [stderr] 14 | |             write_timeout: Duration::new(10, 0),
[INFO] [stderr] 15 | |             watermarks: (60_000, 1_048_576),
[INFO] [stderr] ...  |
[INFO] [stderr] 19 | |         }
[INFO] [stderr] 20 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 87 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/public.rs:26:9
[INFO] [stderr]    |
[INFO] [stderr] 26 | /         return (
[INFO] [stderr] 27 | |             Carbon {
[INFO] [stderr] 28 | |                 chan: tx,
[INFO] [stderr] 29 | |             },
[INFO] [stderr] ...  |
[INFO] [stderr] 33 | |             }
[INFO] [stderr] 34 | |         )
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 26 |         (
[INFO] [stderr] 27 |             Carbon {
[INFO] [stderr] 28 |                 chan: tx,
[INFO] [stderr] 29 |             },
[INFO] [stderr] 30 |             Init {
[INFO] [stderr] 31 |                 chan: rx,
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/proto.rs:67:9
[INFO] [stderr]    |
[INFO] [stderr] 67 |         return Ok(Async::NotReady);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Async::NotReady)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/pool.rs:333:20
[INFO] [stderr]     |
[INFO] [stderr] 333 |               } else {
[INFO] [stderr]     |  ____________________^
[INFO] [stderr] 334 | |                 if self.deadline < Instant::now() {
[INFO] [stderr] 335 | |                     return Err(io::ErrorKind::TimedOut.into());
[INFO] [stderr] 336 | |                 }
[INFO] [stderr] 337 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 333 |             } else if self.deadline < Instant::now() {
[INFO] [stderr] 334 |     return Err(io::ErrorKind::TimedOut.into());
[INFO] [stderr] 335 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]  --> src/config.rs:7:5
[INFO] [stderr]   |
[INFO] [stderr] 7 |     return dur.as_secs() + (dur.subsec_nanos() / 1000000) as u64;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `dur.as_secs() + (dur.subsec_nanos() / 1000000) as u64`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]  --> src/config.rs:7:50
[INFO] [stderr]   |
[INFO] [stderr] 7 |     return dur.as_secs() + (dur.subsec_nanos() / 1000000) as u64;
[INFO] [stderr]   |                                                  ^^^^^^^ help: consider: `1_000_000`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/channel.rs:55:9
[INFO] [stderr]    |
[INFO] [stderr] 55 | /         return (
[INFO] [stderr] 56 | |             self.buffered.load(Ordering::Relaxed),
[INFO] [stderr] 57 | |             self.max_metrics_buffered,
[INFO] [stderr] 58 | |         )
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 55 |         (
[INFO] [stderr] 56 |             self.buffered.load(Ordering::Relaxed),
[INFO] [stderr] 57 |             self.max_metrics_buffered,
[INFO] [stderr] 58 |         )
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]   --> src/public.rs:83:27
[INFO] [stderr]    |
[INFO] [stderr] 83 |             .filter(|&&x| x == b' ' || x == b'\n' || x == b'\n')
[INFO] [stderr]    |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::nonminimal_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 83 |             .filter(|&&x| x == b'\n' || x == b' ')
[INFO] [stderr]    |                           ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 83 |             .filter(|&&x| !(x != b' ' && x != b'\n'))
[INFO] [stderr]    |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name
[INFO] [stderr]   --> src/proto.rs:24:31
[INFO] [stderr]    |
[INFO] [stderr] 24 |     pub fn from_connection<T>(self, conn: T, handle: &Handle)
[INFO] [stderr]    |                               ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/proto.rs:43:12
[INFO] [stderr]    |
[INFO] [stderr] 43 |         if self.io.in_buf.len() > 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.io.in_buf.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/proto.rs:64:38
[INFO] [stderr]    |
[INFO] [stderr] 64 |         if self.channel.is_done() && self.io.out_buf.len() == 0 {
[INFO] [stderr]    |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.io.out_buf.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]   --> src/pool.rs:31:14
[INFO] [stderr]    |
[INFO] [stderr] 31 |       pending: VecDeque<(SocketAddr,
[INFO] [stderr]    |  ______________^
[INFO] [stderr] 32 | |                        Box<Future<Item=Conn<TcpStream>, Error=io::Error>>)>,
[INFO] [stderr]    | |___________________________________________________________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::type_complexity)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/pool.rs:209:23
[INFO] [stderr]     |
[INFO] [stderr] 209 |             } else if c.io.in_buf.len() > 0 {
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!c.io.in_buf.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/pool.rs:225:23
[INFO] [stderr]     |
[INFO] [stderr] 225 |             } else if c.io.in_buf.len() > 0 {
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!c.io.in_buf.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/pool.rs:259:12
[INFO] [stderr]     |
[INFO] [stderr] 259 |         if self.normal.len() == 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.normal.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]  --> src/config.rs:7:28
[INFO] [stderr]   |
[INFO] [stderr] 7 |     return dur.as_secs() + (dur.subsec_nanos() / 1000000) as u64;
[INFO] [stderr]   |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(dur.subsec_nanos() / 1000000)`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: Calling `subsec_millis()` is more concise than this calculation
[INFO] [stderr]  --> src/config.rs:7:28
[INFO] [stderr]   |
[INFO] [stderr] 7 |     return dur.as_secs() + (dur.subsec_nanos() / 1000000) as u64;
[INFO] [stderr]   |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `dur.subsec_millis()`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::duration_subsec)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duration_subsec
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Config`
[INFO] [stderr]   --> src/config.rs:12:5
[INFO] [stderr]    |
[INFO] [stderr] 12 | /     pub fn new() -> Config {
[INFO] [stderr] 13 | |         Config {
[INFO] [stderr] 14 | |             write_timeout: Duration::new(10, 0),
[INFO] [stderr] 15 | |             watermarks: (60_000, 1_048_576),
[INFO] [stderr] ...  |
[INFO] [stderr] 19 | |         }
[INFO] [stderr] 20 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 87 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> examples/pool.rs:26:38
[INFO] [stderr]    |
[INFO] [stderr] 26 |     let name = args().skip(1).next().unwrap_or("localhost:2003".to_string());
[INFO] [stderr]    |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "localhost:2003".to_string())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)`
[INFO] [stderr]   --> examples/pool.rs:26:16
[INFO] [stderr]    |
[INFO] [stderr] 26 |     let name = args().skip(1).next().unwrap_or("localhost:2003".to_string());
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::iter_skip_next)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 32.34s
[INFO] running `"docker" "inspect" "a8348ccbb7aba33b8aadac2c1c35474dc75cfe9bdaf5ba86471de77a8e924c90"`
[INFO] running `"docker" "rm" "-f" "a8348ccbb7aba33b8aadac2c1c35474dc75cfe9bdaf5ba86471de77a8e924c90"`
[INFO] [stdout] a8348ccbb7aba33b8aadac2c1c35474dc75cfe9bdaf5ba86471de77a8e924c90