[INFO] crate tk-cantal 0.3.2 is already in cache [INFO] extracting crate tk-cantal 0.3.2 into work/ex/clippy-test-run/sources/stable/reg/tk-cantal/0.3.2 [INFO] extracting crate tk-cantal 0.3.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tk-cantal/0.3.2 [INFO] validating manifest of tk-cantal-0.3.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tk-cantal-0.3.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tk-cantal-0.3.2 [INFO] finished frobbing tk-cantal-0.3.2 [INFO] frobbed toml for tk-cantal-0.3.2 written to work/ex/clippy-test-run/sources/stable/reg/tk-cantal/0.3.2/Cargo.toml [INFO] started frobbing tk-cantal-0.3.2 [INFO] finished frobbing tk-cantal-0.3.2 [INFO] frobbed toml for tk-cantal-0.3.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tk-cantal/0.3.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tk-cantal-0.3.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/tk-cantal/0.3.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bb58715410c16655b47a4d07e44560b45a2a0c54669cc372c8ae23b5956384db [INFO] running `"docker" "start" "-a" "bb58715410c16655b47a4d07e44560b45a2a0c54669cc372c8ae23b5956384db"` [INFO] [stderr] Checking netbuf v0.4.1 [INFO] [stderr] Checking serde_millis v0.1.1 [INFO] [stderr] Checking abstract-ns v0.4.3 [INFO] [stderr] Checking tokio-reactor v0.1.8 [INFO] [stderr] Checking tokio-threadpool v0.1.11 [INFO] [stderr] Checking tk-bufstream v0.3.0 [INFO] [stderr] Checking tokio-uds v0.2.5 [INFO] [stderr] Checking tokio-tcp v0.1.3 [INFO] [stderr] Checking tokio-udp v0.1.3 [INFO] [stderr] Checking tokio-fs v0.1.5 [INFO] [stderr] Checking tokio v0.1.15 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Checking tk-pool v0.5.3 [INFO] [stderr] Checking tk-http v0.3.9 [INFO] [stderr] Checking tk-easyloop v0.1.1 [INFO] [stderr] Checking tk-cantal v0.3.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/connect.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | pool: pool, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `pool` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/connect.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | pool: pool, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `pool` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/connect.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | / return Connection { [INFO] [stderr] 52 | | pool: pool, [INFO] [stderr] 53 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 51 | Connection { [INFO] [stderr] 52 | pool: pool, [INFO] [stderr] 53 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/peers.rs:130:9 [INFO] [stderr] | [INFO] [stderr] 130 | return Ok(Async::Ready(data.len())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Async::Ready(data.len()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/connect.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | / return Connection { [INFO] [stderr] 52 | | pool: pool, [INFO] [stderr] 53 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 51 | Connection { [INFO] [stderr] 52 | pool: pool, [INFO] [stderr] 53 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/peers.rs:130:9 [INFO] [stderr] | [INFO] [stderr] 130 | return Ok(Async::Ready(data.len())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Async::Ready(data.len()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> examples/get_peers.rs:10:12 [INFO] [stderr] | [INFO] [stderr] 10 | if let Err(_) = env::var("RUST_LOG") { [INFO] [stderr] | _____- ^^^^^^ [INFO] [stderr] 11 | | env::set_var("RUST_LOG", "warn"); [INFO] [stderr] 12 | | } [INFO] [stderr] | |_____- help: try this: `if env::var("RUST_LOG").is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> examples/monitor_peers.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if let Err(_) = env::var("RUST_LOG") { [INFO] [stderr] | _____- ^^^^^^ [INFO] [stderr] 14 | | env::set_var("RUST_LOG", "warn"); [INFO] [stderr] 15 | | } [INFO] [stderr] | |_____- help: try this: `if env::var("RUST_LOG").is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 35.85s [INFO] running `"docker" "inspect" "bb58715410c16655b47a4d07e44560b45a2a0c54669cc372c8ae23b5956384db"` [INFO] running `"docker" "rm" "-f" "bb58715410c16655b47a4d07e44560b45a2a0c54669cc372c8ae23b5956384db"` [INFO] [stdout] bb58715410c16655b47a4d07e44560b45a2a0c54669cc372c8ae23b5956384db