[INFO] crate tk-bufstream 0.3.0 is already in cache [INFO] extracting crate tk-bufstream 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/tk-bufstream/0.3.0 [INFO] extracting crate tk-bufstream 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tk-bufstream/0.3.0 [INFO] validating manifest of tk-bufstream-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tk-bufstream-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tk-bufstream-0.3.0 [INFO] finished frobbing tk-bufstream-0.3.0 [INFO] frobbed toml for tk-bufstream-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/tk-bufstream/0.3.0/Cargo.toml [INFO] started frobbing tk-bufstream-0.3.0 [INFO] finished frobbing tk-bufstream-0.3.0 [INFO] frobbed toml for tk-bufstream-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tk-bufstream/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tk-bufstream-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/tk-bufstream/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e98ee5b4d9840d6a0ff72cabed3f76f3b0f25e7acd95497408a9daf81138ba61 [INFO] running `"docker" "start" "-a" "e98ee5b4d9840d6a0ff72cabed3f76f3b0f25e7acd95497408a9daf81138ba61"` [INFO] [stderr] Checking tk-bufstream v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/split.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | socket: socket, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `socket` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/split.rs:54:9 [INFO] [stderr] | [INFO] [stderr] 54 | done: done, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `done` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/split.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | socket: socket, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `socket` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/split.rs:54:9 [INFO] [stderr] | [INFO] [stderr] 54 | done: done, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `done` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/iobuf.rs:110:9 [INFO] [stderr] | [INFO] [stderr] 110 | return self.done; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.done` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/split.rs:56:5 [INFO] [stderr] | [INFO] [stderr] 56 | / return ( [INFO] [stderr] 57 | | WriteBuf { [INFO] [stderr] 58 | | out_buf: in_buf, [INFO] [stderr] 59 | | shared: b, [INFO] [stderr] ... | [INFO] [stderr] 63 | | shared: a, [INFO] [stderr] 64 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 56 | ( [INFO] [stderr] 57 | WriteBuf { [INFO] [stderr] 58 | out_buf: in_buf, [INFO] [stderr] 59 | shared: b, [INFO] [stderr] 60 | }, [INFO] [stderr] 61 | ReadBuf { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/split.rs:258:9 [INFO] [stderr] | [INFO] [stderr] 258 | return Ok(Async::NotReady); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Async::NotReady)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mock.rs:84:9 [INFO] [stderr] | [INFO] [stderr] 84 | return buf.drain(..num).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `buf.drain(..num).collect()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mock.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | return Ok(bytes); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(bytes)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mock.rs:105:9 [INFO] [stderr] | [INFO] [stderr] 105 | return Ok(buf.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(buf.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> src/lib.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[warn(missing_docs)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![warn(missing_docs)]` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::useless_attribute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/iobuf.rs:72:16 [INFO] [stderr] | [INFO] [stderr] 72 | if self.out_buf.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.out_buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/iobuf.rs:181:9 [INFO] [stderr] | [INFO] [stderr] 181 | self.out_buf.write(buf)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/flushed.rs:19:16 [INFO] [stderr] | [INFO] [stderr] 19 | if conn.out_buf.len() > 0 && !conn.done() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!conn.out_buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/iobuf.rs:110:9 [INFO] [stderr] | [INFO] [stderr] 110 | return self.done; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.done` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/split.rs:56:5 [INFO] [stderr] | [INFO] [stderr] 56 | / return ( [INFO] [stderr] 57 | | WriteBuf { [INFO] [stderr] 58 | | out_buf: in_buf, [INFO] [stderr] 59 | | shared: b, [INFO] [stderr] ... | [INFO] [stderr] 63 | | shared: a, [INFO] [stderr] 64 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 56 | ( [INFO] [stderr] 57 | WriteBuf { [INFO] [stderr] 58 | out_buf: in_buf, [INFO] [stderr] 59 | shared: b, [INFO] [stderr] 60 | }, [INFO] [stderr] 61 | ReadBuf { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/split.rs:258:9 [INFO] [stderr] | [INFO] [stderr] 258 | return Ok(Async::NotReady); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Async::NotReady)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mock.rs:84:9 [INFO] [stderr] | [INFO] [stderr] 84 | return buf.drain(..num).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `buf.drain(..num).collect()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mock.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | return Ok(bytes); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(bytes)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mock.rs:105:9 [INFO] [stderr] | [INFO] [stderr] 105 | return Ok(buf.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(buf.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/split.rs:137:20 [INFO] [stderr] | [INFO] [stderr] 137 | if self.out_buf.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.out_buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/split.rs:198:12 [INFO] [stderr] | [INFO] [stderr] 198 | if self.out_buf.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.out_buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/split.rs:234:20 [INFO] [stderr] | [INFO] [stderr] 234 | if buf.out_buf.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `buf.out_buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `mock::MockData` [INFO] [stderr] --> src/mock.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | / pub fn new() -> MockData { [INFO] [stderr] 49 | | MockData { [INFO] [stderr] 50 | | input: Arc::new(Mutex::new(Vec::new())), [INFO] [stderr] 51 | | output: Arc::new(Mutex::new(Vec::new())), [INFO] [stderr] 52 | | } [INFO] [stderr] 53 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 41 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `tk-bufstream`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> src/lib.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[warn(missing_docs)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![warn(missing_docs)]` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::useless_attribute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/iobuf.rs:72:16 [INFO] [stderr] | [INFO] [stderr] 72 | if self.out_buf.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.out_buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/iobuf.rs:181:9 [INFO] [stderr] | [INFO] [stderr] 181 | self.out_buf.write(buf)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/flushed.rs:19:16 [INFO] [stderr] | [INFO] [stderr] 19 | if conn.out_buf.len() > 0 && !conn.done() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!conn.out_buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/split.rs:137:20 [INFO] [stderr] | [INFO] [stderr] 137 | if self.out_buf.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.out_buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/split.rs:198:12 [INFO] [stderr] | [INFO] [stderr] 198 | if self.out_buf.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.out_buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/split.rs:234:20 [INFO] [stderr] | [INFO] [stderr] 234 | if buf.out_buf.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `buf.out_buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `mock::MockData` [INFO] [stderr] --> src/mock.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | / pub fn new() -> MockData { [INFO] [stderr] 49 | | MockData { [INFO] [stderr] 50 | | input: Arc::new(Mutex::new(Vec::new())), [INFO] [stderr] 51 | | output: Arc::new(Mutex::new(Vec::new())), [INFO] [stderr] 52 | | } [INFO] [stderr] 53 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 41 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `tk-bufstream`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "e98ee5b4d9840d6a0ff72cabed3f76f3b0f25e7acd95497408a9daf81138ba61"` [INFO] running `"docker" "rm" "-f" "e98ee5b4d9840d6a0ff72cabed3f76f3b0f25e7acd95497408a9daf81138ba61"` [INFO] [stdout] e98ee5b4d9840d6a0ff72cabed3f76f3b0f25e7acd95497408a9daf81138ba61