[INFO] crate tixml2svd 0.1.3 is already in cache
[INFO] extracting crate tixml2svd 0.1.3 into work/ex/clippy-test-run/sources/stable/reg/tixml2svd/0.1.3
[INFO] extracting crate tixml2svd 0.1.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tixml2svd/0.1.3
[INFO] validating manifest of tixml2svd-0.1.3 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of tixml2svd-0.1.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing tixml2svd-0.1.3
[INFO] finished frobbing tixml2svd-0.1.3
[INFO] frobbed toml for tixml2svd-0.1.3 written to work/ex/clippy-test-run/sources/stable/reg/tixml2svd/0.1.3/Cargo.toml
[INFO] started frobbing tixml2svd-0.1.3
[INFO] finished frobbing tixml2svd-0.1.3
[INFO] frobbed toml for tixml2svd-0.1.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tixml2svd/0.1.3/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting tixml2svd-0.1.3 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/tixml2svd/0.1.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 3023822429dbb72ac7c9579120c15d5e64be6ad4755aa5c778a8c1ed8b83da0c
[INFO] running `"docker" "start" "-a" "3023822429dbb72ac7c9579120c15d5e64be6ad4755aa5c778a8c1ed8b83da0c"`
[INFO] [stderr]     Checking tixml2svd v0.1.3 (/opt/crater/workdir)
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/lib.rs:49:9
[INFO] [stderr]    |
[INFO] [stderr] 49 |         a
[INFO] [stderr]    |         ^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/lib.rs:42:17
[INFO] [stderr]    |
[INFO] [stderr] 42 |           let a = Args { silent,
[INFO] [stderr]    |  _________________^
[INFO] [stderr] 43 | |                        verbose,
[INFO] [stderr] 44 | |                        peripheral_only,
[INFO] [stderr] 45 | |                        sanitize,
[INFO] [stderr] 46 | |                        no_device_info,
[INFO] [stderr] 47 | |                        cpunum,
[INFO] [stderr] 48 | |         };
[INFO] [stderr]    | |_________^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/lib.rs:245:36
[INFO] [stderr]     |
[INFO] [stderr] 245 |                               } else {
[INFO] [stderr]     |  ____________________________________^
[INFO] [stderr] 246 | |                                 if id.len() > 0 {
[INFO] [stderr] 247 | |                                     if !printed_peripherals_tag {
[INFO] [stderr] 248 | |                                         write_start(args, &mut xml_out, "peripherals")?;
[INFO] [stderr] ...   |
[INFO] [stderr] 284 | |                                 }
[INFO] [stderr] 285 | |                             }
[INFO] [stderr]     | |_____________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 245 |                             } else if id.len() > 0 {
[INFO] [stderr] 246 |     if !printed_peripherals_tag {
[INFO] [stderr] 247 |         write_start(args, &mut xml_out, "peripherals")?;
[INFO] [stderr] 248 |         printed_peripherals_tag = true;
[INFO] [stderr] 249 |     }
[INFO] [stderr] 250 | 
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead
[INFO] [stderr]    --> src/lib.rs:375:49
[INFO] [stderr]     |
[INFO] [stderr] 375 |             Ok(StartElement { name, attributes, namespace: _ }) => {
[INFO] [stderr]     |                                                 ^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unneeded_field_pattern)] on by default
[INFO] [stderr]     = help: Try with `StartElement { name, attributes, .. }`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/lib.rs:485:32
[INFO] [stderr]     |
[INFO] [stderr] 485 |                           } else {
[INFO] [stderr]     |  ________________________________^
[INFO] [stderr] 486 | |                             if let Some(id) = f_id {
[INFO] [stderr] 487 | |                                 write_tag(args, &mut xml_out, "description", &id)?;
[INFO] [stderr] 488 | |                             } else {
[INFO] [stderr] 489 | |                                 write_tag(args, &mut xml_out, "description", "--")?;
[INFO] [stderr] 490 | |                             }
[INFO] [stderr] 491 | |                         }
[INFO] [stderr]     | |_________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 485 |                         } else if let Some(id) = f_id {
[INFO] [stderr] 486 |     write_tag(args, &mut xml_out, "description", &id)?;
[INFO] [stderr] 487 | } else {
[INFO] [stderr] 488 |     write_tag(args, &mut xml_out, "description", "--")?;
[INFO] [stderr] 489 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead
[INFO] [stderr]    --> src/lib.rs:668:45
[INFO] [stderr]     |
[INFO] [stderr] 668 |                 let OwnedName { local_name, prefix: _, namespace: _ } = name;
[INFO] [stderr]     |                                             ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead
[INFO] [stderr]    --> src/lib.rs:668:56
[INFO] [stderr]     |
[INFO] [stderr] 668 |                 let OwnedName { local_name, prefix: _, namespace: _ } = name;
[INFO] [stderr]     |                                                        ^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Try with `OwnedName { local_name, .. }`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/lib.rs:49:9
[INFO] [stderr]    |
[INFO] [stderr] 49 |         a
[INFO] [stderr]    |         ^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/lib.rs:42:17
[INFO] [stderr]    |
[INFO] [stderr] 42 |           let a = Args { silent,
[INFO] [stderr]    |  _________________^
[INFO] [stderr] 43 | |                        verbose,
[INFO] [stderr] 44 | |                        peripheral_only,
[INFO] [stderr] 45 | |                        sanitize,
[INFO] [stderr] 46 | |                        no_device_info,
[INFO] [stderr] 47 | |                        cpunum,
[INFO] [stderr] 48 | |         };
[INFO] [stderr]    | |_________^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/lib.rs:245:36
[INFO] [stderr]     |
[INFO] [stderr] 245 |                               } else {
[INFO] [stderr]     |  ____________________________________^
[INFO] [stderr] 246 | |                                 if id.len() > 0 {
[INFO] [stderr] 247 | |                                     if !printed_peripherals_tag {
[INFO] [stderr] 248 | |                                         write_start(args, &mut xml_out, "peripherals")?;
[INFO] [stderr] ...   |
[INFO] [stderr] 284 | |                                 }
[INFO] [stderr] 285 | |                             }
[INFO] [stderr]     | |_____________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 245 |                             } else if id.len() > 0 {
[INFO] [stderr] 246 |     if !printed_peripherals_tag {
[INFO] [stderr] 247 |         write_start(args, &mut xml_out, "peripherals")?;
[INFO] [stderr] 248 |         printed_peripherals_tag = true;
[INFO] [stderr] 249 |     }
[INFO] [stderr] 250 | 
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead
[INFO] [stderr]    --> src/lib.rs:375:49
[INFO] [stderr]     |
[INFO] [stderr] 375 |             Ok(StartElement { name, attributes, namespace: _ }) => {
[INFO] [stderr]     |                                                 ^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unneeded_field_pattern)] on by default
[INFO] [stderr]     = help: Try with `StartElement { name, attributes, .. }`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/lib.rs:485:32
[INFO] [stderr]     |
[INFO] [stderr] 485 |                           } else {
[INFO] [stderr]     |  ________________________________^
[INFO] [stderr] 486 | |                             if let Some(id) = f_id {
[INFO] [stderr] 487 | |                                 write_tag(args, &mut xml_out, "description", &id)?;
[INFO] [stderr] 488 | |                             } else {
[INFO] [stderr] 489 | |                                 write_tag(args, &mut xml_out, "description", "--")?;
[INFO] [stderr] 490 | |                             }
[INFO] [stderr] 491 | |                         }
[INFO] [stderr]     | |_________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 485 |                         } else if let Some(id) = f_id {
[INFO] [stderr] 486 |     write_tag(args, &mut xml_out, "description", &id)?;
[INFO] [stderr] 487 | } else {
[INFO] [stderr] 488 |     write_tag(args, &mut xml_out, "description", "--")?;
[INFO] [stderr] 489 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead
[INFO] [stderr]    --> src/lib.rs:668:45
[INFO] [stderr]     |
[INFO] [stderr] 668 |                 let OwnedName { local_name, prefix: _, namespace: _ } = name;
[INFO] [stderr]     |                                             ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead
[INFO] [stderr]    --> src/lib.rs:668:56
[INFO] [stderr]     |
[INFO] [stderr] 668 |                 let OwnedName { local_name, prefix: _, namespace: _ } = name;
[INFO] [stderr]     |                                                        ^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Try with `OwnedName { local_name, .. }`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]   --> src/lib.rs:79:21
[INFO] [stderr]    |
[INFO] [stderr] 79 |         Ok(x) => Ok(x),
[INFO] [stderr]    |                     ^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unit_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]    |
[INFO] [stderr] 79 |         Ok(x) => Ok(()),
[INFO] [stderr]    |                     ^^
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/lib.rs:87:35
[INFO] [stderr]    |
[INFO] [stderr] 87 |     let event: writer::XmlEvent = writer::XmlEvent::comment(data).into();
[INFO] [stderr]    |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `writer::XmlEvent::comment(data)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]   --> src/lib.rs:92:21
[INFO] [stderr]    |
[INFO] [stderr] 92 |         Ok(x) => Ok(x),
[INFO] [stderr]    |                     ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]    |
[INFO] [stderr] 92 |         Ok(x) => Ok(()),
[INFO] [stderr]    |                     ^^
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]   --> src/lib.rs:79:21
[INFO] [stderr]    |
[INFO] [stderr] 79 |         Ok(x) => Ok(x),
[INFO] [stderr]    |                     ^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unit_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]    |
[INFO] [stderr] 79 |         Ok(x) => Ok(()),
[INFO] [stderr]    |                     ^^
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/lib.rs:100:35
[INFO] [stderr]     |
[INFO] [stderr] 100 |     let event: writer::XmlEvent = writer::XmlEvent::characters(content).into();
[INFO] [stderr]     |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `writer::XmlEvent::characters(content)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]    --> src/lib.rs:105:21
[INFO] [stderr]     |
[INFO] [stderr] 105 |         Ok(x) => Ok(x),
[INFO] [stderr]     |                     ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]     |
[INFO] [stderr] 105 |         Ok(x) => Ok(()),
[INFO] [stderr]     |                     ^^
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/lib.rs:87:35
[INFO] [stderr]    |
[INFO] [stderr] 87 |     let event: writer::XmlEvent = writer::XmlEvent::comment(data).into();
[INFO] [stderr]    |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `writer::XmlEvent::comment(data)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]   --> src/lib.rs:92:21
[INFO] [stderr]    |
[INFO] [stderr] 92 |         Ok(x) => Ok(x),
[INFO] [stderr]    |                     ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]    |
[INFO] [stderr] 92 |         Ok(x) => Ok(()),
[INFO] [stderr]    |                     ^^
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]    --> src/lib.rs:118:21
[INFO] [stderr]     |
[INFO] [stderr] 118 |         Ok(x) => Ok(x),
[INFO] [stderr]     |                     ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]     |
[INFO] [stderr] 118 |         Ok(x) => Ok(()),
[INFO] [stderr]     |                     ^^
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/lib.rs:100:35
[INFO] [stderr]     |
[INFO] [stderr] 100 |     let event: writer::XmlEvent = writer::XmlEvent::characters(content).into();
[INFO] [stderr]     |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `writer::XmlEvent::characters(content)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]    --> src/lib.rs:105:21
[INFO] [stderr]     |
[INFO] [stderr] 105 |         Ok(x) => Ok(x),
[INFO] [stderr]     |                     ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]     |
[INFO] [stderr] 105 |         Ok(x) => Ok(()),
[INFO] [stderr]     |                     ^^
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]    --> src/lib.rs:118:21
[INFO] [stderr]     |
[INFO] [stderr] 118 |         Ok(x) => Ok(x),
[INFO] [stderr]     |                     ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]     |
[INFO] [stderr] 118 |         Ok(x) => Ok(()),
[INFO] [stderr]     |                     ^^
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 33
[INFO] [stderr]    --> src/lib.rs:155:1
[INFO] [stderr]     |
[INFO] [stderr] 155 | / pub fn process_device_base<I, O>(
[INFO] [stderr] 156 | |     args: &Args,
[INFO] [stderr] 157 | |     parser: xml::EventReader<I>,
[INFO] [stderr] 158 | |     mut xml_out: &mut xml::EventWriter<&mut O>,
[INFO] [stderr] ...   |
[INFO] [stderr] 334 | |     Ok(())
[INFO] [stderr] 335 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cyclomatic_complexity)] on by default
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 33
[INFO] [stderr]    --> src/lib.rs:155:1
[INFO] [stderr]     |
[INFO] [stderr] 155 | / pub fn process_device_base<I, O>(
[INFO] [stderr] 156 | |     args: &Args,
[INFO] [stderr] 157 | |     parser: xml::EventReader<I>,
[INFO] [stderr] 158 | |     mut xml_out: &mut xml::EventWriter<&mut O>,
[INFO] [stderr] ...   |
[INFO] [stderr] 334 | |     Ok(())
[INFO] [stderr] 335 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cyclomatic_complexity)] on by default
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:223:50
[INFO] [stderr]     |
[INFO] [stderr] 223 |                                 "baseaddr" => if value.len() > 0 { f_baseaddr = Some(value) },
[INFO] [stderr]     |                                                  ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!value.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:224:49
[INFO] [stderr]     |
[INFO] [stderr] 224 |                                 "endaddr" => if value.len() > 0 { _f_endaddr = Some(value) },
[INFO] [stderr]     |                                                 ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!value.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:225:46
[INFO] [stderr]     |
[INFO] [stderr] 225 |                                 "size" => if value.len() > 0 { f_size = Some(value) },
[INFO] [stderr]     |                                              ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!value.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:226:44
[INFO] [stderr]     |
[INFO] [stderr] 226 |                                 "id" => if value.len() > 0 { f_id = Some(if args.sanitize { value.replace("-", "_") } else { value } ) },
[INFO] [stderr]     |                                            ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!value.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:227:46
[INFO] [stderr]     |
[INFO] [stderr] 227 |                                 "href" => if value.len() > 0 { f_href = Some(value) },
[INFO] [stderr]     |                                              ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!value.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:223:50
[INFO] [stderr]     |
[INFO] [stderr] 223 |                                 "baseaddr" => if value.len() > 0 { f_baseaddr = Some(value) },
[INFO] [stderr]     |                                                  ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!value.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:224:49
[INFO] [stderr]     |
[INFO] [stderr] 224 |                                 "endaddr" => if value.len() > 0 { _f_endaddr = Some(value) },
[INFO] [stderr]     |                                                 ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!value.is_empty()`
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:246:36
[INFO] [stderr]     |
[INFO] [stderr] 246 |                                 if id.len() > 0 {
[INFO] [stderr]     |                                    ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!id.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:225:46
[INFO] [stderr]     |
[INFO] [stderr] 225 |                                 "size" => if value.len() > 0 { f_size = Some(value) },
[INFO] [stderr]     |                                              ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!value.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:226:44
[INFO] [stderr]     |
[INFO] [stderr] 226 |                                 "id" => if value.len() > 0 { f_id = Some(if args.sanitize { value.replace("-", "_") } else { value } ) },
[INFO] [stderr]     |                                            ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!value.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:227:46
[INFO] [stderr]     |
[INFO] [stderr] 227 |                                 "href" => if value.len() > 0 { f_href = Some(value) },
[INFO] [stderr]     |                                              ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!value.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:246:36
[INFO] [stderr]     |
[INFO] [stderr] 246 |                                 if id.len() > 0 {
[INFO] [stderr]     |                                    ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!id.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 85
[INFO] [stderr]    --> src/lib.rs:349:1
[INFO] [stderr]     |
[INFO] [stderr] 349 | / pub fn process_peripheral_base<I, O>(
[INFO] [stderr] 350 | |     args: &Args,
[INFO] [stderr] 351 | |     parser: xml::EventReader<I>,
[INFO] [stderr] 352 | |     mut xml_out: &mut xml::EventWriter<&mut O>,
[INFO] [stderr] ...   |
[INFO] [stderr] 726 | |     Ok(())
[INFO] [stderr] 727 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 85
[INFO] [stderr]    --> src/lib.rs:349:1
[INFO] [stderr]     |
[INFO] [stderr] 349 | / pub fn process_peripheral_base<I, O>(
[INFO] [stderr] 350 | |     args: &Args,
[INFO] [stderr] 351 | |     parser: xml::EventReader<I>,
[INFO] [stderr] 352 | |     mut xml_out: &mut xml::EventWriter<&mut O>,
[INFO] [stderr] ...   |
[INFO] [stderr] 726 | |     Ok(())
[INFO] [stderr] 727 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:442:44
[INFO] [stderr]     |
[INFO] [stderr] 442 |                                 "id" => if value.len() > 0 { f_id = Some(value) },
[INFO] [stderr]     |                                            ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!value.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:443:47
[INFO] [stderr]     |
[INFO] [stderr] 443 |                                 "value" => if value.len() > 0 { f_value = Some(value) },
[INFO] [stderr]     |                                               ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!value.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:444:47
[INFO] [stderr]     |
[INFO] [stderr] 444 |                                 "width" => if value.len() > 0 { f_width = Some(value) },
[INFO] [stderr]     |                                               ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!value.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:446:53
[INFO] [stderr]     |
[INFO] [stderr] 446 |                                 "description" => if value.len() > 0 { f_description = Some(value) },
[INFO] [stderr]     |                                                     ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!value.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:447:50
[INFO] [stderr]     |
[INFO] [stderr] 447 |                                 "rwaccess" => if value.len() > 0 { f_rwaccess = Some(value) },
[INFO] [stderr]     |                                                  ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!value.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:448:48
[INFO] [stderr]     |
[INFO] [stderr] 448 |                                 "offset" => if value.len() > 0 { f_offset = Some(value) },
[INFO] [stderr]     |                                                ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!value.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:449:50
[INFO] [stderr]     |
[INFO] [stderr] 449 |                                 "resetval" => if value.len() > 0 { f_resetval = Some(value) },
[INFO] [stderr]     |                                                  ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!value.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:524:44
[INFO] [stderr]     |
[INFO] [stderr] 524 |                                 "id" => if value.len() > 0 { f_name = Some(value) },
[INFO] [stderr]     |                                            ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!value.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:525:47
[INFO] [stderr]     |
[INFO] [stderr] 525 |                                 "range" => if value.len() > 0 { f_range = Some(value) },
[INFO] [stderr]     |                                               ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!value.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:526:47
[INFO] [stderr]     |
[INFO] [stderr] 526 |                                 "begin" => if value.len() > 0 { f_begin = Some(value) },
[INFO] [stderr]     |                                               ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!value.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:527:47
[INFO] [stderr]     |
[INFO] [stderr] 527 |                                 "width" => if value.len() > 0 { f_width = Some(value) },
[INFO] [stderr]     |                                               ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!value.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:528:45
[INFO] [stderr]     |
[INFO] [stderr] 528 |                                 "end" => if value.len() > 0 { f_end = Some(value) },
[INFO] [stderr]     |                                             ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!value.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:529:50
[INFO] [stderr]     |
[INFO] [stderr] 529 |                                 "rwaccess" => if value.len() > 0 { f_rwaccess = Some(value) },
[INFO] [stderr]     |                                                  ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!value.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:530:53
[INFO] [stderr]     |
[INFO] [stderr] 530 |                                 "description" => if value.len() > 0 { f_description = Some(value) }
[INFO] [stderr]     |                                                     ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!value.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/lib.rs:532:37
[INFO] [stderr]     |
[INFO] [stderr] 532 | /                                     let resetval: Result<u64, std::num::ParseIntError>;
[INFO] [stderr] 533 | |                                     if value.starts_with("0x") {
[INFO] [stderr] 534 | |                                         resetval = u64::from_str_radix(&value[2..], 16);
[INFO] [stderr] 535 | |                                     } else {
[INFO] [stderr] 536 | |                                         resetval = u64::from_str(&value);
[INFO] [stderr] 537 | |                                     }
[INFO] [stderr]     | |_____________________________________^ help: it is more idiomatic to write: `let resetval = if value.starts_with("0x") { u64::from_str_radix(&value[2..], 16) } else { u64::from_str(&value) };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:587:81
[INFO] [stderr]     |
[INFO] [stderr] 587 |                                 write_tag(args, &mut xml_out, "description", if description.len() == 0 { "--" } else { &description })?;
[INFO] [stderr]     |                                                                                 ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `description.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:623:44
[INFO] [stderr]     |
[INFO] [stderr] 623 |                                 "id" => if value.len() > 0 { f_id = Some(value) },
[INFO] [stderr]     |                                            ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!value.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:624:47
[INFO] [stderr]     |
[INFO] [stderr] 624 |                                 "value" => if value.len() > 0 { f_value = Some(value) },
[INFO] [stderr]     |                                               ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!value.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:625:53
[INFO] [stderr]     |
[INFO] [stderr] 625 |                                 "description" => if value.len() > 0 { f_description = Some(value) }
[INFO] [stderr]     |                                                     ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!value.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:649:85
[INFO] [stderr]     |
[INFO] [stderr] 649 |                                     write_tag(args, &mut xml_out, "description", if description.len() == 0 { "--" } else { &description })?;
[INFO] [stderr]     |                                                                                     ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `description.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:442:44
[INFO] [stderr]     |
[INFO] [stderr] 442 |                                 "id" => if value.len() > 0 { f_id = Some(value) },
[INFO] [stderr]     |                                            ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!value.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:443:47
[INFO] [stderr]     |
[INFO] [stderr] 443 |                                 "value" => if value.len() > 0 { f_value = Some(value) },
[INFO] [stderr]     |                                               ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!value.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:444:47
[INFO] [stderr]     |
[INFO] [stderr] 444 |                                 "width" => if value.len() > 0 { f_width = Some(value) },
[INFO] [stderr]     |                                               ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!value.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:446:53
[INFO] [stderr]     |
[INFO] [stderr] 446 |                                 "description" => if value.len() > 0 { f_description = Some(value) },
[INFO] [stderr]     |                                                     ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!value.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:447:50
[INFO] [stderr]     |
[INFO] [stderr] 447 |                                 "rwaccess" => if value.len() > 0 { f_rwaccess = Some(value) },
[INFO] [stderr]     |                                                  ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!value.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:448:48
[INFO] [stderr]     |
[INFO] [stderr] 448 |                                 "offset" => if value.len() > 0 { f_offset = Some(value) },
[INFO] [stderr]     |                                                ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!value.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:449:50
[INFO] [stderr]     |
[INFO] [stderr] 449 |                                 "resetval" => if value.len() > 0 { f_resetval = Some(value) },
[INFO] [stderr]     |                                                  ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!value.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:524:44
[INFO] [stderr]     |
[INFO] [stderr] 524 |                                 "id" => if value.len() > 0 { f_name = Some(value) },
[INFO] [stderr]     |                                            ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!value.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:525:47
[INFO] [stderr]     |
[INFO] [stderr] 525 |                                 "range" => if value.len() > 0 { f_range = Some(value) },
[INFO] [stderr]     |                                               ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!value.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:526:47
[INFO] [stderr]     |
[INFO] [stderr] 526 |                                 "begin" => if value.len() > 0 { f_begin = Some(value) },
[INFO] [stderr]     |                                               ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!value.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:527:47
[INFO] [stderr]     |
[INFO] [stderr] 527 |                                 "width" => if value.len() > 0 { f_width = Some(value) },
[INFO] [stderr]     |                                               ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!value.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:528:45
[INFO] [stderr]     |
[INFO] [stderr] 528 |                                 "end" => if value.len() > 0 { f_end = Some(value) },
[INFO] [stderr]     |                                             ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!value.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:529:50
[INFO] [stderr]     |
[INFO] [stderr] 529 |                                 "rwaccess" => if value.len() > 0 { f_rwaccess = Some(value) },
[INFO] [stderr]     |                                                  ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!value.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:530:53
[INFO] [stderr]     |
[INFO] [stderr] 530 |                                 "description" => if value.len() > 0 { f_description = Some(value) }
[INFO] [stderr]     |                                                     ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!value.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/lib.rs:532:37
[INFO] [stderr]     |
[INFO] [stderr] 532 | /                                     let resetval: Result<u64, std::num::ParseIntError>;
[INFO] [stderr] 533 | |                                     if value.starts_with("0x") {
[INFO] [stderr] 534 | |                                         resetval = u64::from_str_radix(&value[2..], 16);
[INFO] [stderr] 535 | |                                     } else {
[INFO] [stderr] 536 | |                                         resetval = u64::from_str(&value);
[INFO] [stderr] 537 | |                                     }
[INFO] [stderr]     | |_____________________________________^ help: it is more idiomatic to write: `let resetval = if value.starts_with("0x") { u64::from_str_radix(&value[2..], 16) } else { u64::from_str(&value) };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:587:81
[INFO] [stderr]     |
[INFO] [stderr] 587 |                                 write_tag(args, &mut xml_out, "description", if description.len() == 0 { "--" } else { &description })?;
[INFO] [stderr]     |                                                                                 ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `description.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:623:44
[INFO] [stderr]     |
[INFO] [stderr] 623 |                                 "id" => if value.len() > 0 { f_id = Some(value) },
[INFO] [stderr]     |                                            ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!value.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:624:47
[INFO] [stderr]     |
[INFO] [stderr] 624 |                                 "value" => if value.len() > 0 { f_value = Some(value) },
[INFO] [stderr]     |                                               ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!value.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:625:53
[INFO] [stderr]     |
[INFO] [stderr] 625 |                                 "description" => if value.len() > 0 { f_description = Some(value) }
[INFO] [stderr]     |                                                     ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!value.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:649:85
[INFO] [stderr]     |
[INFO] [stderr] 649 |                                     write_tag(args, &mut xml_out, "description", if description.len() == 0 { "--" } else { &description })?;
[INFO] [stderr]     |                                                                                     ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `description.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/main.rs:71:51
[INFO] [stderr]    |
[INFO] [stderr] 71 |         .map_err(|_| Error::new(ErrorKind::Other, format!("invalid cpunum, must be a valid non-negative integer.")))?;
[INFO] [stderr]    |                                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"invalid cpunum, must be a valid non-negative integer.".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/main.rs:71:51
[INFO] [stderr]    |
[INFO] [stderr] 71 |         .map_err(|_| Error::new(ErrorKind::Other, format!("invalid cpunum, must be a valid non-negative integer.")))?;
[INFO] [stderr]    |                                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"invalid cpunum, must be a valid non-negative integer.".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 2.68s
[INFO] running `"docker" "inspect" "3023822429dbb72ac7c9579120c15d5e64be6ad4755aa5c778a8c1ed8b83da0c"`
[INFO] running `"docker" "rm" "-f" "3023822429dbb72ac7c9579120c15d5e64be6ad4755aa5c778a8c1ed8b83da0c"`
[INFO] [stdout] 3023822429dbb72ac7c9579120c15d5e64be6ad4755aa5c778a8c1ed8b83da0c