[INFO] crate titleformat-rs 0.1.0 is already in cache
[INFO] extracting crate titleformat-rs 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/titleformat-rs/0.1.0
[INFO] extracting crate titleformat-rs 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/titleformat-rs/0.1.0
[INFO] validating manifest of titleformat-rs-0.1.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of titleformat-rs-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing titleformat-rs-0.1.0
[INFO] finished frobbing titleformat-rs-0.1.0
[INFO] frobbed toml for titleformat-rs-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/titleformat-rs/0.1.0/Cargo.toml
[INFO] started frobbing titleformat-rs-0.1.0
[INFO] finished frobbing titleformat-rs-0.1.0
[INFO] frobbed toml for titleformat-rs-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/titleformat-rs/0.1.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting titleformat-rs-0.1.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/titleformat-rs/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] e1c0cb84b6ada7d48997916b3ca7a8481aa15943913550c5e7e9c19ff93ea1b6
[INFO] running `"docker" "start" "-a" "e1c0cb84b6ada7d48997916b3ca7a8481aa15943913550c5e7e9c19ff93ea1b6"`
[INFO] [stderr]     Checking titleformat-rs v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/environment.rs:38:40
[INFO] [stderr]    |
[INFO] [stderr] 38 |   fn add_default_functions (&mut self) -> () {
[INFO] [stderr]    |                                        ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unused_unit)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/program.rs:25:5
[INFO] [stderr]    |
[INFO] [stderr] 25 |     prog
[INFO] [stderr]    |     ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/program.rs:22:16
[INFO] [stderr]    |
[INFO] [stderr] 22 |       let prog = Program {
[INFO] [stderr]    |  ________________^
[INFO] [stderr] 23 | |       instr : vec![],
[INFO] [stderr] 24 | |     };
[INFO] [stderr]    | |_____^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/environment.rs:38:40
[INFO] [stderr]    |
[INFO] [stderr] 38 |   fn add_default_functions (&mut self) -> () {
[INFO] [stderr]    |                                        ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unused_unit)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/program.rs:25:5
[INFO] [stderr]    |
[INFO] [stderr] 25 |     prog
[INFO] [stderr]    |     ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/program.rs:22:16
[INFO] [stderr]    |
[INFO] [stderr] 22 |       let prog = Program {
[INFO] [stderr]    |  ________________^
[INFO] [stderr] 23 | |       instr : vec![],
[INFO] [stderr] 24 | |     };
[INFO] [stderr]    | |_____^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/parser.rs:16:1
[INFO] [stderr]    |
[INFO] [stderr] 16 | / named!(comment<CompleteStr, String>,
[INFO] [stderr] 17 | |     do_parse!(
[INFO] [stderr] 18 | |         alt!(
[INFO] [stderr] 19 | |             delimited!(tag!("//"), take_until!("\n"), tag!("\n"))
[INFO] [stderr] ...  |
[INFO] [stderr] 24 | |     )
[INFO] [stderr] 25 | | );
[INFO] [stderr]    | |__^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/parser.rs:104:1
[INFO] [stderr]     |
[INFO] [stderr] 104 | / named!(unescaped_literal<CompleteStr, String>,
[INFO] [stderr] 105 | |     map!(take_till1!(is_special), |a| String::from(&a as &str))
[INFO] [stderr] 106 | | );
[INFO] [stderr]     | |__^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: this `.fold` can be written more succinctly using another method
[INFO] [stderr]   --> src/functions/control/and.rs:15:37
[INFO] [stderr]    |
[INFO] [stderr] 15 |     Ok(value_string ("", args.iter().fold(true, |cur, x| { cur && x.cond })))
[INFO] [stderr]    |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.all(|x| x.cond)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unnecessary_fold)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold
[INFO] [stderr] 
[INFO] [stderr] warning: this `.fold` can be written more succinctly using another method
[INFO] [stderr]   --> src/functions/control/or.rs:15:37
[INFO] [stderr]    |
[INFO] [stderr] 15 |     Ok(value_string ("", args.iter().fold(false, |cur, x| { cur || x.cond })))
[INFO] [stderr]    |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.any(|x| x.cond)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/functions/num/mod.rs:30:5
[INFO] [stderr]    |
[INFO] [stderr] 30 | /     let mut num = 0;
[INFO] [stderr] 31 | |     if num_str.len() != 0 {
[INFO] [stderr] 32 | |         num = num_str.parse::<i64>().unwrap();
[INFO] [stderr] 33 | |     }
[INFO] [stderr]    | |_____^ help: it is more idiomatic to write: `let <mut> num = if num_str.len() != 0 { num_str.parse::<i64>().unwrap() } else { 0 };`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]    = note: you might not need `mut` at all
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/functions/num/mod.rs:22:37
[INFO] [stderr]    |
[INFO] [stderr] 22 |     let negative = if s.starts_with("-") { s = s.split_off(1); -1 } else { 1 };
[INFO] [stderr]    |                                     ^^^ help: try using a char instead: `'-'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/functions/num/mod.rs:31:8
[INFO] [stderr]    |
[INFO] [stderr] 31 |     if num_str.len() != 0 {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!num_str.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: this `.fold` can be written more succinctly using another method
[INFO] [stderr]    --> src/environment.rs:241:43
[INFO] [stderr]     |
[INFO] [stderr] 241 |         _ => Ok(value_string("", args.iter().fold(true, |c, i| {
[INFO] [stderr]     |  ___________________________________________^
[INFO] [stderr] 242 | |         c && self.meta_num(&i.val) > 0
[INFO] [stderr] 243 | |       }))),
[INFO] [stderr]     | |________^ help: try: `.all(|i| self.meta_num(&i.val) > 0)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold
[INFO] [stderr] 
[INFO] [stderr] warning: this `.fold` can be written more succinctly using another method
[INFO] [stderr]    --> src/environment.rs:267:32
[INFO] [stderr]     |
[INFO] [stderr] 267 |             let c = args.iter().fold(true, |c, val| { c && val.cond });
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.all(|val| val.cond)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold
[INFO] [stderr] 
[INFO] [stderr] warning: this `.fold` can be written more succinctly using another method
[INFO] [stderr]    --> src/environment.rs:275:32
[INFO] [stderr]     |
[INFO] [stderr] 275 |             let c = args.iter().fold(true, |c, val| { c && val.cond });
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.all(|val| val.cond)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `program::Program`
[INFO] [stderr]   --> src/program.rs:21:3
[INFO] [stderr]    |
[INFO] [stderr] 21 | /   pub fn new() -> Self {
[INFO] [stderr] 22 | |     let prog = Program {
[INFO] [stderr] 23 | |       instr : vec![],
[INFO] [stderr] 24 | |     };
[INFO] [stderr] 25 | |     prog
[INFO] [stderr] 26 | |   }
[INFO] [stderr]    | |___^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 8  | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/parser.rs:16:1
[INFO] [stderr]    |
[INFO] [stderr] 16 | / named!(comment<CompleteStr, String>,
[INFO] [stderr] 17 | |     do_parse!(
[INFO] [stderr] 18 | |         alt!(
[INFO] [stderr] 19 | |             delimited!(tag!("//"), take_until!("\n"), tag!("\n"))
[INFO] [stderr] ...  |
[INFO] [stderr] 24 | |     )
[INFO] [stderr] 25 | | );
[INFO] [stderr]    | |__^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/parser.rs:104:1
[INFO] [stderr]     |
[INFO] [stderr] 104 | / named!(unescaped_literal<CompleteStr, String>,
[INFO] [stderr] 105 | |     map!(take_till1!(is_special), |a| String::from(&a as &str))
[INFO] [stderr] 106 | | );
[INFO] [stderr]     | |__^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: this `.fold` can be written more succinctly using another method
[INFO] [stderr]   --> src/functions/control/and.rs:15:37
[INFO] [stderr]    |
[INFO] [stderr] 15 |     Ok(value_string ("", args.iter().fold(true, |cur, x| { cur && x.cond })))
[INFO] [stderr]    |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.all(|x| x.cond)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unnecessary_fold)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold
[INFO] [stderr] 
[INFO] [stderr] warning: this `.fold` can be written more succinctly using another method
[INFO] [stderr]   --> src/functions/control/or.rs:15:37
[INFO] [stderr]    |
[INFO] [stderr] 15 |     Ok(value_string ("", args.iter().fold(false, |cur, x| { cur || x.cond })))
[INFO] [stderr]    |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.any(|x| x.cond)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/functions/num/mod.rs:30:5
[INFO] [stderr]    |
[INFO] [stderr] 30 | /     let mut num = 0;
[INFO] [stderr] 31 | |     if num_str.len() != 0 {
[INFO] [stderr] 32 | |         num = num_str.parse::<i64>().unwrap();
[INFO] [stderr] 33 | |     }
[INFO] [stderr]    | |_____^ help: it is more idiomatic to write: `let <mut> num = if num_str.len() != 0 { num_str.parse::<i64>().unwrap() } else { 0 };`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]    = note: you might not need `mut` at all
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/functions/num/mod.rs:22:37
[INFO] [stderr]    |
[INFO] [stderr] 22 |     let negative = if s.starts_with("-") { s = s.split_off(1); -1 } else { 1 };
[INFO] [stderr]    |                                     ^^^ help: try using a char instead: `'-'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/functions/num/mod.rs:31:8
[INFO] [stderr]    |
[INFO] [stderr] 31 |     if num_str.len() != 0 {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!num_str.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: this `.fold` can be written more succinctly using another method
[INFO] [stderr]    --> src/environment.rs:241:43
[INFO] [stderr]     |
[INFO] [stderr] 241 |         _ => Ok(value_string("", args.iter().fold(true, |c, i| {
[INFO] [stderr]     |  ___________________________________________^
[INFO] [stderr] 242 | |         c && self.meta_num(&i.val) > 0
[INFO] [stderr] 243 | |       }))),
[INFO] [stderr]     | |________^ help: try: `.all(|i| self.meta_num(&i.val) > 0)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold
[INFO] [stderr] 
[INFO] [stderr] warning: this `.fold` can be written more succinctly using another method
[INFO] [stderr]    --> src/environment.rs:267:32
[INFO] [stderr]     |
[INFO] [stderr] 267 |             let c = args.iter().fold(true, |c, val| { c && val.cond });
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.all(|val| val.cond)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold
[INFO] [stderr] 
[INFO] [stderr] warning: this `.fold` can be written more succinctly using another method
[INFO] [stderr]    --> src/environment.rs:275:32
[INFO] [stderr]     |
[INFO] [stderr] 275 |             let c = args.iter().fold(true, |c, val| { c && val.cond });
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.all(|val| val.cond)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `program::Program`
[INFO] [stderr]   --> src/program.rs:21:3
[INFO] [stderr]    |
[INFO] [stderr] 21 | /   pub fn new() -> Self {
[INFO] [stderr] 22 | |     let prog = Program {
[INFO] [stderr] 23 | |       instr : vec![],
[INFO] [stderr] 24 | |     };
[INFO] [stderr] 25 | |     prog
[INFO] [stderr] 26 | |   }
[INFO] [stderr]    | |___^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 8  | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 3.08s
[INFO] running `"docker" "inspect" "e1c0cb84b6ada7d48997916b3ca7a8481aa15943913550c5e7e9c19ff93ea1b6"`
[INFO] running `"docker" "rm" "-f" "e1c0cb84b6ada7d48997916b3ca7a8481aa15943913550c5e7e9c19ff93ea1b6"`
[INFO] [stdout] e1c0cb84b6ada7d48997916b3ca7a8481aa15943913550c5e7e9c19ff93ea1b6