[INFO] crate tirse 0.4.0 is already in cache [INFO] extracting crate tirse 0.4.0 into work/ex/clippy-test-run/sources/stable/reg/tirse/0.4.0 [INFO] extracting crate tirse 0.4.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tirse/0.4.0 [INFO] validating manifest of tirse-0.4.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tirse-0.4.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tirse-0.4.0 [INFO] finished frobbing tirse-0.4.0 [INFO] frobbed toml for tirse-0.4.0 written to work/ex/clippy-test-run/sources/stable/reg/tirse/0.4.0/Cargo.toml [INFO] started frobbing tirse-0.4.0 [INFO] finished frobbing tirse-0.4.0 [INFO] frobbed toml for tirse-0.4.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tirse/0.4.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tirse-0.4.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/tirse/0.4.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3f139c36df4cc157ee5567666affb4344a7bb86ce09de1f87f0a51caba47ce70 [INFO] running `"docker" "start" "-a" "3f139c36df4cc157ee5567666affb4344a7bb86ce09de1f87f0a51caba47ce70"` [INFO] [stderr] Compiling serde v1.0.85 [INFO] [stderr] Checking tirse v0.4.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ser.rs:277:35 [INFO] [stderr] | [INFO] [stderr] 277 | Ok(BinarySerializeTuple { sequence: sequence }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `sequence` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ser.rs:288:41 [INFO] [stderr] | [INFO] [stderr] 288 | Ok(BinarySerializeTupleStruct { sequence: sequence }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `sequence` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ser.rs:305:50 [INFO] [stderr] | [INFO] [stderr] 305 | Ok(BinarySerializeTupleVariant { sequence: sequence }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `sequence` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ser.rs:316:37 [INFO] [stderr] | [INFO] [stderr] 316 | Ok(BinarySerializeMap { sequence: sequence }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `sequence` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ser.rs:328:36 [INFO] [stderr] | [INFO] [stderr] 328 | Ok(BinarySerializeStruct { sequence: sequence }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `sequence` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ser.rs:345:51 [INFO] [stderr] | [INFO] [stderr] 345 | Ok(BinarySerializeStructVariant { sequence: sequence }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `sequence` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | read: read, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `read` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:354:13 [INFO] [stderr] | [INFO] [stderr] 354 | len: len, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ser.rs:277:35 [INFO] [stderr] | [INFO] [stderr] 277 | Ok(BinarySerializeTuple { sequence: sequence }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `sequence` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ser.rs:288:41 [INFO] [stderr] | [INFO] [stderr] 288 | Ok(BinarySerializeTupleStruct { sequence: sequence }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `sequence` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ser.rs:305:50 [INFO] [stderr] | [INFO] [stderr] 305 | Ok(BinarySerializeTupleVariant { sequence: sequence }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `sequence` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ser.rs:316:37 [INFO] [stderr] | [INFO] [stderr] 316 | Ok(BinarySerializeMap { sequence: sequence }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `sequence` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ser.rs:328:36 [INFO] [stderr] | [INFO] [stderr] 328 | Ok(BinarySerializeStruct { sequence: sequence }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `sequence` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ser.rs:345:51 [INFO] [stderr] | [INFO] [stderr] 345 | Ok(BinarySerializeStructVariant { sequence: sequence }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `sequence` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | read: read, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `read` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:354:13 [INFO] [stderr] | [INFO] [stderr] 354 | len: len, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/ser.rs:369:10 [INFO] [stderr] | [INFO] [stderr] 369 | raw: Result, Option, D>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/de.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | / match self { [INFO] [stderr] 24 | | #[cfg(not(feature = "use_std"))] [INFO] [stderr] 25 | | &RequiredAlloc => write!(f, "required alloc"), [INFO] [stderr] 26 | | #[cfg(feature = "use_std")] [INFO] [stderr] ... | [INFO] [stderr] 31 | | &NotSupported => write!(f, "not supported"), [INFO] [stderr] 32 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 23 | match *self { [INFO] [stderr] 24 | #[cfg(not(feature = "use_std"))] [INFO] [stderr] 25 | RequiredAlloc => write!(f, "required alloc"), [INFO] [stderr] 26 | #[cfg(feature = "use_std")] [INFO] [stderr] 27 | &FromUtf8Error(ref e) => write!(f, "{}", e), [INFO] [stderr] 28 | WrongChar(code) => write!(f, "wrong char code: {}", code), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: the `t @ _` pattern can be written as just `t` [INFO] [stderr] --> src/de.rs:245:17 [INFO] [stderr] | [INFO] [stderr] 245 | t @ _ => Err(ErrorAdapter::Inner(Either::Left(BinaryDeserializerError::UnexpectedVariant(t)))), [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/io.rs:54:12 [INFO] [stderr] | [INFO] [stderr] 54 | if self.as_slice().len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.as_slice().is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/err.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | / match self { [INFO] [stderr] 58 | | &Inner(ref e) => write!(f, "{}", e), [INFO] [stderr] 59 | | &Other(ref d) => write!(f, "{}", d), [INFO] [stderr] 60 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 57 | match *self { [INFO] [stderr] 58 | Inner(ref e) => write!(f, "{}", e), [INFO] [stderr] 59 | Other(ref d) => write!(f, "{}", d), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/ser.rs:369:10 [INFO] [stderr] | [INFO] [stderr] 369 | raw: Result, Option, D>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/de.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | / match self { [INFO] [stderr] 24 | | #[cfg(not(feature = "use_std"))] [INFO] [stderr] 25 | | &RequiredAlloc => write!(f, "required alloc"), [INFO] [stderr] 26 | | #[cfg(feature = "use_std")] [INFO] [stderr] ... | [INFO] [stderr] 31 | | &NotSupported => write!(f, "not supported"), [INFO] [stderr] 32 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 23 | match *self { [INFO] [stderr] 24 | #[cfg(not(feature = "use_std"))] [INFO] [stderr] 25 | RequiredAlloc => write!(f, "required alloc"), [INFO] [stderr] 26 | #[cfg(feature = "use_std")] [INFO] [stderr] 27 | &FromUtf8Error(ref e) => write!(f, "{}", e), [INFO] [stderr] 28 | WrongChar(code) => write!(f, "wrong char code: {}", code), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: the `t @ _` pattern can be written as just `t` [INFO] [stderr] --> src/de.rs:245:17 [INFO] [stderr] | [INFO] [stderr] 245 | t @ _ => Err(ErrorAdapter::Inner(Either::Left(BinaryDeserializerError::UnexpectedVariant(t)))), [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/io.rs:54:12 [INFO] [stderr] | [INFO] [stderr] 54 | if self.as_slice().len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.as_slice().is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/err.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | / match self { [INFO] [stderr] 58 | | &Inner(ref e) => write!(f, "{}", e), [INFO] [stderr] 59 | | &Other(ref d) => write!(f, "{}", d), [INFO] [stderr] 60 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 57 | match *self { [INFO] [stderr] 58 | Inner(ref e) => write!(f, "{}", e), [INFO] [stderr] 59 | Other(ref d) => write!(f, "{}", d), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> tests/without_std.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | / match self { [INFO] [stderr] 29 | | &SizeLimit => write!(fmt, "size limit reached"), [INFO] [stderr] 30 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 28 | match *self { [INFO] [stderr] 29 | SizeLimit => write!(fmt, "size limit reached"), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 11.45s [INFO] running `"docker" "inspect" "3f139c36df4cc157ee5567666affb4344a7bb86ce09de1f87f0a51caba47ce70"` [INFO] running `"docker" "rm" "-f" "3f139c36df4cc157ee5567666affb4344a7bb86ce09de1f87f0a51caba47ce70"` [INFO] [stdout] 3f139c36df4cc157ee5567666affb4344a7bb86ce09de1f87f0a51caba47ce70