[INFO] crate tinyprof 0.0.1 is already in cache [INFO] extracting crate tinyprof 0.0.1 into work/ex/clippy-test-run/sources/stable/reg/tinyprof/0.0.1 [INFO] extracting crate tinyprof 0.0.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tinyprof/0.0.1 [INFO] validating manifest of tinyprof-0.0.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tinyprof-0.0.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tinyprof-0.0.1 [INFO] finished frobbing tinyprof-0.0.1 [INFO] frobbed toml for tinyprof-0.0.1 written to work/ex/clippy-test-run/sources/stable/reg/tinyprof/0.0.1/Cargo.toml [INFO] started frobbing tinyprof-0.0.1 [INFO] finished frobbing tinyprof-0.0.1 [INFO] frobbed toml for tinyprof-0.0.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tinyprof/0.0.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tinyprof-0.0.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/tinyprof/0.0.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4dcdfa15f41b924c3c749caf5fed6e45fabff759c4f3d6ea0a88df1206f3deda [INFO] running `"docker" "start" "-a" "4dcdfa15f41b924c3c749caf5fed6e45fabff759c4f3d6ea0a88df1206f3deda"` [INFO] [stderr] Checking tinyprof v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: you should consider adding a `Default` implementation for `profiler_frame::ProfilerFrame` [INFO] [stderr] --> src/profiler_frame.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | / pub fn new() -> ProfilerFrame { [INFO] [stderr] 52 | | ProfilerFrame::begin_new(0.0) [INFO] [stderr] 53 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 42 | impl Default for profiler_frame::ProfilerFrame { [INFO] [stderr] 43 | fn default() -> Self { [INFO] [stderr] 44 | Self::new() [INFO] [stderr] 45 | } [INFO] [stderr] 46 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `profiler_state::ProfilerState` [INFO] [stderr] --> src/profiler_state.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | / pub fn new() -> ProfilerState { [INFO] [stderr] 12 | | ProfilerState { [INFO] [stderr] 13 | | last_frame : 0, [INFO] [stderr] 14 | | frames : vec![ProfilerFrame::begin_new(precise_time_s())] [INFO] [stderr] 15 | | } [INFO] [stderr] 16 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 5 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/profiler_state.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | self.frames.get_mut(self.last_frame - 1).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.frames[self.last_frame - 1]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/profiler_state.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | self.frames.get_mut(self.last_frame).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.frames[self.last_frame]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:99:21 [INFO] [stderr] | [INFO] [stderr] 99 | (1 ..).take(500000).fold(0, |x, y| ((x * y) as f32).sqrt().sin() as i32 + 1); [INFO] [stderr] | ^^^^^^ help: consider: `500_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:103:25 [INFO] [stderr] | [INFO] [stderr] 103 | (1 ..).take(500000).fold(0, |x, y| ((x * y) as f32).sqrt().sin() as i32 + 1); [INFO] [stderr] | ^^^^^^ help: consider: `500_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:108:25 [INFO] [stderr] | [INFO] [stderr] 108 | (1 ..).take(500000).fold(0, |x, y| ((x * y) as f32).sqrt().sin() as i32 + 1); [INFO] [stderr] | ^^^^^^ help: consider: `500_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:112:29 [INFO] [stderr] | [INFO] [stderr] 112 | (1 ..).take(500000).fold(0, |x, y| ((x * y) as f32).sqrt().sin() as i32 + 1); [INFO] [stderr] | ^^^^^^ help: consider: `500_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:117:29 [INFO] [stderr] | [INFO] [stderr] 117 | (1 ..).take(500000).fold(0, |x, y| ((x * y) as f32).sqrt().sin() as i32 + 1); [INFO] [stderr] | ^^^^^^ help: consider: `500_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:124:25 [INFO] [stderr] | [INFO] [stderr] 124 | (1 ..).take(500000).fold(0, |x, y| ((x * y) as f32).sqrt().sin() as i32 + 1); [INFO] [stderr] | ^^^^^^ help: consider: `500_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `profiler_frame::ProfilerFrame` [INFO] [stderr] --> src/profiler_frame.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | / pub fn new() -> ProfilerFrame { [INFO] [stderr] 52 | | ProfilerFrame::begin_new(0.0) [INFO] [stderr] 53 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 42 | impl Default for profiler_frame::ProfilerFrame { [INFO] [stderr] 43 | fn default() -> Self { [INFO] [stderr] 44 | Self::new() [INFO] [stderr] 45 | } [INFO] [stderr] 46 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `profiler_state::ProfilerState` [INFO] [stderr] --> src/profiler_state.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | / pub fn new() -> ProfilerState { [INFO] [stderr] 12 | | ProfilerState { [INFO] [stderr] 13 | | last_frame : 0, [INFO] [stderr] 14 | | frames : vec![ProfilerFrame::begin_new(precise_time_s())] [INFO] [stderr] 15 | | } [INFO] [stderr] 16 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 5 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/profiler_state.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | self.frames.get_mut(self.last_frame - 1).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.frames[self.last_frame - 1]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/profiler_state.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | self.frames.get_mut(self.last_frame).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.frames[self.last_frame]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/lib.rs:90:26 [INFO] [stderr] | [INFO] [stderr] 90 | (1 ..).take(1000).fold(0, |x, y| x + y) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.82s [INFO] running `"docker" "inspect" "4dcdfa15f41b924c3c749caf5fed6e45fabff759c4f3d6ea0a88df1206f3deda"` [INFO] running `"docker" "rm" "-f" "4dcdfa15f41b924c3c749caf5fed6e45fabff759c4f3d6ea0a88df1206f3deda"` [INFO] [stdout] 4dcdfa15f41b924c3c749caf5fed6e45fabff759c4f3d6ea0a88df1206f3deda