[INFO] crate tinyecs 0.0.3 is already in cache [INFO] extracting crate tinyecs 0.0.3 into work/ex/clippy-test-run/sources/stable/reg/tinyecs/0.0.3 [INFO] extracting crate tinyecs 0.0.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tinyecs/0.0.3 [INFO] validating manifest of tinyecs-0.0.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tinyecs-0.0.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tinyecs-0.0.3 [INFO] finished frobbing tinyecs-0.0.3 [INFO] frobbed toml for tinyecs-0.0.3 written to work/ex/clippy-test-run/sources/stable/reg/tinyecs/0.0.3/Cargo.toml [INFO] started frobbing tinyecs-0.0.3 [INFO] finished frobbing tinyecs-0.0.3 [INFO] frobbed toml for tinyecs-0.0.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tinyecs/0.0.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tinyecs-0.0.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/tinyecs/0.0.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e136feced32eb55007184300e025183e4c500012f01032443dfbeecee2322b4d [INFO] running `"docker" "start" "-a" "e136feced32eb55007184300e025183e4c500012f01032443dfbeecee2322b4d"` [INFO] [stderr] Checking tinyprof v0.0.1 [INFO] [stderr] Checking tinyecs v0.0.3 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/entity.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | id : id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/world.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | system : system, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `system` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/world.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | aspect : aspect, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `aspect` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/world.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | data_aspects : data_aspects [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data_aspects` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/entity.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | id : id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/world.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | system : system, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `system` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/world.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | aspect : aspect, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `aspect` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/world.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | data_aspects : data_aspects [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data_aspects` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/world.rs:215:20 [INFO] [stderr] | [INFO] [stderr] 215 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 216 | | if entities.entity_set.contains(&entity_id) { [INFO] [stderr] 217 | | profile_region!(&format!("on_removed: {}", system.get_name())); [INFO] [stderr] 218 | | [INFO] [stderr] ... | [INFO] [stderr] 221 | | } [INFO] [stderr] 222 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 215 | } else if entities.entity_set.contains(&entity_id) { [INFO] [stderr] 216 | profile_region!(&format!("on_removed: {}", system.get_name())); [INFO] [stderr] 217 | [INFO] [stderr] 218 | entities.entity_set.remove(&entity_id); [INFO] [stderr] 219 | system.on_removed(e); [INFO] [stderr] 220 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/world.rs:234:24 [INFO] [stderr] | [INFO] [stderr] 234 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 235 | | if entities.contains(&entity_id) { [INFO] [stderr] 236 | | entities.remove(&entity_id); [INFO] [stderr] 237 | | } [INFO] [stderr] 238 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 234 | } else if entities.contains(&entity_id) { [INFO] [stderr] 235 | entities.remove(&entity_id); [INFO] [stderr] 236 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/world.rs:215:20 [INFO] [stderr] | [INFO] [stderr] 215 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 216 | | if entities.entity_set.contains(&entity_id) { [INFO] [stderr] 217 | | profile_region!(&format!("on_removed: {}", system.get_name())); [INFO] [stderr] 218 | | [INFO] [stderr] ... | [INFO] [stderr] 221 | | } [INFO] [stderr] 222 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 215 | } else if entities.entity_set.contains(&entity_id) { [INFO] [stderr] 216 | profile_region!(&format!("on_removed: {}", system.get_name())); [INFO] [stderr] 217 | [INFO] [stderr] 218 | entities.entity_set.remove(&entity_id); [INFO] [stderr] 219 | system.on_removed(e); [INFO] [stderr] 220 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/world.rs:234:24 [INFO] [stderr] | [INFO] [stderr] 234 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 235 | | if entities.contains(&entity_id) { [INFO] [stderr] 236 | | entities.remove(&entity_id); [INFO] [stderr] 237 | | } [INFO] [stderr] 238 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 234 | } else if entities.contains(&entity_id) { [INFO] [stderr] 235 | entities.remove(&entity_id); [INFO] [stderr] 236 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/fast_dict.rs:102:18 [INFO] [stderr] | [INFO] [stderr] 102 | Some(mut item) => match item { [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/world.rs:59:22 [INFO] [stderr] | [INFO] [stderr] 59 | let id = (*id).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `(*id)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `world::World` [INFO] [stderr] --> src/world.rs:75:5 [INFO] [stderr] | [INFO] [stderr] 75 | / pub fn new() -> World { [INFO] [stderr] 76 | | World { [INFO] [stderr] 77 | | last_id : 0, [INFO] [stderr] 78 | | update_time : PreciseTime::now(), [INFO] [stderr] ... | [INFO] [stderr] 82 | | } [INFO] [stderr] 83 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 73 | impl Default for world::World { [INFO] [stderr] 74 | fn default() -> Self { [INFO] [stderr] 75 | Self::new() [INFO] [stderr] 76 | } [INFO] [stderr] 77 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/world.rs:98:5 [INFO] [stderr] | [INFO] [stderr] 98 | / pub fn entity_manager<'a>(&'a mut self) -> EntityManager<'a> { [INFO] [stderr] 99 | | EntityManager { [INFO] [stderr] 100 | | last_id : &mut self.last_id, [INFO] [stderr] 101 | | entities : &mut self.entities [INFO] [stderr] 102 | | } [INFO] [stderr] 103 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/world.rs:147:80 [INFO] [stderr] | [INFO] [stderr] 147 | for e in world_data.entity_manager.entities.iter_mut().filter(|e| {*e.fresh.borrow_mut() == false}) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!(*e.fresh.borrow_mut())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/world.rs:155:20 [INFO] [stderr] | [INFO] [stderr] 155 | if entities.entity_set.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!entities.entity_set.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/world.rs:165:20 [INFO] [stderr] | [INFO] [stderr] 165 | if entities.entity_set.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!entities.entity_set.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/world.rs:172:28 [INFO] [stderr] | [INFO] [stderr] 172 | if system.data_aspects.len() == 0 || (entities.data_set.len() != 0 && [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `system.data_aspects.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/world.rs:172:63 [INFO] [stderr] | [INFO] [stderr] 172 | if system.data_aspects.len() == 0 || (entities.data_set.len() != 0 && [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!entities.data_set.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/world.rs:173:63 [INFO] [stderr] | [INFO] [stderr] 173 | entities.data_set[0].len() != 0) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!entities.data_set[0].is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/world.rs:185:20 [INFO] [stderr] | [INFO] [stderr] 185 | if entities.entity_set.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!entities.entity_set.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/world.rs:209:20 [INFO] [stderr] | [INFO] [stderr] 209 | if entities.entity_set.contains(&entity_id) == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!entities.entity_set.contains(&entity_id)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/world.rs:231:24 [INFO] [stderr] | [INFO] [stderr] 231 | if entities.contains(&entity_id) == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!entities.contains(&entity_id)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/system.rs:148:5 [INFO] [stderr] | [INFO] [stderr] 148 | / pub fn unwrap_entity<'a>(&'a self) -> &'a Entity { [INFO] [stderr] 149 | | &self.data[0][0] [INFO] [stderr] 150 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/system.rs:152:5 [INFO] [stderr] | [INFO] [stderr] 152 | / pub fn unwrap_entity_nth<'a>(&'a self, n : usize) -> &'a Entity { [INFO] [stderr] 153 | | &self.data[n][0] [INFO] [stderr] 154 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/system.rs:155:5 [INFO] [stderr] | [INFO] [stderr] 155 | / pub fn unwrap_entity_mut<'a>(&'a mut self) -> &'a mut Entity { [INFO] [stderr] 156 | | &mut self.data[0][0] [INFO] [stderr] 157 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/system.rs:171:59 [INFO] [stderr] | [INFO] [stderr] 171 | pub fn new(entity_manager : &mut EntityManager, ids : &Vec>) -> DataList<'b> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[HashSet]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/aspect.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | self.not_accept_types.iter().any(|ty| { entity.components.borrow().contains_key(ty) }) == false [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!self.not_accept_types.iter().any(|ty| { entity.components.borrow().contains_key(ty) })` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/fast_dict.rs:27:24 [INFO] [stderr] | [INFO] [stderr] 27 | ptr::write(self.vec.as_mut_ptr().offset(key as isize), Some(value)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.vec.as_mut_ptr().add(key)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/fast_dict.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | / from_raw_parts_mut(ptr.offset(key as isize), 1).get_mut(0). [INFO] [stderr] 47 | | unwrap().as_mut().unwrap() [INFO] [stderr] | |________________________^ help: try this: `&mut from_raw_parts_mut(ptr.offset(key as isize), 1)[0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/fast_dict.rs:59:14 [INFO] [stderr] | [INFO] [stderr] 59 | (from_raw_parts_mut(ptr.offset(key as isize), 1).get_mut(0).unwrap().as_mut().unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&mut from_raw_parts_mut(ptr.offset(key as isize), 1)[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/fast_dict.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | from_raw_parts_mut(ptr.offset(key2 as isize), 1).get_mut(0).unwrap().as_mut().unwrap()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&mut from_raw_parts_mut(ptr.offset(key2 as isize), 1)[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/fast_dict.rs:102:31 [INFO] [stderr] | [INFO] [stderr] 102 | Some(mut item) => match item { [INFO] [stderr] | _______________________________^ [INFO] [stderr] 103 | | &mut None => self.next(), [INFO] [stderr] 104 | | &mut Some(ref mut item) => Some(item) [INFO] [stderr] 105 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 102 | Some(mut item) => match *item { [INFO] [stderr] 103 | None => self.next(), [INFO] [stderr] 104 | Some(ref mut item) => Some(item) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/fast_dict.rs:120:28 [INFO] [stderr] | [INFO] [stderr] 120 | Some( item) => match item { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 121 | | &None => self.next(), [INFO] [stderr] 122 | | &Some(ref item) => Some(item) [INFO] [stderr] 123 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 120 | Some( item) => match *item { [INFO] [stderr] 121 | None => self.next(), [INFO] [stderr] 122 | Some(ref item) => Some(item) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/fast_dict.rs:102:18 [INFO] [stderr] | [INFO] [stderr] 102 | Some(mut item) => match item { [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/world.rs:59:22 [INFO] [stderr] | [INFO] [stderr] 59 | let id = (*id).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `(*id)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `world::World` [INFO] [stderr] --> src/world.rs:75:5 [INFO] [stderr] | [INFO] [stderr] 75 | / pub fn new() -> World { [INFO] [stderr] 76 | | World { [INFO] [stderr] 77 | | last_id : 0, [INFO] [stderr] 78 | | update_time : PreciseTime::now(), [INFO] [stderr] ... | [INFO] [stderr] 82 | | } [INFO] [stderr] 83 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 73 | impl Default for world::World { [INFO] [stderr] 74 | fn default() -> Self { [INFO] [stderr] 75 | Self::new() [INFO] [stderr] 76 | } [INFO] [stderr] 77 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/world.rs:98:5 [INFO] [stderr] | [INFO] [stderr] 98 | / pub fn entity_manager<'a>(&'a mut self) -> EntityManager<'a> { [INFO] [stderr] 99 | | EntityManager { [INFO] [stderr] 100 | | last_id : &mut self.last_id, [INFO] [stderr] 101 | | entities : &mut self.entities [INFO] [stderr] 102 | | } [INFO] [stderr] 103 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/world.rs:147:80 [INFO] [stderr] | [INFO] [stderr] 147 | for e in world_data.entity_manager.entities.iter_mut().filter(|e| {*e.fresh.borrow_mut() == false}) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!(*e.fresh.borrow_mut())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/world.rs:155:20 [INFO] [stderr] | [INFO] [stderr] 155 | if entities.entity_set.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!entities.entity_set.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/world.rs:165:20 [INFO] [stderr] | [INFO] [stderr] 165 | if entities.entity_set.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!entities.entity_set.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/world.rs:172:28 [INFO] [stderr] | [INFO] [stderr] 172 | if system.data_aspects.len() == 0 || (entities.data_set.len() != 0 && [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `system.data_aspects.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/world.rs:172:63 [INFO] [stderr] | [INFO] [stderr] 172 | if system.data_aspects.len() == 0 || (entities.data_set.len() != 0 && [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!entities.data_set.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/world.rs:173:63 [INFO] [stderr] | [INFO] [stderr] 173 | entities.data_set[0].len() != 0) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!entities.data_set[0].is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/world.rs:185:20 [INFO] [stderr] | [INFO] [stderr] 185 | if entities.entity_set.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!entities.entity_set.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/world.rs:209:20 [INFO] [stderr] | [INFO] [stderr] 209 | if entities.entity_set.contains(&entity_id) == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!entities.entity_set.contains(&entity_id)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/world.rs:231:24 [INFO] [stderr] | [INFO] [stderr] 231 | if entities.contains(&entity_id) == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!entities.contains(&entity_id)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/system.rs:148:5 [INFO] [stderr] | [INFO] [stderr] 148 | / pub fn unwrap_entity<'a>(&'a self) -> &'a Entity { [INFO] [stderr] 149 | | &self.data[0][0] [INFO] [stderr] 150 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/system.rs:152:5 [INFO] [stderr] | [INFO] [stderr] 152 | / pub fn unwrap_entity_nth<'a>(&'a self, n : usize) -> &'a Entity { [INFO] [stderr] 153 | | &self.data[n][0] [INFO] [stderr] 154 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/system.rs:155:5 [INFO] [stderr] | [INFO] [stderr] 155 | / pub fn unwrap_entity_mut<'a>(&'a mut self) -> &'a mut Entity { [INFO] [stderr] 156 | | &mut self.data[0][0] [INFO] [stderr] 157 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/system.rs:171:59 [INFO] [stderr] | [INFO] [stderr] 171 | pub fn new(entity_manager : &mut EntityManager, ids : &Vec>) -> DataList<'b> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[HashSet]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/aspect.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | self.not_accept_types.iter().any(|ty| { entity.components.borrow().contains_key(ty) }) == false [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!self.not_accept_types.iter().any(|ty| { entity.components.borrow().contains_key(ty) })` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/fast_dict.rs:27:24 [INFO] [stderr] | [INFO] [stderr] 27 | ptr::write(self.vec.as_mut_ptr().offset(key as isize), Some(value)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.vec.as_mut_ptr().add(key)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/fast_dict.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | / from_raw_parts_mut(ptr.offset(key as isize), 1).get_mut(0). [INFO] [stderr] 47 | | unwrap().as_mut().unwrap() [INFO] [stderr] | |________________________^ help: try this: `&mut from_raw_parts_mut(ptr.offset(key as isize), 1)[0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/fast_dict.rs:59:14 [INFO] [stderr] | [INFO] [stderr] 59 | (from_raw_parts_mut(ptr.offset(key as isize), 1).get_mut(0).unwrap().as_mut().unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&mut from_raw_parts_mut(ptr.offset(key as isize), 1)[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/fast_dict.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | from_raw_parts_mut(ptr.offset(key2 as isize), 1).get_mut(0).unwrap().as_mut().unwrap()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&mut from_raw_parts_mut(ptr.offset(key2 as isize), 1)[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/fast_dict.rs:102:31 [INFO] [stderr] | [INFO] [stderr] 102 | Some(mut item) => match item { [INFO] [stderr] | _______________________________^ [INFO] [stderr] 103 | | &mut None => self.next(), [INFO] [stderr] 104 | | &mut Some(ref mut item) => Some(item) [INFO] [stderr] 105 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 102 | Some(mut item) => match *item { [INFO] [stderr] 103 | None => self.next(), [INFO] [stderr] 104 | Some(ref mut item) => Some(item) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/fast_dict.rs:120:28 [INFO] [stderr] | [INFO] [stderr] 120 | Some( item) => match item { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 121 | | &None => self.next(), [INFO] [stderr] 122 | | &Some(ref item) => Some(item) [INFO] [stderr] 123 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 120 | Some( item) => match *item { [INFO] [stderr] 121 | None => self.next(), [INFO] [stderr] 122 | Some(ref item) => Some(item) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> src/fast_dict.rs:131:13 [INFO] [stderr] | [INFO] [stderr] 131 | let mut foo : FastDictionary> = FastDictionary::new(0); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> examples/render_gui_system.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | #[macro_use] extern crate tinyecs; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> examples/systems.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[macro_use] extern crate tinyecs; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `GlutinFacade` [INFO] [stderr] --> examples/render_gui_system.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | / pub fn new() -> GlutinFacade { [INFO] [stderr] 11 | | GlutinFacade [INFO] [stderr] 12 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 8 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> examples/process_types.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[macro_use] extern crate tinyecs; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> examples/spawn_system.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[macro_use] extern crate tinyecs; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `RenderSystem` [INFO] [stderr] --> examples/render_gui_system.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | / pub fn new() -> RenderSystem { [INFO] [stderr] 45 | | RenderSystem { [INFO] [stderr] 46 | | facade : Rc::new(RefCell::new(GlutinFacade::new())) [INFO] [stderr] 47 | | } [INFO] [stderr] 48 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 43 | impl Default for RenderSystem { [INFO] [stderr] 44 | fn default() -> Self { [INFO] [stderr] 45 | Self::new() [INFO] [stderr] 46 | } [INFO] [stderr] 47 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> examples/process_macro.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[macro_use] extern crate tinyecs; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.41s [INFO] running `"docker" "inspect" "e136feced32eb55007184300e025183e4c500012f01032443dfbeecee2322b4d"` [INFO] running `"docker" "rm" "-f" "e136feced32eb55007184300e025183e4c500012f01032443dfbeecee2322b4d"` [INFO] [stdout] e136feced32eb55007184300e025183e4c500012f01032443dfbeecee2322b4d