[INFO] crate tinycdb 0.0.7 is already in cache [INFO] extracting crate tinycdb 0.0.7 into work/ex/clippy-test-run/sources/stable/reg/tinycdb/0.0.7 [INFO] extracting crate tinycdb 0.0.7 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tinycdb/0.0.7 [INFO] validating manifest of tinycdb-0.0.7 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tinycdb-0.0.7 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tinycdb-0.0.7 [INFO] finished frobbing tinycdb-0.0.7 [INFO] frobbed toml for tinycdb-0.0.7 written to work/ex/clippy-test-run/sources/stable/reg/tinycdb/0.0.7/Cargo.toml [INFO] started frobbing tinycdb-0.0.7 [INFO] finished frobbing tinycdb-0.0.7 [INFO] frobbed toml for tinycdb-0.0.7 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tinycdb/0.0.7/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tinycdb-0.0.7 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/tinycdb/0.0.7:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b457d26d2cb5ef083e5fb87bdc49675c00dff0e72b1a37ef60b63680dcf7a783 [INFO] running `"docker" "start" "-a" "b457d26d2cb5ef083e5fb87bdc49675c00dff0e72b1a37ef60b63680dcf7a783"` [INFO] [stderr] Compiling tinycdb-sys v0.0.2 [INFO] [stderr] Compiling lz4-sys v1.8.3 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Compiling error-chain v0.12.0 [INFO] [stderr] Compiling cargo_metadata v0.6.4 [INFO] [stderr] Checking tinycdb v0.0.7 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | kind: kind, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:170:13 [INFO] [stderr] | [INFO] [stderr] 170 | fd: fd, [INFO] [stderr] | ^^^^^^ help: replace it with: `fd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:340:13 [INFO] [stderr] | [INFO] [stderr] 340 | fd: fd, [INFO] [stderr] | ^^^^^^ help: replace it with: `fd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/lib.rs:282:9 [INFO] [stderr] | [INFO] [stderr] 282 | / if res <= 0 { [INFO] [stderr] 283 | | false [INFO] [stderr] 284 | | } else { [INFO] [stderr] 285 | | true [INFO] [stderr] 286 | | } [INFO] [stderr] | |_________^ help: you can reduce it to: `!(res <= 0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:293:5 [INFO] [stderr] | [INFO] [stderr] 293 | / pub fn iter<'i>(&'i mut self) -> CdbIterator<'i> { [INFO] [stderr] 294 | | // Need to get around the fact that we're borrowing self as mutable [INFO] [stderr] 295 | | // twice - specifically, once for the CdbIterator, and once to pass to [INFO] [stderr] 296 | | // cdb_seqinit. [INFO] [stderr] ... | [INFO] [stderr] 308 | | iter [INFO] [stderr] 309 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] Compiling skeptic v0.13.4 [INFO] [stderr] Compiling lz4 v1.23.1 [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | kind: kind, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:170:13 [INFO] [stderr] | [INFO] [stderr] 170 | fd: fd, [INFO] [stderr] | ^^^^^^ help: replace it with: `fd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:340:13 [INFO] [stderr] | [INFO] [stderr] 340 | fd: fd, [INFO] [stderr] | ^^^^^^ help: replace it with: `fd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/bench.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `tinycdb`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/lib.rs:282:9 [INFO] [stderr] | [INFO] [stderr] 282 | / if res <= 0 { [INFO] [stderr] 283 | | false [INFO] [stderr] 284 | | } else { [INFO] [stderr] 285 | | true [INFO] [stderr] 286 | | } [INFO] [stderr] | |_________^ help: you can reduce it to: `!(res <= 0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:293:5 [INFO] [stderr] | [INFO] [stderr] 293 | / pub fn iter<'i>(&'i mut self) -> CdbIterator<'i> { [INFO] [stderr] 294 | | // Need to get around the fact that we're borrowing self as mutable [INFO] [stderr] 295 | | // twice - specifically, once for the CdbIterator, and once to pass to [INFO] [stderr] 296 | | // cdb_seqinit. [INFO] [stderr] ... | [INFO] [stderr] 308 | | iter [INFO] [stderr] 309 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:499:9 [INFO] [stderr] | [INFO] [stderr] 499 | / match decoder.read_to_end(&mut decomp) { [INFO] [stderr] 500 | | Err(why) => panic!("Could not decompress bytes: {:?}", why), [INFO] [stderr] 501 | | Ok(_) => {}, [INFO] [stderr] 502 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Err(why) = decoder.read_to_end(&mut decomp) { panic!("Could not decompress bytes: {:?}", why) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:509:9 [INFO] [stderr] | [INFO] [stderr] 509 | / match file.write(decomp.as_ref()) { [INFO] [stderr] 510 | | Err(why) => panic!("Couldn't write to {}: {:?}", path.display(), why), [INFO] [stderr] 511 | | Ok(_) => {}, [INFO] [stderr] 512 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Err(why) = file.write(decomp.as_ref()) { panic!("Couldn't write to {}: {:?}", path.display(), why) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> examples/encode.rs:18:17 [INFO] [stderr] | [INFO] [stderr] 18 | let fname = std::env::args().skip(1).next().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:531:13 [INFO] [stderr] | [INFO] [stderr] 531 | / match fs::remove_file(&self.underlying) { [INFO] [stderr] 532 | | Err(why) => println!("Couldn't remove temp file: {:?}", why), [INFO] [stderr] 533 | | Ok(_) => {}, [INFO] [stderr] 534 | | }; [INFO] [stderr] | |_____________^ help: try this: `if let Err(why) = fs::remove_file(&self.underlying) { println!("Couldn't remove temp file: {:?}", why) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:599:26 [INFO] [stderr] | [INFO] [stderr] 599 | match c.find("bad".as_bytes()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"bad"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> examples/encode.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | / match file.read_to_end(&mut buf) { [INFO] [stderr] 27 | | Err(why) => panic!("Couldn't read {}: {:?}", fname, why), [INFO] [stderr] 28 | | Ok(_) => {}, [INFO] [stderr] 29 | | }; [INFO] [stderr] | |_____^ help: try this: `if let Err(why) = file.read_to_end(&mut buf) { panic!("Couldn't read {}: {:?}", fname, why) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> examples/encode.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | / match encoder.write_all(&*buf) { [INFO] [stderr] 35 | | Err(why) => panic!("Could not compress: {:?}", why), [INFO] [stderr] 36 | | Ok(_) => {}, [INFO] [stderr] 37 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Err(why) = encoder.write_all(&*buf) { panic!("Could not compress: {:?}", why) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "b457d26d2cb5ef083e5fb87bdc49675c00dff0e72b1a37ef60b63680dcf7a783"` [INFO] running `"docker" "rm" "-f" "b457d26d2cb5ef083e5fb87bdc49675c00dff0e72b1a37ef60b63680dcf7a783"` [INFO] [stdout] b457d26d2cb5ef083e5fb87bdc49675c00dff0e72b1a37ef60b63680dcf7a783