[INFO] crate timespan 0.0.4 is already in cache [INFO] extracting crate timespan 0.0.4 into work/ex/clippy-test-run/sources/stable/reg/timespan/0.0.4 [INFO] extracting crate timespan 0.0.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/timespan/0.0.4 [INFO] validating manifest of timespan-0.0.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of timespan-0.0.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing timespan-0.0.4 [INFO] finished frobbing timespan-0.0.4 [INFO] frobbed toml for timespan-0.0.4 written to work/ex/clippy-test-run/sources/stable/reg/timespan/0.0.4/Cargo.toml [INFO] started frobbing timespan-0.0.4 [INFO] finished frobbing timespan-0.0.4 [INFO] frobbed toml for timespan-0.0.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/timespan/0.0.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting timespan-0.0.4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/timespan/0.0.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fca69f4dc87e7e4cb5f2392c597f8d2e81bb6fb3cc885df69206562faac7622b [INFO] running `"docker" "start" "-a" "fca69f4dc87e7e4cb5f2392c597f8d2e81bb6fb3cc885df69206562faac7622b"` [INFO] [stderr] warning: profile `doc` is deprecated and has no effect [INFO] [stderr] Checking timespan v0.0.4 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/span.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/span.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | end: end, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/span.rs:312:13 [INFO] [stderr] | [INFO] [stderr] 312 | fmt: fmt, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `fmt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/span.rs:313:13 [INFO] [stderr] | [INFO] [stderr] 313 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/span.rs:314:13 [INFO] [stderr] | [INFO] [stderr] 314 | end: end, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/span.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/span.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | end: end, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/span.rs:312:13 [INFO] [stderr] | [INFO] [stderr] 312 | fmt: fmt, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `fmt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/span.rs:313:13 [INFO] [stderr] | [INFO] [stderr] 313 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/span.rs:314:13 [INFO] [stderr] | [INFO] [stderr] 314 | end: end, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/span.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | return Err(Error::Empty); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Error::Empty)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/span.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | return Ok(self.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(self.clone())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/span.rs:109:13 [INFO] [stderr] | [INFO] [stderr] 109 | return Ok(self.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(self.clone())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/span.rs:112:13 [INFO] [stderr] | [INFO] [stderr] 112 | / return Ok(Span { [INFO] [stderr] 113 | | start: self.start, [INFO] [stderr] 114 | | end: other.start, [INFO] [stderr] 115 | | }); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 112 | Ok(Span { [INFO] [stderr] 113 | start: self.start, [INFO] [stderr] 114 | end: other.start, [INFO] [stderr] 115 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/span.rs:118:13 [INFO] [stderr] | [INFO] [stderr] 118 | / return Ok(Span { [INFO] [stderr] 119 | | start: other.end, [INFO] [stderr] 120 | | end: self.end, [INFO] [stderr] 121 | | }); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 118 | Ok(Span { [INFO] [stderr] 119 | start: other.end, [INFO] [stderr] 120 | end: self.end, [INFO] [stderr] 121 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/span.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | return Err(Error::NotContinuous); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Error::NotContinuous)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/span.rs:140:13 [INFO] [stderr] | [INFO] [stderr] 140 | / return Ok(Span { [INFO] [stderr] 141 | | start: self.start, [INFO] [stderr] 142 | | end: other.end, [INFO] [stderr] 143 | | }); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 140 | Ok(Span { [INFO] [stderr] 141 | start: self.start, [INFO] [stderr] 142 | end: other.end, [INFO] [stderr] 143 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/span.rs:146:13 [INFO] [stderr] | [INFO] [stderr] 146 | / return Ok(Span { [INFO] [stderr] 147 | | start: other.start, [INFO] [stderr] 148 | | end: self.end, [INFO] [stderr] 149 | | }); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 146 | Ok(Span { [INFO] [stderr] 147 | start: other.start, [INFO] [stderr] 148 | end: self.end, [INFO] [stderr] 149 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/span.rs:151:13 [INFO] [stderr] | [INFO] [stderr] 151 | return Err(Error::NotContinuous); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Error::NotContinuous)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/span.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | return Err(Error::Empty); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Error::Empty)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/span.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | return Ok(self.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(self.clone())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/span.rs:109:13 [INFO] [stderr] | [INFO] [stderr] 109 | return Ok(self.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(self.clone())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/span.rs:112:13 [INFO] [stderr] | [INFO] [stderr] 112 | / return Ok(Span { [INFO] [stderr] 113 | | start: self.start, [INFO] [stderr] 114 | | end: other.start, [INFO] [stderr] 115 | | }); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 112 | Ok(Span { [INFO] [stderr] 113 | start: self.start, [INFO] [stderr] 114 | end: other.start, [INFO] [stderr] 115 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/span.rs:118:13 [INFO] [stderr] | [INFO] [stderr] 118 | / return Ok(Span { [INFO] [stderr] 119 | | start: other.end, [INFO] [stderr] 120 | | end: self.end, [INFO] [stderr] 121 | | }); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 118 | Ok(Span { [INFO] [stderr] 119 | start: other.end, [INFO] [stderr] 120 | end: self.end, [INFO] [stderr] 121 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/span.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | return Err(Error::NotContinuous); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Error::NotContinuous)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/span.rs:140:13 [INFO] [stderr] | [INFO] [stderr] 140 | / return Ok(Span { [INFO] [stderr] 141 | | start: self.start, [INFO] [stderr] 142 | | end: other.end, [INFO] [stderr] 143 | | }); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 140 | Ok(Span { [INFO] [stderr] 141 | start: self.start, [INFO] [stderr] 142 | end: other.end, [INFO] [stderr] 143 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/span.rs:146:13 [INFO] [stderr] | [INFO] [stderr] 146 | / return Ok(Span { [INFO] [stderr] 147 | | start: other.start, [INFO] [stderr] 148 | | end: self.end, [INFO] [stderr] 149 | | }); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 146 | Ok(Span { [INFO] [stderr] 147 | start: other.start, [INFO] [stderr] 148 | end: self.end, [INFO] [stderr] 149 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/span.rs:151:13 [INFO] [stderr] | [INFO] [stderr] 151 | return Err(Error::NotContinuous); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Error::NotContinuous)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/span.rs:107:43 [INFO] [stderr] | [INFO] [stderr] 107 | } else if self.start >= other.end { [INFO] [stderr] | ___________________________________________^ [INFO] [stderr] 108 | | // -(--)-[##]- [INFO] [stderr] 109 | | return Ok(self.clone()); [INFO] [stderr] 110 | | } else if self.end > other.start && self.end <= other.end && self.start < other.start { [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/span.rs:104:43 [INFO] [stderr] | [INFO] [stderr] 104 | } else if self.end <= other.start { [INFO] [stderr] | ___________________________________________^ [INFO] [stderr] 105 | | // -[##]-(--)- [INFO] [stderr] 106 | | return Ok(self.clone()); [INFO] [stderr] 107 | | } else if self.start >= other.end { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/date_time_span.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | |e| Error::Parsing(e), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::Parsing` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/date_time_span.rs:62:47 [INFO] [stderr] | [INFO] [stderr] 62 | Utc.datetime_from_str(s, fmt).map_err(|e| Error::Parsing(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::Parsing` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/date_time_span.rs:69:56 [INFO] [stderr] | [INFO] [stderr] 69 | ChronoDateTime::parse_from_str(s, fmt).map_err(|e| Error::Parsing(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::Parsing` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/naive/naive_date_span.rs:44:51 [INFO] [stderr] | [INFO] [stderr] 44 | NaiveDate::parse_from_str(s, fmt).map_err(|e| Error::Parsing(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::Parsing` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/naive/naive_date_time_span.rs:44:55 [INFO] [stderr] | [INFO] [stderr] 44 | NaiveDateTime::parse_from_str(s, fmt).map_err(|e| Error::Parsing(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::Parsing` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/naive/naive_time_span.rs:44:51 [INFO] [stderr] | [INFO] [stderr] 44 | NaiveTime::parse_from_str(s, fmt).map_err(|e| Error::Parsing(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::Parsing` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `timespan`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/span.rs:107:43 [INFO] [stderr] | [INFO] [stderr] 107 | } else if self.start >= other.end { [INFO] [stderr] | ___________________________________________^ [INFO] [stderr] 108 | | // -(--)-[##]- [INFO] [stderr] 109 | | return Ok(self.clone()); [INFO] [stderr] 110 | | } else if self.end > other.start && self.end <= other.end && self.start < other.start { [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/span.rs:104:43 [INFO] [stderr] | [INFO] [stderr] 104 | } else if self.end <= other.start { [INFO] [stderr] | ___________________________________________^ [INFO] [stderr] 105 | | // -[##]-(--)- [INFO] [stderr] 106 | | return Ok(self.clone()); [INFO] [stderr] 107 | | } else if self.start >= other.end { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/date_time_span.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | |e| Error::Parsing(e), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::Parsing` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/date_time_span.rs:62:47 [INFO] [stderr] | [INFO] [stderr] 62 | Utc.datetime_from_str(s, fmt).map_err(|e| Error::Parsing(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::Parsing` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/date_time_span.rs:69:56 [INFO] [stderr] | [INFO] [stderr] 69 | ChronoDateTime::parse_from_str(s, fmt).map_err(|e| Error::Parsing(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::Parsing` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/naive/naive_date_span.rs:44:51 [INFO] [stderr] | [INFO] [stderr] 44 | NaiveDate::parse_from_str(s, fmt).map_err(|e| Error::Parsing(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::Parsing` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/naive/naive_date_time_span.rs:44:55 [INFO] [stderr] | [INFO] [stderr] 44 | NaiveDateTime::parse_from_str(s, fmt).map_err(|e| Error::Parsing(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::Parsing` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/naive/naive_time_span.rs:44:51 [INFO] [stderr] | [INFO] [stderr] 44 | NaiveTime::parse_from_str(s, fmt).map_err(|e| Error::Parsing(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::Parsing` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `timespan`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "fca69f4dc87e7e4cb5f2392c597f8d2e81bb6fb3cc885df69206562faac7622b"` [INFO] running `"docker" "rm" "-f" "fca69f4dc87e7e4cb5f2392c597f8d2e81bb6fb3cc885df69206562faac7622b"` [INFO] [stdout] fca69f4dc87e7e4cb5f2392c597f8d2e81bb6fb3cc885df69206562faac7622b