[INFO] crate timeplot 0.7.10 is already in cache
[INFO] extracting crate timeplot 0.7.10 into work/ex/clippy-test-run/sources/stable/reg/timeplot/0.7.10
[INFO] extracting crate timeplot 0.7.10 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/timeplot/0.7.10
[INFO] validating manifest of timeplot-0.7.10 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of timeplot-0.7.10 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing timeplot-0.7.10
[INFO] finished frobbing timeplot-0.7.10
[INFO] frobbed toml for timeplot-0.7.10 written to work/ex/clippy-test-run/sources/stable/reg/timeplot/0.7.10/Cargo.toml
[INFO] started frobbing timeplot-0.7.10
[INFO] finished frobbing timeplot-0.7.10
[INFO] frobbed toml for timeplot-0.7.10 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/timeplot/0.7.10/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting timeplot-0.7.10 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/timeplot/0.7.10:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] ce103ebbc3301e7763ee2f334a76c4f0e91caf105463d684acf35c8020f1c4bf
[INFO] running `"docker" "start" "-a" "ce103ebbc3301e7763ee2f334a76c4f0e91caf105463d684acf35c8020f1c4bf"`
[INFO] [stderr]     Checking directories v1.0.2
[INFO] [stderr]     Checking config v0.9.2
[INFO] [stderr]     Checking timeplot v0.7.10 (/opt/crater/workdir)
[INFO] [stderr] warning: equality checks against false can be replaced by a negation
[INFO] [stderr]    --> src/main.rs:107:7
[INFO] [stderr]     |
[INFO] [stderr] 107 |             && categories.contains_key(line.category.as_str()) == false {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!categories.contains_key(line.category.as_str())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::bool_comparison)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/main.rs:111:72
[INFO] [stderr]     |
[INFO] [stderr] 111 |                 color: conf.get_str(&format!("category.{}.color", &line.category)).unwrap_or("black".to_string()).to_string(),
[INFO] [stderr]     |                                                                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "black".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/main.rs:121:16
[INFO] [stderr]     |
[INFO] [stderr] 121 |                 let last = category.values.last().map(|x| *x);
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `category.values.last().cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/main.rs:134:20
[INFO] [stderr]     |
[INFO] [stderr] 134 |             let old_value = category.values.last().map(|x| *x).unwrap_or(latest);
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `category.values.last().cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against false can be replaced by a negation
[INFO] [stderr]    --> src/main.rs:194:5
[INFO] [stderr]     |
[INFO] [stderr] 194 |     if Path::new(&filename).exists() == false {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!Path::new(&filename).exists()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against false can be replaced by a negation
[INFO] [stderr]    --> src/main.rs:202:5
[INFO] [stderr]     |
[INFO] [stderr] 202 |     if child.status.success() == false {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!child.status.success()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/main.rs:219:23
[INFO] [stderr]     |
[INFO] [stderr] 219 |         if line.starts_with("#") || line.is_empty() {
[INFO] [stderr]     |                             ^^^ help: try using a char instead: `'#'`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/main.rs:223:19
[INFO] [stderr]     |
[INFO] [stderr] 223 |         let category = *split.get(0).unwrap();
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^ help: try this: `&split[0]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against false can be replaced by a negation
[INFO] [stderr]    --> src/main.rs:308:12
[INFO] [stderr]     |
[INFO] [stderr] 308 |     } else if child.unwrap().status.success() == false {
[INFO] [stderr]     |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!child.unwrap().status.success()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/main.rs:386:4
[INFO] [stderr]     |
[INFO] [stderr] 386 |         .unwrap_or(dirs.data_local_dir().to_path_buf());
[INFO] [stderr]     |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| dirs.data_local_dir().to_path_buf())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]    --> src/main.rs:408:3
[INFO] [stderr]     |
[INFO] [stderr] 408 |            open::that(dirs.config_dir()).err()
[INFO] [stderr]     |   _________^
[INFO] [stderr]     |  |_________|
[INFO] [stderr]     | ||
[INFO] [stderr] 409 | ||             .map(|_| eprintln!("Debug: failed to `open` config directory"));
[INFO] [stderr]     | ||___________________________________________________________________________^- help: try this: `if let Some(_) = open::that(dirs.config_dir()).err() { $ crate :: io :: _eprint ( format_args_nl ! ( $ ( $ arg ) * ) ) ; }`
[INFO] [stderr]     | |____________________________________________________________________________|
[INFO] [stderr]     | 
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::option_map_unit_fn)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] 
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]    --> src/main.rs:410:3
[INFO] [stderr]     |
[INFO] [stderr] 410 |         open::that(&image_dir).err().map(|_| eprintln!("Debug: failed to `open` image directory"));
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-
[INFO] [stderr]     |         |
[INFO] [stderr]     |         help: try this: `if let Some(_) = open::that(&image_dir).err() { $ crate :: io :: _eprint ( format_args_nl ! ( $ ( $ arg ) * ) ) ; }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against false can be replaced by a negation
[INFO] [stderr]    --> src/main.rs:107:7
[INFO] [stderr]     |
[INFO] [stderr] 107 |             && categories.contains_key(line.category.as_str()) == false {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!categories.contains_key(line.category.as_str())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::bool_comparison)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/main.rs:111:72
[INFO] [stderr]     |
[INFO] [stderr] 111 |                 color: conf.get_str(&format!("category.{}.color", &line.category)).unwrap_or("black".to_string()).to_string(),
[INFO] [stderr]     |                                                                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "black".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/main.rs:121:16
[INFO] [stderr]     |
[INFO] [stderr] 121 |                 let last = category.values.last().map(|x| *x);
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `category.values.last().cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/main.rs:134:20
[INFO] [stderr]     |
[INFO] [stderr] 134 |             let old_value = category.values.last().map(|x| *x).unwrap_or(latest);
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `category.values.last().cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against false can be replaced by a negation
[INFO] [stderr]    --> src/main.rs:194:5
[INFO] [stderr]     |
[INFO] [stderr] 194 |     if Path::new(&filename).exists() == false {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!Path::new(&filename).exists()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against false can be replaced by a negation
[INFO] [stderr]    --> src/main.rs:202:5
[INFO] [stderr]     |
[INFO] [stderr] 202 |     if child.status.success() == false {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!child.status.success()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/main.rs:219:23
[INFO] [stderr]     |
[INFO] [stderr] 219 |         if line.starts_with("#") || line.is_empty() {
[INFO] [stderr]     |                             ^^^ help: try using a char instead: `'#'`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/main.rs:223:19
[INFO] [stderr]     |
[INFO] [stderr] 223 |         let category = *split.get(0).unwrap();
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^ help: try this: `&split[0]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against false can be replaced by a negation
[INFO] [stderr]    --> src/main.rs:308:12
[INFO] [stderr]     |
[INFO] [stderr] 308 |     } else if child.unwrap().status.success() == false {
[INFO] [stderr]     |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!child.unwrap().status.success()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/main.rs:386:4
[INFO] [stderr]     |
[INFO] [stderr] 386 |         .unwrap_or(dirs.data_local_dir().to_path_buf());
[INFO] [stderr]     |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| dirs.data_local_dir().to_path_buf())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]    --> src/main.rs:408:3
[INFO] [stderr]     |
[INFO] [stderr] 408 |            open::that(dirs.config_dir()).err()
[INFO] [stderr]     |   _________^
[INFO] [stderr]     |  |_________|
[INFO] [stderr]     | ||
[INFO] [stderr] 409 | ||             .map(|_| eprintln!("Debug: failed to `open` config directory"));
[INFO] [stderr]     | ||___________________________________________________________________________^- help: try this: `if let Some(_) = open::that(dirs.config_dir()).err() { $ crate :: io :: _eprint ( format_args_nl ! ( $ ( $ arg ) * ) ) ; }`
[INFO] [stderr]     | |____________________________________________________________________________|
[INFO] [stderr]     | 
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::option_map_unit_fn)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] 
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]    --> src/main.rs:410:3
[INFO] [stderr]     |
[INFO] [stderr] 410 |         open::that(&image_dir).err().map(|_| eprintln!("Debug: failed to `open` image directory"));
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-
[INFO] [stderr]     |         |
[INFO] [stderr]     |         help: try this: `if let Some(_) = open::that(&image_dir).err() { $ crate :: io :: _eprint ( format_args_nl ! ( $ ( $ arg ) * ) ) ; }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 4.77s
[INFO] running `"docker" "inspect" "ce103ebbc3301e7763ee2f334a76c4f0e91caf105463d684acf35c8020f1c4bf"`
[INFO] running `"docker" "rm" "-f" "ce103ebbc3301e7763ee2f334a76c4f0e91caf105463d684acf35c8020f1c4bf"`
[INFO] [stdout] ce103ebbc3301e7763ee2f334a76c4f0e91caf105463d684acf35c8020f1c4bf