[INFO] crate timeout_io 0.3.0 is already in cache [INFO] extracting crate timeout_io 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/timeout_io/0.3.0 [INFO] extracting crate timeout_io 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/timeout_io/0.3.0 [INFO] validating manifest of timeout_io-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of timeout_io-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing timeout_io-0.3.0 [INFO] finished frobbing timeout_io-0.3.0 [INFO] frobbed toml for timeout_io-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/timeout_io/0.3.0/Cargo.toml [INFO] started frobbing timeout_io-0.3.0 [INFO] finished frobbing timeout_io-0.3.0 [INFO] frobbed toml for timeout_io-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/timeout_io/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting timeout_io-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/timeout_io/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 83df6133b3e3d8446c2c2f39233da91ff23bc3f059d1ccc4c89089ccec09c0ee [INFO] running `"docker" "start" "-a" "83df6133b3e3d8446c2c2f39233da91ff23bc3f059d1ccc4c89089ccec09c0ee"` [INFO] [stderr] Checking etrace v1.1.1 [INFO] [stderr] Compiling timeout_io v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/event.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | pub fn raw(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/event.rs:67:14 [INFO] [stderr] | [INFO] [stderr] 67 | pub fn is_r(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/event.rs:71:14 [INFO] [stderr] | [INFO] [stderr] 71 | pub fn is_w(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/event.rs:75:14 [INFO] [stderr] | [INFO] [stderr] 75 | pub fn is_e(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `events` [INFO] [stderr] --> src/event.rs:132:11 [INFO] [stderr] | [INFO] [stderr] 132 | for i in 0..handles.as_mut().len() { handles.as_mut()[i].1.set_raw(events[i]); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 132 | for (i, ) in events.iter().enumerate().take(handles.as_mut().len()) { handles.as_mut()[i].1.set_raw(events[i]); } [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/reader.rs:72:6 [INFO] [stderr] | [INFO] [stderr] 72 | if buffer.len() == 0 { return Ok(0) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `buffer.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/reader.rs:120:50 [INFO] [stderr] | [INFO] [stderr] 120 | try_err!(Reader::read_exact(self, &mut buffer[total_read .. total_read + 1], timeout_point.remaining())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `total_read..=total_read` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/resolver.rs:42:26 [INFO] [stderr] | [INFO] [stderr] 42 | Ok(ref addresses) if (addresses as &ExactSizeIterator).len() == 0 => [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `(addresses as &ExactSizeIterator).is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/resolver.rs:64:5 [INFO] [stderr] | [INFO] [stderr] 64 | Err(_) => panic!("Resolver thread crashed without result") [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:84:30 [INFO] [stderr] | [INFO] [stderr] 84 | (self.as_secs() * 1000) + (self.subsec_nanos() as u64 / 1_000_000) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/event.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | pub fn raw(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/event.rs:67:14 [INFO] [stderr] | [INFO] [stderr] 67 | pub fn is_r(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/event.rs:71:14 [INFO] [stderr] | [INFO] [stderr] 71 | pub fn is_w(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/event.rs:75:14 [INFO] [stderr] | [INFO] [stderr] 75 | pub fn is_e(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `events` [INFO] [stderr] --> src/event.rs:132:11 [INFO] [stderr] | [INFO] [stderr] 132 | for i in 0..handles.as_mut().len() { handles.as_mut()[i].1.set_raw(events[i]); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 132 | for (i, ) in events.iter().enumerate().take(handles.as_mut().len()) { handles.as_mut()[i].1.set_raw(events[i]); } [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/reader.rs:72:6 [INFO] [stderr] | [INFO] [stderr] 72 | if buffer.len() == 0 { return Ok(0) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `buffer.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/reader.rs:120:50 [INFO] [stderr] | [INFO] [stderr] 120 | try_err!(Reader::read_exact(self, &mut buffer[total_read .. total_read + 1], timeout_point.remaining())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `total_read..=total_read` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/resolver.rs:42:26 [INFO] [stderr] | [INFO] [stderr] 42 | Ok(ref addresses) if (addresses as &ExactSizeIterator).len() == 0 => [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `(addresses as &ExactSizeIterator).is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/resolver.rs:64:5 [INFO] [stderr] | [INFO] [stderr] 64 | Err(_) => panic!("Resolver thread crashed without result") [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:84:30 [INFO] [stderr] | [INFO] [stderr] 84 | (self.as_secs() * 1000) + (self.subsec_nanos() as u64 / 1_000_000) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: The function/method `write` doesn't need a mutable reference [INFO] [stderr] --> tests/writer.rs:56:11 [INFO] [stderr] | [INFO] [stderr] 56 | s0.write(&mut data.clone(), Duration::from_secs(1)).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `write` doesn't need a mutable reference [INFO] [stderr] --> tests/writer.rs:70:12 [INFO] [stderr] | [INFO] [stderr] 70 | s0.write(&mut data, Duration::from_secs(1)).unwrap_err().kind.kind, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `write` doesn't need a mutable reference [INFO] [stderr] --> tests/writer.rs:82:12 [INFO] [stderr] | [INFO] [stderr] 82 | s0.write(&mut data, Duration::from_secs(1)).unwrap_err().kind.kind, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> tests/writer.rs:83:3 [INFO] [stderr] | [INFO] [stderr] 83 | match true { [INFO] [stderr] | _________^ [INFO] [stderr] 84 | | _ if cfg!(unix) => IoErrorKind::BrokenPipe, [INFO] [stderr] 85 | | _ if cfg!(windows) => IoErrorKind::Other, [INFO] [stderr] 86 | | _ => panic!("Unsupported platform") [INFO] [stderr] 87 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: The function/method `write` doesn't need a mutable reference [INFO] [stderr] --> tests/writer.rs:98:28 [INFO] [stderr] | [INFO] [stderr] 98 | if let Err(e) = s0.write(&mut data, Duration::from_secs(1)) { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `write` doesn't need a mutable reference [INFO] [stderr] --> tests/writer.rs:107:12 [INFO] [stderr] | [INFO] [stderr] 107 | s0.write(&mut data, Duration::from_secs(1)).unwrap_err().kind.kind, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `write_exact` doesn't need a mutable reference [INFO] [stderr] --> tests/writer.rs:120:17 [INFO] [stderr] | [INFO] [stderr] 120 | s0.write_exact(&mut data.clone(), Duration::from_secs(4)).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `write_exact` doesn't need a mutable reference [INFO] [stderr] --> tests/writer.rs:131:18 [INFO] [stderr] | [INFO] [stderr] 131 | s0.write_exact(&mut data.clone(), Duration::from_secs(4)).unwrap_err().kind.kind, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> tests/writer.rs:132:3 [INFO] [stderr] | [INFO] [stderr] 132 | match true { [INFO] [stderr] | _________^ [INFO] [stderr] 133 | | _ if cfg!(unix) => IoErrorKind::BrokenPipe, [INFO] [stderr] 134 | | _ if cfg!(windows) => IoErrorKind::Other, [INFO] [stderr] 135 | | _ => panic!("Unsupported platform") [INFO] [stderr] 136 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: The function/method `write_exact` doesn't need a mutable reference [INFO] [stderr] --> tests/writer.rs:145:18 [INFO] [stderr] | [INFO] [stderr] 145 | s0.write_exact(&mut data.clone(), Duration::from_secs(1)).unwrap_err().kind.kind, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.87s [INFO] running `"docker" "inspect" "83df6133b3e3d8446c2c2f39233da91ff23bc3f059d1ccc4c89089ccec09c0ee"` [INFO] running `"docker" "rm" "-f" "83df6133b3e3d8446c2c2f39233da91ff23bc3f059d1ccc4c89089ccec09c0ee"` [INFO] [stdout] 83df6133b3e3d8446c2c2f39233da91ff23bc3f059d1ccc4c89089ccec09c0ee