[INFO] crate timely 0.8.0 is already in cache [INFO] extracting crate timely 0.8.0 into work/ex/clippy-test-run/sources/stable/reg/timely/0.8.0 [INFO] extracting crate timely 0.8.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/timely/0.8.0 [INFO] validating manifest of timely-0.8.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of timely-0.8.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing timely-0.8.0 [INFO] finished frobbing timely-0.8.0 [INFO] frobbed toml for timely-0.8.0 written to work/ex/clippy-test-run/sources/stable/reg/timely/0.8.0/Cargo.toml [INFO] started frobbing timely-0.8.0 [INFO] finished frobbing timely-0.8.0 [INFO] frobbed toml for timely-0.8.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/timely/0.8.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting timely-0.8.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/timely/0.8.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bd832863d9fe0ccff230aefb0a2727c6ed8d18ff3eac6f8a54e577bcc5ae9853 [INFO] running `"docker" "start" "-a" "bd832863d9fe0ccff230aefb0a2727c6ed8d18ff3eac6f8a54e577bcc5ae9853"` [INFO] [stderr] Checking abomonation v0.7.0 [INFO] [stderr] Checking timely_bytes v0.7.0 [INFO] [stderr] Checking timely_logging v0.7.1 [INFO] [stderr] Checking timely_sort v0.1.6 [INFO] [stderr] Compiling abomonation_derive v0.3.0 [INFO] [stderr] Checking timely_communication v0.8.0 [INFO] [stderr] Checking timely v0.8.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/progress/broadcast.rs:132:21 [INFO] [stderr] | [INFO] [stderr] 132 | source: source, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `source` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/progress/broadcast.rs:132:21 [INFO] [stderr] | [INFO] [stderr] 132 | source: source, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `source` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/dataflow/operators/capture/mod.rs:84:1 [INFO] [stderr] | [INFO] [stderr] 84 | pub mod capture; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/dataflow/operators/capture/mod.rs:84:1 [INFO] [stderr] | [INFO] [stderr] 84 | pub mod capture; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/worker.rs:49:20 [INFO] [stderr] | [INFO] [stderr] 49 | timer: now.clone(), [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `now` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/worker.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | logging.as_mut().map(|l| l.flush()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(l) = logging.as_mut() { l.flush() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/worker.rs:171:59 [INFO] [stderr] | [INFO] [stderr] 171 | fn allocate(&mut self, identifier: usize) -> (Vec>>>, Box>>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `progress::change_batch::ChangeBatch` [INFO] [stderr] --> src/progress/change_batch.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | / pub fn new() -> ChangeBatch { [INFO] [stderr] 33 | | ChangeBatch { [INFO] [stderr] 34 | | updates: Vec::new(), [INFO] [stderr] 35 | | clean: 0 [INFO] [stderr] 36 | | } [INFO] [stderr] 37 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 13 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/progress/change_batch.rs:194:21 [INFO] [stderr] | [INFO] [stderr] 194 | pub fn is_empty(&mut self) -> bool { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/progress/nested/subgraph.rs:130:13 [INFO] [stderr] | [INFO] [stderr] 130 | / self.logging.as_mut().map(|l| l.log(::logging::OperatesEvent { [INFO] [stderr] 131 | | id: identifier, [INFO] [stderr] 132 | | addr: child_path, [INFO] [stderr] 133 | | name: child.name().to_owned(), [INFO] [stderr] 134 | | })); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 130 | if let Some(l) = self.logging.as_mut() { l.log(::logging::OperatesEvent { [INFO] [stderr] 131 | id: identifier, [INFO] [stderr] 132 | addr: child_path, [INFO] [stderr] 133 | name: child.name().to_owned(), [INFO] [stderr] 134 | }) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/progress/nested/subgraph.rs:251:43 [INFO] [stderr] | [INFO] [stderr] 251 | fn get_internal_summary(&mut self) -> (Vec>>, Vec>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: the loop variable `input` is used to index `internal_summary` [INFO] [stderr] --> src/progress/nested/subgraph.rs:291:22 [INFO] [stderr] | [INFO] [stderr] 291 | for input in 0..self.inputs() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 291 | for (input, ) in internal_summary.iter_mut().enumerate().take(self.inputs()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `output` is used to index `summary` [INFO] [stderr] --> src/progress/nested/subgraph.rs:377:27 [INFO] [stderr] | [INFO] [stderr] 377 | for output in 0..child.outputs { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 377 | for (output, ) in summary.iter_mut().enumerate().take(child.outputs) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `input` is used to index `capabilities` [INFO] [stderr] --> src/progress/nested/subgraph.rs:688:22 [INFO] [stderr] | [INFO] [stderr] 688 | for input in 0 .. self.inputs { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 688 | for (input, ) in capabilities.iter_mut().enumerate().take(self.inputs) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/progress/nested/subgraph.rs:778:21 [INFO] [stderr] | [INFO] [stderr] 778 | / self.logging.as_mut().map(|l| { [INFO] [stderr] 779 | | l.log(::logging::PushProgressEvent { [INFO] [stderr] 780 | | op_id: self_id, [INFO] [stderr] 781 | | }); [INFO] [stderr] 782 | | }); [INFO] [stderr] | |______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 778 | if let Some(l) = self.logging.as_mut() { l.log(::logging::PushProgressEvent { [INFO] [stderr] 779 | op_id: self_id, [INFO] [stderr] 780 | }); } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/progress/nested/subgraph.rs:794:17 [INFO] [stderr] | [INFO] [stderr] 794 | / self.logging.as_mut().map(|l| l.log(::logging::ScheduleEvent { [INFO] [stderr] 795 | | id: self_id, start_stop: ::logging::StartStop::Start [INFO] [stderr] 796 | | })); [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 794 | if let Some(l) = self.logging.as_mut() { l.log(::logging::ScheduleEvent { [INFO] [stderr] 795 | id: self_id, start_stop: ::logging::StartStop::Start [INFO] [stderr] 796 | }) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/progress/nested/subgraph.rs:837:17 [INFO] [stderr] | [INFO] [stderr] 837 | / self.logging.as_mut().map(|l| [INFO] [stderr] 838 | | l.log(::logging::ScheduleEvent { [INFO] [stderr] 839 | | id: self_id, [INFO] [stderr] 840 | | start_stop: ::logging::StartStop::Stop { activity: did_work } [INFO] [stderr] 841 | | })); [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 837 | if let Some(l) = self.logging.as_mut() { l.log(::logging::ScheduleEvent { [INFO] [stderr] 838 | id: self_id, [INFO] [stderr] 839 | start_stop: ::logging::StartStop::Stop { activity: did_work } [INFO] [stderr] 840 | }) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `progress::nested::reachability::Builder` [INFO] [stderr] --> src/progress/nested/reachability.rs:114:5 [INFO] [stderr] | [INFO] [stderr] 114 | / pub fn new() -> Self { [INFO] [stderr] 115 | | Builder { [INFO] [stderr] 116 | | nodes: Vec::new(), [INFO] [stderr] 117 | | edges: Vec::new(), [INFO] [stderr] 118 | | shape: Vec::new(), [INFO] [stderr] 119 | | } [INFO] [stderr] 120 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 95 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/progress/nested/reachability.rs:181:32 [INFO] [stderr] | [INFO] [stderr] 181 | let mut source_target: Vec)>>> = Vec::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/progress/nested/reachability.rs:182:32 [INFO] [stderr] | [INFO] [stderr] 182 | let mut target_target: Vec)>>> = Vec::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: the loop variable `node` is used to index `target_target` [INFO] [stderr] --> src/progress/nested/reachability.rs:228:25 [INFO] [stderr] | [INFO] [stderr] 228 | for node in 0 .. target_target.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 228 | for (node, ) in target_target.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `index` is used to index `target_target` [INFO] [stderr] --> src/progress/nested/reachability.rs:241:22 [INFO] [stderr] | [INFO] [stderr] 241 | for index in 0 .. self.nodes.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 241 | for (index, ) in target_target.iter_mut().enumerate().take(self.nodes.len()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/progress/nested/reachability.rs:275:24 [INFO] [stderr] | [INFO] [stderr] 275 | pub source_target: Vec)>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/progress/nested/reachability.rs:280:24 [INFO] [stderr] | [INFO] [stderr] 280 | pub target_target: Vec)>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/progress/nested/reachability.rs:346:20 [INFO] [stderr] | [INFO] [stderr] 346 | source_target: Vec)>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/progress/nested/reachability.rs:347:20 [INFO] [stderr] | [INFO] [stderr] 347 | target_target: Vec)>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/progress/nested/reachability.rs:374:51 [INFO] [stderr] | [INFO] [stderr] 374 | pub fn node_state(&mut self, index: usize) -> (&[MutableAntichain], &[MutableAntichain], &mut [ChangeBatch]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/progress/nested/reachability.rs:396:21 [INFO] [stderr] | [INFO] [stderr] 396 | pub fn is_empty(&mut self) -> bool { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: the loop variable `index` is only used to index `source_target`. [INFO] [stderr] --> src/progress/nested/reachability.rs:419:22 [INFO] [stderr] | [INFO] [stderr] 419 | for index in 0 .. source_target.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 419 | for in &source_target { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `index` is only used to index `target_target`. [INFO] [stderr] --> src/progress/nested/reachability.rs:425:22 [INFO] [stderr] | [INFO] [stderr] 425 | for index in 0 .. target_target.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 425 | for in &target_target { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `progress::nested::reachability_neu::Builder` [INFO] [stderr] --> src/progress/nested/reachability_neu.rs:149:5 [INFO] [stderr] | [INFO] [stderr] 149 | / pub fn new() -> Self { [INFO] [stderr] 150 | | Builder { [INFO] [stderr] 151 | | nodes: Vec::new(), [INFO] [stderr] 152 | | edges: Vec::new(), [INFO] [stderr] 153 | | shape: Vec::new(), [INFO] [stderr] 154 | | } [INFO] [stderr] 155 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 130 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/progress/nested/reachability_neu.rs:513:12 [INFO] [stderr] | [INFO] [stderr] 513 | nodes: &Vec>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Vec>>]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/progress/nested/reachability_neu.rs:514:12 [INFO] [stderr] | [INFO] [stderr] 514 | edges: &Vec>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Vec>]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/progress/nested/reachability_neu.rs:559:66 [INFO] [stderr] | [INFO] [stderr] 559 | let mut antichains = results.entry(location).or_insert(Vec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/progress/nested/reachability_neu.rs:580:65 [INFO] [stderr] | [INFO] [stderr] 580 | let mut antichains = results.entry(*source).or_insert(Vec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/progress/operate.rs:46:43 [INFO] [stderr] | [INFO] [stderr] 46 | fn get_internal_summary(&mut self) -> (Vec>>, Vec>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/progress/broadcast.rs:33:61 [INFO] [stderr] | [INFO] [stderr] 33 | pub fn new(worker: &mut A, path: &Vec, mut logging: Option) -> Progcaster { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 33 | pub fn new(worker: &mut A, path: &[usize], mut logging: Option) -> Progcaster { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] help: change `path.clone()` to [INFO] [stderr] | [INFO] [stderr] 42 | let addr = path.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/progress/broadcast.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | / logging.as_mut().map(|l| l.log(::logging::CommChannelsEvent { [INFO] [stderr] 38 | | identifier: channel_identifier, [INFO] [stderr] 39 | | kind: ::logging::CommChannelKind::Progress, [INFO] [stderr] 40 | | })); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 37 | if let Some(l) = logging.as_mut() { l.log(::logging::CommChannelsEvent { [INFO] [stderr] 38 | identifier: channel_identifier, [INFO] [stderr] 39 | kind: ::logging::CommChannelKind::Progress, [INFO] [stderr] 40 | }) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/progress/broadcast.rs:73:17 [INFO] [stderr] | [INFO] [stderr] 73 | / self.logging.as_ref().map(|l| l.log(::logging::ProgressEvent { [INFO] [stderr] 74 | | is_send: true, [INFO] [stderr] 75 | | source: self.source, [INFO] [stderr] 76 | | channel: self.channel_identifier, [INFO] [stderr] ... | [INFO] [stderr] 81 | | internal: Vec::new(), [INFO] [stderr] 82 | | })); [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 73 | if let Some(l) = self.logging.as_ref() { l.log(::logging::ProgressEvent { [INFO] [stderr] 74 | is_send: true, [INFO] [stderr] 75 | source: self.source, [INFO] [stderr] 76 | channel: self.channel_identifier, [INFO] [stderr] 77 | seq_no: self.counter, [INFO] [stderr] 78 | addr: self.addr.clone(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/progress/broadcast.rs:130:17 [INFO] [stderr] | [INFO] [stderr] 130 | / self.logging.as_ref().map(|l| l.log(::logging::ProgressEvent { [INFO] [stderr] 131 | | is_send: false, [INFO] [stderr] 132 | | source: source, [INFO] [stderr] 133 | | seq_no: counter, [INFO] [stderr] ... | [INFO] [stderr] 138 | | internal: Vec::new(), [INFO] [stderr] 139 | | })); [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 130 | if let Some(l) = self.logging.as_ref() { l.log(::logging::ProgressEvent { [INFO] [stderr] 131 | is_send: false, [INFO] [stderr] 132 | source: source, [INFO] [stderr] 133 | seq_no: counter, [INFO] [stderr] 134 | channel, [INFO] [stderr] 135 | addr: addr.clone(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/worker.rs:49:20 [INFO] [stderr] | [INFO] [stderr] 49 | timer: now.clone(), [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `now` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/worker.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | logging.as_mut().map(|l| l.flush()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(l) = logging.as_mut() { l.flush() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/worker.rs:171:59 [INFO] [stderr] | [INFO] [stderr] 171 | fn allocate(&mut self, identifier: usize) -> (Vec>>>, Box>>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `progress::change_batch::ChangeBatch` [INFO] [stderr] --> src/progress/change_batch.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | / pub fn new() -> ChangeBatch { [INFO] [stderr] 33 | | ChangeBatch { [INFO] [stderr] 34 | | updates: Vec::new(), [INFO] [stderr] 35 | | clean: 0 [INFO] [stderr] 36 | | } [INFO] [stderr] 37 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 13 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/dataflow/operators/input.rs:134:43 [INFO] [stderr] | [INFO] [stderr] 134 | fn get_internal_summary(&mut self) -> (Vec::Summary>>>, [INFO] [stderr] | ___________________________________________^ [INFO] [stderr] 135 | | Vec>) { [INFO] [stderr] | |_______________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/progress/change_batch.rs:194:21 [INFO] [stderr] | [INFO] [stderr] 194 | pub fn is_empty(&mut self) -> bool { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `dataflow::operators::input::Handle` [INFO] [stderr] --> src/dataflow/operators/input.rs:191:5 [INFO] [stderr] | [INFO] [stderr] 191 | / pub fn new() -> Self { [INFO] [stderr] 192 | | Handle { [INFO] [stderr] 193 | | progress: Vec::new(), [INFO] [stderr] 194 | | pushers: Vec::new(), [INFO] [stderr] ... | [INFO] [stderr] 198 | | } [INFO] [stderr] 199 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 155 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/dataflow/operators/input.rs:227:32 [INFO] [stderr] | [INFO] [stderr] 227 | pub fn to_stream(&mut self, scope: &mut G) -> Stream [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/dataflow/operators/unordered_input.rs:76:50 [INFO] [stderr] | [INFO] [stderr] 76 | fn new_unordered_input(&mut self) -> ((UnorderedHandle, Capability), Stream); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/dataflow/operators/unordered_input.rs:81:50 [INFO] [stderr] | [INFO] [stderr] 81 | fn new_unordered_input(&mut self) -> ((UnorderedHandle, Capability), Stream) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/dataflow/operators/unordered_input.rs:113:43 [INFO] [stderr] | [INFO] [stderr] 113 | fn get_internal_summary(&mut self) -> (Vec::Summary>>>, [INFO] [stderr] | ___________________________________________^ [INFO] [stderr] 114 | | Vec>) { [INFO] [stderr] | |_______________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/dataflow/operators/feedback.rs:71:66 [INFO] [stderr] | [INFO] [stderr] 71 | fn loop_variable(&mut self, summary: T::Summary) -> (Handle, D>, Stream, D>); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/dataflow/operators/feedback.rs:107:66 [INFO] [stderr] | [INFO] [stderr] 107 | fn loop_variable(&mut self, summary: T::Summary) -> (Handle, D>, Stream, D>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/dataflow/operators/feedback.rs:188:43 [INFO] [stderr] | [INFO] [stderr] 188 | fn get_internal_summary(&mut self) -> (Vec>>, Vec>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/progress/nested/subgraph.rs:130:13 [INFO] [stderr] | [INFO] [stderr] 130 | / self.logging.as_mut().map(|l| l.log(::logging::OperatesEvent { [INFO] [stderr] 131 | | id: identifier, [INFO] [stderr] 132 | | addr: child_path, [INFO] [stderr] 133 | | name: child.name().to_owned(), [INFO] [stderr] 134 | | })); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 130 | if let Some(l) = self.logging.as_mut() { l.log(::logging::OperatesEvent { [INFO] [stderr] 131 | id: identifier, [INFO] [stderr] 132 | addr: child_path, [INFO] [stderr] 133 | name: child.name().to_owned(), [INFO] [stderr] 134 | }) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/progress/nested/subgraph.rs:251:43 [INFO] [stderr] | [INFO] [stderr] 251 | fn get_internal_summary(&mut self) -> (Vec>>, Vec>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/dataflow/operators/partition.rs:68:14 [INFO] [stderr] | [INFO] [stderr] 68 | outputs: Vec>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: the loop variable `input` is used to index `internal_summary` [INFO] [stderr] --> src/progress/nested/subgraph.rs:291:22 [INFO] [stderr] | [INFO] [stderr] 291 | for input in 0..self.inputs() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 291 | for (input, ) in internal_summary.iter_mut().enumerate().take(self.inputs()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/dataflow/operators/map.rs:57:74 [INFO] [stderr] | [INFO] [stderr] 57 | output.session(&time).give_iterator(vector.drain(..).map(|x| logic(x))); [INFO] [stderr] | ^^^^^^^^^^^^ help: remove closure as shown: `logic` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: the loop variable `output` is used to index `summary` [INFO] [stderr] --> src/progress/nested/subgraph.rs:377:27 [INFO] [stderr] | [INFO] [stderr] 377 | for output in 0..child.outputs { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 377 | for (output, ) in summary.iter_mut().enumerate().take(child.outputs) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/dataflow/operators/filter.rs:32:20 [INFO] [stderr] | [INFO] [stderr] 32 | if vector.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!vector.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the loop variable `input` is used to index `capabilities` [INFO] [stderr] --> src/progress/nested/subgraph.rs:688:22 [INFO] [stderr] | [INFO] [stderr] 688 | for input in 0 .. self.inputs { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 688 | for (input, ) in capabilities.iter_mut().enumerate().take(self.inputs) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/progress/nested/subgraph.rs:778:21 [INFO] [stderr] | [INFO] [stderr] 778 | / self.logging.as_mut().map(|l| { [INFO] [stderr] 779 | | l.log(::logging::PushProgressEvent { [INFO] [stderr] 780 | | op_id: self_id, [INFO] [stderr] 781 | | }); [INFO] [stderr] 782 | | }); [INFO] [stderr] | |______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 778 | if let Some(l) = self.logging.as_mut() { l.log(::logging::PushProgressEvent { [INFO] [stderr] 779 | op_id: self_id, [INFO] [stderr] 780 | }); } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/dataflow/operators/broadcast.rs:68:12 [INFO] [stderr] | [INFO] [stderr] 68 | input: PullCounter>>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/dataflow/operators/broadcast.rs:77:43 [INFO] [stderr] | [INFO] [stderr] 77 | fn get_internal_summary(&mut self) -> (Vec>>, Vec>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/progress/nested/subgraph.rs:794:17 [INFO] [stderr] | [INFO] [stderr] 794 | / self.logging.as_mut().map(|l| l.log(::logging::ScheduleEvent { [INFO] [stderr] 795 | | id: self_id, start_stop: ::logging::StartStop::Start [INFO] [stderr] 796 | | })); [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 794 | if let Some(l) = self.logging.as_mut() { l.log(::logging::ScheduleEvent { [INFO] [stderr] 795 | id: self_id, start_stop: ::logging::StartStop::Start [INFO] [stderr] 796 | }) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/progress/nested/subgraph.rs:837:17 [INFO] [stderr] | [INFO] [stderr] 837 | / self.logging.as_mut().map(|l| [INFO] [stderr] 838 | | l.log(::logging::ScheduleEvent { [INFO] [stderr] 839 | | id: self_id, [INFO] [stderr] 840 | | start_stop: ::logging::StartStop::Stop { activity: did_work } [INFO] [stderr] 841 | | })); [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 837 | if let Some(l) = self.logging.as_mut() { l.log(::logging::ScheduleEvent { [INFO] [stderr] 838 | id: self_id, [INFO] [stderr] 839 | start_stop: ::logging::StartStop::Stop { activity: did_work } [INFO] [stderr] 840 | }) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `progress::nested::reachability::Builder` [INFO] [stderr] --> src/progress/nested/reachability.rs:114:5 [INFO] [stderr] | [INFO] [stderr] 114 | / pub fn new() -> Self { [INFO] [stderr] 115 | | Builder { [INFO] [stderr] 116 | | nodes: Vec::new(), [INFO] [stderr] 117 | | edges: Vec::new(), [INFO] [stderr] 118 | | shape: Vec::new(), [INFO] [stderr] 119 | | } [INFO] [stderr] 120 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 95 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `dataflow::operators::probe::Handle` [INFO] [stderr] --> src/dataflow/operators/probe.rs:150:15 [INFO] [stderr] | [INFO] [stderr] 150 | #[inline] pub fn new() -> Self { Handle { frontier: Rc::new(RefCell::new(MutableAntichain::new())) } } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 138 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/progress/nested/reachability.rs:181:32 [INFO] [stderr] | [INFO] [stderr] 181 | let mut source_target: Vec)>>> = Vec::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/progress/nested/reachability.rs:182:32 [INFO] [stderr] | [INFO] [stderr] 182 | let mut target_target: Vec)>>> = Vec::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: the loop variable `node` is used to index `target_target` [INFO] [stderr] --> src/progress/nested/reachability.rs:228:25 [INFO] [stderr] | [INFO] [stderr] 228 | for node in 0 .. target_target.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 228 | for (node, ) in target_target.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `index` is used to index `target_target` [INFO] [stderr] --> src/progress/nested/reachability.rs:241:22 [INFO] [stderr] | [INFO] [stderr] 241 | for index in 0 .. self.nodes.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 241 | for (index, ) in target_target.iter_mut().enumerate().take(self.nodes.len()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/progress/nested/reachability.rs:275:24 [INFO] [stderr] | [INFO] [stderr] 275 | pub source_target: Vec)>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/progress/nested/reachability.rs:280:24 [INFO] [stderr] | [INFO] [stderr] 280 | pub target_target: Vec)>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/progress/nested/reachability.rs:346:20 [INFO] [stderr] | [INFO] [stderr] 346 | source_target: Vec)>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/progress/nested/reachability.rs:347:20 [INFO] [stderr] | [INFO] [stderr] 347 | target_target: Vec)>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/progress/nested/reachability.rs:374:51 [INFO] [stderr] | [INFO] [stderr] 374 | pub fn node_state(&mut self, index: usize) -> (&[MutableAntichain], &[MutableAntichain], &mut [ChangeBatch]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/progress/nested/reachability.rs:396:21 [INFO] [stderr] | [INFO] [stderr] 396 | pub fn is_empty(&mut self) -> bool { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: the loop variable `index` is only used to index `source_target`. [INFO] [stderr] --> src/progress/nested/reachability.rs:419:22 [INFO] [stderr] | [INFO] [stderr] 419 | for index in 0 .. source_target.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 419 | for in &source_target { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `index` is only used to index `target_target`. [INFO] [stderr] --> src/progress/nested/reachability.rs:425:22 [INFO] [stderr] | [INFO] [stderr] 425 | for index in 0 .. target_target.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 425 | for in &target_target { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `progress::nested::reachability_neu::Builder` [INFO] [stderr] --> src/progress/nested/reachability_neu.rs:149:5 [INFO] [stderr] | [INFO] [stderr] 149 | / pub fn new() -> Self { [INFO] [stderr] 150 | | Builder { [INFO] [stderr] 151 | | nodes: Vec::new(), [INFO] [stderr] 152 | | edges: Vec::new(), [INFO] [stderr] 153 | | shape: Vec::new(), [INFO] [stderr] 154 | | } [INFO] [stderr] 155 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 130 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `dataflow::operators::capture::event::link::EventLink` [INFO] [stderr] --> src/dataflow/operators/capture/event.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | / pub fn new() -> EventLink { [INFO] [stderr] 66 | | EventLink { event: None, next: RefCell::new(None) } [INFO] [stderr] 67 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 53 | #[derive(Default)] [INFO] [stderr] 54 | pub struct EventLink { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/progress/nested/reachability_neu.rs:513:12 [INFO] [stderr] | [INFO] [stderr] 513 | nodes: &Vec>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Vec>>]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/progress/nested/reachability_neu.rs:514:12 [INFO] [stderr] | [INFO] [stderr] 514 | edges: &Vec>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Vec>]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/progress/nested/reachability_neu.rs:559:66 [INFO] [stderr] | [INFO] [stderr] 559 | let mut antichains = results.entry(location).or_insert(Vec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/progress/nested/reachability_neu.rs:580:65 [INFO] [stderr] | [INFO] [stderr] 580 | let mut antichains = results.entry(*source).or_insert(Vec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/progress/operate.rs:46:43 [INFO] [stderr] | [INFO] [stderr] 46 | fn get_internal_summary(&mut self) -> (Vec>>, Vec>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/progress/broadcast.rs:33:61 [INFO] [stderr] | [INFO] [stderr] 33 | pub fn new(worker: &mut A, path: &Vec, mut logging: Option) -> Progcaster { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 33 | pub fn new(worker: &mut A, path: &[usize], mut logging: Option) -> Progcaster { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] help: change `path.clone()` to [INFO] [stderr] | [INFO] [stderr] 42 | let addr = path.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/progress/broadcast.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | / logging.as_mut().map(|l| l.log(::logging::CommChannelsEvent { [INFO] [stderr] 38 | | identifier: channel_identifier, [INFO] [stderr] 39 | | kind: ::logging::CommChannelKind::Progress, [INFO] [stderr] 40 | | })); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 37 | if let Some(l) = logging.as_mut() { l.log(::logging::CommChannelsEvent { [INFO] [stderr] 38 | identifier: channel_identifier, [INFO] [stderr] 39 | kind: ::logging::CommChannelKind::Progress, [INFO] [stderr] 40 | }) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/progress/broadcast.rs:73:17 [INFO] [stderr] | [INFO] [stderr] 73 | / self.logging.as_ref().map(|l| l.log(::logging::ProgressEvent { [INFO] [stderr] 74 | | is_send: true, [INFO] [stderr] 75 | | source: self.source, [INFO] [stderr] 76 | | channel: self.channel_identifier, [INFO] [stderr] ... | [INFO] [stderr] 81 | | internal: Vec::new(), [INFO] [stderr] 82 | | })); [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 73 | if let Some(l) = self.logging.as_ref() { l.log(::logging::ProgressEvent { [INFO] [stderr] 74 | is_send: true, [INFO] [stderr] 75 | source: self.source, [INFO] [stderr] 76 | channel: self.channel_identifier, [INFO] [stderr] 77 | seq_no: self.counter, [INFO] [stderr] 78 | addr: self.addr.clone(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/progress/broadcast.rs:130:17 [INFO] [stderr] | [INFO] [stderr] 130 | / self.logging.as_ref().map(|l| l.log(::logging::ProgressEvent { [INFO] [stderr] 131 | | is_send: false, [INFO] [stderr] 132 | | source: source, [INFO] [stderr] 133 | | seq_no: counter, [INFO] [stderr] ... | [INFO] [stderr] 138 | | internal: Vec::new(), [INFO] [stderr] 139 | | })); [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 130 | if let Some(l) = self.logging.as_ref() { l.log(::logging::ProgressEvent { [INFO] [stderr] 131 | is_send: false, [INFO] [stderr] 132 | source: source, [INFO] [stderr] 133 | seq_no: counter, [INFO] [stderr] 134 | channel, [INFO] [stderr] 135 | addr: addr.clone(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/dataflow/operators/generic/builder_rc.rs:32:15 [INFO] [stderr] | [INFO] [stderr] 32 | internal: Rc>>>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/dataflow/operators/generic/builder_rc.rs:81:46 [INFO] [stderr] | [INFO] [stderr] 81 | pub fn new_output(&mut self) -> (OutputWrapper>, Stream) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/dataflow/operators/generic/builder_rc.rs:87:123 [INFO] [stderr] | [INFO] [stderr] 87 | pub fn new_output_connection(&mut self, connection: Vec::Summary>>) -> (OutputWrapper>, Stream) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/dataflow/operators/generic/builder_raw.rs:192:43 [INFO] [stderr] | [INFO] [stderr] 192 | fn get_internal_summary(&mut self) -> (Vec>>, Vec>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/dataflow/operators/generic/handles.rs:27:15 [INFO] [stderr] | [INFO] [stderr] 27 | internal: Rc>>>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/dataflow/operators/generic/handles.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | / pub fn next(&mut self) -> Option<(CapabilityRef, RefOrMut>)> { [INFO] [stderr] 46 | | let internal = &self.internal; [INFO] [stderr] 47 | | self.pull_counter.next().map(|bundle| { [INFO] [stderr] 48 | | match bundle.as_ref_or_mut() { [INFO] [stderr] ... | [INFO] [stderr] 56 | | }) [INFO] [stderr] 57 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/dataflow/operators/generic/handles.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | logging.as_mut().map(|l| l.log(::logging::GuardedMessageEvent { is_start: true })); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(l) = logging.as_mut() { l.log(::logging::GuardedMessageEvent { is_start: true }) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/dataflow/operators/generic/handles.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | logging.as_mut().map(|l| l.log(::logging::GuardedMessageEvent { is_start: false })); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(l) = logging.as_mut() { l.log(::logging::GuardedMessageEvent { is_start: false }) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/dataflow/operators/generic/handles.rs:102:5 [INFO] [stderr] | [INFO] [stderr] 102 | / pub fn next(&mut self) -> Option<(CapabilityRef, RefOrMut>)> { [INFO] [stderr] 103 | | self.handle.next() [INFO] [stderr] 104 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/dataflow/operators/generic/handles.rs:142:111 [INFO] [stderr] | [INFO] [stderr] 142 | pub fn new_input_handle>>(pull_counter: PullCounter, internal: Rc>>>>>, logging: Option) -> InputHandle { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/dataflow/operators/generic/notificator.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | self.logging.as_ref().map(|l| l.log(::logging::GuardedProgressEvent { is_start: true })); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(l) = self.logging.as_ref() { l.log(::logging::GuardedProgressEvent { is_start: true }) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/dataflow/operators/generic/notificator.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | self.logging.as_ref().map(|l| l.log(::logging::GuardedProgressEvent { is_start: false })); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(l) = self.logging.as_ref() { l.log(::logging::GuardedProgressEvent { is_start: false }) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `dataflow::operators::generic::notificator::FrontierNotificator` [INFO] [stderr] --> src/dataflow/operators/generic/notificator.rs:240:5 [INFO] [stderr] | [INFO] [stderr] 240 | / pub fn new() -> Self { [INFO] [stderr] 241 | | FrontierNotificator { [INFO] [stderr] 242 | | pending: Vec::new(), [INFO] [stderr] 243 | | available: ::std::collections::BinaryHeap::new(), [INFO] [stderr] 244 | | } [INFO] [stderr] 245 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 233 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/dataflow/operators/generic/notificator.rs:285:22 [INFO] [stderr] | [INFO] [stderr] 285 | pub fn notify_at<'a>(&mut self, cap: Capability) { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/dataflow/operators/input.rs:134:43 [INFO] [stderr] | [INFO] [stderr] 134 | fn get_internal_summary(&mut self) -> (Vec::Summary>>>, [INFO] [stderr] | ___________________________________________^ [INFO] [stderr] 135 | | Vec>) { [INFO] [stderr] | |_______________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `dataflow::operators::input::Handle` [INFO] [stderr] --> src/dataflow/operators/input.rs:191:5 [INFO] [stderr] | [INFO] [stderr] 191 | / pub fn new() -> Self { [INFO] [stderr] 192 | | Handle { [INFO] [stderr] 193 | | progress: Vec::new(), [INFO] [stderr] 194 | | pushers: Vec::new(), [INFO] [stderr] ... | [INFO] [stderr] 198 | | } [INFO] [stderr] 199 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 155 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/dataflow/operators/input.rs:227:32 [INFO] [stderr] | [INFO] [stderr] 227 | pub fn to_stream(&mut self, scope: &mut G) -> Stream [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/dataflow/operators/capability.rs:171:15 [INFO] [stderr] | [INFO] [stderr] 171 | internal: Rc>>>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/dataflow/operators/capability.rs:253:62 [INFO] [stderr] | [INFO] [stderr] 253 | pub fn mint_ref<'cap, T: Timestamp>(time: &'cap T, internal: Rc>>>>>) -> CapabilityRef<'cap, T> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `dataflow::operators::capability::CapabilitySet` [INFO] [stderr] --> src/dataflow/operators/capability.rs:268:5 [INFO] [stderr] | [INFO] [stderr] 268 | / pub fn new() -> Self { [INFO] [stderr] 269 | | CapabilitySet { elements: Vec::new() } [INFO] [stderr] 270 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 261 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/dataflow/operators/unordered_input.rs:76:50 [INFO] [stderr] | [INFO] [stderr] 76 | fn new_unordered_input(&mut self) -> ((UnorderedHandle, Capability), Stream); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/dataflow/channels/pushers/tee.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | shared: Rc>>>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/dataflow/operators/unordered_input.rs:81:50 [INFO] [stderr] | [INFO] [stderr] 81 | fn new_unordered_input(&mut self) -> ((UnorderedHandle, Capability), Stream) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/dataflow/channels/pushers/tee.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | shared: Rc>>>>> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/dataflow/operators/unordered_input.rs:113:43 [INFO] [stderr] | [INFO] [stderr] 113 | fn get_internal_summary(&mut self) -> (Vec::Summary>>>, [INFO] [stderr] | ___________________________________________^ [INFO] [stderr] 114 | | Vec>) { [INFO] [stderr] | |_______________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/dataflow/operators/feedback.rs:71:66 [INFO] [stderr] | [INFO] [stderr] 71 | fn loop_variable(&mut self, summary: T::Summary) -> (Handle, D>, Stream, D>); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/dataflow/operators/feedback.rs:107:66 [INFO] [stderr] | [INFO] [stderr] 107 | fn loop_variable(&mut self, summary: T::Summary) -> (Handle, D>, Stream, D>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/dataflow/operators/feedback.rs:188:43 [INFO] [stderr] | [INFO] [stderr] 188 | fn get_internal_summary(&mut self) -> (Vec>>, Vec>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/dataflow/channels/pushers/buffer.rs:116:12 [INFO] [stderr] | [INFO] [stderr] 116 | if message.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!message.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/dataflow/channels/pushers/buffer.rs:147:12 [INFO] [stderr] | [INFO] [stderr] 147 | if message.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!message.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/dataflow/channels/pullers/counter.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | / pub fn next(&mut self) -> Option<&mut Bundle> { [INFO] [stderr] 21 | | if let Some(message) = self.pullable.pull() { [INFO] [stderr] 22 | | if message.data.len() > 0 { [INFO] [stderr] 23 | | self.consumed.borrow_mut().update(message.time.clone(), message.data.len() as i64); [INFO] [stderr] ... | [INFO] [stderr] 28 | | else { None } [INFO] [stderr] 29 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/dataflow/channels/pullers/counter.rs:22:16 [INFO] [stderr] | [INFO] [stderr] 22 | if message.data.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!message.data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/dataflow/channels/pact.rs:123:13 [INFO] [stderr] | [INFO] [stderr] 123 | / self.logging.as_ref().map(|l| l.log(::logging::MessagesEvent { [INFO] [stderr] 124 | | is_send: true, [INFO] [stderr] 125 | | channel: self.channel, [INFO] [stderr] 126 | | source: self.source, [INFO] [stderr] ... | [INFO] [stderr] 129 | | length: bundle.data.len(), [INFO] [stderr] 130 | | })); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 123 | if let Some(l) = self.logging.as_ref() { l.log(::logging::MessagesEvent { [INFO] [stderr] 124 | is_send: true, [INFO] [stderr] 125 | channel: self.channel, [INFO] [stderr] 126 | source: self.source, [INFO] [stderr] 127 | target: self.target, [INFO] [stderr] 128 | seq_no: self.counter-1, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/dataflow/operators/partition.rs:68:14 [INFO] [stderr] | [INFO] [stderr] 68 | outputs: Vec>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/dataflow/channels/pact.rs:164:13 [INFO] [stderr] | [INFO] [stderr] 164 | / self.logging.as_ref().map(|l| l.log(::logging::MessagesEvent { [INFO] [stderr] 165 | | is_send: false, [INFO] [stderr] 166 | | channel, [INFO] [stderr] 167 | | source: bundle.from, [INFO] [stderr] ... | [INFO] [stderr] 170 | | length: bundle.data.len(), [INFO] [stderr] 171 | | })); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 164 | if let Some(l) = self.logging.as_ref() { l.log(::logging::MessagesEvent { [INFO] [stderr] 165 | is_send: false, [INFO] [stderr] 166 | channel, [INFO] [stderr] 167 | source: bundle.from, [INFO] [stderr] 168 | target, [INFO] [stderr] 169 | seq_no: bundle.seq, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/dataflow/operators/map.rs:57:74 [INFO] [stderr] | [INFO] [stderr] 57 | output.session(&time).give_iterator(vector.drain(..).map(|x| logic(x))); [INFO] [stderr] | ^^^^^^^^^^^^ help: remove closure as shown: `logic` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/dataflow/operators/filter.rs:32:20 [INFO] [stderr] | [INFO] [stderr] 32 | if vector.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!vector.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/dataflow/scopes/child.rs:114:59 [INFO] [stderr] | [INFO] [stderr] 114 | fn allocate(&mut self, identifier: usize) -> (Vec>>>, Box>>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/dataflow/operators/broadcast.rs:68:12 [INFO] [stderr] | [INFO] [stderr] 68 | input: PullCounter>>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/dataflow/operators/broadcast.rs:77:43 [INFO] [stderr] | [INFO] [stderr] 77 | fn get_internal_summary(&mut self) -> (Vec>>, Vec>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/dataflow/stream.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | / logging.as_mut().map(|l| l.log(::logging::ChannelsEvent { [INFO] [stderr] 39 | | id: identifier, [INFO] [stderr] 40 | | scope_addr: self.scope.addr(), [INFO] [stderr] 41 | | source: (self.name.index, self.name.port), [INFO] [stderr] 42 | | target: (target.index, target.port), [INFO] [stderr] 43 | | })); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 38 | if let Some(l) = logging.as_mut() { l.log(::logging::ChannelsEvent { [INFO] [stderr] 39 | id: identifier, [INFO] [stderr] 40 | scope_addr: self.scope.addr(), [INFO] [stderr] 41 | source: (self.name.index, self.name.port), [INFO] [stderr] 42 | target: (target.index, target.port), [INFO] [stderr] 43 | }) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `dataflow::operators::probe::Handle` [INFO] [stderr] --> src/dataflow/operators/probe.rs:150:15 [INFO] [stderr] | [INFO] [stderr] 150 | #[inline] pub fn new() -> Self { Handle { frontier: Rc::new(RefCell::new(MutableAntichain::new())) } } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 138 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/synchronization/sequence.rs:84:41 [INFO] [stderr] | [INFO] [stderr] 84 | recvd.push((time.time().clone(), element)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*time.time()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/synchronization/sequence.rs:110:5 [INFO] [stderr] | [INFO] [stderr] 110 | / pub fn next(&mut self) -> Option { [INFO] [stderr] 111 | | self.recv.borrow_mut().pop_front() [INFO] [stderr] 112 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `dataflow::operators::capture::event::link::EventLink` [INFO] [stderr] --> src/dataflow/operators/capture/event.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | / pub fn new() -> EventLink { [INFO] [stderr] 66 | | EventLink { event: None, next: RefCell::new(None) } [INFO] [stderr] 67 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 53 | #[derive(Default)] [INFO] [stderr] 54 | pub struct EventLink { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/logging.rs:32:28 [INFO] [stderr] | [INFO] [stderr] 32 | let new_frontier = time.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/logging.rs:33:28 [INFO] [stderr] | [INFO] [stderr] 33 | let old_frontier = self.time.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/logging.rs:36:21 [INFO] [stderr] | [INFO] [stderr] 36 | self.time = time.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/dataflow/operators/generic/builder_rc.rs:32:15 [INFO] [stderr] | [INFO] [stderr] 32 | internal: Rc>>>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/dataflow/operators/generic/builder_rc.rs:81:46 [INFO] [stderr] | [INFO] [stderr] 81 | pub fn new_output(&mut self) -> (OutputWrapper>, Stream) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/dataflow/operators/generic/builder_rc.rs:87:123 [INFO] [stderr] | [INFO] [stderr] 87 | pub fn new_output_connection(&mut self, connection: Vec::Summary>>) -> (OutputWrapper>, Stream) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/dataflow/operators/generic/builder_raw.rs:192:43 [INFO] [stderr] | [INFO] [stderr] 192 | fn get_internal_summary(&mut self) -> (Vec>>, Vec>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/dataflow/operators/generic/handles.rs:27:15 [INFO] [stderr] | [INFO] [stderr] 27 | internal: Rc>>>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/dataflow/operators/generic/handles.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | / pub fn next(&mut self) -> Option<(CapabilityRef, RefOrMut>)> { [INFO] [stderr] 46 | | let internal = &self.internal; [INFO] [stderr] 47 | | self.pull_counter.next().map(|bundle| { [INFO] [stderr] 48 | | match bundle.as_ref_or_mut() { [INFO] [stderr] ... | [INFO] [stderr] 56 | | }) [INFO] [stderr] 57 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/dataflow/operators/generic/handles.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | logging.as_mut().map(|l| l.log(::logging::GuardedMessageEvent { is_start: true })); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(l) = logging.as_mut() { l.log(::logging::GuardedMessageEvent { is_start: true }) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/dataflow/operators/generic/handles.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | logging.as_mut().map(|l| l.log(::logging::GuardedMessageEvent { is_start: false })); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(l) = logging.as_mut() { l.log(::logging::GuardedMessageEvent { is_start: false }) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/dataflow/operators/generic/handles.rs:102:5 [INFO] [stderr] | [INFO] [stderr] 102 | / pub fn next(&mut self) -> Option<(CapabilityRef, RefOrMut>)> { [INFO] [stderr] 103 | | self.handle.next() [INFO] [stderr] 104 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/dataflow/operators/generic/handles.rs:142:111 [INFO] [stderr] | [INFO] [stderr] 142 | pub fn new_input_handle>>(pull_counter: PullCounter, internal: Rc>>>>>, logging: Option) -> InputHandle { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/dataflow/operators/generic/notificator.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | self.logging.as_ref().map(|l| l.log(::logging::GuardedProgressEvent { is_start: true })); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(l) = self.logging.as_ref() { l.log(::logging::GuardedProgressEvent { is_start: true }) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/dataflow/operators/generic/notificator.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | self.logging.as_ref().map(|l| l.log(::logging::GuardedProgressEvent { is_start: false })); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(l) = self.logging.as_ref() { l.log(::logging::GuardedProgressEvent { is_start: false }) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `dataflow::operators::generic::notificator::FrontierNotificator` [INFO] [stderr] --> src/dataflow/operators/generic/notificator.rs:240:5 [INFO] [stderr] | [INFO] [stderr] 240 | / pub fn new() -> Self { [INFO] [stderr] 241 | | FrontierNotificator { [INFO] [stderr] 242 | | pending: Vec::new(), [INFO] [stderr] 243 | | available: ::std::collections::BinaryHeap::new(), [INFO] [stderr] 244 | | } [INFO] [stderr] 245 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 233 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/dataflow/operators/generic/notificator.rs:285:22 [INFO] [stderr] | [INFO] [stderr] 285 | pub fn notify_at<'a>(&mut self, cap: Capability) { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/dataflow/operators/capability.rs:171:15 [INFO] [stderr] | [INFO] [stderr] 171 | internal: Rc>>>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/dataflow/operators/capability.rs:253:62 [INFO] [stderr] | [INFO] [stderr] 253 | pub fn mint_ref<'cap, T: Timestamp>(time: &'cap T, internal: Rc>>>>>) -> CapabilityRef<'cap, T> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `dataflow::operators::capability::CapabilitySet` [INFO] [stderr] --> src/dataflow/operators/capability.rs:268:5 [INFO] [stderr] | [INFO] [stderr] 268 | / pub fn new() -> Self { [INFO] [stderr] 269 | | CapabilitySet { elements: Vec::new() } [INFO] [stderr] 270 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 261 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/dataflow/channels/pushers/tee.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | shared: Rc>>>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/dataflow/channels/pushers/tee.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | shared: Rc>>>>> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/dataflow/channels/pushers/buffer.rs:116:12 [INFO] [stderr] | [INFO] [stderr] 116 | if message.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!message.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/dataflow/channels/pushers/buffer.rs:147:12 [INFO] [stderr] | [INFO] [stderr] 147 | if message.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!message.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/dataflow/channels/pullers/counter.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | / pub fn next(&mut self) -> Option<&mut Bundle> { [INFO] [stderr] 21 | | if let Some(message) = self.pullable.pull() { [INFO] [stderr] 22 | | if message.data.len() > 0 { [INFO] [stderr] 23 | | self.consumed.borrow_mut().update(message.time.clone(), message.data.len() as i64); [INFO] [stderr] ... | [INFO] [stderr] 28 | | else { None } [INFO] [stderr] 29 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/dataflow/channels/pullers/counter.rs:22:16 [INFO] [stderr] | [INFO] [stderr] 22 | if message.data.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!message.data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/dataflow/channels/pact.rs:123:13 [INFO] [stderr] | [INFO] [stderr] 123 | / self.logging.as_ref().map(|l| l.log(::logging::MessagesEvent { [INFO] [stderr] 124 | | is_send: true, [INFO] [stderr] 125 | | channel: self.channel, [INFO] [stderr] 126 | | source: self.source, [INFO] [stderr] ... | [INFO] [stderr] 129 | | length: bundle.data.len(), [INFO] [stderr] 130 | | })); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 123 | if let Some(l) = self.logging.as_ref() { l.log(::logging::MessagesEvent { [INFO] [stderr] 124 | is_send: true, [INFO] [stderr] 125 | channel: self.channel, [INFO] [stderr] 126 | source: self.source, [INFO] [stderr] 127 | target: self.target, [INFO] [stderr] 128 | seq_no: self.counter-1, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/dataflow/channels/pact.rs:164:13 [INFO] [stderr] | [INFO] [stderr] 164 | / self.logging.as_ref().map(|l| l.log(::logging::MessagesEvent { [INFO] [stderr] 165 | | is_send: false, [INFO] [stderr] 166 | | channel, [INFO] [stderr] 167 | | source: bundle.from, [INFO] [stderr] ... | [INFO] [stderr] 170 | | length: bundle.data.len(), [INFO] [stderr] 171 | | })); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 164 | if let Some(l) = self.logging.as_ref() { l.log(::logging::MessagesEvent { [INFO] [stderr] 165 | is_send: false, [INFO] [stderr] 166 | channel, [INFO] [stderr] 167 | source: bundle.from, [INFO] [stderr] 168 | target, [INFO] [stderr] 169 | seq_no: bundle.seq, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/dataflow/scopes/child.rs:114:59 [INFO] [stderr] | [INFO] [stderr] 114 | fn allocate(&mut self, identifier: usize) -> (Vec>>>, Box>>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/dataflow/stream.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | / logging.as_mut().map(|l| l.log(::logging::ChannelsEvent { [INFO] [stderr] 39 | | id: identifier, [INFO] [stderr] 40 | | scope_addr: self.scope.addr(), [INFO] [stderr] 41 | | source: (self.name.index, self.name.port), [INFO] [stderr] 42 | | target: (target.index, target.port), [INFO] [stderr] 43 | | })); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 38 | if let Some(l) = logging.as_mut() { l.log(::logging::ChannelsEvent { [INFO] [stderr] 39 | id: identifier, [INFO] [stderr] 40 | scope_addr: self.scope.addr(), [INFO] [stderr] 41 | source: (self.name.index, self.name.port), [INFO] [stderr] 42 | target: (target.index, target.port), [INFO] [stderr] 43 | }) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/synchronization/sequence.rs:84:41 [INFO] [stderr] | [INFO] [stderr] 84 | recvd.push((time.time().clone(), element)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*time.time()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/synchronization/sequence.rs:110:5 [INFO] [stderr] | [INFO] [stderr] 110 | / pub fn next(&mut self) -> Option { [INFO] [stderr] 111 | | self.recv.borrow_mut().pop_front() [INFO] [stderr] 112 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/logging.rs:32:28 [INFO] [stderr] | [INFO] [stderr] 32 | let new_frontier = time.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/logging.rs:33:28 [INFO] [stderr] | [INFO] [stderr] 33 | let old_frontier = self.time.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/logging.rs:36:21 [INFO] [stderr] | [INFO] [stderr] 36 | self.time = time.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> tests/barrier.rs:23:53 [INFO] [stderr] | [INFO] [stderr] 23 | while let Some((cap, _count)) = notificator.next() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `for (cap, _count) in notificator { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> examples/flow_controlled.rs:8:32 [INFO] [stderr] | [INFO] [stderr] 8 | let mut input = (0u64..100000).peekable(); [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> examples/unionfind.rs:75:34 [INFO] [stderr] | [INFO] [stderr] 75 | for i in roots.len() .. (m + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `roots.len()..=m` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> examples/logging-recv.rs:23:18 [INFO] [stderr] | [INFO] [stderr] 23 | .map(|r| EventReader::::new(r)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `EventReader::::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> examples/capture_recv.rs:20:18 [INFO] [stderr] | [INFO] [stderr] 20 | .map(|r| EventReader::<_,u64,_>::new(r)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `EventReader::<_,u64,_>::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> examples/pingpong.rs:22:41 [INFO] [stderr] | [INFO] [stderr] 22 | .branch_when(move |t| t < &iterations).1 [INFO] [stderr] | ^^^^----------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `iterations` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> examples/exchange.rs:40:85 [INFO] [stderr] | [INFO] [stderr] 40 | let seconds = elapsed.as_secs() as f64 + (f64::from(elapsed.subsec_nanos())/1000000000.0); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `1_000_000_000.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> examples/distinct.rs:27:34 [INFO] [stderr] | [INFO] [stderr] 27 | .or_insert(HashMap::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(HashMap::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> examples/logging-send.rs:73:85 [INFO] [stderr] | [INFO] [stderr] 73 | let seconds = elapsed.as_secs() as f64 + (f64::from(elapsed.subsec_nanos())/1000000000.0); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `1_000_000_000.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> examples/hashjoin.rs:55:55 [INFO] [stderr] | [INFO] [stderr] 55 | session.give((val1.clone(), val2.clone())); [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `val1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> examples/hashjoin.rs:55:69 [INFO] [stderr] | [INFO] [stderr] 55 | session.give((val1.clone(), val2.clone())); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*val2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> examples/hashjoin.rs:59:49 [INFO] [stderr] | [INFO] [stderr] 59 | map1.entry(key).or_insert(Vec::new()).push(val1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> examples/hashjoin.rs:70:55 [INFO] [stderr] | [INFO] [stderr] 70 | session.give((val1.clone(), val2.clone())); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*val1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> examples/hashjoin.rs:70:69 [INFO] [stderr] | [INFO] [stderr] 70 | session.give((val1.clone(), val2.clone())); [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `val2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> examples/hashjoin.rs:74:49 [INFO] [stderr] | [INFO] [stderr] 74 | map2.entry(key).or_insert(Vec::new()).push(val2); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> examples/openloop.rs:50:66 [INFO] [stderr] | [INFO] [stderr] 50 | let elapsed_ns = elapsed.as_secs() * 1_000_000_000 + (elapsed.subsec_nanos() as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(elapsed.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> examples/wordcount.rs:35:36 [INFO] [stderr] | [INFO] [stderr] 35 | .or_insert(Vec::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> examples/loopdemo.rs:34:29 [INFO] [stderr] | [INFO] [stderr] 34 | .filter(|x| x > &1); [INFO] [stderr] | ^^^^-- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> examples/loopdemo.rs:56:66 [INFO] [stderr] | [INFO] [stderr] 56 | let elapsed_ns = elapsed.as_secs() * 1_000_000_000 + (elapsed.subsec_nanos() as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(elapsed.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> examples/barrier.rs:20:53 [INFO] [stderr] | [INFO] [stderr] 20 | while let Some((cap, _count)) = notificator.next() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `for (cap, _count) in notificator { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> examples/pagerank.rs:55:61 [INFO] [stderr] | [INFO] [stderr] 55 | edge_stash.entry(time.retain()).or_insert(Vec::new()).extend(edge_vec.drain(..)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> examples/pagerank.rs:61:61 [INFO] [stderr] | [INFO] [stderr] 61 | rank_stash.entry(time.retain()).or_insert(Vec::new()).extend(rank_vec.drain(..)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 27.27s [INFO] running `"docker" "inspect" "bd832863d9fe0ccff230aefb0a2727c6ed8d18ff3eac6f8a54e577bcc5ae9853"` [INFO] running `"docker" "rm" "-f" "bd832863d9fe0ccff230aefb0a2727c6ed8d18ff3eac6f8a54e577bcc5ae9853"` [INFO] [stdout] bd832863d9fe0ccff230aefb0a2727c6ed8d18ff3eac6f8a54e577bcc5ae9853