[INFO] crate tiled 0.8.0 is already in cache
[INFO] extracting crate tiled 0.8.0 into work/ex/clippy-test-run/sources/stable/reg/tiled/0.8.0
[INFO] extracting crate tiled 0.8.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tiled/0.8.0
[INFO] validating manifest of tiled-0.8.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of tiled-0.8.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing tiled-0.8.0
[INFO] removed 0 missing examples
[INFO] finished frobbing tiled-0.8.0
[INFO] frobbed toml for tiled-0.8.0 written to work/ex/clippy-test-run/sources/stable/reg/tiled/0.8.0/Cargo.toml
[INFO] started frobbing tiled-0.8.0
[INFO] removed 0 missing examples
[INFO] finished frobbing tiled-0.8.0
[INFO] frobbed toml for tiled-0.8.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tiled/0.8.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting tiled-0.8.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/tiled/0.8.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] b3a93fcf5f75904eb948e75f91f61f879db798f32205bed99e9ea512f0e2967d
[INFO] running `"docker" "start" "-a" "b3a93fcf5f75904eb948e75f91f61f879db798f32205bed99e9ea512f0e2967d"`
[INFO] [stderr]     Checking tiled v0.8.0 (/opt/crater/workdir)
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]    --> src/lib.rs:238:27
[INFO] [stderr]     |
[INFO] [stderr] 238 |         let (c, (v, o, w, h, tw, th)) = get_attrs!(
[INFO] [stderr]     |                           ^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::many_single_char_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:367:21
[INFO] [stderr]     |
[INFO] [stderr] 367 |         Ok(Tileset {first_gid: first_gid,
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `first_gid`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:368:21
[INFO] [stderr]     |
[INFO] [stderr] 368 |                     name: name,
[INFO] [stderr]     |                     ^^^^^^^^^^ help: replace it with: `name`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:372:21
[INFO] [stderr]     |
[INFO] [stderr] 372 |                     images: images,
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^ help: replace it with: `images`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:373:21
[INFO] [stderr]     |
[INFO] [stderr] 373 |                     tiles: tiles})
[INFO] [stderr]     |                     ^^^^^^^^^^^^ help: replace it with: `tiles`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:426:21
[INFO] [stderr]     |
[INFO] [stderr] 426 |         Ok(Tileset {first_gid: first_gid,
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `first_gid`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:427:21
[INFO] [stderr]     |
[INFO] [stderr] 427 |                     name: name,
[INFO] [stderr]     |                     ^^^^^^^^^^ help: replace it with: `name`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:431:21
[INFO] [stderr]     |
[INFO] [stderr] 431 |                     images: images,
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^ help: replace it with: `images`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:432:21
[INFO] [stderr]     |
[INFO] [stderr] 432 |                     tiles: tiles})
[INFO] [stderr]     |                     ^^^^^^^^^^^^ help: replace it with: `tiles`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:487:41
[INFO] [stderr]     |
[INFO] [stderr] 487 |         Ok(Tile {id: i, flip_h, flip_v, images: images, properties: properties, objectgroup: objectgroup, animation: animation})
[INFO] [stderr]     |                                         ^^^^^^^^^^^^^^ help: replace it with: `images`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:487:57
[INFO] [stderr]     |
[INFO] [stderr] 487 |         Ok(Tile {id: i, flip_h, flip_v, images: images, properties: properties, objectgroup: objectgroup, animation: animation})
[INFO] [stderr]     |                                                         ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `properties`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:487:81
[INFO] [stderr]     |
[INFO] [stderr] 487 |         Ok(Tile {id: i, flip_h, flip_v, images: images, properties: properties, objectgroup: objectgroup, animation: animation})
[INFO] [stderr]     |                                                                                 ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `objectgroup`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:487:107
[INFO] [stderr]     |
[INFO] [stderr] 487 |         Ok(Tile {id: i, flip_h, flip_v, images: images, properties: properties, objectgroup: objectgroup, animation: animation})
[INFO] [stderr]     |                                                                                                           ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `animation`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:545:83
[INFO] [stderr]     |
[INFO] [stderr] 545 |         Ok(Layer {name: n, opacity: o.unwrap_or(1.0), visible: v.unwrap_or(true), tiles: tiles,
[INFO] [stderr]     |                                                                                   ^^^^^^^^^^^^ help: replace it with: `tiles`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:546:19
[INFO] [stderr]     |
[INFO] [stderr] 546 |                   properties: properties})
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `properties`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:624:25
[INFO] [stderr]     |
[INFO] [stderr] 624 |                         objects: objects,
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^ help: replace it with: `objects`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]    --> src/lib.rs:663:32
[INFO] [stderr]     |
[INFO] [stderr] 663 |         let ((id,gid,n,t,w, h, v, r), (x, y)) = get_attrs!(
[INFO] [stderr]     |                                ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 6th binding whose name is just one char
[INFO] [stderr]    --> src/lib.rs:663:35
[INFO] [stderr]     |
[INFO] [stderr] 663 |         let ((id,gid,n,t,w, h, v, r), (x, y)) = get_attrs!(
[INFO] [stderr]     |                                   ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 7th binding whose name is just one char
[INFO] [stderr]    --> src/lib.rs:663:40
[INFO] [stderr]     |
[INFO] [stderr] 663 |         let ((id,gid,n,t,w, h, v, r), (x, y)) = get_attrs!(
[INFO] [stderr]     |                                        ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 8th binding whose name is just one char
[INFO] [stderr]    --> src/lib.rs:663:43
[INFO] [stderr]     |
[INFO] [stderr] 663 |         let ((id,gid,n,t,w, h, v, r), (x, y)) = get_attrs!(
[INFO] [stderr]     |                                           ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:716:13
[INFO] [stderr]     |
[INFO] [stderr] 716 |             id: id,
[INFO] [stderr]     |             ^^^^^^ help: replace it with: `id`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:717:13
[INFO] [stderr]     |
[INFO] [stderr] 717 |             gid: gid,
[INFO] [stderr]     |             ^^^^^^^^ help: replace it with: `gid`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:720:13
[INFO] [stderr]     |
[INFO] [stderr] 720 |             x: x,
[INFO] [stderr]     |             ^^^^ help: replace it with: `x`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:721:13
[INFO] [stderr]     |
[INFO] [stderr] 721 |             y: y,
[INFO] [stderr]     |             ^^^^ help: replace it with: `y`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:724:13
[INFO] [stderr]     |
[INFO] [stderr] 724 |             shape: shape,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `shape`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:725:13
[INFO] [stderr]     |
[INFO] [stderr] 725 |             properties: properties,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `properties`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:737:12
[INFO] [stderr]     |
[INFO] [stderr] 737 |            points: points,
[INFO] [stderr]     |            ^^^^^^^^^^^^^^ help: replace it with: `points`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:749:12
[INFO] [stderr]     |
[INFO] [stderr] 749 |            points: points,
[INFO] [stderr]     |            ^^^^^^^^^^^^^^ help: replace it with: `points`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:786:13
[INFO] [stderr]     |
[INFO] [stderr] 786 |             tile_id: tile_id,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `tile_id`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:787:13
[INFO] [stderr]     |
[INFO] [stderr] 787 |             duration: duration,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `duration`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]    --> src/lib.rs:238:27
[INFO] [stderr]     |
[INFO] [stderr] 238 |         let (c, (v, o, w, h, tw, th)) = get_attrs!(
[INFO] [stderr]     |                           ^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::many_single_char_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:367:21
[INFO] [stderr]     |
[INFO] [stderr] 367 |         Ok(Tileset {first_gid: first_gid,
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `first_gid`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:368:21
[INFO] [stderr]     |
[INFO] [stderr] 368 |                     name: name,
[INFO] [stderr]     |                     ^^^^^^^^^^ help: replace it with: `name`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:372:21
[INFO] [stderr]     |
[INFO] [stderr] 372 |                     images: images,
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^ help: replace it with: `images`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:373:21
[INFO] [stderr]     |
[INFO] [stderr] 373 |                     tiles: tiles})
[INFO] [stderr]     |                     ^^^^^^^^^^^^ help: replace it with: `tiles`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:426:21
[INFO] [stderr]     |
[INFO] [stderr] 426 |         Ok(Tileset {first_gid: first_gid,
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `first_gid`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:427:21
[INFO] [stderr]     |
[INFO] [stderr] 427 |                     name: name,
[INFO] [stderr]     |                     ^^^^^^^^^^ help: replace it with: `name`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:431:21
[INFO] [stderr]     |
[INFO] [stderr] 431 |                     images: images,
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^ help: replace it with: `images`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:432:21
[INFO] [stderr]     |
[INFO] [stderr] 432 |                     tiles: tiles})
[INFO] [stderr]     |                     ^^^^^^^^^^^^ help: replace it with: `tiles`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:487:41
[INFO] [stderr]     |
[INFO] [stderr] 487 |         Ok(Tile {id: i, flip_h, flip_v, images: images, properties: properties, objectgroup: objectgroup, animation: animation})
[INFO] [stderr]     |                                         ^^^^^^^^^^^^^^ help: replace it with: `images`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:487:57
[INFO] [stderr]     |
[INFO] [stderr] 487 |         Ok(Tile {id: i, flip_h, flip_v, images: images, properties: properties, objectgroup: objectgroup, animation: animation})
[INFO] [stderr]     |                                                         ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `properties`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:487:81
[INFO] [stderr]     |
[INFO] [stderr] 487 |         Ok(Tile {id: i, flip_h, flip_v, images: images, properties: properties, objectgroup: objectgroup, animation: animation})
[INFO] [stderr]     |                                                                                 ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `objectgroup`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:487:107
[INFO] [stderr]     |
[INFO] [stderr] 487 |         Ok(Tile {id: i, flip_h, flip_v, images: images, properties: properties, objectgroup: objectgroup, animation: animation})
[INFO] [stderr]     |                                                                                                           ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `animation`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:545:83
[INFO] [stderr]     |
[INFO] [stderr] 545 |         Ok(Layer {name: n, opacity: o.unwrap_or(1.0), visible: v.unwrap_or(true), tiles: tiles,
[INFO] [stderr]     |                                                                                   ^^^^^^^^^^^^ help: replace it with: `tiles`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:546:19
[INFO] [stderr]     |
[INFO] [stderr] 546 |                   properties: properties})
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `properties`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:624:25
[INFO] [stderr]     |
[INFO] [stderr] 624 |                         objects: objects,
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^ help: replace it with: `objects`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]    --> src/lib.rs:663:32
[INFO] [stderr]     |
[INFO] [stderr] 663 |         let ((id,gid,n,t,w, h, v, r), (x, y)) = get_attrs!(
[INFO] [stderr]     |                                ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 6th binding whose name is just one char
[INFO] [stderr]    --> src/lib.rs:663:35
[INFO] [stderr]     |
[INFO] [stderr] 663 |         let ((id,gid,n,t,w, h, v, r), (x, y)) = get_attrs!(
[INFO] [stderr]     |                                   ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 7th binding whose name is just one char
[INFO] [stderr]    --> src/lib.rs:663:40
[INFO] [stderr]     |
[INFO] [stderr] 663 |         let ((id,gid,n,t,w, h, v, r), (x, y)) = get_attrs!(
[INFO] [stderr]     |                                        ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 8th binding whose name is just one char
[INFO] [stderr]    --> src/lib.rs:663:43
[INFO] [stderr]     |
[INFO] [stderr] 663 |         let ((id,gid,n,t,w, h, v, r), (x, y)) = get_attrs!(
[INFO] [stderr]     |                                           ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:716:13
[INFO] [stderr]     |
[INFO] [stderr] 716 |             id: id,
[INFO] [stderr]     |             ^^^^^^ help: replace it with: `id`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:717:13
[INFO] [stderr]     |
[INFO] [stderr] 717 |             gid: gid,
[INFO] [stderr]     |             ^^^^^^^^ help: replace it with: `gid`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:720:13
[INFO] [stderr]     |
[INFO] [stderr] 720 |             x: x,
[INFO] [stderr]     |             ^^^^ help: replace it with: `x`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:721:13
[INFO] [stderr]     |
[INFO] [stderr] 721 |             y: y,
[INFO] [stderr]     |             ^^^^ help: replace it with: `y`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:724:13
[INFO] [stderr]     |
[INFO] [stderr] 724 |             shape: shape,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `shape`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:725:13
[INFO] [stderr]     |
[INFO] [stderr] 725 |             properties: properties,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `properties`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:737:12
[INFO] [stderr]     |
[INFO] [stderr] 737 |            points: points,
[INFO] [stderr]     |            ^^^^^^^^^^^^^^ help: replace it with: `points`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:749:12
[INFO] [stderr]     |
[INFO] [stderr] 749 |            points: points,
[INFO] [stderr]     |            ^^^^^^^^^^^^^^ help: replace it with: `points`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:786:13
[INFO] [stderr]     |
[INFO] [stderr] 786 |             tile_id: tile_id,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `tile_id`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:787:13
[INFO] [stderr]     |
[INFO] [stderr] 787 |             duration: duration,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `duration`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:450:29
[INFO] [stderr]     |
[INFO] [stderr] 450 | const ALL_FLIP_FLAGS: u32 = 0xE0000000;
[INFO] [stderr]     |                             ^^^^^^^^^^ help: consider: `0xE000_0000`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:461:26
[INFO] [stderr]     |
[INFO] [stderr] 461 |         let i: u32 = i & 0x1FFFFFFF;
[INFO] [stderr]     |                          ^^^^^^^^^^ help: consider: `0x1FFF_FFFF`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:811:24
[INFO] [stderr]     |
[INFO] [stderr] 811 |         (None,None) => return Err(TiledError::Other("XML format is currently not supported".to_string())),
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(TiledError::Other("XML format is currently not supported".to_string()))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:814:29
[INFO] [stderr]     |
[INFO] [stderr] 814 |                 "base64" => return parse_base64(parser).map(|v| convert_to_u32(&v,width)),
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `parse_base64(parser).map(|v| convert_to_u32(&v,width))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:815:26
[INFO] [stderr]     |
[INFO] [stderr] 815 |                 "csv" => return decode_csv(parser),
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `decode_csv(parser)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:816:22
[INFO] [stderr]     |
[INFO] [stderr] 816 |                 e => return Err(TiledError::Other(format!("Unknown encoding format {}",e))),
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(TiledError::Other(format!("Unknown encoding format {}",e)))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:820:38
[INFO] [stderr]     |
[INFO] [stderr] 820 |                 ("base64","zlib") => return parse_base64(parser).and_then(decode_zlib).map(|v| convert_to_u32(&v,width) ),
[INFO] [stderr]     |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `parse_base64(parser).and_then(decode_zlib).map(|v| convert_to_u32(&v,width) )`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:821:38
[INFO] [stderr]     |
[INFO] [stderr] 821 |                 ("base64","gzip") => return parse_base64(parser).and_then(decode_gzip).map(|v| convert_to_u32(&v,width)),
[INFO] [stderr]     |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `parse_base64(parser).and_then(decode_gzip).map(|v| convert_to_u32(&v,width))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:822:26
[INFO] [stderr]     |
[INFO] [stderr] 822 |                 (e,c) => return Err(TiledError::Other(format!("Unknown combination of {} encoding and {} compression",e,c)))
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(TiledError::Other(format!("Unknown combination of {} encoding and {} compression",e,c)))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:824:14
[INFO] [stderr]     |
[INFO] [stderr] 824 |         _ => return Err(TiledError::Other("Missing encoding format".to_string())),
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(TiledError::Other("Missing encoding format".to_string()))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:450:29
[INFO] [stderr]     |
[INFO] [stderr] 450 | const ALL_FLIP_FLAGS: u32 = 0xE0000000;
[INFO] [stderr]     |                             ^^^^^^^^^^ help: consider: `0xE000_0000`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:461:26
[INFO] [stderr]     |
[INFO] [stderr] 461 |         let i: u32 = i & 0x1FFFFFFF;
[INFO] [stderr]     |                          ^^^^^^^^^^ help: consider: `0x1FFF_FFFF`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:811:24
[INFO] [stderr]     |
[INFO] [stderr] 811 |         (None,None) => return Err(TiledError::Other("XML format is currently not supported".to_string())),
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(TiledError::Other("XML format is currently not supported".to_string()))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:814:29
[INFO] [stderr]     |
[INFO] [stderr] 814 |                 "base64" => return parse_base64(parser).map(|v| convert_to_u32(&v,width)),
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `parse_base64(parser).map(|v| convert_to_u32(&v,width))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:815:26
[INFO] [stderr]     |
[INFO] [stderr] 815 |                 "csv" => return decode_csv(parser),
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `decode_csv(parser)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:816:22
[INFO] [stderr]     |
[INFO] [stderr] 816 |                 e => return Err(TiledError::Other(format!("Unknown encoding format {}",e))),
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(TiledError::Other(format!("Unknown encoding format {}",e)))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:820:38
[INFO] [stderr]     |
[INFO] [stderr] 820 |                 ("base64","zlib") => return parse_base64(parser).and_then(decode_zlib).map(|v| convert_to_u32(&v,width) ),
[INFO] [stderr]     |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `parse_base64(parser).and_then(decode_zlib).map(|v| convert_to_u32(&v,width) )`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:821:38
[INFO] [stderr]     |
[INFO] [stderr] 821 |                 ("base64","gzip") => return parse_base64(parser).and_then(decode_gzip).map(|v| convert_to_u32(&v,width)),
[INFO] [stderr]     |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `parse_base64(parser).and_then(decode_gzip).map(|v| convert_to_u32(&v,width))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:822:26
[INFO] [stderr]     |
[INFO] [stderr] 822 |                 (e,c) => return Err(TiledError::Other(format!("Unknown combination of {} encoding and {} compression",e,c)))
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(TiledError::Other(format!("Unknown combination of {} encoding and {} compression",e,c)))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:824:14
[INFO] [stderr]     |
[INFO] [stderr] 824 |         _ => return Err(TiledError::Other("Missing encoding format".to_string())),
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(TiledError::Other("Missing encoding format".to_string()))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/lib.rs:89:34
[INFO] [stderr]    |
[INFO] [stderr] 89 |         let s = if s.starts_with("#") {
[INFO] [stderr]    |                                  ^^^ help: try using a char instead: `'#'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/lib.rs:189:49
[INFO] [stderr]     |
[INFO] [stderr] 189 |                 Err(_) => Err(TiledError::Other(format!("Improperly formatted color property"))),
[INFO] [stderr]     |                                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Improperly formatted color property".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/lib.rs:210:24
[INFO] [stderr]     |
[INFO] [stderr] 210 |              let t = t.unwrap_or("string".into());
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "string".into())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/lib.rs:344:66
[INFO] [stderr]     |
[INFO] [stderr] 344 |     fn new_internal<R: Read>(parser: &mut EventReader<R>, attrs: &Vec<OwnedAttribute>) -> Result<Tileset, TiledError> {
[INFO] [stderr]     |                                                                  ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[OwnedAttribute]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/lib.rs:376:29
[INFO] [stderr]     |
[INFO] [stderr] 376 |     fn new_reference(attrs: &Vec<OwnedAttribute>, map_path: Option<&Path>) -> Result<Tileset, TiledError> {
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[OwnedAttribute]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/lib.rs:384:37
[INFO] [stderr]     |
[INFO] [stderr] 384 |         let tileset_path = map_path.ok_or(TiledError::Other("Maps with external tilesets must know their file location.  See parse_with_path(Path).".to_string()))?.with_file_name(source);
[INFO] [stderr]     |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| TiledError::Other("Maps with external tilesets must know their file location.  See parse_with_path(Path).".to_string()))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/lib.rs:404:92
[INFO] [stderr]     |
[INFO] [stderr] 404 |     fn parse_external_tileset<R: Read>(first_gid: u32, parser: &mut EventReader<R>, attrs: &Vec<OwnedAttribute>) -> Result<Tileset, TiledError> {
[INFO] [stderr]     |                                                                                            ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[OwnedAttribute]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/lib.rs:35:17
[INFO] [stderr]     |
[INFO] [stderr] 35  | /                 match attr.name.local_name.as_ref() {
[INFO] [stderr] 36  | |                     $($oName => $oVar = $oMethod(attr.value.clone()),)*
[INFO] [stderr] 37  | |                     $($name => $var = $method(attr.value.clone()),)*
[INFO] [stderr] 38  | |                     _ => {}
[INFO] [stderr] 39  | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr] ...
[INFO] [stderr] 454 |           let (_, i): (_, u32) = get_attrs!(
[INFO] [stderr]     |  ________________________________-
[INFO] [stderr] 455 | |             attrs,
[INFO] [stderr] 456 | |             optionals: [],
[INFO] [stderr] 457 | |             required: [("id", id, |v:String| v.parse().ok())],
[INFO] [stderr] 458 | |             TiledError::MalformedAttributes("tile must have an id with the correct type".to_string()));
[INFO] [stderr]     | |______________________________________________________________________________________________________- in this macro invocation
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 35  |                 if let "id" = attr.name.local_name.as_ref() { get_attrs!(
[INFO] [stderr] 36  |             attrs,
[INFO] [stderr] 37  |             optionals: [],
[INFO] [stderr] 38  |             required: [("id", id, |v:String| v.parse().ok())],
[INFO] [stderr] 39  |             TiledError::MalformedAttributes("tile must have an id with the correct type".to_string())) }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new`
[INFO] [stderr]    --> src/lib.rs:622:31
[INFO] [stderr]     |
[INFO] [stderr] 622 |         Ok(ObjectGroup {name: n.unwrap_or(String::new()),
[INFO] [stderr]     |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `n.unwrap_or_default()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new`
[INFO] [stderr]    --> src/lib.rs:682:17
[INFO] [stderr]     |
[INFO] [stderr] 682 |         let n = n.unwrap_or(String::new());
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `n.unwrap_or_default()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new`
[INFO] [stderr]    --> src/lib.rs:683:17
[INFO] [stderr]     |
[INFO] [stderr] 683 |         let t = t.unwrap_or(String::new());
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `t.unwrap_or_default()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/lib.rs:35:17
[INFO] [stderr]     |
[INFO] [stderr] 35  | /                 match attr.name.local_name.as_ref() {
[INFO] [stderr] 36  | |                     $($oName => $oVar = $oMethod(attr.value.clone()),)*
[INFO] [stderr] 37  | |                     $($name => $var = $method(attr.value.clone()),)*
[INFO] [stderr] 38  | |                     _ => {}
[INFO] [stderr] 39  | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr] ...
[INFO] [stderr] 730 |           let ((), s) = get_attrs!(
[INFO] [stderr]     |  _______________________-
[INFO] [stderr] 731 | |             attrs,
[INFO] [stderr] 732 | |             optionals: [],
[INFO] [stderr] 733 | |             required: [("points", points, |v| Some(v))],
[INFO] [stderr] 734 | |             TiledError::MalformedAttributes("A polyline must have points".to_string()));
[INFO] [stderr]     | |_______________________________________________________________________________________- in this macro invocation
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 35  |                 if let "points" = attr.name.local_name.as_ref() { get_attrs!(
[INFO] [stderr] 36  |             attrs,
[INFO] [stderr] 37  |             optionals: [],
[INFO] [stderr] 38  |             required: [("points", points, |v| Some(v))],
[INFO] [stderr] 39  |             TiledError::MalformedAttributes("A polyline must have points".to_string())) }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/lib.rs:35:17
[INFO] [stderr]     |
[INFO] [stderr] 35  | /                 match attr.name.local_name.as_ref() {
[INFO] [stderr] 36  | |                     $($oName => $oVar = $oMethod(attr.value.clone()),)*
[INFO] [stderr] 37  | |                     $($name => $var = $method(attr.value.clone()),)*
[INFO] [stderr] 38  | |                     _ => {}
[INFO] [stderr] 39  | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr] ...
[INFO] [stderr] 742 |           let ((), s) = get_attrs!(
[INFO] [stderr]     |  _______________________-
[INFO] [stderr] 743 | |             attrs,
[INFO] [stderr] 744 | |             optionals: [],
[INFO] [stderr] 745 | |             required: [("points", points, |v| Some(v))],
[INFO] [stderr] 746 | |             TiledError::MalformedAttributes("A polygon must have points".to_string()));
[INFO] [stderr]     | |______________________________________________________________________________________- in this macro invocation
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 35  |                 if let "points" = attr.name.local_name.as_ref() { get_attrs!(
[INFO] [stderr] 36  |             attrs,
[INFO] [stderr] 37  |             optionals: [],
[INFO] [stderr] 38  |             required: [("points", points, |v| Some(v))],
[INFO] [stderr] 39  |             TiledError::MalformedAttributes("A polygon must have points".to_string())) }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/lib.rs:89:34
[INFO] [stderr]    |
[INFO] [stderr] 89 |         let s = if s.starts_with("#") {
[INFO] [stderr]    |                                  ^^^ help: try using a char instead: `'#'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/lib.rs:856:40
[INFO] [stderr]     |
[INFO] [stderr] 856 |     gzd.read_to_end(&mut data).map_err(|e| TiledError::DecompressingError(e))?;
[INFO] [stderr]     |                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `TiledError::DecompressingError`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/lib.rs:189:49
[INFO] [stderr]     |
[INFO] [stderr] 189 |                 Err(_) => Err(TiledError::Other(format!("Improperly formatted color property"))),
[INFO] [stderr]     |                                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Improperly formatted color property".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/lib.rs:883:24
[INFO] [stderr]     |
[INFO] [stderr] 883 | fn convert_to_u32(all: &Vec<u8>, width: u32) -> Vec<Vec<u32>> {
[INFO] [stderr]     |                        ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:889:22
[INFO] [stderr]     |
[INFO] [stderr] 889 |             let n = ((chunk[start + 3] as u32) << 24) +
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(chunk[start + 3])`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:890:22
[INFO] [stderr]     |
[INFO] [stderr] 890 |                     ((chunk[start + 2] as u32) << 16) +
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(chunk[start + 2])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:891:22
[INFO] [stderr]     |
[INFO] [stderr] 891 |                     ((chunk[start + 1] as u32) <<  8) +
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(chunk[start + 1])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:892:21
[INFO] [stderr]     |
[INFO] [stderr] 892 |                     chunk[start] as u32;
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(chunk[start])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/lib.rs:210:24
[INFO] [stderr]     |
[INFO] [stderr] 210 |              let t = t.unwrap_or("string".into());
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "string".into())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/lib.rs:344:66
[INFO] [stderr]     |
[INFO] [stderr] 344 |     fn new_internal<R: Read>(parser: &mut EventReader<R>, attrs: &Vec<OwnedAttribute>) -> Result<Tileset, TiledError> {
[INFO] [stderr]     |                                                                  ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[OwnedAttribute]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/lib.rs:376:29
[INFO] [stderr]     |
[INFO] [stderr] 376 |     fn new_reference(attrs: &Vec<OwnedAttribute>, map_path: Option<&Path>) -> Result<Tileset, TiledError> {
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[OwnedAttribute]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/lib.rs:384:37
[INFO] [stderr]     |
[INFO] [stderr] 384 |         let tileset_path = map_path.ok_or(TiledError::Other("Maps with external tilesets must know their file location.  See parse_with_path(Path).".to_string()))?.with_file_name(source);
[INFO] [stderr]     |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| TiledError::Other("Maps with external tilesets must know their file location.  See parse_with_path(Path).".to_string()))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/lib.rs:404:92
[INFO] [stderr]     |
[INFO] [stderr] 404 |     fn parse_external_tileset<R: Read>(first_gid: u32, parser: &mut EventReader<R>, attrs: &Vec<OwnedAttribute>) -> Result<Tileset, TiledError> {
[INFO] [stderr]     |                                                                                            ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[OwnedAttribute]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/lib.rs:35:17
[INFO] [stderr]     |
[INFO] [stderr] 35  | /                 match attr.name.local_name.as_ref() {
[INFO] [stderr] 36  | |                     $($oName => $oVar = $oMethod(attr.value.clone()),)*
[INFO] [stderr] 37  | |                     $($name => $var = $method(attr.value.clone()),)*
[INFO] [stderr] 38  | |                     _ => {}
[INFO] [stderr] 39  | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr] ...
[INFO] [stderr] 454 |           let (_, i): (_, u32) = get_attrs!(
[INFO] [stderr]     |  ________________________________-
[INFO] [stderr] 455 | |             attrs,
[INFO] [stderr] 456 | |             optionals: [],
[INFO] [stderr] 457 | |             required: [("id", id, |v:String| v.parse().ok())],
[INFO] [stderr] 458 | |             TiledError::MalformedAttributes("tile must have an id with the correct type".to_string()));
[INFO] [stderr]     | |______________________________________________________________________________________________________- in this macro invocation
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 35  |                 if let "id" = attr.name.local_name.as_ref() { get_attrs!(
[INFO] [stderr] 36  |             attrs,
[INFO] [stderr] 37  |             optionals: [],
[INFO] [stderr] 38  |             required: [("id", id, |v:String| v.parse().ok())],
[INFO] [stderr] 39  |             TiledError::MalformedAttributes("tile must have an id with the correct type".to_string())) }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new`
[INFO] [stderr]    --> src/lib.rs:622:31
[INFO] [stderr]     |
[INFO] [stderr] 622 |         Ok(ObjectGroup {name: n.unwrap_or(String::new()),
[INFO] [stderr]     |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `n.unwrap_or_default()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new`
[INFO] [stderr]    --> src/lib.rs:682:17
[INFO] [stderr]     |
[INFO] [stderr] 682 |         let n = n.unwrap_or(String::new());
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `n.unwrap_or_default()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new`
[INFO] [stderr]    --> src/lib.rs:683:17
[INFO] [stderr]     |
[INFO] [stderr] 683 |         let t = t.unwrap_or(String::new());
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `t.unwrap_or_default()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/lib.rs:35:17
[INFO] [stderr]     |
[INFO] [stderr] 35  | /                 match attr.name.local_name.as_ref() {
[INFO] [stderr] 36  | |                     $($oName => $oVar = $oMethod(attr.value.clone()),)*
[INFO] [stderr] 37  | |                     $($name => $var = $method(attr.value.clone()),)*
[INFO] [stderr] 38  | |                     _ => {}
[INFO] [stderr] 39  | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr] ...
[INFO] [stderr] 730 |           let ((), s) = get_attrs!(
[INFO] [stderr]     |  _______________________-
[INFO] [stderr] 731 | |             attrs,
[INFO] [stderr] 732 | |             optionals: [],
[INFO] [stderr] 733 | |             required: [("points", points, |v| Some(v))],
[INFO] [stderr] 734 | |             TiledError::MalformedAttributes("A polyline must have points".to_string()));
[INFO] [stderr]     | |_______________________________________________________________________________________- in this macro invocation
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 35  |                 if let "points" = attr.name.local_name.as_ref() { get_attrs!(
[INFO] [stderr] 36  |             attrs,
[INFO] [stderr] 37  |             optionals: [],
[INFO] [stderr] 38  |             required: [("points", points, |v| Some(v))],
[INFO] [stderr] 39  |             TiledError::MalformedAttributes("A polyline must have points".to_string())) }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/lib.rs:35:17
[INFO] [stderr]     |
[INFO] [stderr] 35  | /                 match attr.name.local_name.as_ref() {
[INFO] [stderr] 36  | |                     $($oName => $oVar = $oMethod(attr.value.clone()),)*
[INFO] [stderr] 37  | |                     $($name => $var = $method(attr.value.clone()),)*
[INFO] [stderr] 38  | |                     _ => {}
[INFO] [stderr] 39  | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr] ...
[INFO] [stderr] 742 |           let ((), s) = get_attrs!(
[INFO] [stderr]     |  _______________________-
[INFO] [stderr] 743 | |             attrs,
[INFO] [stderr] 744 | |             optionals: [],
[INFO] [stderr] 745 | |             required: [("points", points, |v| Some(v))],
[INFO] [stderr] 746 | |             TiledError::MalformedAttributes("A polygon must have points".to_string()));
[INFO] [stderr]     | |______________________________________________________________________________________- in this macro invocation
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 35  |                 if let "points" = attr.name.local_name.as_ref() { get_attrs!(
[INFO] [stderr] 36  |             attrs,
[INFO] [stderr] 37  |             optionals: [],
[INFO] [stderr] 38  |             required: [("points", points, |v| Some(v))],
[INFO] [stderr] 39  |             TiledError::MalformedAttributes("A polygon must have points".to_string())) }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/lib.rs:856:40
[INFO] [stderr]     |
[INFO] [stderr] 856 |     gzd.read_to_end(&mut data).map_err(|e| TiledError::DecompressingError(e))?;
[INFO] [stderr]     |                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `TiledError::DecompressingError`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/lib.rs:883:24
[INFO] [stderr]     |
[INFO] [stderr] 883 | fn convert_to_u32(all: &Vec<u8>, width: u32) -> Vec<Vec<u32>> {
[INFO] [stderr]     |                        ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:889:22
[INFO] [stderr]     |
[INFO] [stderr] 889 |             let n = ((chunk[start + 3] as u32) << 24) +
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(chunk[start + 3])`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:890:22
[INFO] [stderr]     |
[INFO] [stderr] 890 |                     ((chunk[start + 2] as u32) << 16) +
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(chunk[start + 2])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:891:22
[INFO] [stderr]     |
[INFO] [stderr] 891 |                     ((chunk[start + 1] as u32) <<  8) +
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(chunk[start + 1])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:892:21
[INFO] [stderr]     |
[INFO] [stderr] 892 |                     chunk[start] as u32;
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(chunk[start])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]  --> tests/lib.rs:9:5
[INFO] [stderr]   |
[INFO] [stderr] 9 |     return parse(file);
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `parse(file)`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> tests/lib.rs:13:5
[INFO] [stderr]    |
[INFO] [stderr] 13 |     return parse_file(p);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `parse_file(p)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> tests/lib.rs:53:43
[INFO] [stderr]    |
[INFO] [stderr] 53 |         let image = second.image.as_ref().expect(&format!("{}'s image shouldn't be None", second.name));
[INFO] [stderr]    |                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("{}'s image shouldn't be None", second.name))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 4.27s
[INFO] running `"docker" "inspect" "b3a93fcf5f75904eb948e75f91f61f879db798f32205bed99e9ea512f0e2967d"`
[INFO] running `"docker" "rm" "-f" "b3a93fcf5f75904eb948e75f91f61f879db798f32205bed99e9ea512f0e2967d"`
[INFO] [stdout] b3a93fcf5f75904eb948e75f91f61f879db798f32205bed99e9ea512f0e2967d