[INFO] crate tilde-expand 0.1.1 is already in cache [INFO] extracting crate tilde-expand 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/tilde-expand/0.1.1 [INFO] extracting crate tilde-expand 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tilde-expand/0.1.1 [INFO] validating manifest of tilde-expand-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tilde-expand-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tilde-expand-0.1.1 [INFO] finished frobbing tilde-expand-0.1.1 [INFO] frobbed toml for tilde-expand-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/tilde-expand/0.1.1/Cargo.toml [INFO] started frobbing tilde-expand-0.1.1 [INFO] finished frobbing tilde-expand-0.1.1 [INFO] frobbed toml for tilde-expand-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tilde-expand/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tilde-expand-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/tilde-expand/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] af9921a1acf084caaaf2e696ee9da8eb025fc8dce3291f9e22cd5a22b397f976 [INFO] running `"docker" "start" "-a" "af9921a1acf084caaaf2e696ee9da8eb025fc8dce3291f9e22cd5a22b397f976"` [INFO] [stderr] Checking tilde-expand v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/lib.rs:16:18 [INFO] [stderr] | [INFO] [stderr] 16 | let result = if username == &[] [INFO] [stderr] | ^^^^^^^^^^^^--- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `[]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: You appear to be counting bytes the naive way [INFO] [stderr] --> src/lib.rs:50:18 [INFO] [stderr] | [INFO] [stderr] 50 | Some(&b'~') if s.iter().filter(|&&c| c==b'~').count() == 1 => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider using the bytecount crate: `bytecount::count(s, b'~')` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::naive_bytecount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#naive_bytecount [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:51:46 [INFO] [stderr] | [INFO] [stderr] 51 | let end = s.iter().position(|&c| c==b'/').unwrap_or(s.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| s.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/lib.rs:16:18 [INFO] [stderr] | [INFO] [stderr] 16 | let result = if username == &[] [INFO] [stderr] | ^^^^^^^^^^^^--- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `[]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: You appear to be counting bytes the naive way [INFO] [stderr] --> src/lib.rs:50:18 [INFO] [stderr] | [INFO] [stderr] 50 | Some(&b'~') if s.iter().filter(|&&c| c==b'~').count() == 1 => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider using the bytecount crate: `bytecount::count(s, b'~')` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::naive_bytecount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#naive_bytecount [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:51:46 [INFO] [stderr] | [INFO] [stderr] 51 | let end = s.iter().position(|&c| c==b'/').unwrap_or(s.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| s.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.06s [INFO] running `"docker" "inspect" "af9921a1acf084caaaf2e696ee9da8eb025fc8dce3291f9e22cd5a22b397f976"` [INFO] running `"docker" "rm" "-f" "af9921a1acf084caaaf2e696ee9da8eb025fc8dce3291f9e22cd5a22b397f976"` [INFO] [stdout] af9921a1acf084caaaf2e696ee9da8eb025fc8dce3291f9e22cd5a22b397f976